[jira] [Commented] (SPARK-25973) Spark History Main page performance improvement

2018-11-09 Thread Apache Spark (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681054#comment-16681054
 ] 

Apache Spark commented on SPARK-25973:
--

User 'Willymontaz' has created a pull request for this issue:
https://github.com/apache/spark/pull/22982

> Spark History Main page performance improvement
> ---
>
> Key: SPARK-25973
> URL: https://issues.apache.org/jira/browse/SPARK-25973
> Project: Spark
>  Issue Type: Improvement
>  Components: Web UI
>Affects Versions: 2.3.2
>Reporter: William Montaz
>Priority: Minor
> Attachments: fix.patch
>
>
> HistoryPage.scala counts applications (with a predicate depending on if it is 
> displaying incomplete or complete applications) to check if it must display 
> the dataTable.
> Since it only checks if allAppsSize > 0, we could use exists method on the 
> iterator. This way we stop iterating at the first occurence found.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-25973) Spark History Main page performance improvement

2018-11-08 Thread William Montaz (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679772#comment-16679772
 ] 

William Montaz commented on SPARK-25973:


Ok created https://github.com/apache/spark/pull/22980

> Spark History Main page performance improvement
> ---
>
> Key: SPARK-25973
> URL: https://issues.apache.org/jira/browse/SPARK-25973
> Project: Spark
>  Issue Type: Improvement
>  Components: Web UI
>Affects Versions: 2.3.2
>Reporter: William Montaz
>Priority: Minor
> Attachments: fix.patch
>
>
> HistoryPage.scala counts applications (with a predicate depending on if it is 
> displaying incomplete or complete applications) to check if it must display 
> the dataTable.
> Since it only checks if allAppsSize > 0, we could use exists method on the 
> iterator. This way we stop iterating at the first occurence found.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-25973) Spark History Main page performance improvement

2018-11-08 Thread William Montaz (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679853#comment-16679853
 ] 

William Montaz commented on SPARK-25973:


New pull request on master branch https://github.com/apache/spark/pull/22982

> Spark History Main page performance improvement
> ---
>
> Key: SPARK-25973
> URL: https://issues.apache.org/jira/browse/SPARK-25973
> Project: Spark
>  Issue Type: Improvement
>  Components: Web UI
>Affects Versions: 2.3.2
>Reporter: William Montaz
>Priority: Minor
> Attachments: fix.patch
>
>
> HistoryPage.scala counts applications (with a predicate depending on if it is 
> displaying incomplete or complete applications) to check if it must display 
> the dataTable.
> Since it only checks if allAppsSize > 0, we could use exists method on the 
> iterator. This way we stop iterating at the first occurence found.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-25973) Spark History Main page performance improvement

2018-11-08 Thread Yuming Wang (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679639#comment-16679639
 ] 

Yuming Wang commented on SPARK-25973:
-

Please create a pull request: https://github.com/apache/spark/pulls

> Spark History Main page performance improvement
> ---
>
> Key: SPARK-25973
> URL: https://issues.apache.org/jira/browse/SPARK-25973
> Project: Spark
>  Issue Type: Improvement
>  Components: Web UI
>Affects Versions: 2.3.2
>Reporter: William Montaz
>Priority: Minor
> Attachments: fix.patch
>
>
> HistoryPage.scala counts applications (with a predicate depending on if it is 
> displaying incomplete or complete applications) to check if it must display 
> the dataTable.
> Since it only checks if allAppsSize > 0, we could use exists method on the 
> iterator> This way we stop iterating at the first occurence found.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org