[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717577#comment-16717577
 ] 

ASF GitHub Bot commented on SPARK-26300:


dongjoon-hyun closed pull request #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
 
b/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
index d9fe1a992a093..881cd96cc9dc9 100644
--- 
a/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
+++ 
b/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
@@ -246,9 +246,7 @@ class StreamingQueryManager private[sql] (sparkSession: 
SparkSession) extends Lo
 val analyzedPlan = df.queryExecution.analyzed
 df.queryExecution.assertAnalyzed()
 
-if (sparkSession.sessionState.conf.isUnsupportedOperationCheckEnabled) {
-  UnsupportedOperationChecker.checkForStreaming(analyzedPlan, outputMode)
-}
+val operationCheckEnabled = 
sparkSession.sessionState.conf.isUnsupportedOperationCheckEnabled
 
 if (sparkSession.sessionState.conf.adaptiveExecutionEnabled) {
   logWarning(s"${SQLConf.ADAPTIVE_EXECUTION_ENABLED.key} " +
@@ -257,7 +255,7 @@ class StreamingQueryManager private[sql] (sparkSession: 
SparkSession) extends Lo
 
 (sink, trigger) match {
   case (v2Sink: StreamingWriteSupportProvider, trigger: ContinuousTrigger) 
=>
-if (sparkSession.sessionState.conf.isUnsupportedOperationCheckEnabled) 
{
+if (operationCheckEnabled) {
   UnsupportedOperationChecker.checkForContinuous(analyzedPlan, 
outputMode)
 }
 new StreamingQueryWrapper(new ContinuousExecution(
@@ -272,6 +270,9 @@ class StreamingQueryManager private[sql] (sparkSession: 
SparkSession) extends Lo
   extraOptions,
   deleteCheckpointOnStop))
   case _ =>
+if (operationCheckEnabled) {
+  UnsupportedOperationChecker.checkForStreaming(analyzedPlan, 
outputMode)
+}
 new StreamingQueryWrapper(new MicroBatchExecution(
   sparkSession,
   userSpecifiedName.orNull,


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Assignee: liuxian
>Priority: Minor
> Fix For: 3.0.0
>
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717566#comment-16717566
 ] 

ASF GitHub Bot commented on SPARK-26300:


dongjoon-hyun commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446284050
 
 
   Thank you, @10110346 , @HeartSaVioR , @cloud-fan , @gaborgsomogyi .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Assignee: liuxian
>Priority: Minor
> Fix For: 3.0.0
>
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717558#comment-16717558
 ] 

ASF GitHub Bot commented on SPARK-26300:


dongjoon-hyun commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446282924
 
 
   Merged to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716920#comment-16716920
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446177352
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99961/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716921#comment-16716921
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a 
redundant `checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446177346
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716922#comment-16716922
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a 
redundant `checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446177352
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99961/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716919#comment-16716919
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446177346
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716915#comment-16716915
 ] 

ASF GitHub Bot commented on SPARK-26300:


SparkQA removed a comment on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446112832
 
 
   **[Test build #99961 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99961/testReport)**
 for PR 23251 at commit 
[`b1e71ee`](https://github.com/apache/spark/commit/b1e71ee7a723d63f1cf3c0754f2372eb185439d3).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716913#comment-16716913
 ] 

ASF GitHub Bot commented on SPARK-26300:


SparkQA commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446176845
 
 
   **[Test build #99961 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99961/testReport)**
 for PR 23251 at commit 
[`b1e71ee`](https://github.com/apache/spark/commit/b1e71ee7a723d63f1cf3c0754f2372eb185439d3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716529#comment-16716529
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446112962
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5963/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716532#comment-16716532
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a 
redundant `checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446112962
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5963/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716530#comment-16716530
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a 
redundant `checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446112953
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716528#comment-16716528
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446112953
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716526#comment-16716526
 ] 

ASF GitHub Bot commented on SPARK-26300:


SparkQA commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446112832
 
 
   **[Test build #99961 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99961/testReport)**
 for PR 23251 at commit 
[`b1e71ee`](https://github.com/apache/spark/commit/b1e71ee7a723d63f1cf3c0754f2372eb185439d3).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716510#comment-16716510
 ] 

ASF GitHub Bot commented on SPARK-26300:


10110346 commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446111373
 
 
   Retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716478#comment-16716478
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a 
redundant `checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446108206
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99949/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716468#comment-16716468
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a 
redundant `checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446108201
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716467#comment-16716467
 ] 

ASF GitHub Bot commented on SPARK-26300:


SparkQA removed a comment on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446081221
 
 
   **[Test build #99949 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99949/testReport)**
 for PR 23251 at commit 
[`b1e71ee`](https://github.com/apache/spark/commit/b1e71ee7a723d63f1cf3c0754f2372eb185439d3).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716439#comment-16716439
 ] 

ASF GitHub Bot commented on SPARK-26300:


SparkQA commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446108012
 
 
   **[Test build #99949 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99949/testReport)**
 for PR 23251 at commit 
[`b1e71ee`](https://github.com/apache/spark/commit/b1e71ee7a723d63f1cf3c0754f2372eb185439d3).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716454#comment-16716454
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446108206
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99949/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716453#comment-16716453
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446108201
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716281#comment-16716281
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a 
redundant `checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446082207
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716266#comment-16716266
 ] 

ASF GitHub Bot commented on SPARK-26300:


SparkQA commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446081221
 
 
   **[Test build #99949 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99949/testReport)**
 for PR 23251 at commit 
[`b1e71ee`](https://github.com/apache/spark/commit/b1e71ee7a723d63f1cf3c0754f2372eb185439d3).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716282#comment-16716282
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins removed a comment on issue #23251: [SPARK-26300][SS] Remove a 
redundant `checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446082209
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5954/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716278#comment-16716278
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446082209
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5954/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716277#comment-16716277
 ] 

ASF GitHub Bot commented on SPARK-26300:


AmplabJenkins commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446082207
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716265#comment-16716265
 ] 

ASF GitHub Bot commented on SPARK-26300:


dongjoon-hyun commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446081142
 
 
   cc @tdas , too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716264#comment-16716264
 ] 

ASF GitHub Bot commented on SPARK-26300:


dongjoon-hyun commented on issue #23251: [SPARK-26300][SS] Remove a redundant 
`checkForStreaming` call
URL: https://github.com/apache/spark/pull/23251#issuecomment-446081024
 
 
   Retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26300) The `checkForStreaming` mothod may be called twice in `createQuery`

2018-12-06 Thread Apache Spark (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712296#comment-16712296
 ] 

Apache Spark commented on SPARK-26300:
--

User '10110346' has created a pull request for this issue:
https://github.com/apache/spark/pull/23251

> The `checkForStreaming`  mothod  may be called twice in `createQuery`
> -
>
> Key: SPARK-26300
> URL: https://issues.apache.org/jira/browse/SPARK-26300
> Project: Spark
>  Issue Type: Improvement
>  Components: Structured Streaming
>Affects Versions: 2.4.0
>Reporter: liuxian
>Priority: Minor
>
> If {{checkForContinuous}} is called ( {{checkForStreaming}} is called in 
> {{checkForContinuous}} ), the {{checkForStreaming}} mothod will be called 
> twice in {{createQuery}} , this is not necessary, and the 
> {{checkForStreaming}} method has a lot of statements, so it's better to 
> remove one of them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org