[jira] [Commented] (SPARK-27797) Shuffle service metric "registeredConnections" not tracked correctly

2019-05-23 Thread Hyukjin Kwon (JIRA) 


[ 
https://issues.apache.org/jira/browse/SPARK-27797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847232#comment-16847232
 ] 

Hyukjin Kwon commented on SPARK-27797:
--

(Oops, I wrongly linked)

> Shuffle service metric "registeredConnections" not tracked correctly
> 
>
> Key: SPARK-27797
> URL: https://issues.apache.org/jira/browse/SPARK-27797
> Project: Spark
>  Issue Type: Bug
>  Components: Shuffle
>Affects Versions: 3.0.0
>Reporter: Marcelo Vanzin
>Priority: Minor
>
> In {{ExternalShuffleBlockHandler}}:
> {code}
> // Number of registered connections to the shuffle service
> private Counter registeredConnections = new Counter();
> public ShuffleMetrics() {
>   ...
>   allMetrics.put("numRegisteredConnections", registeredConnections);
> }
> {code}
> But the counter that's actually updated is in {{TransportContext}}. The call 
> site is in {{TransportChannelHandler}}:
> {code}
>   @Override
>   public void channelRegistered(ChannelHandlerContext ctx) throws Exception {
> transportContext.getRegisteredConnections().inc();
> super.channelRegistered(ctx);
>   }
>   @Override
>   public void channelUnregistered(ChannelHandlerContext ctx) throws Exception 
> {
> transportContext.getRegisteredConnections().dec();
> super.channelUnregistered(ctx);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-27797) Shuffle service metric "registeredConnections" not tracked correctly

2019-05-22 Thread Marcelo Vanzin (JIRA) 


[ 
https://issues.apache.org/jira/browse/SPARK-27797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846068#comment-16846068
 ] 

Marcelo Vanzin commented on SPARK-27797:


You're right. Looks just like some dead code in that case.

> Shuffle service metric "registeredConnections" not tracked correctly
> 
>
> Key: SPARK-27797
> URL: https://issues.apache.org/jira/browse/SPARK-27797
> Project: Spark
>  Issue Type: Bug
>  Components: Shuffle
>Affects Versions: 3.0.0
>Reporter: Marcelo Vanzin
>Priority: Minor
>
> In {{ExternalShuffleBlockHandler}}:
> {code}
> // Number of registered connections to the shuffle service
> private Counter registeredConnections = new Counter();
> public ShuffleMetrics() {
>   ...
>   allMetrics.put("numRegisteredConnections", registeredConnections);
> }
> {code}
> But the counter that's actually updated is in {{TransportContext}}. The call 
> site is in {{TransportChannelHandler}}:
> {code}
>   @Override
>   public void channelRegistered(ChannelHandlerContext ctx) throws Exception {
> transportContext.getRegisteredConnections().inc();
> super.channelRegistered(ctx);
>   }
>   @Override
>   public void channelUnregistered(ChannelHandlerContext ctx) throws Exception 
> {
> transportContext.getRegisteredConnections().dec();
> super.channelUnregistered(ctx);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-27797) Shuffle service metric "registeredConnections" not tracked correctly

2019-05-21 Thread Steven Rand (JIRA) 


[ 
https://issues.apache.org/jira/browse/SPARK-27797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845535#comment-16845535
 ] 

Steven Rand commented on SPARK-27797:
-

I think it might be okay -- ExternalShuffleService.start() does:

{code}
blockHandler.getAllMetrics.getMetrics.put("numRegisteredConnections",
server.getRegisteredConnections)
{code}

Which I think makes the result correct (though in any case, agreed that the 
structure is confusing).

> Shuffle service metric "registeredConnections" not tracked correctly
> 
>
> Key: SPARK-27797
> URL: https://issues.apache.org/jira/browse/SPARK-27797
> Project: Spark
>  Issue Type: Bug
>  Components: Shuffle
>Affects Versions: 3.0.0
>Reporter: Marcelo Vanzin
>Priority: Minor
>
> In {{ExternalShuffleBlockHandler}}:
> {code}
> // Number of registered connections to the shuffle service
> private Counter registeredConnections = new Counter();
> public ShuffleMetrics() {
>   ...
>   allMetrics.put("numRegisteredConnections", registeredConnections);
> }
> {code}
> But the counter that's actually updated is in {{TransportContext}}. The call 
> site is in {{TransportChannelHandler}}:
> {code}
>   @Override
>   public void channelRegistered(ChannelHandlerContext ctx) throws Exception {
> transportContext.getRegisteredConnections().inc();
> super.channelRegistered(ctx);
>   }
>   @Override
>   public void channelUnregistered(ChannelHandlerContext ctx) throws Exception 
> {
> transportContext.getRegisteredConnections().dec();
> super.channelUnregistered(ctx);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org