[jira] [Commented] (SPARK-32398) Upgrade to scalatest 3.2.0 for Scala 2.13.3 compatibility
[ https://issues.apache.org/jira/browse/SPARK-32398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248021#comment-17248021 ] Steve Loughran commented on SPARK-32398: doesn't work with old versions though. I think I'll end up having to do some JAR containing nothing but a FunSuite parent and doing separate releases for the different versions. bq. I continue to hope that these API-breaking changes won't continue, yeah, they should have regression tests for this > Upgrade to scalatest 3.2.0 for Scala 2.13.3 compatibility > - > > Key: SPARK-32398 > URL: https://issues.apache.org/jira/browse/SPARK-32398 > Project: Spark > Issue Type: Sub-task > Components: ML, Spark Core, SQL, Structured Streaming, Tests >Affects Versions: 3.0.0 >Reporter: Sean R. Owen >Assignee: Sean R. Owen >Priority: Major > Fix For: 3.1.0 > > > We'll need to update to scalatest 3.2.0 in order to pick up the fix here, > which fixes an incompatibility with Scala 2.13.3: > https://github.com/scalatest/scalatest/commit/7c89416aa9f3e7f2730a343ad6d3bdcff65809de > That's a big change unfortunately - 3.1 / 3.2 reorganized many classes. > Fortunately it's just like import updates in 100 files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-32398) Upgrade to scalatest 3.2.0 for Scala 2.13.3 compatibility
[ https://issues.apache.org/jira/browse/SPARK-32398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247545#comment-17247545 ] Sean R. Owen commented on SPARK-32398: -- Yes it did. It's just how it goes, I think. I continue to hope that these API-breaking changes won't continue, so, updating to the latest version now should help future-proof the code. But yes seems like we had to to buy 2.13 compatibility. > Upgrade to scalatest 3.2.0 for Scala 2.13.3 compatibility > - > > Key: SPARK-32398 > URL: https://issues.apache.org/jira/browse/SPARK-32398 > Project: Spark > Issue Type: Sub-task > Components: ML, Spark Core, SQL, Structured Streaming, Tests >Affects Versions: 3.0.0 >Reporter: Sean R. Owen >Assignee: Sean R. Owen >Priority: Major > Fix For: 3.1.0 > > > We'll need to update to scalatest 3.2.0 in order to pick up the fix here, > which fixes an incompatibility with Scala 2.13.3: > https://github.com/scalatest/scalatest/commit/7c89416aa9f3e7f2730a343ad6d3bdcff65809de > That's a big change unfortunately - 3.1 / 3.2 reorganized many classes. > Fortunately it's just like import updates in 100 files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-32398) Upgrade to scalatest 3.2.0 for Scala 2.13.3 compatibility
[ https://issues.apache.org/jira/browse/SPARK-32398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247484#comment-17247484 ] Steve Loughran commented on SPARK-32398: Did scalatest really rename funsuite? That's just antisocial; now my downstream projects have stopped buildingI have to decide whether my tests line up with older spark builds or not. How stable is SparkFunSuite if someone were to extend it rather than the scalatest parent? otherwise it's time to build/publish my own shim class > Upgrade to scalatest 3.2.0 for Scala 2.13.3 compatibility > - > > Key: SPARK-32398 > URL: https://issues.apache.org/jira/browse/SPARK-32398 > Project: Spark > Issue Type: Sub-task > Components: ML, Spark Core, SQL, Structured Streaming, Tests >Affects Versions: 3.0.0 >Reporter: Sean R. Owen >Assignee: Sean R. Owen >Priority: Major > Fix For: 3.1.0 > > > We'll need to update to scalatest 3.2.0 in order to pick up the fix here, > which fixes an incompatibility with Scala 2.13.3: > https://github.com/scalatest/scalatest/commit/7c89416aa9f3e7f2730a343ad6d3bdcff65809de > That's a big change unfortunately - 3.1 / 3.2 reorganized many classes. > Fortunately it's just like import updates in 100 files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-32398) Upgrade to scalatest 3.2.0 for Scala 2.13.3 compatibility
[ https://issues.apache.org/jira/browse/SPARK-32398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163161#comment-17163161 ] Apache Spark commented on SPARK-32398: -- User 'srowen' has created a pull request for this issue: https://github.com/apache/spark/pull/29196 > Upgrade to scalatest 3.2.0 for Scala 2.13.3 compatibility > - > > Key: SPARK-32398 > URL: https://issues.apache.org/jira/browse/SPARK-32398 > Project: Spark > Issue Type: Sub-task > Components: ML, Spark Core, SQL, Structured Streaming, Tests >Affects Versions: 3.0.0 >Reporter: Sean R. Owen >Assignee: Sean R. Owen >Priority: Major > > We'll need to update to scalatest 3.2.0 in order to pick up the fix here, > which fixes an incompatibility with Scala 2.13.3: > https://github.com/scalatest/scalatest/commit/7c89416aa9f3e7f2730a343ad6d3bdcff65809de > That's a big change unfortunately - 3.1 / 3.2 reorganized many classes. > Fortunately it's just like import updates in 100 files. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
