[jira] [Commented] (SPARK-5541) Allow running Maven or SBT in run-tests
[ https://issues.apache.org/jira/browse/SPARK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360628#comment-14360628 ] Brennon York commented on SPARK-5541: - [~nchammas], [~pwendell] was there anything specific we wanted to accomplish with this JIRA different (or in addition) to SPARK-3355? Otherwise I was going to close it out. Just wanted to make sure first! Allow running Maven or SBT in run-tests --- Key: SPARK-5541 URL: https://issues.apache.org/jira/browse/SPARK-5541 Project: Spark Issue Type: Improvement Components: Build Reporter: Patrick Wendell Assignee: Nicholas Chammas It would be nice if we had a hook for the spark test scripts to run with Maven in addition to running with SBT. Right now it is difficult for us to test pull requests in maven and we get master build breaks because of it. A simple first step is to modify run-tests to allow building with maven. Then we can add a second PRB that invokes this maven build. I would just add an env var called SPARK_BUILD_TOOL that can be set to sbt or mvn. And make sure the associated logic works in either case. If we don't want to have the fancy SQL only stuff in Maven, that's fine too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-5541) Allow running Maven or SBT in run-tests
[ https://issues.apache.org/jira/browse/SPARK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333991#comment-14333991 ] Brennon York commented on SPARK-5541: - Just pushed up a PR for [SPARK-3355|https://issues.apache.org/jira/browse/SPARK-3355], but could easily change the env. var. to SPARK_BUILD_TOOL (rather than AMPLAB_JENKINS_BUILD_TOOL) if that would be the now-preferred route. Allow running Maven or SBT in run-tests --- Key: SPARK-5541 URL: https://issues.apache.org/jira/browse/SPARK-5541 Project: Spark Issue Type: Improvement Components: Build Reporter: Patrick Wendell Assignee: Nicholas Chammas It would be nice if we had a hook for the spark test scripts to run with Maven in addition to running with SBT. Right now it is difficult for us to test pull requests in maven and we get master build breaks because of it. A simple first step is to modify run-tests to allow building with maven. Then we can add a second PRB that invokes this maven build. I would just add an env var called SPARK_BUILD_TOOL that can be set to sbt or mvn. And make sure the associated logic works in either case. If we don't want to have the fancy SQL only stuff in Maven, that's fine too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-5541) Allow running Maven or SBT in run-tests
[ https://issues.apache.org/jira/browse/SPARK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302525#comment-14302525 ] Nicholas Chammas commented on SPARK-5541: - Dup of SPARK-3355? Allow running Maven or SBT in run-tests --- Key: SPARK-5541 URL: https://issues.apache.org/jira/browse/SPARK-5541 Project: Spark Issue Type: Bug Components: Build Reporter: Patrick Wendell Assignee: Nicholas Chammas It would be nice if we had a hook for the spark test scripts to run with Maven in addition to running with SBT. Right now it is difficult for us to test pull requests in maven and we get master build breaks because of it. A simple first step is to modify run-tests to allow building with maven. Then we can add a second PRB that invokes this maven build. I would just add an env var called SPARK_BUILD_TOOL that can be set to sbt or mvn. And make sure the associated logic works in either case. If we don't want to have the fancy SQL only stuff in Maven, that's fine too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
