[jira] [Commented] (SPARK-7651) PySpark GMM predict, predictSoft should fail on bad input
[ https://issues.apache.org/jira/browse/SPARK-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545126#comment-14545126 ] Apache Spark commented on SPARK-7651: - User 'FlytxtRnD' has created a pull request for this issue: https://github.com/apache/spark/pull/6180 > PySpark GMM predict, predictSoft should fail on bad input > - > > Key: SPARK-7651 > URL: https://issues.apache.org/jira/browse/SPARK-7651 > Project: Spark > Issue Type: Bug > Components: MLlib, PySpark >Affects Versions: 1.3.0, 1.3.1, 1.4.0 >Reporter: Joseph K. Bradley >Priority: Minor > > In PySpark, GaussianMixtureModel predict and predictSoft test if the argument > is an RDD and operate correctly if so. But if the argument is not an RDD, > they fail silently, returning nothing. > [https://github.com/apache/spark/blob/11a1a135d1fe892cd48a9116acc7554846aed84c/python/pyspark/mllib/clustering.py#L176] > Instead, they should raise errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7651) PySpark GMM predict, predictSoft should fail on bad input
[ https://issues.apache.org/jira/browse/SPARK-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544930#comment-14544930 ] Meethu Mathew commented on SPARK-7651: -- Ok thank you > PySpark GMM predict, predictSoft should fail on bad input > - > > Key: SPARK-7651 > URL: https://issues.apache.org/jira/browse/SPARK-7651 > Project: Spark > Issue Type: Bug > Components: MLlib, PySpark >Affects Versions: 1.3.0, 1.3.1, 1.4.0 >Reporter: Joseph K. Bradley >Priority: Minor > > In PySpark, GaussianMixtureModel predict and predictSoft test if the argument > is an RDD and operate correctly if so. But if the argument is not an RDD, > they fail silently, returning nothing. > [https://github.com/apache/spark/blob/11a1a135d1fe892cd48a9116acc7554846aed84c/python/pyspark/mllib/clustering.py#L176] > Instead, they should raise errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7651) PySpark GMM predict, predictSoft should fail on bad input
[ https://issues.apache.org/jira/browse/SPARK-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544929#comment-14544929 ] Meethu Mathew commented on SPARK-7651: -- Ok thank you > PySpark GMM predict, predictSoft should fail on bad input > - > > Key: SPARK-7651 > URL: https://issues.apache.org/jira/browse/SPARK-7651 > Project: Spark > Issue Type: Bug > Components: MLlib, PySpark >Affects Versions: 1.3.0, 1.3.1, 1.4.0 >Reporter: Joseph K. Bradley >Priority: Minor > > In PySpark, GaussianMixtureModel predict and predictSoft test if the argument > is an RDD and operate correctly if so. But if the argument is not an RDD, > they fail silently, returning nothing. > [https://github.com/apache/spark/blob/11a1a135d1fe892cd48a9116acc7554846aed84c/python/pyspark/mllib/clustering.py#L176] > Instead, they should raise errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7651) PySpark GMM predict, predictSoft should fail on bad input
[ https://issues.apache.org/jira/browse/SPARK-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544927#comment-14544927 ] Joseph K. Bradley commented on SPARK-7651: -- Please base your PR on master. I can then merge it with master + the other branches. > PySpark GMM predict, predictSoft should fail on bad input > - > > Key: SPARK-7651 > URL: https://issues.apache.org/jira/browse/SPARK-7651 > Project: Spark > Issue Type: Bug > Components: MLlib, PySpark >Affects Versions: 1.3.0, 1.3.1, 1.4.0 >Reporter: Joseph K. Bradley >Priority: Minor > > In PySpark, GaussianMixtureModel predict and predictSoft test if the argument > is an RDD and operate correctly if so. But if the argument is not an RDD, > they fail silently, returning nothing. > [https://github.com/apache/spark/blob/11a1a135d1fe892cd48a9116acc7554846aed84c/python/pyspark/mllib/clustering.py#L176] > Instead, they should raise errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7651) PySpark GMM predict, predictSoft should fail on bad input
[ https://issues.apache.org/jira/browse/SPARK-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544924#comment-14544924 ] Meethu Mathew commented on SPARK-7651: -- Could you please tell me where I should make the changes? In master branch or 1.3.0? > PySpark GMM predict, predictSoft should fail on bad input > - > > Key: SPARK-7651 > URL: https://issues.apache.org/jira/browse/SPARK-7651 > Project: Spark > Issue Type: Bug > Components: MLlib, PySpark >Affects Versions: 1.3.0, 1.3.1, 1.4.0 >Reporter: Joseph K. Bradley >Priority: Minor > > In PySpark, GaussianMixtureModel predict and predictSoft test if the argument > is an RDD and operate correctly if so. But if the argument is not an RDD, > they fail silently, returning nothing. > [https://github.com/apache/spark/blob/11a1a135d1fe892cd48a9116acc7554846aed84c/python/pyspark/mllib/clustering.py#L176] > Instead, they should raise errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7651) PySpark GMM predict, predictSoft should fail on bad input
[ https://issues.apache.org/jira/browse/SPARK-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544923#comment-14544923 ] Joseph K. Bradley commented on SPARK-7651: -- Great, thank you! > PySpark GMM predict, predictSoft should fail on bad input > - > > Key: SPARK-7651 > URL: https://issues.apache.org/jira/browse/SPARK-7651 > Project: Spark > Issue Type: Bug > Components: MLlib, PySpark >Affects Versions: 1.3.0, 1.3.1, 1.4.0 >Reporter: Joseph K. Bradley >Priority: Minor > > In PySpark, GaussianMixtureModel predict and predictSoft test if the argument > is an RDD and operate correctly if so. But if the argument is not an RDD, > they fail silently, returning nothing. > [https://github.com/apache/spark/blob/11a1a135d1fe892cd48a9116acc7554846aed84c/python/pyspark/mllib/clustering.py#L176] > Instead, they should raise errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7651) PySpark GMM predict, predictSoft should fail on bad input
[ https://issues.apache.org/jira/browse/SPARK-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544910#comment-14544910 ] Meethu Mathew commented on SPARK-7651: -- [~josephkb] Yea, I wil fix it asap. > PySpark GMM predict, predictSoft should fail on bad input > - > > Key: SPARK-7651 > URL: https://issues.apache.org/jira/browse/SPARK-7651 > Project: Spark > Issue Type: Bug > Components: MLlib, PySpark >Affects Versions: 1.3.0, 1.3.1, 1.4.0 >Reporter: Joseph K. Bradley >Priority: Minor > > In PySpark, GaussianMixtureModel predict and predictSoft test if the argument > is an RDD and operate correctly if so. But if the argument is not an RDD, > they fail silently, returning nothing. > [https://github.com/apache/spark/blob/11a1a135d1fe892cd48a9116acc7554846aed84c/python/pyspark/mllib/clustering.py#L176] > Instead, they should raise errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7651) PySpark GMM predict, predictSoft should fail on bad input
[ https://issues.apache.org/jira/browse/SPARK-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544599#comment-14544599 ] Joseph K. Bradley commented on SPARK-7651: -- Ping [~MeethuMathew]: Could you please make this fix? It should be quick. Thank you! > PySpark GMM predict, predictSoft should fail on bad input > - > > Key: SPARK-7651 > URL: https://issues.apache.org/jira/browse/SPARK-7651 > Project: Spark > Issue Type: Bug > Components: MLlib, PySpark >Affects Versions: 1.3.0, 1.3.1, 1.4.0 >Reporter: Joseph K. Bradley > > In PySpark, GaussianMixtureModel predict and predictSoft test if the argument > is an RDD and operate correctly if so. But if the argument is not an RDD, > they fail silently, returning nothing. > [https://github.com/apache/spark/blob/11a1a135d1fe892cd48a9116acc7554846aed84c/python/pyspark/mllib/clustering.py#L176] > Instead, they should raise errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
