[jira] [Commented] (SPARK-7992) Hide private classes/objects in in generated Java API doc
[
https://issues.apache.org/jira/browse/SPARK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253031#comment-15253031
]
Xiangrui Meng commented on SPARK-7992:
--
Thanks for making this work in the official repo! I'm going to close this JIRA.
I posted some issues on https://github.com/typesafehub/genjavadoc/issues/73,
which we can either discuss there on in SPARK-14511.
> Hide private classes/objects in in generated Java API doc
> -
>
> Key: SPARK-7992
> URL: https://issues.apache.org/jira/browse/SPARK-7992
> Project: Spark
> Issue Type: Improvement
> Components: Build, Documentation
>Affects Versions: 1.4.0
>Reporter: Xiangrui Meng
> Fix For: 2.0.0
>
>
> After SPARK-5610, we found that private classes/objects still show up in the
> generated Java API doc, e.g., under `org.apache.spark.api.r` we can see
> {code}
> BaseRRDD
> PairwiseRRDD
> RRDD
> SpecialLengths
> StringRRDD
> {code}
> We should update genjavadoc to hide those private classes/methods. The best
> approach is to find a good mapping from Scala private to Java, and merge it
> into the main genjavadoc repo. A WIP PR is at
> https://github.com/typesafehub/genjavadoc/pull/47.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7992) Hide private classes/objects in in generated Java API doc
[
https://issues.apache.org/jira/browse/SPARK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242725#comment-15242725
]
Jakob Odersky commented on SPARK-7992:
--
[~mengxr], The PR is finally in! Let's hope upstream makes a release soon.
> Hide private classes/objects in in generated Java API doc
> -
>
> Key: SPARK-7992
> URL: https://issues.apache.org/jira/browse/SPARK-7992
> Project: Spark
> Issue Type: Improvement
> Components: Build, Documentation
>Affects Versions: 1.4.0
>Reporter: Xiangrui Meng
>
> After SPARK-5610, we found that private classes/objects still show up in the
> generated Java API doc, e.g., under `org.apache.spark.api.r` we can see
> {code}
> BaseRRDD
> PairwiseRRDD
> RRDD
> SpecialLengths
> StringRRDD
> {code}
> We should update genjavadoc to hide those private classes/methods. The best
> approach is to find a good mapping from Scala private to Java, and merge it
> into the main genjavadoc repo. A WIP PR is at
> https://github.com/typesafehub/genjavadoc/pull/47.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7992) Hide private classes/objects in in generated Java API doc
[
https://issues.apache.org/jira/browse/SPARK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215315#comment-15215315
]
Jakob Odersky commented on SPARK-7992:
--
[~mengxr], I just submitted [another
PR|https://github.com/typesafehub/genjavadoc/pull/71] to the genjavadoc
project. Once accepted, the original functionality should be straight-forward
to merge.
> Hide private classes/objects in in generated Java API doc
> -
>
> Key: SPARK-7992
> URL: https://issues.apache.org/jira/browse/SPARK-7992
> Project: Spark
> Issue Type: Improvement
> Components: Build, Documentation
>Affects Versions: 1.4.0
>Reporter: Xiangrui Meng
>
> After SPARK-5610, we found that private classes/objects still show up in the
> generated Java API doc, e.g., under `org.apache.spark.api.r` we can see
> {code}
> BaseRRDD
> PairwiseRRDD
> RRDD
> SpecialLengths
> StringRRDD
> {code}
> We should update genjavadoc to hide those private classes/methods. The best
> approach is to find a good mapping from Scala private to Java, and merge it
> into the main genjavadoc repo. A WIP PR is at
> https://github.com/typesafehub/genjavadoc/pull/47.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7992) Hide private classes/objects in in generated Java API doc
[
https://issues.apache.org/jira/browse/SPARK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209280#comment-15209280
]
Jakob Odersky commented on SPARK-7992:
--
Hey Xiangrui,
you caught me in a very busy time last week and I'm afraid to say that I
completely forgot about this. I just took up the issue. Take a look at my
comment on the PR thread https://github.com/typesafehub/genjavadoc/pull/47.
> Hide private classes/objects in in generated Java API doc
> -
>
> Key: SPARK-7992
> URL: https://issues.apache.org/jira/browse/SPARK-7992
> Project: Spark
> Issue Type: Improvement
> Components: Build, Documentation
>Affects Versions: 1.4.0
>Reporter: Xiangrui Meng
>
> After SPARK-5610, we found that private classes/objects still show up in the
> generated Java API doc, e.g., under `org.apache.spark.api.r` we can see
> {code}
> BaseRRDD
> PairwiseRRDD
> RRDD
> SpecialLengths
> StringRRDD
> {code}
> We should update genjavadoc to hide those private classes/methods. The best
> approach is to find a good mapping from Scala private to Java, and merge it
> into the main genjavadoc repo. A WIP PR is at
> https://github.com/typesafehub/genjavadoc/pull/47.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7992) Hide private classes/objects in in generated Java API doc
[
https://issues.apache.org/jira/browse/SPARK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208770#comment-15208770
]
Xiangrui Meng commented on SPARK-7992:
--
[~jodersky] Any updates?
> Hide private classes/objects in in generated Java API doc
> -
>
> Key: SPARK-7992
> URL: https://issues.apache.org/jira/browse/SPARK-7992
> Project: Spark
> Issue Type: Improvement
> Components: Build, Documentation
>Affects Versions: 1.4.0
>Reporter: Xiangrui Meng
>
> After SPARK-5610, we found that private classes/objects still show up in the
> generated Java API doc, e.g., under `org.apache.spark.api.r` we can see
> {code}
> BaseRRDD
> PairwiseRRDD
> RRDD
> SpecialLengths
> StringRRDD
> {code}
> We should update genjavadoc to hide those private classes/methods. The best
> approach is to find a good mapping from Scala private to Java, and merge it
> into the main genjavadoc repo. A WIP PR is at
> https://github.com/typesafehub/genjavadoc/pull/47.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7992) Hide private classes/objects in in generated Java API doc
[
https://issues.apache.org/jira/browse/SPARK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200106#comment-15200106
]
Xiangrui Meng commented on SPARK-7992:
--
Great! I pinged you on the old genjavadoc PR page. Hopefully we don't need to
maintain a forked version in Spark 2.0.
> Hide private classes/objects in in generated Java API doc
> -
>
> Key: SPARK-7992
> URL: https://issues.apache.org/jira/browse/SPARK-7992
> Project: Spark
> Issue Type: Improvement
> Components: Build, Documentation
>Affects Versions: 1.4.0
>Reporter: Xiangrui Meng
>
> After SPARK-5610, we found that private classes/objects still show up in the
> generated Java API doc, e.g., under `org.apache.spark.api.r` we can see
> {code}
> BaseRRDD
> PairwiseRRDD
> RRDD
> SpecialLengths
> StringRRDD
> {code}
> We should update genjavadoc to hide those private classes/methods. The best
> approach is to find a good mapping from Scala private to Java, and merge it
> into the main genjavadoc repo. A WIP PR is at
> https://github.com/typesafehub/genjavadoc/pull/47.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7992) Hide private classes/objects in in generated Java API doc
[
https://issues.apache.org/jira/browse/SPARK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197676#comment-15197676
]
Xiangrui Meng commented on SPARK-7992:
--
[~jodersky] Do you mind taking a look at this issue?
We used a patched version of genjavadoc in Spark to hide package private
members in the generated Java API doc. However, this was not merged into the
official genjavadoc repo and it creates problems to support new Scala versions
since genjavadoc requires cross build. It would be good to spend some time to
get the patch in.
This is the patch
(https://github.com/typesafehub/genjavadoc/compare/master...mengxr:hide-private)
but it no longer works in the current genjavadoc master.
cc [~yhuai] and [~rxin]
> Hide private classes/objects in in generated Java API doc
> -
>
> Key: SPARK-7992
> URL: https://issues.apache.org/jira/browse/SPARK-7992
> Project: Spark
> Issue Type: Improvement
> Components: Build, Documentation
>Affects Versions: 1.4.0
>Reporter: Xiangrui Meng
>Assignee: Xiangrui Meng
>
> After SPARK-5610, we found that private classes/objects still show up in the
> generated Java API doc, e.g., under `org.apache.spark.api.r` we can see
> {code}
> BaseRRDD
> PairwiseRRDD
> RRDD
> SpecialLengths
> StringRRDD
> {code}
> We should update genjavadoc to hide those private classes/methods. The best
> approach is to find a good mapping from Scala private to Java, and merge it
> into the main genjavadoc repo. A WIP PR is at
> https://github.com/typesafehub/genjavadoc/pull/47.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7992) Hide private classes/objects in in generated Java API doc
[
https://issues.apache.org/jira/browse/SPARK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197877#comment-15197877
]
Jakob Odersky commented on SPARK-7992:
--
I'll check it out
> Hide private classes/objects in in generated Java API doc
> -
>
> Key: SPARK-7992
> URL: https://issues.apache.org/jira/browse/SPARK-7992
> Project: Spark
> Issue Type: Improvement
> Components: Build, Documentation
>Affects Versions: 1.4.0
>Reporter: Xiangrui Meng
>
> After SPARK-5610, we found that private classes/objects still show up in the
> generated Java API doc, e.g., under `org.apache.spark.api.r` we can see
> {code}
> BaseRRDD
> PairwiseRRDD
> RRDD
> SpecialLengths
> StringRRDD
> {code}
> We should update genjavadoc to hide those private classes/methods. The best
> approach is to find a good mapping from Scala private to Java, and merge it
> into the main genjavadoc repo. A WIP PR is at
> https://github.com/typesafehub/genjavadoc/pull/47.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7992) Hide private classes/objects in in generated Java API doc
[
https://issues.apache.org/jira/browse/SPARK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703246#comment-14703246
]
Xiangrui Meng commented on SPARK-7992:
--
We need to update the official genjavadoc to make this a feature flag. But I
haven't found a time to do it yet.
Hide private classes/objects in in generated Java API doc
-
Key: SPARK-7992
URL: https://issues.apache.org/jira/browse/SPARK-7992
Project: Spark
Issue Type: Improvement
Components: Documentation
Affects Versions: 1.4.0
Reporter: Xiangrui Meng
Assignee: Xiangrui Meng
After SPARK-5610, we found that private classes/objects still show up in the
generated Java API doc, e.g., under `org.apache.spark.api.r` we can see
{code}
BaseRRDD
PairwiseRRDD
RRDD
SpecialLengths
StringRRDD
{code}
We should update genjavadoc to hide those private classes/methods. The best
approach is to find a good mapping from Scala private to Java, and merge it
into the main genjavadoc repo. A WIP PR is at
https://github.com/typesafehub/genjavadoc/pull/47.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-7992) Hide private classes/objects in in generated Java API doc
[
https://issues.apache.org/jira/browse/SPARK-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702500#comment-14702500
]
Reynold Xin commented on SPARK-7992:
[~mengxr] what's going on with this one?
Hide private classes/objects in in generated Java API doc
-
Key: SPARK-7992
URL: https://issues.apache.org/jira/browse/SPARK-7992
Project: Spark
Issue Type: Improvement
Components: Documentation
Affects Versions: 1.4.0
Reporter: Xiangrui Meng
Assignee: Xiangrui Meng
After SPARK-5610, we found that private classes/objects still show up in the
generated Java API doc, e.g., under `org.apache.spark.api.r` we can see
{code}
BaseRRDD
PairwiseRRDD
RRDD
SpecialLengths
StringRRDD
{code}
We should update genjavadoc to hide those private classes/methods. The best
approach is to find a good mapping from Scala private to Java, and merge it
into the main genjavadoc repo. A WIP PR is at
https://github.com/typesafehub/genjavadoc/pull/47.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
