[jira] [Commented] (SPARK-9715) Store numFeatures in all ML PredictionModel types

2015-09-09 Thread Apache Spark (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-9715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737797#comment-14737797
 ] 

Apache Spark commented on SPARK-9715:
-

User 'sethah' has created a pull request for this issue:
https://github.com/apache/spark/pull/8675

> Store numFeatures in all ML PredictionModel types
> -
>
> Key: SPARK-9715
> URL: https://issues.apache.org/jira/browse/SPARK-9715
> Project: Spark
>  Issue Type: Improvement
>  Components: ML
>Reporter: Joseph K. Bradley
>Priority: Minor
>
> The PredictionModel abstraction should store numFeatures.  Currently, only 
> RandomForest* types do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-9715) Store numFeatures in all ML PredictionModel types

2015-09-08 Thread Joseph K. Bradley (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-9715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735938#comment-14735938
 ] 

Joseph K. Bradley commented on SPARK-9715:
--

Sounds good.  The main issue is that, for backwards compatibility, you'll need 
to provide a default value.  That should probably be -1, and documented.  
Thanks!

> Store numFeatures in all ML PredictionModel types
> -
>
> Key: SPARK-9715
> URL: https://issues.apache.org/jira/browse/SPARK-9715
> Project: Spark
>  Issue Type: Improvement
>  Components: ML
>Reporter: Joseph K. Bradley
>Priority: Minor
>
> The PredictionModel abstraction should store numFeatures.  Currently, only 
> RandomForest* types do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-9715) Store numFeatures in all ML PredictionModel types

2015-09-08 Thread Seth Hendrickson (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-9715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735065#comment-14735065
 ] 

Seth Hendrickson commented on SPARK-9715:
-

I can take this one if no one else has started it. Plan is to add abstract 
method {{def numFeatures: Int}} to the {{PredictionModel}} abstract class and 
implement methods for each learning model that inherits from PredictionModel. 

> Store numFeatures in all ML PredictionModel types
> -
>
> Key: SPARK-9715
> URL: https://issues.apache.org/jira/browse/SPARK-9715
> Project: Spark
>  Issue Type: Improvement
>  Components: ML
>Reporter: Joseph K. Bradley
>Priority: Minor
>
> The PredictionModel abstraction should store numFeatures.  Currently, only 
> RandomForest* types do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org