[
https://issues.apache.org/jira/browse/SPARK-25534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun updated SPARK-25534:
----------------------------------
Comment: was deleted
(was: User 'dongjoon-hyun' has created a pull request for this issue:
https://github.com/apache/spark/pull/22548)
> Make `SQLHelper` trait
> ----------------------
>
> Key: SPARK-25534
> URL: https://issues.apache.org/jira/browse/SPARK-25534
> Project: Spark
> Issue Type: Bug
> Components: SQL
> Affects Versions: 2.5.0
> Reporter: Dongjoon Hyun
> Assignee: Dongjoon Hyun
> Priority: Major
>
> Currently, Spark has 7 `withTempPath` and 6 `withSQLConf` functions. This PR
> aims to remove duplicated and inconsistent code and reduce them to the
> following meaningful implementations.
> *withTempPath*
> - `SQLHelper.withTempPath`: The one which was used in `SQLTestUtils`.
> *withSQLConf*
> - `SQLHelper.withSQLConf`: The one which was used in `PlanTest`.
> - `ExecutorSideSQLConfSuite.withSQLConf`: The one which doesn't throw
> `AnalysisException` on StaticConf changes.
> - `SQLTestUtils.withSQLConf`: The one which overrides intentionally to change
> the active session.
> {code}
> protected override def withSQLConf(pairs: (String, String)*)(f: => Unit):
> Unit = {
> SparkSession.setActiveSession(spark)
> super.withSQLConf(pairs: _*)(f)
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
