[jira] [Resolved] (STORM-3276) Can't run Flux with Storm 2.0.0

2018-12-21 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3276.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Can't run Flux with Storm 2.0.0
> ---
>
> Key: STORM-3276
> URL: https://issues.apache.org/jira/browse/STORM-3276
> Project: Apache Storm
>  Issue Type: Bug
>  Components: Flux
>Affects Versions: 2.0.0
>Reporter: Julien Nioche
>Assignee: Robert Joseph Evans
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> I try to run a Flux-based topology with Storm 2.0.0
>  
> _apache-storm-2.0.0/bin/storm local target/2-1.0-SNAPSHOT.jar 
> org.apache.storm.flux.Flux crawler.flux --local-ttl 999_
>  
> Am getting 
>  
> _17:41:22.191 [main] ERROR o.a.s.f.Flux - To run in local mode run with 
> 'storm local' instead of 'storm jar'_
> _17:41:22.191 [main] INFO o.a.s.LocalCluster -_
> _RUNNING LOCAL CLUSTER for 999 seconds._
> and nothing happens after that. 
>  
> The documentation for Flux 
> [http://storm.apache.org/releases/2.0.0-SNAPSHOT/flux.html] still mentions 
> using 'storm jar' as well as --local and --sleep.
> My test topology can be found at [https://github.com/DigitalPebble/storm2] 
> and requires the branch 2.x of StormCrawler 
> [https://github.com/DigitalPebble/storm-crawler/tree/2.x] to by installed.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3295) Blacklist scheduling doesn't handle multiple supervisors on a host properly

2018-12-18 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3295.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~agresch],

 

I merged this into master

> Blacklist scheduling doesn't handle multiple supervisors on a host properly
> ---
>
> Key: STORM-3295
> URL: https://issues.apache.org/jira/browse/STORM-3295
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> If two supervisors on a host are blacklisted, the RasBlacklistStrategy code 
> can release one supervisor and keep the other blacklisted.  The 
> BlacklistScheduler then sees the one blacklisted supervisor and considers 
> that host still blacklisted, preventing scheduling from operating properly.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3303) update some logging priorities

2018-12-18 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3303.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~agresch],

 

I merged this into master

> update some logging priorities
> --
>
> Key: STORM-3303
> URL: https://issues.apache.org/jira/browse/STORM-3303
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Some log messages could use some tweaking in priorities:
>  
> Sample: this could be a warning, as retries/reconnects are built-in:
> {code:java}
> 2018-12-06 06:36:56.439 o.a.s.p.PacemakerClient timer [ERROR] Not getting 
> response or getting null response. Making 6 more attempts for .
> {code}
>  * [|https://jira.ouroath.com/secure/AddComment!default.jspa?id=3421505]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3288) Extracting jar dirs with resources in them are corrupted

2018-11-16 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3288:
--

 Summary: Extracting jar dirs with resources in them are corrupted
 Key: STORM-3288
 URL: https://issues.apache.org/jira/browse/STORM-3288
 Project: Apache Storm
  Issue Type: Bug
  Components: storm-server
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


The current code when it tries to remove resources/ from the beginning of the 
path ends up removing it everywhere it exists in the path, which messes up 
anything with a directory named
{code:java}
*resources/{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-2891) Upgrade Checkstyle plugin to version 3.0.0

2018-11-13 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-2891.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~Srdo],

 

I merged this into master

> Upgrade Checkstyle plugin to version 3.0.0
> --
>
> Key: STORM-2891
> URL: https://issues.apache.org/jira/browse/STORM-2891
> Project: Apache Storm
>  Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: Stig Rohde Døssing
>Assignee: Stig Rohde Døssing
>Priority: Minor
>  Labels: newbie, pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It would be good to upgrade the maven-checkstyle-plugin to version 3.0.0. 
> Some pretty nice quality of life improvements there 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223=12333072.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3284) Add cgroup inheritance to cgroup manager

2018-11-13 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3284.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Add cgroup inheritance to cgroup manager
> 
>
> Key: STORM-3284
> URL: https://issues.apache.org/jira/browse/STORM-3284
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Reporter: Kishor Patil
>Assignee: Kishor Patil
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It is ability for CgroupManager to allow creating worker cgroups by 
> inheriting parent group configs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3275) Fix Storm Profiler Start UI Helper method

2018-11-02 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3275.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Fix Storm Profiler Start UI Helper method
> -
>
> Key: STORM-3275
> URL: https://issues.apache.org/jira/browse/STORM-3275
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-webapp
>Reporter: Kishor Patil
>Assignee: Kishor Patil
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The Jprofiler start action, requires calculating timeout in milliseconds, 
> while input is in minutes. Also, the logic works to say, STOP at timeout 
> instead of start. This was I think clojure to java translation error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (STORM-3261) YAML headers in the /docs

2018-10-31 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans reassigned STORM-3261:
--

Assignee: Manuel Dossinger

> YAML headers in the /docs
> -
>
> Key: STORM-3261
> URL: https://issues.apache.org/jira/browse/STORM-3261
> Project: Apache Storm
>  Issue Type: Documentation
>  Components: documentation
>Reporter: Manuel Dossinger
>Assignee: Manuel Dossinger
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I was looking through the documentation when I found some dead links, e.g. 
> `storm-pmml` and `storm-kinesis`. The links are there on the index page, 
> however jekyll does not generate the wanted HTML-files them as the 
> Markdown-files lack YAML headers.
> I'd volunteer to search for other occurrences of that problem and fix it by 
> adding YAML headers to the according files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3261) YAML headers in the /docs

2018-10-31 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3261.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~contradictioned],

 

I merged this into master.  Keep up the good work.

> YAML headers in the /docs
> -
>
> Key: STORM-3261
> URL: https://issues.apache.org/jira/browse/STORM-3261
> Project: Apache Storm
>  Issue Type: Documentation
>  Components: documentation
>Reporter: Manuel Dossinger
>Assignee: Manuel Dossinger
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I was looking through the documentation when I found some dead links, e.g. 
> `storm-pmml` and `storm-kinesis`. The links are there on the index page, 
> however jekyll does not generate the wanted HTML-files them as the 
> Markdown-files lack YAML headers.
> I'd volunteer to search for other occurrences of that problem and fix it by 
> adding YAML headers to the according files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3273) Don't pass storm.local.hostname to topology conf

2018-10-24 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3273.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Don't pass storm.local.hostname to topology conf
> 
>
> Key: STORM-3273
> URL: https://issues.apache.org/jira/browse/STORM-3273
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We have found that if we set storm.local.hostname on nimbus it gets put into 
> the topology conf which in turn causes the topology to report all metrics as 
> coming from nimbus, which is not what we want.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3269) storm-client and storm-server indirectly depend on storm-core

2018-10-23 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3269.

   Resolution: Fixed
Fix Version/s: 2.0.0

> storm-client and storm-server indirectly depend on storm-core
> -
>
> Key: STORM-3269
> URL: https://issues.apache.org/jira/browse/STORM-3269
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-client, storm-core, storm-server
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When trying to get the version information for nimbus it looks for 
> storm-core, which requires the storm-core class to be on the classpath.  We 
> need to fix this, because VersionInfo is in storm-client so it is possible 
> for someone who uses it from storm-client to load the wrong thing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3260) Add in more admin commands to debug cluster state

2018-10-23 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3260.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Add in more admin commands to debug cluster state
> -
>
> Key: STORM-3260
> URL: https://issues.apache.org/jira/browse/STORM-3260
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-server
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> It would be really nice to have more visibility into exactly what is stored 
> in ZK.  Specifically the topology that the user submitted to us.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Issue Comment Deleted] (STORM-3273) Don't pass storm.local.hostname to topology conf

2018-10-23 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3273:
---
Comment: was deleted

(was: In the latest versions of ZK this is mostly fixed.  There are some cases 
where it will shut down the entire server if there are errors.  But I don't 
think that they are good enough and we need to extend it further.)

> Don't pass storm.local.hostname to topology conf
> 
>
> Key: STORM-3273
> URL: https://issues.apache.org/jira/browse/STORM-3273
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Critical
>
> We have found that if we set storm.local.hostname on nimbus it gets put into 
> the topology conf which in turn causes the topology to report all metrics as 
> coming from nimbus, which is not what we want.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (STORM-3273) Don't pass storm.local.hostname to topology conf

2018-10-23 Thread Robert Joseph Evans (JIRA)


[ 
https://issues.apache.org/jira/browse/STORM-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660710#comment-16660710
 ] 

Robert Joseph Evans commented on STORM-3273:


In the latest versions of ZK this is mostly fixed.  There are some cases where 
it will shut down the entire server if there are errors.  But I don't think 
that they are good enough and we need to extend it further.

> Don't pass storm.local.hostname to topology conf
> 
>
> Key: STORM-3273
> URL: https://issues.apache.org/jira/browse/STORM-3273
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Critical
>
> We have found that if we set storm.local.hostname on nimbus it gets put into 
> the topology conf which in turn causes the topology to report all metrics as 
> coming from nimbus, which is not what we want.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3273) Don't pass storm.local.hostname to topology conf

2018-10-23 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3273:
--

 Summary: Don't pass storm.local.hostname to topology conf
 Key: STORM-3273
 URL: https://issues.apache.org/jira/browse/STORM-3273
 Project: Apache Storm
  Issue Type: Bug
  Components: storm-server
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


We have found that if we set storm.local.hostname on nimbus it gets put into 
the topology conf which in turn causes the topology to report all metrics as 
coming from nimbus, which is not what we want.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3263) Memory and CPU guarantee columns do not sort correctly in Owner Summary

2018-10-22 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3263.

   Resolution: Fixed
 Assignee: Jacob Tolar
Fix Version/s: 2.0.0

Thanks [~jtolar],

 

I merged this into master.

> Memory and CPU guarantee columns do not sort correctly in Owner Summary
> ---
>
> Key: STORM-3263
> URL: https://issues.apache.org/jira/browse/STORM-3263
> Project: Apache Storm
>  Issue Type: Improvement
>Reporter: Jacob Tolar
>Assignee: Jacob Tolar
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
> Attachments: after-fix.png, screenshot-1.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If there is a user running with no guarantees, the memory and CPU guarantee 
> columns show up as "N/A". I think that breaks the DataTables auto detection 
> of the column type and it falls back to string type. Then it does string sort 
> instead of numeric sort which is incorrect for these columns.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3258) prevent flooding supervisor log with blobstore location

2018-10-22 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3258:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> prevent flooding supervisor log with blobstore location
> ---
>
> Key: STORM-3258
> URL: https://issues.apache.org/jira/browse/STORM-3258
> Project: Apache Storm
>  Issue Type: Improvement
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This line repeats over and over in supervisor logs, and really does not 
> provide any useful information.  We should at least change it to debug.
> [https://github.com/apache/storm/blob/master/external/storm-hdfs-blobstore/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStoreImpl.java#L128]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3249) Nimbus Shutdown Faster

2018-10-22 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3249:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> Nimbus Shutdown Faster
> --
>
> Key: STORM-3249
> URL: https://issues.apache.org/jira/browse/STORM-3249
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Nimbus takes for ever to shut down in 2.x.  It would really be nice to fix 
> that. (and it is really our own fault why it takes so long)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3262) Nimbus REST API reports leader before it gains leadership

2018-10-22 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3262.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~agresch],

 

I merged this into master.

> Nimbus REST API reports leader before it gains leadership
> -
>
> Key: STORM-3262
> URL: https://issues.apache.org/jira/browse/STORM-3262
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> At times when nimbus restarts, the REST API returns Leader before leadership 
> is acquired.  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3269) storm-client and storm-server indirectly depend on storm-core

2018-10-22 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3269:
--

 Summary: storm-client and storm-server indirectly depend on 
storm-core
 Key: STORM-3269
 URL: https://issues.apache.org/jira/browse/STORM-3269
 Project: Apache Storm
  Issue Type: Bug
  Components: storm-client, storm-core, storm-server
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


When trying to get the version information for nimbus it looks for storm-core, 
which requires the storm-core class to be on the classpath.  We need to fix 
this, because VersionInfo is in storm-client so it is possible for someone who 
uses it from storm-client to load the wrong thing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3258) prevent flooding supervisor log with blobstore location

2018-10-19 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3258.

   Resolution: Fixed
Fix Version/s: 2.0.1

Thanks [~agresch],

 

I merged this to master.

> prevent flooding supervisor log with blobstore location
> ---
>
> Key: STORM-3258
> URL: https://issues.apache.org/jira/browse/STORM-3258
> Project: Apache Storm
>  Issue Type: Improvement
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This line repeats over and over in supervisor logs, and really does not 
> provide any useful information.  We should at least change it to debug.
> [https://github.com/apache/storm/blob/master/external/storm-hdfs-blobstore/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStoreImpl.java#L128]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3260) Add in more admin commands to debug cluster state

2018-10-17 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3260:
--

 Summary: Add in more admin commands to debug cluster state
 Key: STORM-3260
 URL: https://issues.apache.org/jira/browse/STORM-3260
 Project: Apache Storm
  Issue Type: Improvement
  Components: storm-server
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


It would be really nice to have more visibility into exactly what is stored in 
ZK.  Specifically the topology that the user submitted to us.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3233) Upgrade zookeeper client to newest version (3.4.13)

2018-10-16 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3233:
---
Fix Version/s: (was: 1.1.4)
   (was: 1.2.3)
   (was: 2.0.0)

> Upgrade zookeeper client to newest version (3.4.13)
> ---
>
> Key: STORM-3233
> URL: https://issues.apache.org/jira/browse/STORM-3233
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Affects Versions: 2.0.0
>Reporter: Michal Koziorowski
>Assignee: Michal Koziorowski
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Hi,
> I would like to see new zookeeper client (3.4.13) used in storm.
> New release contains an important fix for cloud environments where zookeeper 
> servers have dynamic ips 
> ([https://jira.apache.org/jira/browse/ZOOKEEPER-2184]).
> If possible, it would be nice to see updated zookeeper also on older storm 
> versions (1.2.x, 1.1.x)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3254) Blob localization time-outs can cause Slot to be stuck and leaked over time

2018-10-15 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3254.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~kishorvpatil],

I merged this into master.

> Blob localization time-outs can cause Slot to be stuck and leaked over time
> ---
>
> Key: STORM-3254
> URL: https://issues.apache.org/jira/browse/STORM-3254
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Reporter: Kishor Patil
>Assignee: Kishor Patil
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If Blobs requested by slot take forever to come back, the Slot could get 
> stuck in  _waiting-for-blob-localization_ state, even after release of slot 
> or topology being killed making that slot unusable. So worker for next 
> assignment will never be launched.
> The steps to reproduce this are:
>  # Delay blob store localization.
>  # kill topology and check jstack.
>  #  worker will not be scheduled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3255) Run with dev-zookeeper on travis-ci

2018-10-15 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3255.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~dagit],

 

I merged this into master.

> Run with dev-zookeeper on travis-ci
> ---
>
> Key: STORM-3255
> URL: https://issues.apache.org/jira/browse/STORM-3255
> Project: Apache Storm
>  Issue Type: Bug
>  Components: integration-test
>Reporter: Derek Dagit
>Assignee: Derek Dagit
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently as part of our automated testing on travis-ci, we install ZooKeeper 
> using the system's package manager.
> Recently, the version of the {{zookeeper}} package (3.4.5) became unavailable 
> from the system's package repositories, and this caused errors in our 
> integration tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3253) Deprecate 'storm repl' subcommand

2018-10-15 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3253.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~dagit],

 

I merged this into master.

> Deprecate 'storm repl' subcommand
> -
>
> Key: STORM-3253
> URL: https://issues.apache.org/jira/browse/STORM-3253
> Project: Apache Storm
>  Issue Type: Task
>  Components: storm-core
>Reporter: Derek Dagit
>Assignee: Derek Dagit
>Priority: Major
>  Labels: java-migration, pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should deprecate {{storm repl}} so that we can remove it in a future 
> release.
> We would remove it because of the move away from Clojure toward Java.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3243) Clean up Maven POM dependency on clojure

2018-10-15 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3243.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~dagit],

 

I merged this into master.

> Clean up Maven POM dependency on clojure
> 
>
> Key: STORM-3243
> URL: https://issues.apache.org/jira/browse/STORM-3243
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: build
>Reporter: Derek Dagit
>Assignee: Derek Dagit
>Priority: Major
>  Labels: java-migration, jstorm-merger, pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Investigate whether we can drop non-test dependencies on Clojure. Drop 
> dependencies on Clojure that we no longer need.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3251) Using Logviewer Filter settings causes anyone to access logs via log viewer REST API

2018-10-12 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3251.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~agresch],

 

I merged this into master.

> Using Logviewer Filter settings causes anyone to access logs via log viewer 
> REST API
> 
>
> Key: STORM-3251
> URL: https://issues.apache.org/jira/browse/STORM-3251
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The rest API for logviewer access is checking if UI filter params is set to 
> deny access to users.  It's possible now to configure the logviewer without 
> UI filter params, so this check is no longer sufficient and can allow anyone 
> access to logs.
>  
> See ResourceAuthorizer line 68



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (STORM-3252) Blobstore sync bug fix

2018-10-12 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans reassigned STORM-3252:
--

Assignee: Arun Mahadevan

> Blobstore sync bug fix
> --
>
> Key: STORM-3252
> URL: https://issues.apache.org/jira/browse/STORM-3252
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 1.2.2
>Reporter: Arun Mahadevan
>Assignee: Arun Mahadevan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3252) Blobstore sync bug fix

2018-10-12 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3252.

   Resolution: Fixed
Fix Version/s: (was: 1.x)

Thanks [~arunmahadevan],

 

I merged this into master.

> Blobstore sync bug fix
> --
>
> Key: STORM-3252
> URL: https://issues.apache.org/jira/browse/STORM-3252
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 1.2.2
>Reporter: Arun Mahadevan
>Assignee: Arun Mahadevan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (STORM-3233) Upgrade zookeeper client to newest version (3.4.13)

2018-10-11 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans reopened STORM-3233:


Need to revert this so we can wait for 3.4.14

> Upgrade zookeeper client to newest version (3.4.13)
> ---
>
> Key: STORM-3233
> URL: https://issues.apache.org/jira/browse/STORM-3233
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Affects Versions: 2.0.0
>Reporter: Michal Koziorowski
>Assignee: Michal Koziorowski
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0, 1.2.3, 1.1.4
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Hi,
> I would like to see new zookeeper client (3.4.13) used in storm.
> New release contains an important fix for cloud environments where zookeeper 
> servers have dynamic ips 
> ([https://jira.apache.org/jira/browse/ZOOKEEPER-2184]).
> If possible, it would be nice to see updated zookeeper also on older storm 
> versions (1.2.x, 1.1.x)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3233) Upgrade zookeeper client to newest version (3.4.13)

2018-10-11 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3233:
---
Summary: Upgrade zookeeper client to newest version (3.4.13)  (was: Upgrade 
zookeeper client to newest version (3.4.14))

> Upgrade zookeeper client to newest version (3.4.13)
> ---
>
> Key: STORM-3233
> URL: https://issues.apache.org/jira/browse/STORM-3233
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Affects Versions: 2.0.0
>Reporter: Michal Koziorowski
>Assignee: Michal Koziorowski
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0, 1.2.3, 1.1.4
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Hi,
> I would like to see new zookeeper client (3.4.13) used in storm.
> New release contains an important fix for cloud environments where zookeeper 
> servers have dynamic ips 
> ([https://jira.apache.org/jira/browse/ZOOKEEPER-2184]).
> If possible, it would be nice to see updated zookeeper also on older storm 
> versions (1.2.x, 1.1.x)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3249) Nimbus Shutdown Faster

2018-10-11 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3249.

   Resolution: Fixed
Fix Version/s: 2.0.1

> Nimbus Shutdown Faster
> --
>
> Key: STORM-3249
> URL: https://issues.apache.org/jira/browse/STORM-3249
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Nimbus takes for ever to shut down in 2.x.  It would really be nice to fix 
> that. (and it is really our own fault why it takes so long)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3248) outputStats not returned in getComponent via Storm API

2018-10-09 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3248.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~govindmenon],

I merged this into master.

> outputStats not returned in getComponent via Storm API
> --
>
> Key: STORM-3248
> URL: https://issues.apache.org/jira/browse/STORM-3248
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Govind Menon
>Assignee: Govind Menon
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-1318) Investigate if backtype.storm.command.shell-submission shuld be dropped

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-1318:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> Investigate if backtype.storm.command.shell-submission shuld be dropped
> ---
>
> Key: STORM-1318
> URL: https://issues.apache.org/jira/browse/STORM-1318
> Project: Apache Storm
>  Issue Type: New Feature
>Reporter: Robert Joseph Evans
>Assignee: Derek Dagit
>Priority: Major
>  Labels: java-migration, jstorm-merger, pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As part of the merger with Jstorm we need to decide if 
> backtype.storm.command.shell-submission should be dropped, or if we should 
> migrate it over to a storm-clojure package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-621) UI should expose more version information

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-621:
--
Fix Version/s: (was: 2.0.1)
   2.0.0

> UI should expose more version information
> -
>
> Key: STORM-621
> URL: https://issues.apache.org/jira/browse/STORM-621
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-core
>Affects Versions: 0.10.0
>Reporter: caofangkun
>Assignee: Robert Joseph Evans
>Priority: Minor
> Fix For: 2.0.0
>
>
> We should view the following information on UI page:
> Storm Version: 0.10.0-SNAPSHOT
> Git https  clone URL : https://github.com/caofangkun/apache-storm.git -r 
> ffba148cc47a92185fa1a5db11f72982de10f106
> Git last checkin id: ffba148cc47a92185fa1a5db11f72982de10f106
> Branch storm-243
> Compiled by somebody on Thu Jan 8 10:47:48 CST 2015
> From source with checksum 97e7c942939e3e82dcb854b497991a51



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-2963) Updates to Performance.md

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-2963:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> Updates to Performance.md 
> --
>
> Key: STORM-2963
> URL: https://issues.apache.org/jira/browse/STORM-2963
> Project: Apache Storm
>  Issue Type: Documentation
>Affects Versions: 2.0.0
>Reporter: Roshan Naik
>Assignee: Roshan Naik
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3236) DRPC meterShutdownCalls marked after metrics stopped

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3236:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> DRPC meterShutdownCalls marked after metrics stopped
> 
>
> Key: STORM-3236
> URL: https://issues.apache.org/jira/browse/STORM-3236
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If we want to track shutdown calls, we need to mark before the 
> metricsRegistry.stopMetricsReporters() call occurs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3233) Upgrade zookeeper client to newest version (3.4.14)

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3233:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> Upgrade zookeeper client to newest version (3.4.14)
> ---
>
> Key: STORM-3233
> URL: https://issues.apache.org/jira/browse/STORM-3233
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Affects Versions: 2.0.0
>Reporter: Michal Koziorowski
>Assignee: Michal Koziorowski
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0, 1.2.3, 1.1.4
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Hi,
> I would like to see new zookeeper client (3.4.13) used in storm.
> New release contains an important fix for cloud environments where zookeeper 
> servers have dynamic ips 
> ([https://jira.apache.org/jira/browse/ZOOKEEPER-2184]).
> If possible, it would be nice to see updated zookeeper also on older storm 
> versions (1.2.x, 1.1.x)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3238) The result of log search for topology doesn't show in UI page

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3238:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> The result of log search for topology doesn't show in UI page
> -
>
> Key: STORM-3238
> URL: https://issues.apache.org/jira/browse/STORM-3238
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-ui
>Affects Versions: 2.0.0
>Reporter: Jungtaek Lim
>Assignee: Derek Dagit
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 2.0.0
>
> Attachments: Screen Shot 2018-09-30 at 4.26.12 PM.png, Screen Shot 
> 2018-09-30 at 4.26.23 PM.png, Screen Shot 2018-09-30 at 4.27.26 PM.png, 
> Screen Shot 2018-09-30 at 4.27.36 PM.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Please refer the attachments to see the symptom. The result seems to be 
> returned from Logviewer but UI doesn't reflect the output.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3235) Auto renewal of WorkerTokens broken.

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3235:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> Auto renewal of WorkerTokens broken.
> 
>
> Key: STORM-3235
> URL: https://issues.apache.org/jira/browse/STORM-3235
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Reporter: Kishor Patil
>Assignee: Kishor Patil
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The condition to renew WorkerToken needs fix and refactor code out of 
> {{Nimbus}} into {{WorkerTokenManager}}.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3234) Document Cluster Metrics

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3234:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> Document Cluster Metrics
> 
>
> Key: STORM-3234
> URL: https://issues.apache.org/jira/browse/STORM-3234
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: documentation
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> We need better docs on what cluster metrics we have in storm.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3237) create metric to track mkAssignments exceptions

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3237:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> create metric to track mkAssignments exceptions
> ---
>
> Key: STORM-3237
> URL: https://issues.apache.org/jira/browse/STORM-3237
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> We had an issue in the past where scheduling was throwing exceptions on 
> nimbus.  I'd like to be able to monitor this issue going forward.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3244) Logviewer uses UI filter settings

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3244:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> Logviewer uses UI filter settings
> -
>
> Key: STORM-3244
> URL: https://issues.apache.org/jira/browse/STORM-3244
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> I was configuring filter settings for the logviewer and discovered I needed 
> to update "ui.filter.params" for the logviewer.  Logviewer should use it's 
> own settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3240) healthchecks fail if scripts return 0 exit code

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3240:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> healthchecks fail if scripts return 0 exit code
> ---
>
> Key: STORM-3240
> URL: https://issues.apache.org/jira/browse/STORM-3240
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3239) Worker profile actions don't work

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3239:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> Worker profile actions don't work
> -
>
> Key: STORM-3239
> URL: https://issues.apache.org/jira/browse/STORM-3239
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-ui
>Affects Versions: 2.0.0
>Reporter: Jungtaek Lim
>Assignee: Govind Menon
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I just noticed that all worker profile actions don't work in 2.0.0-RC1. 
> access-ui logged the message that the action happened, but there's no further 
> log message as well as no action.
> Assigning to [~govindmenon] since he said he is working on this in mailing 
> list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3241) Event Log link on the UI Component page is broken when topology.eventlogger.executors is 0

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3241:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> Event Log link on the UI Component page is broken when 
> topology.eventlogger.executors is 0
> --
>
> Key: STORM-3241
> URL: https://issues.apache.org/jira/browse/STORM-3241
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-webapp
>Reporter: Derek Dagit
>Assignee: Derek Dagit
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The event log link can appear with {{null}} in place of the host. We should 
> hide the event log link when no eventlogger executors have been configured to 
> run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3246) Use UTF-8 charset to ensure log capture non ascii characters from logs

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3246:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> Use UTF-8 charset to ensure log capture non ascii characters from logs
> --
>
> Key: STORM-3246
> URL: https://issues.apache.org/jira/browse/STORM-3246
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-client, storm-core
>Reporter: Kishor Patil
>Assignee: Kishor Patil
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Many a times, user events contain non-standard characters and not print them 
> in visible mode can make it difficult to debug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3247) remove BLOBSTORE_SUPERUSER

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3247:
---
Fix Version/s: (was: 2.0.1)
   2.0.0

> remove BLOBSTORE_SUPERUSER
> --
>
> Key: STORM-3247
> URL: https://issues.apache.org/jira/browse/STORM-3247
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> BLOBSTORE_SUPERUSER doesn't appear to be used. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3247) remove BLOBSTORE_SUPERUSER

2018-10-08 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3247.

   Resolution: Fixed
Fix Version/s: 2.0.1

Thanks [~agresch],

 

I merged this into master

> remove BLOBSTORE_SUPERUSER
> --
>
> Key: STORM-3247
> URL: https://issues.apache.org/jira/browse/STORM-3247
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> BLOBSTORE_SUPERUSER doesn't appear to be used. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3246) Use UTF-8 charset to ensure log capture non ascii characters from logs

2018-10-05 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3246.

   Resolution: Fixed
Fix Version/s: 2.0.1

Thanks [~kishorvpatil],

 

I merged this into master.  If you want it to go anywhere else just let me know 
and we can cherry-pick it.

> Use UTF-8 charset to ensure log capture non ascii characters from logs
> --
>
> Key: STORM-3246
> URL: https://issues.apache.org/jira/browse/STORM-3246
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-client, storm-core
>Reporter: Kishor Patil
>Assignee: Kishor Patil
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Many a times, user events contain non-standard characters and not print them 
> in visible mode can make it difficult to debug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3244) Logviewer uses UI filter settings

2018-10-05 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3244.

   Resolution: Fixed
Fix Version/s: 2.0.1

Thanks [~agresch],

 

I merged this into master.

> Logviewer uses UI filter settings
> -
>
> Key: STORM-3244
> URL: https://issues.apache.org/jira/browse/STORM-3244
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> I was configuring filter settings for the logviewer and discovered I needed 
> to update "ui.filter.params" for the logviewer.  Logviewer should use it's 
> own settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3245) Log viewer cleanup failes if multiple empty worker-artifact dirs

2018-10-05 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3245.

   Resolution: Fixed
Fix Version/s: 2.0.1

> Log viewer cleanup failes if multiple empty worker-artifact dirs
> 
>
> Key: STORM-3245
> URL: https://issues.apache.org/jira/browse/STORM-3245
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If a drive fills up for various reasons it is possible that we can create the 
> directory for a worker in worker-artifacts, but not able to create the 
> worker.yaml.  If we get more than one of these on a node we get an exception 
> like.
>  
> {code:java}
> o.a.s.d.l.u.LogCleaner logviewer-cleanup [ERROR] Exception while cleaning up 
> old log.
> java.lang.IllegalStateException: Duplicate key ...
>     at 
> java.util.stream.Collectors.lambda$throwingMerger$0(Collectors.java:133) 
> ~[?:1.8.0_102]
>     at java.util.HashMap.merge(HashMap.java:1253) ~[?:1.8.0_102]
>     at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320) 
> ~[?:1.8.0_102]
>     at 
> java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169) 
> ~[?:1.8.0_102]
>     at 
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) 
> ~[?:1.8.0_102]
>     at 
> java.util.TreeMap$KeySpliterator.forEachRemaining(TreeMap.java:2746) 
> ~[?:1.8.0_102]
>     at 
> java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481) 
> ~[?:1.8.0_102]
>     at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) 
> ~[?:1.8.0_102]
>     at 
> java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708) 
> ~[?:1.8.0_102]
>     at 
> java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) 
> ~[?:1.8.0_102]
>     at 
> java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499) 
> ~[?:1.8.0_102]
>     at 
> org.apache.storm.daemon.logviewer.utils.WorkerLogs.identifyWorkerLogDirs(WorkerLogs.java:214)
>  ~[storm-webapp-...{code}
> After that we cannot clean up any directories any longer...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3245) Log viewer cleanup failes if multiple empty worker-artifact dirs

2018-10-04 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3245:
--

 Summary: Log viewer cleanup failes if multiple empty 
worker-artifact dirs
 Key: STORM-3245
 URL: https://issues.apache.org/jira/browse/STORM-3245
 Project: Apache Storm
  Issue Type: Bug
  Components: storm-server
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


If a drive fills up for various reasons it is possible that we can create the 
directory for a worker in worker-artifacts, but not able to create the 
worker.yaml.  If we get more than one of these on a node we get an exception 
like.

 
{code:java}
o.a.s.d.l.u.LogCleaner logviewer-cleanup [ERROR] Exception while cleaning up 
old log.
java.lang.IllegalStateException: Duplicate key ...
    at 
java.util.stream.Collectors.lambda$throwingMerger$0(Collectors.java:133) 
~[?:1.8.0_102]
    at java.util.HashMap.merge(HashMap.java:1253) ~[?:1.8.0_102]
    at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320) 
~[?:1.8.0_102]
    at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169) 
~[?:1.8.0_102]
    at 
java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) 
~[?:1.8.0_102]
    at java.util.TreeMap$KeySpliterator.forEachRemaining(TreeMap.java:2746) 
~[?:1.8.0_102]
    at 
java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481) 
~[?:1.8.0_102]
    at 
java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) 
~[?:1.8.0_102]
    at 
java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708) 
~[?:1.8.0_102]
    at 
java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) 
~[?:1.8.0_102]
    at 
java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499) 
~[?:1.8.0_102]
    at 
org.apache.storm.daemon.logviewer.utils.WorkerLogs.identifyWorkerLogDirs(WorkerLogs.java:214)
 ~[storm-webapp-...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3239) Worker profile actions don't work

2018-10-03 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3239.

   Resolution: Fixed
Fix Version/s: 2.0.1

Thanks [~govindmenon],

 

I merged this into master.

> Worker profile actions don't work
> -
>
> Key: STORM-3239
> URL: https://issues.apache.org/jira/browse/STORM-3239
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-ui
>Affects Versions: 2.0.0
>Reporter: Jungtaek Lim
>Assignee: Govind Menon
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I just noticed that all worker profile actions don't work in 2.0.0-RC1. 
> access-ui logged the message that the action happened, but there's no further 
> log message as well as no action.
> Assigning to [~govindmenon] since he said he is working on this in mailing 
> list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3240) healthchecks fail if scripts return 0 exit code

2018-10-03 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3240.

   Resolution: Fixed
Fix Version/s: 2.0.1

Thanks [~agresch],

 

I merged this into master.

> healthchecks fail if scripts return 0 exit code
> ---
>
> Key: STORM-3240
> URL: https://issues.apache.org/jira/browse/STORM-3240
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-2963) Updates to Performance.md

2018-10-02 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-2963.

   Resolution: Fixed
Fix Version/s: 2.0.1

Thanks [~roshan_naik],

Merged this into master.

> Updates to Performance.md 
> --
>
> Key: STORM-2963
> URL: https://issues.apache.org/jira/browse/STORM-2963
> Project: Apache Storm
>  Issue Type: Documentation
>Affects Versions: 2.0.0
>Reporter: Roshan Naik
>Assignee: Roshan Naik
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3237) create metric to track mkAssignments exceptions

2018-10-01 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3237.

   Resolution: Fixed
Fix Version/s: 2.0.1

Thanks [~agresch],

I merged this into master.

> create metric to track mkAssignments exceptions
> ---
>
> Key: STORM-3237
> URL: https://issues.apache.org/jira/browse/STORM-3237
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> We had an issue in the past where scheduling was throwing exceptions on 
> nimbus.  I'd like to be able to monitor this issue going forward.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3235) Auto renewal of WorkerTokens broken.

2018-09-28 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3235.

   Resolution: Fixed
Fix Version/s: 2.0.1

Thanks [~kishorvpatil],

 

I merged this into master.

> Auto renewal of WorkerTokens broken.
> 
>
> Key: STORM-3235
> URL: https://issues.apache.org/jira/browse/STORM-3235
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Reporter: Kishor Patil
>Assignee: Kishor Patil
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The condition to renew WorkerToken needs fix and refactor code out of 
> {{Nimbus}} into {{WorkerTokenManager}}.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (STORM-3233) Upgrade zookeeper client to newest version (3.4.14)

2018-09-26 Thread Robert Joseph Evans (JIRA)


[ 
https://issues.apache.org/jira/browse/STORM-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629241#comment-16629241
 ] 

Robert Joseph Evans commented on STORM-3233:


FYI we just found https://issues.apache.org/jira/browse/ZOOKEEPER-3156 with the 
3.4.13 version of the ZK client.  This is a blocker for many setups secured by 
kerberos.  I think we might need to revert this change until we can get the 
zookeeper client fixed.

> Upgrade zookeeper client to newest version (3.4.14)
> ---
>
> Key: STORM-3233
> URL: https://issues.apache.org/jira/browse/STORM-3233
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Affects Versions: 2.0.0
>Reporter: Michal Koziorowski
>Assignee: Michal Koziorowski
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.2.3, 1.1.4, 2.0.1
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Hi,
> I would like to see new zookeeper client (3.4.13) used in storm.
> New release contains an important fix for cloud environments where zookeeper 
> servers have dynamic ips 
> ([https://jira.apache.org/jira/browse/ZOOKEEPER-2184]).
> If possible, it would be nice to see updated zookeeper also on older storm 
> versions (1.2.x, 1.1.x)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-621) UI should expose more version information

2018-09-25 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-621.
---
   Resolution: Fixed
Fix Version/s: 2.0.1

> UI should expose more version information
> -
>
> Key: STORM-621
> URL: https://issues.apache.org/jira/browse/STORM-621
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-core
>Affects Versions: 0.10.0
>Reporter: caofangkun
>Assignee: Robert Joseph Evans
>Priority: Minor
> Fix For: 2.0.1
>
>
> We should view the following information on UI page:
> Storm Version: 0.10.0-SNAPSHOT
> Git https  clone URL : https://github.com/caofangkun/apache-storm.git -r 
> ffba148cc47a92185fa1a5db11f72982de10f106
> Git last checkin id: ffba148cc47a92185fa1a5db11f72982de10f106
> Branch storm-243
> Compiled by somebody on Thu Jan 8 10:47:48 CST 2015
> From source with checksum 97e7c942939e3e82dcb854b497991a51



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3232) Display other versions of storm offered on the cluster in the UI

2018-09-25 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3232.

   Resolution: Fixed
Fix Version/s: 2.0.1

> Display other versions of storm offered on the cluster in the UI
> 
>
> Key: STORM-3232
> URL: https://issues.apache.org/jira/browse/STORM-3232
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-webapp
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> In Storm 2.0.0 we have the option to have older versions of storm installed 
> on the cluster for backwards compatibility.  If this happens we should 
> display it on the UI do others know everything that is installed on the 
> cluster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3234) Document Cluster Metrics

2018-09-25 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3234.

   Resolution: Fixed
Fix Version/s: 2.0.1

> Document Cluster Metrics
> 
>
> Key: STORM-3234
> URL: https://issues.apache.org/jira/browse/STORM-3234
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: documentation
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.1
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We need better docs on what cluster metrics we have in storm.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3233) Upgrade zookeeper client to newest version (3.4.14)

2018-09-25 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3233.

   Resolution: Fixed
Fix Version/s: 1.1.4
   1.2.3
   2.0.1

Thanks [~michallo],

 

I merged this into master, branch-1.x and branch-1.1.x. Keep up the good work.

> Upgrade zookeeper client to newest version (3.4.14)
> ---
>
> Key: STORM-3233
> URL: https://issues.apache.org/jira/browse/STORM-3233
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Affects Versions: 2.0.0
>Reporter: Michal Koziorowski
>Assignee: Michal Koziorowski
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.1, 1.2.3, 1.1.4
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Hi,
> I would like to see new zookeeper client (3.4.13) used in storm.
> New release contains an important fix for cloud environments where zookeeper 
> servers have dynamic ips 
> ([https://jira.apache.org/jira/browse/ZOOKEEPER-2184]).
> If possible, it would be nice to see updated zookeeper also on older storm 
> versions (1.2.x, 1.1.x)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (STORM-3233) Upgrade zookeeper client to newest version (3.4.14)

2018-09-25 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans reassigned STORM-3233:
--

Assignee: Michal Koziorowski

> Upgrade zookeeper client to newest version (3.4.14)
> ---
>
> Key: STORM-3233
> URL: https://issues.apache.org/jira/browse/STORM-3233
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Affects Versions: 2.0.0
>Reporter: Michal Koziorowski
>Assignee: Michal Koziorowski
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Hi,
> I would like to see new zookeeper client (3.4.13) used in storm.
> New release contains an important fix for cloud environments where zookeeper 
> servers have dynamic ips 
> ([https://jira.apache.org/jira/browse/ZOOKEEPER-2184]).
> If possible, it would be nice to see updated zookeeper also on older storm 
> versions (1.2.x, 1.1.x)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3234) Document Cluster Metrics

2018-09-22 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3234:
--

 Summary: Document Cluster Metrics
 Key: STORM-3234
 URL: https://issues.apache.org/jira/browse/STORM-3234
 Project: Apache Storm
  Issue Type: New Feature
  Components: documentation
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


We need better docs on what cluster metrics we have in storm.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (STORM-621) UI should expose more version information

2018-09-21 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans reassigned STORM-621:
-

Assignee: Robert Joseph Evans  (was: caofangkun)

> UI should expose more version information
> -
>
> Key: STORM-621
> URL: https://issues.apache.org/jira/browse/STORM-621
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-core
>Affects Versions: 0.10.0
>Reporter: caofangkun
>Assignee: Robert Joseph Evans
>Priority: Minor
>
> We should view the following information on UI page:
> Storm Version: 0.10.0-SNAPSHOT
> Git https  clone URL : https://github.com/caofangkun/apache-storm.git -r 
> ffba148cc47a92185fa1a5db11f72982de10f106
> Git last checkin id: ffba148cc47a92185fa1a5db11f72982de10f106
> Branch storm-243
> Compiled by somebody on Thu Jan 8 10:47:48 CST 2015
> From source with checksum 97e7c942939e3e82dcb854b497991a51



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3232) Display other versions of storm offered on the cluster in the UI

2018-09-20 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3232:
--

 Summary: Display other versions of storm offered on the cluster in 
the UI
 Key: STORM-3232
 URL: https://issues.apache.org/jira/browse/STORM-3232
 Project: Apache Storm
  Issue Type: New Feature
  Components: storm-webapp
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


In Storm 2.0.0 we have the option to have older versions of storm installed on 
the cluster for backwards compatibility.  If this happens we should display it 
on the UI do others know everything that is installed on the cluster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3230) Small race with worker tokens.

2018-09-20 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3230.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Small race with worker tokens.
> --
>
> Key: STORM-3230
> URL: https://issues.apache.org/jira/browse/STORM-3230
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-client
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> There is a small race in zookeeper I missed when trying to get the secret out 
> of ZK for worker tokens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3229) Better error reporting in WorkerTokenAuthorizer

2018-09-20 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3229.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Better error reporting in WorkerTokenAuthorizer
> ---
>
> Key: STORM-3229
> URL: https://issues.apache.org/jira/browse/STORM-3229
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-client
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The error handling code in WorkerTokenAuthorizer logs some errors at a debug 
> level, that should be logged at a much higher level.  Specifically ZK auth 
> errors, where we can have the Zk client not authenticated because it is using 
> an older jaas conf.  When this happens DRPC auth just does not work and there 
> is no indication as to why.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3105) Update storm hive dependency version

2018-09-19 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3105.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Update storm hive dependency version
> 
>
> Key: STORM-3105
> URL: https://issues.apache.org/jira/browse/STORM-3105
> Project: Apache Storm
>  Issue Type: Task
>Reporter: Abhishek
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Storm hive is compiled with \{{hive.version}} 
> [{{0.14.0}}|https://github.com/apache/storm/blob/0eb6b5116f251e17b6f14a61cebfadfc286faa59/pom.xml#L292]
>  which is quite old. The current stable hive release is {{3.0.0}}. Using 
> {{storm-hive}} with such an old version causes issues when hive cluster 
> version is newer. See this 
> [thread|https://lists.apache.org/thread.html/36f674f74e73f9ddc83b6b2452acfd9773af4e6394c8cb157dd367fd@%3Cuser.storm.apache.org%3E]
>  for one such issue. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3147) Port ClusterSummary as Metrics to StormMetricsRegistry

2018-09-19 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3147.

Resolution: Fixed

Thanks [~Srdo] and [~zhengdai],

 

I merged this into master

> Port ClusterSummary as Metrics to StormMetricsRegistry
> --
>
> Key: STORM-3147
> URL: https://issues.apache.org/jira/browse/STORM-3147
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Zhengdai Hu
>Assignee: Zhengdai Hu
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 18h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3229) Better error reporting in WorkerTokenAuthorizer

2018-09-18 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3229:
--

 Summary: Better error reporting in WorkerTokenAuthorizer
 Key: STORM-3229
 URL: https://issues.apache.org/jira/browse/STORM-3229
 Project: Apache Storm
  Issue Type: Improvement
  Components: storm-client
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


The error handling code in WorkerTokenAuthorizer logs some errors at a debug 
level, that should be logged at a much higher level.  Specifically ZK auth 
errors, where we can have the Zk client not authenticated because it is using 
an older jaas conf.  When this happens DRPC auth just does not work and there 
is no indication as to why.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3228) Supervisor blobstore ref counting not working properly

2018-09-18 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3228.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~agresch],

 

I merged this into master.

> Supervisor blobstore ref counting not working properly
> --
>
> Key: STORM-3228
> URL: https://issues.apache.org/jira/browse/STORM-3228
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Aaron Gresch
>Assignee: Aaron Gresch
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> When supervisors release slots, they can continue to indefinitely download 
> the blob.
> {code:java}
> 2018-09-17 16:18:00.955 o.a.s.l.AsyncLocalizer SLOT_6703 [INFO] Releasing 
> slot for logviewer-ui-groups-test-11-1537201071 6703
> 2018-09-17 16:18:00.956 o.a.s.l.LocallyCachedBlob SLOT_6703 [WARN] 
> {logviewer-ui-groups-test-11-1537201071 on 6703} had no reservation for 
> logviewer-ui-groups-test-11-1537201071 stormjar.jar
> 2018-09-17 16:22:50.198 o.a.s.l.AsyncLocalizer AsyncLocalizer Executor - 2 
> [WARN] Failed to download blob LOCAL TOPO BLOB TOPO_CONF 
> logviewer-ui-groups-test-11-1537201071 will try again in 100 ms{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3227) Improve security of credentials push

2018-09-18 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3227.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Improve security of credentials push
> 
>
> Key: STORM-3227
> URL: https://issues.apache.org/jira/browse/STORM-3227
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-client, storm-server
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When pushing credentials to a topology most of the checks we do right now are 
> to verify that the topology is allowing a given user to do the push, but we 
> also need to protect the user from pushing to the wrong topology.
>  
> This is really only an issue if a user has the push setup on some kind of a 
> cron like job, and the topology is down (which should be rare), but to 
> eliminate any race conditions we should have nimbus either verify that the 
> topology is owned by the same user as the one doing the push, or have an 
> optional user that the client expects the topology to be owned by.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (STORM-3105) Update storm hive dependency version

2018-09-18 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans reassigned STORM-3105:
--

Assignee: Robert Joseph Evans

> Update storm hive dependency version
> 
>
> Key: STORM-3105
> URL: https://issues.apache.org/jira/browse/STORM-3105
> Project: Apache Storm
>  Issue Type: Task
>Reporter: Abhishek
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Storm hive is compiled with \{{hive.version}} 
> [{{0.14.0}}|https://github.com/apache/storm/blob/0eb6b5116f251e17b6f14a61cebfadfc286faa59/pom.xml#L292]
>  which is quite old. The current stable hive release is {{3.0.0}}. Using 
> {{storm-hive}} with such an old version causes issues when hive cluster 
> version is newer. See this 
> [thread|https://lists.apache.org/thread.html/36f674f74e73f9ddc83b6b2452acfd9773af4e6394c8cb157dd367fd@%3Cuser.storm.apache.org%3E]
>  for one such issue. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3197) Make StormMetricsRegistry a regular instance class rather than a static utility

2018-09-17 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3197.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~Srdo],

 

I merged this into master.

> Make StormMetricsRegistry a regular instance class rather than a static 
> utility
> ---
>
> Key: STORM-3197
> URL: https://issues.apache.org/jira/browse/STORM-3197
> Project: Apache Storm
>  Issue Type: Task
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Stig Rohde Døssing
>Assignee: Stig Rohde Døssing
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Having the registry be a static utility makes fixing some issues harder than 
> it should be. Preventing daemons from accidentally registering metrics for 
> other daemons (STORM-3101) and flushing reporters on shutdown without 
> breaking the tests (STORM-3173) for example.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3205) Optimization in TuplImpl

2018-09-17 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3205.

Resolution: Fixed

Thanks [~roshan_naik],

 

I merged this to master.

> Optimization in TuplImpl
> 
>
> Key: STORM-3205
> URL: https://issues.apache.org/jira/browse/STORM-3205
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-client
>Affects Versions: 2.0.0
>Reporter: Roshan Naik
>Assignee: Roshan Naik
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Wrapping {{TuplImpl.values}} with Collections.unmodifiableList() turns out be 
> very expensive. Its intention is obviously to check and prevent accidental 
> tweaking TuplImpl once created. Given the high cost, if needed, we can limit 
> this extra checking mechanism in debug/dev mode. Being in the critical path 
> it means several thousand/million additional allocations per second of the 
> List wrapper object  proportional to the number of bolt/spout instances.
> *TVL :*
> | |throughput (k/sec)|cores|mem (mb)|
> |*master (#f5a410ba3)*|412 |4.26|103|
> |*storm-3205*|547  (+33%)|4.09|132|
> {{+cmd:+ bin/storm jar topos/storm-loadgen-2.0.0-SNAPSHOT.jar 
> org.apache.storm.loadgen.ThroughputVsLatency *--rate 55* --spouts 1 
> --splitters 3 --counters 2 -c topology.acker.executors=0}}
> *+ConstSpoutIdentityBoltNullBolt :+*
> | |throughput|
> |*master*|4.25 mill/sec|
> |*storm-3205*|5.4 mill/sec (+27%)|
> +cmd+: {{bin/storm jar topos/storm-perf-2.0.0-SNAPSHOT.jar 
> org.apache.storm.perf.ConstSpoutIdBoltNullBoltTopo -c 
> topology.acker.executors=0 -c topology.producer.batch.size=1000 400}}
> *Note:* The perf gains are more evident when operating at high thoughputs w/o 
> backpressure occurring (i.e. some bolts have not yet become a bottleneck)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3225) AuthorizedUserFilter should not convert the media type to a string

2018-09-17 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3225.

   Resolution: Fixed
Fix Version/s: 2.0.0

> AuthorizedUserFilter should not convert the media type to a string
> --
>
> Key: STORM-3225
> URL: https://issues.apache.org/jira/browse/STORM-3225
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-webapp
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The AuthorizedUserFilter is converting the media type to a string so it can 
> do a comparison check.  There is a better way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3226) Improve Supervisor authorization handler error message

2018-09-17 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3226.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Improve Supervisor authorization handler error message
> --
>
> Key: STORM-3226
> URL: https://issues.apache.org/jira/browse/STORM-3226
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The error in the supervisor about the authorization handler is confusing and 
> does not explain how to fix the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3227) Improve security of credentials push

2018-09-17 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3227:
--

 Summary: Improve security of credentials push
 Key: STORM-3227
 URL: https://issues.apache.org/jira/browse/STORM-3227
 Project: Apache Storm
  Issue Type: Improvement
  Components: storm-client, storm-server
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


When pushing credentials to a topology most of the checks we do right now are 
to verify that the topology is allowing a given user to do the push, but we 
also need to protect the user from pushing to the wrong topology.

 

This is really only an issue if a user has the push setup on some kind of a 
cron like job, and the topology is down (which should be rare), but to 
eliminate any race conditions we should have nimbus either verify that the 
topology is owned by the same user as the one doing the push, or have an 
optional user that the client expects the topology to be owned by.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3223) RAS can get an NPE if entire rack is blacklisted

2018-09-14 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3223.

   Resolution: Fixed
Fix Version/s: 2.0.0

Merged this into master

> RAS can get an NPE if entire rack is blacklisted
> 
>
> Key: STORM-3223
> URL: https://issues.apache.org/jira/browse/STORM-3223
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If an entire rack is blacklisted the RAS scheduler can end up getting an NPE. 
>  This is a more extreme version of a fix that was merged in previously for 
> single nodes that are blacklisted causing NPEs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3222) Fix KafkaSpout internals to use LinkedList instead of ArrayList

2018-09-14 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3222.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~arunmahadevan],

 

I merged this into master, if you want this into other places please feel free 
to file more pull requests.

> Fix KafkaSpout internals to use LinkedList instead of ArrayList
> ---
>
> Key: STORM-3222
> URL: https://issues.apache.org/jira/browse/STORM-3222
> Project: Apache Storm
>  Issue Type: Improvement
>Reporter: Arun Mahadevan
>Assignee: Arun Mahadevan
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> KafkaSpout internally maintains a waitingToEmit list per topic partition and 
> keeps removing the first item to emit during each nextTuple. The 
> implementation uses an ArrayList which results in un-necessary traversal and 
> copy for each tuple.
> Also I am not sure why the nextTuple only emits a single tuple wheres ideally 
> it should emit whatever it can emit in a single nextTuple call which is more 
> efficient.  However the logic appears too complicated to refactor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3226) Improve Supervisor authorization handler error message

2018-09-14 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3226:
--

 Summary: Improve Supervisor authorization handler error message
 Key: STORM-3226
 URL: https://issues.apache.org/jira/browse/STORM-3226
 Project: Apache Storm
  Issue Type: Improvement
  Components: storm-server
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


The error in the supervisor about the authorization handler is confusing and 
does not explain how to fix the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3225) AuthorizedUserFilter should not convert the media type to a string

2018-09-14 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3225:
--

 Summary: AuthorizedUserFilter should not convert the media type to 
a string
 Key: STORM-3225
 URL: https://issues.apache.org/jira/browse/STORM-3225
 Project: Apache Storm
  Issue Type: Bug
  Components: storm-webapp
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


The AuthorizedUserFilter is converting the media type to a string so it can do 
a comparison check.  There is a better way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3217) Component errors missing in /api/v1/component API call

2018-09-13 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3217.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~govindmenon],

 

I merged this into master.

> Component errors missing in /api/v1/component API call
> --
>
> Key: STORM-3217
> URL: https://issues.apache.org/jira/browse/STORM-3217
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-webapp
>Affects Versions: 2.0.0
>Reporter: Govind Menon
>Assignee: Govind Menon
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> componentErrors and other component stats were missed by me in the migration.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3221) Utilization in clusterSummary is inverted - shows free instead of used

2018-09-13 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3221.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~govindmenon],

I merged this into master.

> Utilization in clusterSummary is inverted - shows free instead of used
> --
>
> Key: STORM-3221
> URL: https://issues.apache.org/jira/browse/STORM-3221
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Govind Menon
>Assignee: Govind Menon
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3219) Storm UI javascript needs better error reporting

2018-09-13 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3219.

   Resolution: Fixed
Fix Version/s: 2.0.0

> Storm UI javascript needs better error reporting
> 
>
> Key: STORM-3219
> URL: https://issues.apache.org/jira/browse/STORM-3219
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In many places on the UI we report errors by placing them in a section at the 
> bottom of the page, but not all of the sections of the pages do this.  Which 
> can make it hard to debug what is happening, and not very obvious to our end 
> users that there is a problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3220) Allow excplicit enabling or disabling of HTTP daemon endpoints

2018-09-13 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3220.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~kishorvpatil],

 

I merged this into master

> Allow excplicit enabling or disabling of HTTP  daemon endpoints
> ---
>
> Key: STORM-3220
> URL: https://issues.apache.org/jira/browse/STORM-3220
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-webapp
>Reporter: Kishor Patil
>Assignee: Kishor Patil
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Defaulting to http many times is not desired for security. Allowing explicit  
> enabling/disabling HTTP endpoint helps ensure that it is intentional.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3223) RAS can get an NPE if entire rack is blacklisted

2018-09-13 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3223:
---
Summary: RAS can get an NPE if entire rack is blacklisted  (was: RAS can 
get an NPE of entire rack is blacklisted)

> RAS can get an NPE if entire rack is blacklisted
> 
>
> Key: STORM-3223
> URL: https://issues.apache.org/jira/browse/STORM-3223
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-server
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>
> If an entire rack is blacklisted the RAS scheduler can end up getting an NPE. 
>  This is a more extreme version of a fix that was merged in previously for 
> single nodes that are blacklisted causing NPEs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3218) AuthorizedUserFilter should handle authorization exceptions better.

2018-09-13 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3218.

   Resolution: Fixed
Fix Version/s: 2.0.0

> AuthorizedUserFilter should handle authorization exceptions better.
> ---
>
> Key: STORM-3218
> URL: https://issues.apache.org/jira/browse/STORM-3218
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-webapp
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Sorry I missed this before when I added back in impersonation.  The code that 
> gets the topology conf to validate if the user is allowed to make the given 
> REST call should not be doing impersonation because.  I tested the code as a 
> single user, but the issue is that because the ReqContext is tied to a thread 
> if we don't clear/clean up the impersonation code properly the old user is 
> still in the ReqContext so when we try to get the conf we are doing it as the 
> wrong user and get an error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3223) RAS can get an NPE of entire rack is blacklisted

2018-09-13 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3223:
--

 Summary: RAS can get an NPE of entire rack is blacklisted
 Key: STORM-3223
 URL: https://issues.apache.org/jira/browse/STORM-3223
 Project: Apache Storm
  Issue Type: Bug
  Components: storm-server
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


If an entire rack is blacklisted the RAS scheduler can end up getting an NPE.  
This is a more extreme version of a fix that was merged in previously for 
single nodes that are blacklisted causing NPEs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3206) don't validate topoConf against DaemonConfig during submission

2018-09-12 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3206.

   Resolution: Fixed
Fix Version/s: 2.0.0

> don't validate topoConf against DaemonConfig during submission
> --
>
> Key: STORM-3206
> URL: https://issues.apache.org/jira/browse/STORM-3206
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Ethan Li
>Assignee: Ethan Li
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There is no need to validate topoconf against daemonConfig since daemonConfig 
> is only server-side configs. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (STORM-2886) Look into better phemeral port support in LocalCluster.withNimbusDaemon

2018-09-12 Thread Robert Joseph Evans (JIRA)


[ 
https://issues.apache.org/jira/browse/STORM-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612216#comment-16612216
 ] 

Robert Joseph Evans commented on STORM-2886:


LocalCluster.java is just a wrapper around setting up an instance of Nimbus.
 
Turing on the daemon piece controls if the thrift server should be launched or 
not.  By default it is not launched and the clients call directly into the 
nimbus class itself.
 
[https://github.com/apache/storm/blob/8f9061a1b7c56499a42bcb406a11287955cfce73/storm-server/src/main/java/org/apache/storm/LocalCluster.java#L247]
 
[https://github.com/apache/storm/blob/8f9061a1b7c56499a42bcb406a11287955cfce73/storm-server/src/main/java/org/apache/storm/LocalCluster.java#L280-L285]
 
If you look at ThriftServer.java that is a wrapper that makes the configuration 
of the thrift server happen based off the type of daemon being launched.
 
[https://github.com/apache/storm/blob/8f9061a1b7c56499a42bcb406a11287955cfce73/storm-client/src/jvm/org/apache/storm/security/auth/ThriftServer.java#L50]
 
So what we need is a way to override the port in the constructor so it can be 
ephemeral, and then a good way to get the port it actually bound to back out 
from the ThriftServer, and passed to all of the clients that might need it 
(typically this would be done through the config similar to how we do the 
zookeeper ephemeral port.
 
[https://github.com/apache/storm/blob/8f9061a1b7c56499a42bcb406a11287955cfce73/storm-server/src/main/java/org/apache/storm/LocalCluster.java#L213-L219]
 
I hope this helps

> Look into better phemeral port support in LocalCluster.withNimbusDaemon
> ---
>
> Key: STORM-2886
> URL: https://issues.apache.org/jira/browse/STORM-2886
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-server
>Affects Versions: 1.0.0, 2.0.0
>Reporter: Robert Joseph Evans
>Priority: Major
>  Labels: newbie
>
> We have a few tests that use a LocalCluster and then launch an actual Nimbus 
> Thrift Server instance.  This is mostly to test that the thrift code works 
> properly.
> In some cases this can cause issues because by default it is going to get a 
> single hard coded port.
> In most cases we work around this, like in STORM-2885 by finding a free port 
> and then using that for both client and server configs.
> This does not eliminate the race, but it makes it very unlikely.  It would be 
> great if we could eliminate the race by somehow bringing up the thrift server 
> on an ephemeral port, and then providing a way to get that port through an 
> API in LocalCluster.
> One of the issues we would have to overcome is that we explicitly check for 
> positive port numbers, and we would only want to turn that off for this 
> particular use case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3219) Storm UI javascript needs better error reporting

2018-09-11 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3219:
--

 Summary: Storm UI javascript needs better error reporting
 Key: STORM-3219
 URL: https://issues.apache.org/jira/browse/STORM-3219
 Project: Apache Storm
  Issue Type: Bug
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


In many places on the UI we report errors by placing them in a section at the 
bottom of the page, but not all of the sections of the pages do this.  Which 
can make it hard to debug what is happening, and not very obvious to our end 
users that there is a problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (STORM-3218) AuthorizedUserFilter should handle authorization exceptions better.

2018-09-11 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated STORM-3218:
---
Summary: AuthorizedUserFilter should handle authorization exceptions 
better.  (was: Impersonation should not happen when checking security.)

> AuthorizedUserFilter should handle authorization exceptions better.
> ---
>
> Key: STORM-3218
> URL: https://issues.apache.org/jira/browse/STORM-3218
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-webapp
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>
> Sorry I missed this before when I added back in impersonation.  The code that 
> gets the topology conf to validate if the user is allowed to make the given 
> REST call should not be doing impersonation because.  I tested the code as a 
> single user, but the issue is that because the ReqContext is tied to a thread 
> if we don't clear/clean up the impersonation code properly the old user is 
> still in the ReqContext so when we try to get the conf we are doing it as the 
> wrong user and get an error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (STORM-3218) Impersonation should not happen when checking security.

2018-09-11 Thread Robert Joseph Evans (JIRA)


[ 
https://issues.apache.org/jira/browse/STORM-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610608#comment-16610608
 ] 

Robert Joseph Evans commented on STORM-3218:


Actually it is a bit different.  The we are impersonating the correct user when 
trying to get the topology conf, but  it should be returning a different error 
in those cases.

> Impersonation should not happen when checking security.
> ---
>
> Key: STORM-3218
> URL: https://issues.apache.org/jira/browse/STORM-3218
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-webapp
>Affects Versions: 2.0.0
>Reporter: Robert Joseph Evans
>Assignee: Robert Joseph Evans
>Priority: Major
>
> Sorry I missed this before when I added back in impersonation.  The code that 
> gets the topology conf to validate if the user is allowed to make the given 
> REST call should not be doing impersonation because.  I tested the code as a 
> single user, but the issue is that because the ReqContext is tied to a thread 
> if we don't clear/clean up the impersonation code properly the old user is 
> still in the ReqContext so when we try to get the conf we are doing it as the 
> wrong user and get an error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (STORM-3218) Impersonation should not happen when checking security.

2018-09-11 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-3218:
--

 Summary: Impersonation should not happen when checking security.
 Key: STORM-3218
 URL: https://issues.apache.org/jira/browse/STORM-3218
 Project: Apache Storm
  Issue Type: Bug
  Components: storm-webapp
Affects Versions: 2.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans


Sorry I missed this before when I added back in impersonation.  The code that 
gets the topology conf to validate if the user is allowed to make the given 
REST call should not be doing impersonation because.  I tested the code as a 
single user, but the issue is that because the ReqContext is tied to a thread 
if we don't clear/clean up the impersonation code properly the old user is 
still in the ReqContext so when we try to get the conf we are doing it as the 
wrong user and get an error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-3198) Topology submitters should be able to supply log4j2 configurations

2018-09-10 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-3198.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~jtolar],

 

I merged this into master.

> Topology submitters should be able to supply log4j2 configurations
> --
>
> Key: STORM-3198
> URL: https://issues.apache.org/jira/browse/STORM-3198
> Project: Apache Storm
>  Issue Type: Improvement
>Reporter: Jacob Tolar
>Assignee: Jacob Tolar
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> As a topology submitter, I would like to submit a log4j2 configuration 
> alongside my topology to easily control my application's logging parameters. 
>  
> For example, I might need to reduce the log level of a particularly noisy 
> dependency. Or, I might want to add a filter to drop these messages.
>  
> Since log4j supports [composite 
> configurations|https://logging.apache.org/log4j/2.x/manual/configuration.html#CompositeConfiguration],
>  Storm could support the user passing in a log4j2.xml file to be combined 
> with the 'default' log4j2.xml. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (STORM-2832) misuse of Utils.readStormConfig() and ConfigUtils.readStormConfig()

2018-09-10 Thread Robert Joseph Evans (JIRA)


 [ 
https://issues.apache.org/jira/browse/STORM-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans resolved STORM-2832.

   Resolution: Fixed
Fix Version/s: 2.0.0

Thanks [~jingc],

 

I merged this into master.

> misuse of Utils.readStormConfig() and ConfigUtils.readStormConfig()
> ---
>
> Key: STORM-2832
> URL: https://issues.apache.org/jira/browse/STORM-2832
> Project: Apache Storm
>  Issue Type: Improvement
>Reporter: Ethan Li
>Assignee: Jing Chen
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We want to validate confs before launching daemons. However, code in many 
> places uses Utils.readStormConfig() instead of ConfigUtils.readStormConfig(). 
> We should change them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   3   4   5   >