[jira] [Updated] (WW-4465) StatusCode parameter in the URL when using redirectAction
[
https://issues.apache.org/jira/browse/WW-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-4465:
--
Fix Version/s: 2.3.22
StatusCode parameter in the URL when using redirectAction
-
Key: WW-4465
URL: https://issues.apache.org/jira/browse/WW-4465
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.20
Reporter: Harry Chan
Fix For: 2.3.22
Attachments: WW-4465.patch
In the WW-3389, it solved the problem when using *redirect type result.
However, the same issue would be occurred when using the *redirectAction*
type result.
e.g:
{code:xml}
result name=redirectAction type=redirectAction
param name=namespace//param
param name=actionNameanotherAction/param
/result
{code}
The solution should be updated the
{code}org.apache.struts2.dispatcher.ServletActionRedirectResult.getProhibitedResultParams(){code}
same as WW-3389
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4465) StatusCode parameter in the URL when using redirectAction
[
https://issues.apache.org/jira/browse/WW-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323720#comment-14323720
]
ASF subversion and git services commented on WW-4465:
-
Commit c5867e2ea2c72864730c77167b9827e49c0cd38f in struts's branch
refs/heads/develop from [~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=c5867e2 ]
WW-4465 Ignores statusCode parameter when building redirect url
StatusCode parameter in the URL when using redirectAction
-
Key: WW-4465
URL: https://issues.apache.org/jira/browse/WW-4465
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.20
Reporter: Harry Chan
Fix For: 2.3.22
Attachments: WW-4465.patch
In the WW-3389, it solved the problem when using *redirect type result.
However, the same issue would be occurred when using the *redirectAction*
type result.
e.g:
{code:xml}
result name=redirectAction type=redirectAction
param name=namespace//param
param name=actionNameanotherAction/param
/result
{code}
The solution should be updated the
{code}org.apache.struts2.dispatcher.ServletActionRedirectResult.getProhibitedResultParams(){code}
same as WW-3389
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (WW-4465) StatusCode parameter in the URL when using redirectAction
[
https://issues.apache.org/jira/browse/WW-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart resolved WW-4465.
---
Resolution: Fixed
Assignee: Lukasz Lenart
Patch applied, thanks!
StatusCode parameter in the URL when using redirectAction
-
Key: WW-4465
URL: https://issues.apache.org/jira/browse/WW-4465
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.20
Reporter: Harry Chan
Assignee: Lukasz Lenart
Fix For: 2.3.22
Attachments: WW-4465.patch
In the WW-3389, it solved the problem when using *redirect type result.
However, the same issue would be occurred when using the *redirectAction*
type result.
e.g:
{code:xml}
result name=redirectAction type=redirectAction
param name=namespace//param
param name=actionNameanotherAction/param
/result
{code}
The solution should be updated the
{code}org.apache.struts2.dispatcher.ServletActionRedirectResult.getProhibitedResultParams(){code}
same as WW-3389
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4465) StatusCode parameter in the URL when using redirectAction
[
https://issues.apache.org/jira/browse/WW-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323764#comment-14323764
]
Hudson commented on WW-4465:
SUCCESS: Integrated in Struts-JDK6-develop #132 (See
[https://builds.apache.org/job/Struts-JDK6-develop/132/])
WW-4465 Ignores statusCode parameter when building redirect url (lukaszlenart:
rev c5867e2ea2c72864730c77167b9827e49c0cd38f)
*
core/src/test/java/org/apache/struts2/dispatcher/ServletActionRedirectResultTest.java
*
core/src/main/java/org/apache/struts2/dispatcher/ServletActionRedirectResult.java
StatusCode parameter in the URL when using redirectAction
-
Key: WW-4465
URL: https://issues.apache.org/jira/browse/WW-4465
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.20
Reporter: Harry Chan
Assignee: Lukasz Lenart
Fix For: 2.3.22
Attachments: WW-4465.patch
In the WW-3389, it solved the problem when using *redirect type result.
However, the same issue would be occurred when using the *redirectAction*
type result.
e.g:
{code:xml}
result name=redirectAction type=redirectAction
param name=namespace//param
param name=actionNameanotherAction/param
/result
{code}
The solution should be updated the
{code}org.apache.struts2.dispatcher.ServletActionRedirectResult.getProhibitedResultParams(){code}
same as WW-3389
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323765#comment-14323765 ] Hudson commented on WW-4427: SUCCESS: Integrated in Struts-JDK6-develop #132 (See [https://builds.apache.org/job/Struts-JDK6-develop/132/]) WW-4427 - Converters are no longer applied to values coming from the context on error path (pbruski: rev e0d72397c24542a8b83a371a36590570ccd8fd74) * xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * xwork-core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4466) struts.multipart.bufferSize must be set manually
[ https://issues.apache.org/jira/browse/WW-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322751#comment-14322751 ] ASF subversion and git services commented on WW-4466: - Commit fbe7d5138e7f4e67552f766c80cc033050660777 in struts's branch refs/heads/develop from cnenning [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=fbe7d51 ] made bufferSize optional, see WW-4466 struts.multipart.bufferSize must be set manually Key: WW-4466 URL: https://issues.apache.org/jira/browse/WW-4466 Project: Struts 2 Issue Type: Bug Components: Core Actions Affects Versions: 2.3.20 Reporter: Christoph Nenning Priority: Minor Fix For: 2.3.22 With WW-3025 there was a new config constant introduced: struts.multipart.bufferSize Currently it is set as required and hence applications must specify it. The default value is always overridden. - should be required = false -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4466) struts.multipart.bufferSize must be set manually
[ https://issues.apache.org/jira/browse/WW-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322775#comment-14322775 ] Hudson commented on WW-4466: SUCCESS: Integrated in Struts-JDK6-develop #131 (See [https://builds.apache.org/job/Struts-JDK6-develop/131/]) made bufferSize optional, see WW-4466 (cnenning: rev fbe7d5138e7f4e67552f766c80cc033050660777) * core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaStreamMultiPartRequest.java struts.multipart.bufferSize must be set manually Key: WW-4466 URL: https://issues.apache.org/jira/browse/WW-4466 Project: Struts 2 Issue Type: Bug Components: Core Actions Affects Versions: 2.3.20 Reporter: Christoph Nenning Priority: Minor Fix For: 2.3.22 With WW-3025 there was a new config constant introduced: struts.multipart.bufferSize Currently it is set as required and hence applications must specify it. The default value is always overridden. - should be required = false -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WW-4466) struts.multipart.bufferSize must be set manually
[ https://issues.apache.org/jira/browse/WW-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christoph Nenning resolved WW-4466. --- Resolution: Fixed done struts.multipart.bufferSize must be set manually Key: WW-4466 URL: https://issues.apache.org/jira/browse/WW-4466 Project: Struts 2 Issue Type: Bug Components: Core Actions Affects Versions: 2.3.20 Reporter: Christoph Nenning Priority: Minor Fix For: 2.3.22 With WW-3025 there was a new config constant introduced: struts.multipart.bufferSize Currently it is set as required and hence applications must specify it. The default value is always overridden. - should be required = false -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323740#comment-14323740 ] ASF subversion and git services commented on WW-4427: - Commit 66248a80e3b238092bf547cc196ad2f7b0225b76 in struts's branch refs/heads/develop from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=66248a8 ] WW-4427 adds complete fix Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323739#comment-14323739 ] ASF subversion and git services commented on WW-4427: - Commit e0d72397c24542a8b83a371a36590570ccd8fd74 in struts's branch refs/heads/develop from [~pbruski_] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=e0d7239 ] WW-4427 - Converters are no longer applied to values coming from the context on error path Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-4427. --- Resolution: Fixed PR merged, thanks! Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
[ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323741#comment-14323741 ] ASF GitHub Bot commented on WW-4427: Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/36 Converters no longer applied to values coming from the context -- Key: WW-4427 URL: https://issues.apache.org/jira/browse/WW-4427 Project: Struts 2 Issue Type: Bug Affects Versions: 2.3.16.1 Reporter: Przemek Bruski Assignee: Lukasz Lenart Fix For: 2.3.22 Attachments: struts_patch.diff As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer applied to values coming directly from OGNL context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WW-4462) Regression bug in ognl for is... property getters
[
https://issues.apache.org/jira/browse/WW-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-4462:
--
Fix Version/s: 2.5
Regression bug in ognl for is... property getters
---
Key: WW-4462
URL: https://issues.apache.org/jira/browse/WW-4462
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.20
Reporter: Jasper Rosenberg
Priority: Critical
Labels: ognl
Fix For: 2.5
We have a lot of getters on our actions that look like:
public boolean getIsTruck() {
return isTruck;
}
That lets us write ftl that looks like:
#if isTruck.../#if
However, this support was broken in a recent ognl release, I believe by this
patch:
https://github.com/jkuhnert/ognl/commit/6fb948c8a4528546e6e24750f09a89b6a730e17a
I don't see any reason why this pattern shouldn't be supported, so I'm
assuming it is a bug.
This is also keeping us from being able to upgrade to the latest ognl which
has some critical fixes we were really hoping to take advantage of.
Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WW-4462) Regression bug in ognl for is... property getters
[
https://issues.apache.org/jira/browse/WW-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-4462:
--
Fix Version/s: (was: 2.5)
2.3.22
Regression bug in ognl for is... property getters
---
Key: WW-4462
URL: https://issues.apache.org/jira/browse/WW-4462
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.20
Reporter: Jasper Rosenberg
Priority: Critical
Labels: ognl
Fix For: 2.3.22
We have a lot of getters on our actions that look like:
public boolean getIsTruck() {
return isTruck;
}
That lets us write ftl that looks like:
#if isTruck.../#if
However, this support was broken in a recent ognl release, I believe by this
patch:
https://github.com/jkuhnert/ognl/commit/6fb948c8a4528546e6e24750f09a89b6a730e17a
I don't see any reason why this pattern shouldn't be supported, so I'm
assuming it is a bug.
This is also keeping us from being able to upgrade to the latest ognl which
has some critical fixes we were really hoping to take advantage of.
Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WW-4463) Support propagating ognl errors other than NoSuchPropertyException
[
https://issues.apache.org/jira/browse/WW-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-4463:
--
Fix Version/s: 2.3.22
Support propagating ognl errors other than NoSuchPropertyException
--
Key: WW-4463
URL: https://issues.apache.org/jira/browse/WW-4463
Project: Struts 2
Issue Type: Improvement
Components: Core Actions
Affects Versions: 2.3.20
Reporter: Jasper Rosenberg
Priority: Minor
Labels: ognl
Fix For: 2.3.22
So, if you have a getter on an action that does some real work (say lazy load
a list of cars from the database), and therefore might fail, it would be nice
to have the option to have that propagate the exception, rather than be
interpreted as if the property was not defined.
The place that looks like this should be done is OgnlValueStack.setValue().
It takes throwExceptionOnFailure, but that is all or nothing. That ends up
including XWorkExceptions with a root issue of ognl NoSuchPropertyException.
These are frequent and not something we care about, at least in our code
base. What I'd like to do is have some kind of parameterization that would
let me turn on error propagation for not ognl property missing error. I did
this locally, but it had to be super hacky because OgnlValueStack.setValue()
is private. I basically installed my own ValueStackFactory that returned a
copy of OgnlValueStack with the function changed to be like:
{code:java}
/**
* @see
com.opensymphony.xwork2.util.ValueStack#findValue(java.lang.String)
*/
public Object findValue(String expr, boolean throwExceptionOnFailure) {
try {
setupExceptionOnFailure(throwExceptionOnFailure);
return tryFindValueWhenExpressionIsNotNull(expr);
} catch (OgnlException e) {
return handleOgnlException(expr, throwExceptionOnFailure, e);
} catch (XWorkException e) {
Throwable cause = e.getCause();
if (cause instanceof NoSuchPropertyException) {
return handleOtherException(expr, throwExceptionOnFailure, e);
}
return handleOtherException(expr, true, e);
} catch (Exception e) {
return handleOtherException(expr, throwExceptionOnFailure, e);
} finally {
ReflectionContextState.clear(context);
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WW-4464) Improve LocalizedTextUtil defend NPE
[ https://issues.apache.org/jira/browse/WW-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4464: -- Fix Version/s: 2.3.x Improve LocalizedTextUtil defend NPE Key: WW-4464 URL: https://issues.apache.org/jira/browse/WW-4464 Project: Struts 2 Issue Type: Improvement Affects Versions: 2.3.20 Reporter: zhouyanming Fix For: 2.3.x https://github.com/apache/struts/pull/35 there is a typo in commit comment, depend should be defend -- This message was sent by Atlassian JIRA (v6.3.4#6332)
