[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326476#comment-15326476
 ] 

Hudson commented on WW-4634:


SUCCESS: Integrated in Struts-JDK7-master #480 (See 
[https://builds.apache.org/job/Struts-JDK7-master/480/])
WW-4634 (victorsosa: rev 6b360108e57b8986c6409b26cba9b3cd4f16a603)
* core/src/main/resources/template/xhtml/controlheader.ftl
* core/src/main/resources/template/xhtml/styles.css
WW-4634 (victorsosa: rev ffdacf1b60b8bf1df54af004a5fd84752eb522b4)
* core/src/main/resources/template/xhtml/controlheader.ftl
* core/src/main/resources/template/xhtml/styles.css
WW-4634 (victorsosa: rev d06c71d68e5c10990386e8904ca60927ed209250)
* core/src/main/resources/template/xhtml/styles.css
* core/src/main/resources/template/xhtml/controlheader.ftl
WW-4634 (victorsosa: rev 9e11b2c2b1962d3bcaa1c2744ecda56f42e21b77)
* core/src/main/resources/template/xhtml/controlheader.ftl
* core/src/main/resources/template/xhtml/styles.css


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326442#comment-15326442
 ] 

ASF GitHub Bot commented on WW-4634:


Github user asfgit closed the pull request at:

https://github.com/apache/struts/pull/95


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326437#comment-15326437
 ] 

ASF subversion and git services commented on WW-4634:
-

Commit d06c71d68e5c10990386e8904ca60927ed209250 in struts's branch 
refs/heads/master from [~victorsosa]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=d06c71d ]

WW-4634


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326439#comment-15326439
 ] 

ASF subversion and git services commented on WW-4634:
-

Commit 30b74a3f01379f095f83431a26d6d232a7b7f061 in struts's branch 
refs/heads/master from [~victorsosa]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=30b74a3 ]

Merge branch 'WW-4634' of github.com:victorsosa/struts into WW-4634


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326440#comment-15326440
 ] 

ASF subversion and git services commented on WW-4634:
-

Commit 30b74a3f01379f095f83431a26d6d232a7b7f061 in struts's branch 
refs/heads/master from [~victorsosa]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=30b74a3 ]

Merge branch 'WW-4634' of github.com:victorsosa/struts into WW-4634


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326438#comment-15326438
 ] 

ASF subversion and git services commented on WW-4634:
-

Commit 9e11b2c2b1962d3bcaa1c2744ecda56f42e21b77 in struts's branch 
refs/heads/master from [~victorsosa]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=9e11b2c ]

WW-4634


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302820#comment-15302820
 ] 

ASF GitHub Bot commented on WW-4634:


Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-221976394
  
Looks fine. Good job.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301722#comment-15301722
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-221804220
  
Yes, I am ok


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301583#comment-15301583
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-221785224
  
I assume we're ok with this and this PR can be merged?


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300273#comment-15300273
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-221621914
  
@victorsosa osm!


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300170#comment-15300170
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa closed the pull request at:

https://github.com/apache/struts/pull/96


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300169#comment-15300169
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/96#issuecomment-221600945
  
PR remove, it wasn't requested


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1525#comment-1525
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-221567053
  
I will fix the 103 test cases, give me some time


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299964#comment-15299964
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-221556310
  
103 tests need to be updated, I think it isn't worth


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299961#comment-15299961
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-221556014
  
Tests are failing :(
```
Error Message

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299583#comment-15299583
 ] 

ASF GitHub Bot commented on WW-4634:


Github user cnenning commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-221490265
  
:+1: 


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298454#comment-15298454
 ] 

ASF GitHub Bot commented on WW-4634:


Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-221326208
  
@victorsosa IMO it would be great. BUT if we really really want it to be 
backward compatible then we can do both. Add a class for future **and** use 
align attribute with `class="align-${parameters.align?html}"` like you propose 
in this PR.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296838#comment-15296838
 ] 

ASF GitHub Bot commented on WW-4634:


Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-221056549
  
I would prefer to follow html5 and drop align attribute completely from S2 
tags, BUT @victorsosa can you at least add some css class to input cell along 
with your solution.
Something like:
```
if align then class="tdInput align-${parameters.align?html}" else 
class="tdInput"
```


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296539#comment-15296539
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/96#issuecomment-221015218
  
OK


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296224#comment-15296224
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/96#issuecomment-220948751
  
That's why people should migrate to 2.5 ;-) I think we can ask reported if 
he wants the same in 2.3


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296221#comment-15296221
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/96#issuecomment-220947364
  
But it is using the parameter align instead of a css class. the align 
parameter is deprecated in html 5.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296000#comment-15296000
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/96#issuecomment-220900444
  
As far I understand the issue was in 2.5 only, 2.3 works as expected.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295569#comment-15295569
 ] 

ASF GitHub Bot commented on WW-4634:


GitHub user victorsosa opened a pull request:

https://github.com/apache/struts/pull/96

WW-4634

Cherry-pick PR for support-2-3

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/victorsosa/struts support-2-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #96


commit 73ccb56cd8b1adf6625fe25e611fd0d365a69c1b
Author: victorsosa 
Date:   2016-05-17T13:00:33Z

WW-4634




> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295450#comment-15295450
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-220818804
  
@lukaszlenart ok


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295435#comment-15295435
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-220817379
  
@victorsosa this commit a0b34806b0f700a1fd240b698c4cec474711bbd0 dropped 
`align` attribute for buttons, it shouldn't affect `textfield` tag. Anyway, I 
think we should merge this PR and if needed prepare another one to target 2.3


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295204#comment-15295204
 ] 

ASF GitHub Bot commented on WW-4634:


Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-220795005
  
@victorsosa You see, this commit already *broke* backward compatibility, 
but it was incomplete in the way it didn't introduce css class for the input 
cell.
It is 2.5 so some breaking changes are expected.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294517#comment-15294517
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-220740769
  
It will break back compatibility as @lukaszlenart said. 


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292760#comment-15292760
 ] 

ASF GitHub Bot commented on WW-4634:


Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-220522532
  
@victorsosa I mean something like `` in 
controlheader.ftl and `.tdInput {text-align:left;}` in styles.css. <-- This is 
for 2.5.

And if alignment doesn't work in 2.3 and your solution fixes it, then this 
PR should target `support-2-3` branch.



> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287382#comment-15287382
 ] 

ASF GitHub Bot commented on WW-4634:


Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219829978
  
@lukaszlenart Ahh ok. Thanks for clarifying that.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287372#comment-15287372
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219829308
  
All the tags are implemented in FreeMarker, those archive templates are 
deprecated and should be thrown away.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287353#comment-15287353
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219826548
  
the css class for that cell is in the controlheader.ftl already.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287350#comment-15287350
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219826190
  
OH ok, got you 
https://github.com/apache/struts/tree/master/core/src/main/resources/template/archive
 I miss that.





> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287331#comment-15287331
 ] 

ASF GitHub Bot commented on WW-4634:


Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219824169
  
Yep, the aforementioned commit misses css class for that cell in the 
`controlheader.ftl`. It should be the same way as for the buttons. :)


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287325#comment-15287325
 ] 

ASF GitHub Bot commented on WW-4634:


Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219823160
  
How the Velocity templating is working? The only Velocity templates I see 
are in the 
[archive](https://github.com/apache/struts/tree/master/core/src/main/resources/template/archive).


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287298#comment-15287298
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219820007
  
@lukaszlenart  the parameter align was remove on this commit 

https://github.com/victorsosa/struts/commit/a0b34806b0f700a1fd240b698c4cec474711bbd0


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287309#comment-15287309
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219820654
  
So it's not a regression bug ;-) Yes, we do support Velocity.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287301#comment-15287301
 ] 

ASF GitHub Bot commented on WW-4634:


Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219820070
  
Issue is about Velocity tags, not FreeMarker. Are we still supporting 
Velocity tags?


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287280#comment-15287280
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219817155
  
I'm just wondering what was the main reason, I have prepared a unit test 
and it didn't pass when using 2.3.29-SNAPSHOT which means 2.3.28.1 is broken 
the same way.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287240#comment-15287240
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219813310
  
CSS class to this table cell is what we have now and to have back 
compatibility as @lukaszlenart said. 


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[Aleksandr Mashchenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287207#comment-15287207
 ] 

Aleksandr Mashchenko commented on WW-4634:
--

Velocity tags? Are we still supporting them?

> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287201#comment-15287201
 ] 

ASF GitHub Bot commented on WW-4634:


Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219809968
  
Why not just add some CSS class to this table cell? Then end-users can 
style it as they want and align parameter will not be needed.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[Jon Juaristi (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286629#comment-15286629
 ] 

Jon Juaristi commented on WW-4634:
--

2.3.28.1

> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[Lukasz Lenart (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286598#comment-15286598
 ] 

Lukasz Lenart commented on WW-4634:
---

[~jontxu] exactly what 2.3 version you have used?

> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286586#comment-15286586
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219713305
  
Another thing I will change the name to just 

> align-center

because this css class can be used in other places that are using the align 
attribute; which is s Not supported in HTML5.


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286570#comment-15286570
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on a diff in the pull request:

https://github.com/apache/struts/pull/95#discussion_r63517163
  
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
  */
 -->
 <#include 
"/${parameters.templateDir}/${parameters.expandTheme}/controlheader-core.ftl" />
-
+class="tdAlign${parameters.align?html}"
--- End diff --

Done


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286560#comment-15286560
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219709110
  
Yes, it fix the main issue and keep the back compatibility. 


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286557#comment-15286557
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on a diff in the pull request:

https://github.com/apache/struts/pull/95#discussion_r63516015
  
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
  */
 -->
 <#include 
"/${parameters.templateDir}/${parameters.expandTheme}/controlheader-core.ftl" />
-
+class="tdAlign${parameters.align?html}"
--- End diff --

yes


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286555#comment-15286555
 ] 

ASF GitHub Bot commented on WW-4634:


Github user victorsosa commented on a diff in the pull request:

https://github.com/apache/struts/pull/95#discussion_r63515782
  
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
  */
 -->
 <#include 
"/${parameters.templateDir}/${parameters.expandTheme}/controlheader-core.ftl" />
-
+class="tdAlign${parameters.align?html}"
--- End diff --

You mean like this class="tdAlign-${parameters.align?html}" ?


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286540#comment-15286540
 ] 

ASF GitHub Bot commented on WW-4634:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/95#issuecomment-219706843
  
This doesn't fix the main issue, right?


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286529#comment-15286529
 ] 

ASF GitHub Bot commented on WW-4634:


GitHub user victorsosa opened a pull request:

https://github.com/apache/struts/pull/95

WW-4634  Centre alignment doesn't seem to work in Velocity tags

Fix for WW-4634

Centre alignment doesn't seem to work in Velocity tags

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/victorsosa/struts WW-4634

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #95


commit da8b13a87ef0d6af54a8cabbc62d54fbca67f683
Author: victor sosa 
Date:   2016-03-03T18:16:11Z

Merge pull request #8 from apache/master

update pull

commit a5d716393999110b3701563479a96e83136a8b97
Author: victor sosa 
Date:   2016-03-03T18:41:11Z

Merge pull request #9 from victorsosa/easymock_update

Easymock update

commit 6bb1ec67ad539d4bf6850f8314ef521e06b8295e
Author: victor sosa 
Date:   2016-03-04T22:07:16Z

Merge pull request #10 from apache/master

pull update

commit 379b75292e6d084dc881e71f0a826c45934d9df8
Author: victor sosa 
Date:   2016-03-27T18:43:40Z

Merge pull request #11 from apache/master

update pull

commit 6b360108e57b8986c6409b26cba9b3cd4f16a603
Author: victorsosa 
Date:   2016-05-17T12:37:13Z

WW-4634




> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[victorsosa (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286505#comment-15286505
 ] 

victorsosa commented on WW-4634:


So, as [~lukaszlenart] said; to keep the old style but at the same time using 
the CSS classes.
You just keep using  {code}#stextfield("label=Foo" "align=center"){code}

{code}

class="tdAlign${parameters.align?html}"


 .tdAligncenter{text-align:center;}
{code}

This code will produce: 


> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[Lukasz Lenart (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286446#comment-15286446
 ] 

Lukasz Lenart commented on WW-4634:
---

This is a regression, it must be fixed without introducing any additional 
dependencies. Such change with additional CSS class can be introduced in 2.5

> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[victorsosa (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286440#comment-15286440
 ] 

victorsosa commented on WW-4634:


I agree on  not generate inline css. 

And we should assign a default class to this component; So If any applications 
can style on their own by just overwriting the classes.

> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[victorsosa (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286402#comment-15286402
 ] 

victorsosa commented on WW-4634:


OK, I can workout a CSS fix to apply the *align="center"* in the second TD.

> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[Christoph Nenning (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286398#comment-15286398
 ] 

Christoph Nenning commented on WW-4634:
---

I would prefer to not generate inline css as that prevents usage of CSP.

https://en.wikipedia.org/wiki/Content_Security_Policy


What do you think about generating class names based on tag attributes? So 
applications can style on their own and yet decide on tag level which styles to 
apply.

> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[victorsosa (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286390#comment-15286390
 ] 

victorsosa commented on WW-4634:


Can you please post the generated HTML code?

> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4634) Centre alignment doesn't seem to work in Velocity tags

[victorsosa (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286381#comment-15286381
 ] 

victorsosa commented on WW-4634:


HI,

I am not sure when this happen; but I think is because *align is Not supported 
in HTML5*.

http://www.w3schools.com/tags/att_td_align.asp

We should use the align attribute and instead use CSS.

> Centre alignment doesn't seem to work in Velocity tags
> --
>
> Key: WW-4634
> URL: https://issues.apache.org/jira/browse/WW-4634
> Project: Struts 2
>  Issue Type: Bug
>  Components: Other
>Affects Versions: 2.5
>Reporter: Jon Juaristi
>Priority: Minor
> Fix For: 2.5.1
>
>
> When using a tag in a Velocity template, for instance 
> {{#stextfield("label=Foo" "align=center")}} with the default xhtml theme, 
> inputs are prepended with just  instead of  (as it 
> happens in 2.3.x) in the generated HTML. A form where you want to centre some 
> of the inputs simply doesn't render as intended.
> I'm using Velocity 1.7 and Velocity Tools 2.0, if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)