[jira] [Commented] (WW-4800) Aspects are not executed when chaining AOPed actions

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036613#comment-16036613
 ] 

Hudson commented on WW-4800:


FAILURE: Integrated in Jenkins build Struts-JDK7-master #634 (See 
[https://builds.apache.org/job/Struts-JDK7-master/634/])
WW-4800 Executes aspects when chaining AOPed actions (yasser.zamani: rev 
8e9f9fb89ff84e3f383d0aef73443af919c271d7)
* (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
* (edit) 
core/src/test/java/com/opensymphony/xwork2/spring/SpringProxyUtilTest.java
* (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/util/reflection/ReflectionProvider.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java
* (add) core/src/test/java/com/opensymphony/xwork2/spring/TestAspect.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlReflectionProvider.java
* (edit) 
core/src/test/resources/com/opensymphony/xwork2/spring/actionContext-spring.xml
* (edit) 
core/src/test/java/com/opensymphony/xwork2/spring/ActionsFromSpringTest.java
* (edit) core/src/main/java/com/opensymphony/xwork2/util/ProxyUtil.java


> Aspects are not executed when chaining AOPed actions
> 
>
> Key: WW-4800
> URL: https://issues.apache.org/jira/browse/WW-4800
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Reporter: Yasser Zamani
>Assignee: Lukasz Lenart
> Fix For: 2.5.next
>
>
> This is a bug in resolution of WW-4105. When we pass the unwrapped object of 
> the proxied action to the `reflectionProvider.copy`, actually we miss aspects 
> executions which are implemented inside the proxied object rather than the 
> unwrapped one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (WW-4800) Aspects are not executed when chaining AOPed actions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036602#comment-16036602
 ] 

ASF GitHub Bot commented on WW-4800:


Github user lukaszlenart commented on the issue:

https://github.com/apache/struts/pull/139
  
Thanks, merged :)


> Aspects are not executed when chaining AOPed actions
> 
>
> Key: WW-4800
> URL: https://issues.apache.org/jira/browse/WW-4800
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Reporter: Yasser Zamani
>Assignee: Lukasz Lenart
> Fix For: 2.5.next
>
>
> This is a bug in resolution of WW-4105. When we pass the unwrapped object of 
> the proxied action to the `reflectionProvider.copy`, actually we miss aspects 
> executions which are implemented inside the proxied object rather than the 
> unwrapped one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (WW-4800) Aspects are not executed when chaining AOPed actions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036600#comment-16036600
 ] 

ASF GitHub Bot commented on WW-4800:


Github user asfgit closed the pull request at:

https://github.com/apache/struts/pull/139


> Aspects are not executed when chaining AOPed actions
> 
>
> Key: WW-4800
> URL: https://issues.apache.org/jira/browse/WW-4800
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Reporter: Yasser Zamani
> Fix For: 2.5.next
>
>
> This is a bug in resolution of WW-4105. When we pass the unwrapped object of 
> the proxied action to the `reflectionProvider.copy`, actually we miss aspects 
> executions which are implemented inside the proxied object rather than the 
> unwrapped one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (WW-4800) Aspects are not executed when chaining AOPed actions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036599#comment-16036599
 ] 

ASF subversion and git services commented on WW-4800:
-

Commit 8e9f9fb89ff84e3f383d0aef73443af919c271d7 in struts's branch 
refs/heads/master from [~yasser.zamani]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=8e9f9fb ]

WW-4800 Executes aspects when chaining AOPed actions


> Aspects are not executed when chaining AOPed actions
> 
>
> Key: WW-4800
> URL: https://issues.apache.org/jira/browse/WW-4800
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Reporter: Yasser Zamani
> Fix For: 2.5.next
>
>
> This is a bug in resolution of WW-4105. When we pass the unwrapped object of 
> the proxied action to the `reflectionProvider.copy`, actually we miss aspects 
> executions which are implemented inside the proxied object rather than the 
> unwrapped one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (WW-4800) Aspects are not executed when chaining AOPed actions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028412#comment-16028412
 ] 

ASF GitHub Bot commented on WW-4800:


GitHub user yasserzamani opened a pull request:

https://github.com/apache/struts/pull/139

WW-4800 Executes aspects when chaining AOPed actions

These fix some bugs in my previous PR, #135 which passes the unwrapped 
object of the proxied action to the `reflectionProvider.copy`, then we miss 
aspects executions which are implemented inside the proxied object rather than 
the unwrapped one.

Also fix some bugs in unit tests of my previous PR and improves them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yasserzamani/struts WW-4800

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit 8e9f9fb89ff84e3f383d0aef73443af919c271d7
Author: Yasser Zamani 
Date:   2017-05-29T14:26:10Z

WW-4800 Executes aspects when chaining AOPed actions




> Aspects are not executed when chaining AOPed actions
> 
>
> Key: WW-4800
> URL: https://issues.apache.org/jira/browse/WW-4800
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Reporter: Yasser Zamani
> Fix For: 2.5.next
>
>
> This is a bug in resolution of WW-4105. When we pass the unwrapped object of 
> the proxied action to the `reflectionProvider.copy`, actually we miss aspects 
> executions which are implemented inside the proxied object rather than the 
> unwrapped one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (WW-4800) Aspects are not executed when chaining AOPed actions

[Yasser Zamani (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026003#comment-16026003
 ] 

Yasser Zamani commented on WW-4800:
---

I'm working on this. The resolution is simple and I have similar impl 
previously at [[WW-4105] OgnlUtil improved in order to only setting properties 
defined|https://github.com/apache/struts/pull/118].

> Aspects are not executed when chaining AOPed actions
> 
>
> Key: WW-4800
> URL: https://issues.apache.org/jira/browse/WW-4800
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Reporter: Yasser Zamani
> Fix For: 2.5.next
>
>
> This is a bug in resolution of WW-4105. When we pass the unwrapped object of 
> the proxied action to the `reflectionProvider.copy`, actually we miss aspects 
> executions which are implemented inside the proxied object rather than the 
> unwrapped one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)