[jira] [Commented] (WW-4915) Replace deprecated commons-lang3 classes
[ https://issues.apache.org/jira/browse/WW-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401942#comment-16401942 ] Hudson commented on WW-4915: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #111 (See [https://builds.apache.org/job/Struts-master-JDK7/111/]) WW-4915 Replace deprecated commons-lang3 classes (add commons-text (amashchenko: rev 478945a0bd563a5586eccfa34fc033c0ba24168d) * (edit) core/src/main/java/com/opensymphony/xwork2/validator/validators/RepopulateConversionErrorFieldValidatorSupport.java * (edit) core/src/main/java/org/apache/struts2/util/TextProviderHelper.java * (edit) core/src/main/java/org/apache/struts2/dispatcher/Parameter.java * (edit) pom.xml * (edit) core/pom.xml * (edit) plugins/json/src/main/java/org/apache/struts2/json/JSONValidationInterceptor.java * (edit) core/src/main/java/org/apache/struts2/views/util/DefaultUrlHelper.java * (edit) apps/showcase/src/main/java/org/apache/struts2/showcase/model/Skill.java * (edit) plugins/javatemplates/src/main/java/org/apache/struts2/views/java/Attributes.java * (edit) plugins/json/pom.xml * (edit) plugins/config-browser/src/main/java/org/apache/struts2/config_browser/ActionNamesAction.java * (edit) plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java * (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/ConversionErrorInterceptor.java * (edit) plugins/javatemplates/pom.xml * (edit) plugins/javatemplates/src/main/java/org/apache/struts2/views/java/XHTMLTagSerializer.java * (edit) plugins/config-browser/src/main/java/org/apache/struts2/config_browser/ShowConfigAction.java * (edit) core/src/main/java/com/opensymphony/xwork2/DefaultActionProxy.java * (edit) plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxListHandler.java WW-4915 Replace deprecated commons-lang3 classes (replace (amashchenko: rev eb6ea7656720650dcd54aa8739b7284cd46286c4) * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/EnvsValueSubstitutor.java WW-4915 Replace deprecated commons-lang3 classes (replace (amashchenko: rev dac624431ef42352cd5343a1a1a7275398ec45d4) * (edit) core/src/main/java/org/apache/struts2/components/Property.java * (edit) core/src/main/java/org/apache/struts2/components/Text.java > Replace deprecated commons-lang3 classes > > > Key: WW-4915 > URL: https://issues.apache.org/jira/browse/WW-4915 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.5.14.1 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > > The Apache Commons Community has recently set up the Commons Text component > as a home for algorithms working on strings. For this reason most of the > string focused functionality in Commons Lang has been deprecated and moved to > Commons Text. This includes: > * All classes in the org.apache.commons.lang3.text and the > org.apache.commons.lang3.text.translate packages > * org.apache.commons.lang3.StringEscapeUtils > * org.apache.commons.lang3.RandomStringUtils > * The methods org.apache.commons.lang3.StringUtils.getJaroWinklerDistance > and org.apache.commons.lang3.StringUtils.getLevenshteinDistance > For more information see the Commons Text website: > http://commons.apache.org/text -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4915) Replace deprecated commons-lang3 classes
[ https://issues.apache.org/jira/browse/WW-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401894#comment-16401894 ] ASF GitHub Bot commented on WW-4915: lukaszlenart closed pull request #208: WW-4915 Replace deprecated commons-lang3 classes URL: https://github.com/apache/struts/pull/208 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/apps/showcase/src/main/java/org/apache/struts2/showcase/model/Skill.java b/apps/showcase/src/main/java/org/apache/struts2/showcase/model/Skill.java index 3dd5bde49..740644d8b 100644 --- a/apps/showcase/src/main/java/org/apache/struts2/showcase/model/Skill.java +++ b/apps/showcase/src/main/java/org/apache/struts2/showcase/model/Skill.java @@ -20,7 +20,7 @@ */ package org.apache.struts2.showcase.model; -import org.apache.commons.lang3.StringEscapeUtils; +import org.apache.commons.text.StringEscapeUtils; import java.io.Serializable; diff --git a/core/pom.xml b/core/pom.xml index 61e6772d7..420b1baa5 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -262,6 +262,10 @@ org.apache.commons commons-lang3 + +org.apache.commons +commons-text + org.springframework spring-core diff --git a/core/src/main/java/com/opensymphony/xwork2/DefaultActionProxy.java b/core/src/main/java/com/opensymphony/xwork2/DefaultActionProxy.java index 81afc3b2e..87b9b7f90 100644 --- a/core/src/main/java/com/opensymphony/xwork2/DefaultActionProxy.java +++ b/core/src/main/java/com/opensymphony/xwork2/DefaultActionProxy.java @@ -23,7 +23,7 @@ import com.opensymphony.xwork2.config.entities.ActionConfig; import com.opensymphony.xwork2.inject.Inject; import com.opensymphony.xwork2.util.profiling.UtilTimerStack; -import org.apache.commons.lang3.StringEscapeUtils; +import org.apache.commons.text.StringEscapeUtils; import org.apache.commons.lang3.StringUtils; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; diff --git a/core/src/main/java/com/opensymphony/xwork2/config/providers/EnvsValueSubstitutor.java b/core/src/main/java/com/opensymphony/xwork2/config/providers/EnvsValueSubstitutor.java index de53caf52..6aff302a1 100644 --- a/core/src/main/java/com/opensymphony/xwork2/config/providers/EnvsValueSubstitutor.java +++ b/core/src/main/java/com/opensymphony/xwork2/config/providers/EnvsValueSubstitutor.java @@ -18,7 +18,7 @@ */ package com.opensymphony.xwork2.config.providers; -import org.apache.commons.lang3.text.StrSubstitutor; +import org.apache.commons.text.StrSubstitutor; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; diff --git a/core/src/main/java/com/opensymphony/xwork2/interceptor/ConversionErrorInterceptor.java b/core/src/main/java/com/opensymphony/xwork2/interceptor/ConversionErrorInterceptor.java index 2c2113b7e..32270de95 100644 --- a/core/src/main/java/com/opensymphony/xwork2/interceptor/ConversionErrorInterceptor.java +++ b/core/src/main/java/com/opensymphony/xwork2/interceptor/ConversionErrorInterceptor.java @@ -22,7 +22,7 @@ import com.opensymphony.xwork2.ActionInvocation; import com.opensymphony.xwork2.conversion.impl.XWorkConverter; import com.opensymphony.xwork2.util.ValueStack; -import org.apache.commons.lang3.StringEscapeUtils; +import org.apache.commons.text.StringEscapeUtils; import java.util.HashMap; import java.util.Map; diff --git a/core/src/main/java/com/opensymphony/xwork2/validator/validators/RepopulateConversionErrorFieldValidatorSupport.java b/core/src/main/java/com/opensymphony/xwork2/validator/validators/RepopulateConversionErrorFieldValidatorSupport.java index 30799215f..e67a39d54 100644 --- a/core/src/main/java/com/opensymphony/xwork2/validator/validators/RepopulateConversionErrorFieldValidatorSupport.java +++ b/core/src/main/java/com/opensymphony/xwork2/validator/validators/RepopulateConversionErrorFieldValidatorSupport.java @@ -23,7 +23,7 @@ import com.opensymphony.xwork2.interceptor.PreResultListener; import com.opensymphony.xwork2.util.ValueStack; import com.opensymphony.xwork2.validator.ValidationException; -import org.apache.commons.lang3.StringEscapeUtils; +import org.apache.commons.text.StringEscapeUtils; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; diff --git a/core/src/main/java/org/apache/struts2/components/Property.java b/core/src/main/java/org/apache/struts2/components/Property.java index 10e1d1e54..4be202551 100644 --- a/core/src/main/java/org/apache/struts2/components/Property.java +++ b/core/src/main/java/org/apache/struts2/components/Property.java @@ -19,7 +19,7 @@ package
[jira] [Commented] (WW-4915) Replace deprecated commons-lang3 classes
[ https://issues.apache.org/jira/browse/WW-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401896#comment-16401896 ] ASF subversion and git services commented on WW-4915: - Commit eb6ea7656720650dcd54aa8739b7284cd46286c4 in struts's branch refs/heads/master from [~aleksandr-m] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=eb6ea76 ] WW-4915 Replace deprecated commons-lang3 classes (replace StrSubstitutor) > Replace deprecated commons-lang3 classes > > > Key: WW-4915 > URL: https://issues.apache.org/jira/browse/WW-4915 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.5.14.1 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > > The Apache Commons Community has recently set up the Commons Text component > as a home for algorithms working on strings. For this reason most of the > string focused functionality in Commons Lang has been deprecated and moved to > Commons Text. This includes: > * All classes in the org.apache.commons.lang3.text and the > org.apache.commons.lang3.text.translate packages > * org.apache.commons.lang3.StringEscapeUtils > * org.apache.commons.lang3.RandomStringUtils > * The methods org.apache.commons.lang3.StringUtils.getJaroWinklerDistance > and org.apache.commons.lang3.StringUtils.getLevenshteinDistance > For more information see the Commons Text website: > http://commons.apache.org/text -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4915) Replace deprecated commons-lang3 classes
[ https://issues.apache.org/jira/browse/WW-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401895#comment-16401895 ] ASF subversion and git services commented on WW-4915: - Commit 478945a0bd563a5586eccfa34fc033c0ba24168d in struts's branch refs/heads/master from [~aleksandr-m] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=478945a ] WW-4915 Replace deprecated commons-lang3 classes (add commons-text dependency, replace StringEscapeUtils) > Replace deprecated commons-lang3 classes > > > Key: WW-4915 > URL: https://issues.apache.org/jira/browse/WW-4915 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.5.14.1 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > > The Apache Commons Community has recently set up the Commons Text component > as a home for algorithms working on strings. For this reason most of the > string focused functionality in Commons Lang has been deprecated and moved to > Commons Text. This includes: > * All classes in the org.apache.commons.lang3.text and the > org.apache.commons.lang3.text.translate packages > * org.apache.commons.lang3.StringEscapeUtils > * org.apache.commons.lang3.RandomStringUtils > * The methods org.apache.commons.lang3.StringUtils.getJaroWinklerDistance > and org.apache.commons.lang3.StringUtils.getLevenshteinDistance > For more information see the Commons Text website: > http://commons.apache.org/text -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4915) Replace deprecated commons-lang3 classes
[ https://issues.apache.org/jira/browse/WW-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401898#comment-16401898 ] ASF subversion and git services commented on WW-4915: - Commit 7f3c09c98e2cc4c951af679dc152cd0ca5d18aac in struts's branch refs/heads/master from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=7f3c09c ] Merge pull request #208 from aleksandr-m/feature/lang_to_text WW-4915 Replace deprecated commons-lang3 classes > Replace deprecated commons-lang3 classes > > > Key: WW-4915 > URL: https://issues.apache.org/jira/browse/WW-4915 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.5.14.1 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > > The Apache Commons Community has recently set up the Commons Text component > as a home for algorithms working on strings. For this reason most of the > string focused functionality in Commons Lang has been deprecated and moved to > Commons Text. This includes: > * All classes in the org.apache.commons.lang3.text and the > org.apache.commons.lang3.text.translate packages > * org.apache.commons.lang3.StringEscapeUtils > * org.apache.commons.lang3.RandomStringUtils > * The methods org.apache.commons.lang3.StringUtils.getJaroWinklerDistance > and org.apache.commons.lang3.StringUtils.getLevenshteinDistance > For more information see the Commons Text website: > http://commons.apache.org/text -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4915) Replace deprecated commons-lang3 classes
[ https://issues.apache.org/jira/browse/WW-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401897#comment-16401897 ] ASF subversion and git services commented on WW-4915: - Commit dac624431ef42352cd5343a1a1a7275398ec45d4 in struts's branch refs/heads/master from [~aleksandr-m] [ https://gitbox.apache.org/repos/asf?p=struts.git;h=dac6244 ] WW-4915 Replace deprecated commons-lang3 classes (replace StringEscapeUtils.escapeXml with StringEscapeUtils.escapeXml10) > Replace deprecated commons-lang3 classes > > > Key: WW-4915 > URL: https://issues.apache.org/jira/browse/WW-4915 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.5.14.1 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > > The Apache Commons Community has recently set up the Commons Text component > as a home for algorithms working on strings. For this reason most of the > string focused functionality in Commons Lang has been deprecated and moved to > Commons Text. This includes: > * All classes in the org.apache.commons.lang3.text and the > org.apache.commons.lang3.text.translate packages > * org.apache.commons.lang3.StringEscapeUtils > * org.apache.commons.lang3.RandomStringUtils > * The methods org.apache.commons.lang3.StringUtils.getJaroWinklerDistance > and org.apache.commons.lang3.StringUtils.getLevenshteinDistance > For more information see the Commons Text website: > http://commons.apache.org/text -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4915) Replace deprecated commons-lang3 classes
[ https://issues.apache.org/jira/browse/WW-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352799#comment-16352799 ] ASF GitHub Bot commented on WW-4915: aleksandr-m opened a new pull request #208: WW-4915 Replace deprecated commons-lang3 classes URL: https://github.com/apache/struts/pull/208 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace deprecated commons-lang3 classes > > > Key: WW-4915 > URL: https://issues.apache.org/jira/browse/WW-4915 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.5.14.1 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > > The Apache Commons Community has recently set up the Commons Text component > as a home for algorithms working on strings. For this reason most of the > string focused functionality in Commons Lang has been deprecated and moved to > Commons Text. This includes: > * All classes in the org.apache.commons.lang3.text and the > org.apache.commons.lang3.text.translate packages > * org.apache.commons.lang3.StringEscapeUtils > * org.apache.commons.lang3.RandomStringUtils > * The methods org.apache.commons.lang3.StringUtils.getJaroWinklerDistance > and org.apache.commons.lang3.StringUtils.getLevenshteinDistance > For more information see the Commons Text website: > http://commons.apache.org/text -- This message was sent by Atlassian JIRA (v7.6.3#76005)
