[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-02-19 Thread Lukasz Lenart (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772664#comment-16772664
 ] 

Lukasz Lenart commented on WW-5004:
---

[~santos.r9] this happens in devMode only, see this part {{set struts.devMode 
to false to disable this message}}

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-02-19 Thread Juan Santos (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772272#comment-16772272
 ] 

Juan Santos commented on WW-5004:
-

Hi, i'm having a trouble with static parameters, i'm migrating an Application 
from Struts 2.3.35 to 2.5.18, i have this Struts configuration:
{code:java}

 2
 ${tipoSoc}
 1
 /WEB-INF/jsp/operacion/ag_operacion_cap.jsp
{code}
In the log i'm getting this stacktrace:
{code:java}
[ERROR] [com.opensymphony.xwork2.interceptor.StaticParametersInterceptor]: 
Developer Notification (set struts.devMode to false to disable this message):
Unexpected Exception caught setting 'tipoSoc' on 'class 
mx.ag.principal.AGClsFinancieroAction: Error setting expression 'tipoSoc' with 
value '${tipoSoc}'
[ERROR] [com.opensymphony.xwork2.interceptor.StaticParametersInterceptor]: 
Developer Notification (set struts.devMode to false to disable this message):
Unexpected Exception caught setting 'tipoSoc' on 'class 
mx.ag.principal.AGClsFinancieroAction: Error setting expression 'tipoSoc' with 
value '${tipoSoc}'
[ERROR] [com.opensymphony.xwork2.interceptor.StaticParametersInterceptor]: 
Developer Notification (set struts.devMode to false to disable this message):
Unexpected Exception caught setting 'tipoSoc' on 'class 
mx.ag.principal.AGClsFinancieroAction: Error setting expression 'tipoSoc' with 
value '${tipoSoc}'
[WARN ] [com.opensymphony.xwork2.util.AbstractLocalizedTextProvider]: Missing 
key [devmode.notification] in bundle [mx.ag.AGClsMensajeError]!
[ERROR] [com.opensymphony.xwork2.interceptor.ParametersInterceptor]: Developer 
Notification (set struts.devMode to false to disable this message):
Unexpected Exception caught setting 'tipoSoc' on 'class 
mx.ag.principal.AGClsFinancieroAction: Error setting expression 'tipoSoc' with 
value '${tipoSoc}'
[WARN ] [com.opensymphony.xwork2.util.AbstractLocalizedTextProvider]: Missing 
key [invalid.fieldvalue.tipoSoc] in bundle [mx.ag.AGClsMensajeError]!
[WARN ] [com.opensymphony.xwork2.util.AbstractLocalizedTextProvider]: Missing 
key [invalid.fieldvalue.tipoSoc] in bundles [[formatter, global, 
org/apache/struts2/struts-messages, com/opensymphony/xwork2/xwork-messages]]!
[INFO ] [com.opensymphony.xwork2.config.ConfigurationManager]: Detected 
container provider [Struts XML configuration provider (struts-default.xml)] 
needs to be reloaded. Reloading all providers.
[ERROR] [com.opensymphony.xwork2.interceptor.ExceptionMappingInterceptor]: No 
result defined for action mx.ag.principal.AGClsFinancieroAction and result input
com.opensymphony.xwork2.config.ConfigurationException: No result defined for 
action mx.ag.principal.AGClsFinancieroAction and result input
 at 
com.opensymphony.xwork2.DefaultActionInvocation.executeResult(DefaultActionInvocation.java:377)
 ~[struts2-core-2.5.18.jar:2.5.18]{code}

The referrercaptura field doesn´t have a setter or getter in the 
action(currently it's working fine with Struts 2.3.35), this field is validated 
by a custom interceptor.
The tipoCons and tipoSoc fields have their setters and getters in the Action 
class.

I have been trying with Struts 2.5.18 and 2.5.20 and OGNL 3.1.18 and 3.1.15 but 
the problem is the same.

Thanks in advance

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-02-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759473#comment-16759473
 ] 

ASF GitHub Bot commented on WW-5004:


lukaszlenart commented on pull request #327: [WW-5004] Fixes changing 
"struts.ognl.allowStaticMethodAccess"
URL: https://github.com/apache/struts/pull/327
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-02-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759357#comment-16759357
 ] 

ASF GitHub Bot commented on WW-5004:


lukaszlenart commented on pull request #327: [WW-5004] Fixes changing 
"struts.ognl.allowStaticMethodAccess"
URL: https://github.com/apache/struts/pull/327
 
 
   This PR relates to [WW-5004](https://issues.apache.org/jira/browse/WW-5004) 
to allow change the flag to a non-default value.
   
   See #317  for discussion
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-02-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759356#comment-16759356
 ] 

ASF GitHub Bot commented on WW-5004:


lukaszlenart commented on pull request #317: [WW-5004] Fixes changing 
"struts.ognl.allowStaticMethodAccess"
URL: https://github.com/apache/struts/pull/317
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-31 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757416#comment-16757416
 ] 

Hudson commented on WW-5004:


SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #258 (See 
[https://builds.apache.org/job/Struts-master-JDK7/258/])
Fix for access issue for 2.6 discovered in WW-5004 (2nd amended commit): 
(43964333+jcgh4164838gh792c124b5: rev 925eb62949347eaf29867b295bcfbc55f210f23a)
* (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java
* (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java
* (edit) 
core/src/test/java/com/opensymphony/xwork2/interceptor/ParametersInterceptorTest.java
* (edit) 
core/src/test/java/org/apache/struts2/util/SecurityMemberAccessInServletsTest.java
* (add) 
core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-staticfield-false.xml
* (edit) 
core/src/test/java/com/opensymphony/xwork2/ognl/SecurityMemberAccessProxyTest.java
* (edit) core/src/test/java/com/opensymphony/xwork2/ognl/SetPropertiesTest.java
* (add) 
core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-staticfield-true.xml
* (edit) core/src/main/java/org/apache/struts2/StrutsConstants.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStackFactory.java
* (edit) 
core/src/test/java/org/apache/struts2/result/ServletRedirectResultTest.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java
* (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java
* (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java
* (edit) 
core/src/test/java/com/opensymphony/xwork2/ognl/SecurityMemberAccessTest.java
Fix for access issue for 2.6 discovered in WW-5004 (Minor update to 
(43964333+jcgh4164838gh792c124b5: rev 64bd12b26da0916b088910c21e1852ef1f2ccaeb)
* (edit) 
core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757375#comment-16757375
 ] 

ASF subversion and git services commented on WW-5004:
-

Commit 64bd12b26da0916b088910c21e1852ef1f2ccaeb in struts's branch 
refs/heads/master from JCgH4164838Gh792C124B5
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=64bd12b ]

Fix for access issue for 2.6 discovered in WW-5004 (Minor update to previous 
commit):
- Restored ability to access public static fields (true by default).
- Introduced a boolean configuration flag (allowStaticFieldAccess).
- Replaced one remaining Boolean.parseBoolean() conversion in OgnlUtil use 
BooleanUtils.toBoolean().
- Enhanced unit tests to confirm proper operation of the fix.
- Replicating L. Lenart's change in PR#317:
  - Removed injection parameter for setAllowStaticMethodAccess in 
OgnlValueStackFactory.
  - Replaced with lazy retrieval of allowStaticMethodAccess from container.
  - Used same pattern for the new allowStaticFieldAccess flag.
  - Added retrieval methods for both flags from the container.
- Optimized calling sequence of isAccessible() based on feedback from previous 
commit.
- Made a couple of getters and the protected checkXXX methods final (avoid 
descendant interference).


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757376#comment-16757376
 ] 

ASF subversion and git services commented on WW-5004:
-

Commit efd5a7c7abc0231bb0a96daab5fcde19916f5fa9 in struts's branch 
refs/heads/master from Aleksandr Mashchenko
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=efd5a7c ]

Merge pull request #320 from JCgH4164838Gh792C124B5/localS2_26x_B2

Fix for access issue for 2.6 discovered in WW-5004:

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757374#comment-16757374
 ] 

ASF subversion and git services commented on WW-5004:
-

Commit 925eb62949347eaf29867b295bcfbc55f210f23a in struts's branch 
refs/heads/master from JCgH4164838Gh792C124B5
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=925eb62 ]

Fix for access issue for 2.6 discovered in WW-5004 (2nd amended commit):
- Restored ability to access public static fields (true by default).
- Introduced a boolean configuration flag (allowStaticFieldAccess).
- Replaced one remaining Boolean.parseBoolean() conversion in OgnlUtil use 
BooleanUtils.toBoolean().
- Enhanced unit tests to confirm proper operation of the fix.
- Replicating L. Lenart's change in PR#317:
  - Removed injection parameter for setAllowStaticMethodAccess in 
OgnlValueStackFactory.
  - Replaced with lazy retrieval of allowStaticMethodAccess from container.
  - Used same pattern for the new allowStaticFieldAccess flag.
  - Added retrieval methods for both flags from the container.


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757373#comment-16757373
 ] 

ASF GitHub Bot commented on WW-5004:


aleksandr-m commented on pull request #320: Fix for access issue for 2.6 
discovered in WW-5004:
URL: https://github.com/apache/struts/pull/320
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757292#comment-16757292
 ] 

ASF subversion and git services commented on WW-5004:
-

Commit 5524c579d29dbe91fe82428a74fb4cb1888330ba in struts's branch 
refs/heads/struts-2-5-x from JCgH4164838Gh792C124B5
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=5524c57 ]

Fix for NPE issue discovered in WW-5004. (#316)

* Fix for NPE issue discovered in WW-5004.
- Guard fix for a NPE that can arise under certain conditions, identified by A. 
Mashchenko.

* Fix for NPE issue discovered in WW-5004 (amended commit).
- Guard fix for a NPE that can arise under certain conditions, identified by A. 
Mashchenko.
- Requires the following elements to implement a fuller fix:
  - Back-port relevant guard logic in ProxyUtil from master into 2.5.x to deal 
with the NPE.
  - Update SecurityMemberAccess to block access to static fields.
  - Upgrade to OGNL 3.1.22 (re-enables access to public static fields w/out 
access checks).
  - Add unit test to confirm proper functionality of the fix.
  - Correct missing entry in 4 test configuration XML files (needed for new 
unit test).
- Replaced literal injection parameter name for setStaticFieldAccessLevel in 
OgnlValueStackFactory with the appropriate constant.
  Note: Even though a constant was defined in StrutsConstants, the value for 
the injection name in all places is the XWorkConstants.
It has to remain the same to avoid breaking anything.


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757291#comment-16757291
 ] 

ASF subversion and git services commented on WW-5004:
-

Commit 5524c579d29dbe91fe82428a74fb4cb1888330ba in struts's branch 
refs/heads/struts-2-5-x from JCgH4164838Gh792C124B5
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=5524c57 ]

Fix for NPE issue discovered in WW-5004. (#316)

* Fix for NPE issue discovered in WW-5004.
- Guard fix for a NPE that can arise under certain conditions, identified by A. 
Mashchenko.

* Fix for NPE issue discovered in WW-5004 (amended commit).
- Guard fix for a NPE that can arise under certain conditions, identified by A. 
Mashchenko.
- Requires the following elements to implement a fuller fix:
  - Back-port relevant guard logic in ProxyUtil from master into 2.5.x to deal 
with the NPE.
  - Update SecurityMemberAccess to block access to static fields.
  - Upgrade to OGNL 3.1.22 (re-enables access to public static fields w/out 
access checks).
  - Add unit test to confirm proper functionality of the fix.
  - Correct missing entry in 4 test configuration XML files (needed for new 
unit test).
- Replaced literal injection parameter name for setStaticFieldAccessLevel in 
OgnlValueStackFactory with the appropriate constant.
  Note: Even though a constant was defined in StrutsConstants, the value for 
the injection name in all places is the XWorkConstants.
It has to remain the same to avoid breaking anything.


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757289#comment-16757289
 ] 

ASF GitHub Bot commented on WW-5004:


yasserzamani commented on pull request #316: Fix for NPE issue discovered in 
WW-5004.
URL: https://github.com/apache/struts/pull/316
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757290#comment-16757290
 ] 

ASF subversion and git services commented on WW-5004:
-

Commit 5524c579d29dbe91fe82428a74fb4cb1888330ba in struts's branch 
refs/heads/struts-2-5-x from JCgH4164838Gh792C124B5
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=5524c57 ]

Fix for NPE issue discovered in WW-5004. (#316)

* Fix for NPE issue discovered in WW-5004.
- Guard fix for a NPE that can arise under certain conditions, identified by A. 
Mashchenko.

* Fix for NPE issue discovered in WW-5004 (amended commit).
- Guard fix for a NPE that can arise under certain conditions, identified by A. 
Mashchenko.
- Requires the following elements to implement a fuller fix:
  - Back-port relevant guard logic in ProxyUtil from master into 2.5.x to deal 
with the NPE.
  - Update SecurityMemberAccess to block access to static fields.
  - Upgrade to OGNL 3.1.22 (re-enables access to public static fields w/out 
access checks).
  - Add unit test to confirm proper functionality of the fix.
  - Correct missing entry in 4 test configuration XML files (needed for new 
unit test).
- Replaced literal injection parameter name for setStaticFieldAccessLevel in 
OgnlValueStackFactory with the appropriate constant.
  Note: Even though a constant was defined in StrutsConstants, the value for 
the injection name in all places is the XWorkConstants.
It has to remain the same to avoid breaking anything.


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753764#comment-16753764
 ] 

ASF GitHub Bot commented on WW-5004:


JCgH4164838Gh792C124B5 commented on pull request #320: Fix for access issue for 
2.6 discovered in WW-5004:
URL: https://github.com/apache/struts/pull/320
 
 
   Fix for access issue for 2.6 discovered in WW-5004:
   - Restored ability to access public static fields by default.
   - Introduced a configuration flag (staticFieldAccessLevel) with three levels:
 0 - disable static field access completely.
 1 - allow public static field access (default).
 2 - allow limited non-public static field access (primitives and strings 
only, with hardcoded exclusions).
   - Required 3 new test configuration files, enhanced unit tests and updates 
to multiple modules to handle the new flag.
   - Fixed bad/mismatched injection parameter name for 
setStaticFieldAccessLevel in OgnlValueStackFactory.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752171#comment-16752171
 ] 

ASF GitHub Bot commented on WW-5004:


lukaszlenart commented on pull request #317: [WW-5004] Fixes changing 
"struts.ognl.allowStaticMethodAccess"
URL: https://github.com/apache/struts/pull/317
 
 
   This PR relates to WW-5004 to allow change a flag to a non-default value.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751635#comment-16751635
 ] 

ASF GitHub Bot commented on WW-5004:


JCgH4164838Gh792C124B5 commented on pull request #316: Fix for NPE issue 
discovered in WW-5004.
URL: https://github.com/apache/struts/pull/316
 
 
Fix for `NPE` issue discovered in WW-5004.
   - Guard fix for a `NPE` that can arise under certain conditions, identified 
by _A. Mashchenko_.
   - This guard (or something similar) will probably be required for future 
non-public field access logic ... may want to hold-off on this PR and instead 
include the fix in a "fuller solution".
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-22 Thread Lukasz Lenart (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748497#comment-16748497
 ] 

Lukasz Lenart commented on WW-5004:
---

I would rather opt to add another flag {{struts.allowStaticFieldAccess}} and 
set it to {{true}} by default. OGNL shouldn't be changed and checking access to 
static fields is a good idea.

{{OgnlContext.DEFAULT_MEMBER_ACCESS}} is always used to hack a system, with 
such flag and control mechanism in place this won't be possible anymore.

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-20 Thread James Chaplin (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747696#comment-16747696
 ] 

James Chaplin commented on WW-5004:
---

Hello.

For 2.5.x it seems that the flag _struts.allowStaticMethodAccess_ does produce 
a change, to allow the field access, but as commented above that wasn't 
necessary to access public static fields in 2.5.18.

There's a recent PR for OGNL 3.1.x that might mitigate the issue for 2.5.21, 
but downgrading to OGNL 3.1.18 also worked for me with 2.5.20 (at least 
according to a test page created to simulate the scenario).

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-20 Thread Lukasz Lenart (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747474#comment-16747474
 ] 

Lukasz Lenart commented on WW-5004:
---

Looks like we have a bug and setting {{struts.ognl.allowStaticMethodAccess}} to 
{{true}} does nothing.

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-18 Thread JIRA


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745872#comment-16745872
 ] 

Deniz Renkligül commented on WW-5004:
-

it works as a workaround downgrade OGNL to 3.1.18.
{noformat}

 ognl
 ognl
 3.1.18
{noformat}

Thanks!

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Lukasz Lenart (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745526#comment-16745526
 ] 

Lukasz Lenart commented on WW-5004:
---

No, but we can ask the author here https://github.com/jkuhnert/ognl/issues/58 
for a use case

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Aleksandr Mashchenko (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745521#comment-16745521
 ] 

Aleksandr Mashchenko commented on WW-5004:
--

[~lukaszlenart] Do you have some example why it should be restricted at all?

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Lukasz Lenart (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745520#comment-16745520
 ] 

Lukasz Lenart commented on WW-5004:
---

I think this makes sense to check access to fields as well, we are checking 
access to static methods.

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Lukasz Lenart (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745518#comment-16745518
 ] 

Lukasz Lenart commented on WW-5004:
---

Ah, right. And yes, you are right, so maybe we should add a new flag 
{{allowStaticFieldAccess}}?

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Aleksandr Mashchenko (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745517#comment-16745517
 ] 

Aleksandr Mashchenko commented on WW-5004:
--

[~lukaszlenart] {{disallowProxyMemberAccess}}  will be true if spring plugin is 
used. Still, why MemberAccess should be called for fields?

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Aleksandr Mashchenko (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745498#comment-16745498
 ] 

Aleksandr Mashchenko commented on WW-5004:
--

{\{allowStaticMethodAccess}} will work only if \{{disallowProxyMemberAccess}} 
is \{{false}} and \{{ProxyUtil.isProxyMember}} is not called. But it is still 
wrong to use \{{allowStaticMethodAccess}} for fields.

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Lukasz Lenart (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745514#comment-16745514
 ] 

Lukasz Lenart commented on WW-5004:
---

Not sure if I understand, {{disallowProxyMemberAccess}} is {{false}} by default 
which should fix the issue.

And maybe move discussion about OGNL to https://github.com/jkuhnert/ognl ?

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Aleksandr Mashchenko (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745513#comment-16745513
 ] 

Aleksandr Mashchenko commented on WW-5004:
--

It is kind of working in 2.6 with caveat that \{{allowStaticMethodAccess}} is 
used for fields which is wrong.

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Aleksandr Mashchenko (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745465#comment-16745465
 ] 

Aleksandr Mashchenko commented on WW-5004:
--

[~DenizR] As a workaround you can downgrade OGNL to 3.1.18.

 
{code:java}

  ognl
  ognl
  3.1.18

{code}

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Aleksandr Mashchenko (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745398#comment-16745398
 ] 

Aleksandr Mashchenko commented on WW-5004:
--

We've discovered same bug today. It is broken by this commit 
[https://github.com/jkuhnert/ognl/commit/4da6759b2f8e746cd1b8fbfabde5d067e3ea0baa]
 in OGNL.

NPE is thrown somewhere in {{ProxyUtil}} and even if it is fixed then 
displaying static field still doesn't work.

I wonder why do we need to call MemberAccess in case of static fields at all?

Also why do OGNL allows to access private static fields? It doesn't seem 
reasonable.

 

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread JIRA


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744996#comment-16744996
 ] 

Deniz Renkligül commented on WW-5004:
-

After the putting in struts.xml 
  
 same behavior. The error still exists.

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Major
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Lukasz Lenart (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744982#comment-16744982
 ] 

Lukasz Lenart commented on WW-5004:
---

Could you set the below constant in struts.xml?

{code:xml}
  
{code}

And WW-4984 is unrelated as well, it was issue with serving static files like 
JS or CSS, not about accessing static fields.

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Major
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread JIRA


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744976#comment-16744976
 ] 

Deniz Renkligül commented on WW-5004:
-

Sorry, no logs or error messages are shown.

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Major
>  Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available

2019-01-17 Thread Lukasz Lenart (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744971#comment-16744971
 ] 

Lukasz Lenart commented on WW-5004:
---

Do you see any WARN in logs?

Also these constants

{code:xml}


{code}

do not relate to accessing constants via {{@}}

> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Major
>  Labels: build, features, patch, usability
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call 
> a java static variable in JSP like
> {code:java}
> 
> {code}
> Please see for more details the release notes of 2.5.20
>  [link 
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
>  and I tried without success the following description assigned above in the 
> release version notes 2.5.20 with :
> {code:java}
> 
> 
> {code}
>  https://issues.apache.org/jira/browse/WW-4984
>  
> Thanks in advance for your support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)