[jira] [Work logged] (WW-5385) Decompose StrutsVelocityContext for better reuse
[ https://issues.apache.org/jira/browse/WW-5385?focusedWorklogId=898402=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898402 ] ASF GitHub Bot logged work on WW-5385: -- Author: ASF GitHub Bot Created on: 08/Jan/24 09:45 Start Date: 08/Jan/24 09:45 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #839: URL: https://github.com/apache/struts/pull/839#issuecomment-1880667269 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_struts=839) **Quality Gate failed** Failed conditions [B Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts=839) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=839) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![SonarLint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'SonarLint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) Issue Time Tracking --- Worklog Id: (was: 898402) Time Spent: 1h 20m (was: 1h 10m) > Decompose StrutsVelocityContext for better reuse > > > Key: WW-5385 > URL: https://issues.apache.org/jira/browse/WW-5385 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5385) Decompose StrutsVelocityContext for better reuse
[ https://issues.apache.org/jira/browse/WW-5385?focusedWorklogId=898400=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898400 ] ASF GitHub Bot logged work on WW-5385: -- Author: ASF GitHub Bot Created on: 08/Jan/24 09:42 Start Date: 08/Jan/24 09:42 Worklog Time Spent: 10m Work Description: kusalk closed pull request #839: WW-5385 Decompose StrutsVelocityContext for better re-usability URL: https://github.com/apache/struts/pull/839 Issue Time Tracking --- Worklog Id: (was: 898400) Time Spent: 1h (was: 50m) > Decompose StrutsVelocityContext for better reuse > > > Key: WW-5385 > URL: https://issues.apache.org/jira/browse/WW-5385 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5385) Decompose StrutsVelocityContext for better reuse
[ https://issues.apache.org/jira/browse/WW-5385?focusedWorklogId=898401=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898401 ] ASF GitHub Bot logged work on WW-5385: -- Author: ASF GitHub Bot Created on: 08/Jan/24 09:42 Start Date: 08/Jan/24 09:42 Worklog Time Spent: 10m Work Description: kusalk commented on PR #839: URL: https://github.com/apache/struts/pull/839#issuecomment-1880664081 Closing this for now and considering for Struts 7.0 instead as these changes break backwards compatibility with Velocity 1.x Issue Time Tracking --- Worklog Id: (was: 898401) Time Spent: 1h 10m (was: 1h) > Decompose StrutsVelocityContext for better reuse > > > Key: WW-5385 > URL: https://issues.apache.org/jira/browse/WW-5385 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5385) Decompose StrutsVelocityContext for better reuse
[ https://issues.apache.org/jira/browse/WW-5385?focusedWorklogId=898358=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898358 ] ASF GitHub Bot logged work on WW-5385: -- Author: ASF GitHub Bot Created on: 08/Jan/24 07:45 Start Date: 08/Jan/24 07:45 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #839: URL: https://github.com/apache/struts/pull/839#issuecomment-1880513155 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_struts=839) **Quality Gate failed** Failed conditions [B Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts=839) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=839) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![SonarLint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'SonarLint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) Issue Time Tracking --- Worklog Id: (was: 898358) Time Spent: 50m (was: 40m) > Decompose StrutsVelocityContext for better reuse > > > Key: WW-5385 > URL: https://issues.apache.org/jira/browse/WW-5385 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.4.0 > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5385) Decompose StrutsVelocityContext for better reuse
[ https://issues.apache.org/jira/browse/WW-5385?focusedWorklogId=898357=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898357 ] ASF GitHub Bot logged work on WW-5385: -- Author: ASF GitHub Bot Created on: 08/Jan/24 07:42 Start Date: 08/Jan/24 07:42 Worklog Time Spent: 10m Work Description: kusalk commented on PR #839: URL: https://github.com/apache/struts/pull/839#issuecomment-1880509868 SonarCloud note: There are indeed 6 levels of inheritance here but 3 of them are within the Velocity library - plus each of our context classes have a distinct purpose/use Issue Time Tracking --- Worklog Id: (was: 898357) Time Spent: 40m (was: 0.5h) > Decompose StrutsVelocityContext for better reuse > > > Key: WW-5385 > URL: https://issues.apache.org/jira/browse/WW-5385 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.4.0 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5385) Decompose StrutsVelocityContext for better reuse
[ https://issues.apache.org/jira/browse/WW-5385?focusedWorklogId=898355=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898355 ] ASF GitHub Bot logged work on WW-5385: -- Author: ASF GitHub Bot Created on: 08/Jan/24 07:36 Start Date: 08/Jan/24 07:36 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #839: URL: https://github.com/apache/struts/pull/839#issuecomment-1880504599 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_struts=839) **Quality Gate failed** Failed conditions [B Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts=839) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=839) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![SonarLint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'SonarLint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) Issue Time Tracking --- Worklog Id: (was: 898355) Time Spent: 0.5h (was: 20m) > Decompose StrutsVelocityContext for better reuse > > > Key: WW-5385 > URL: https://issues.apache.org/jira/browse/WW-5385 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.4.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5385) Decompose StrutsVelocityContext for better reuse
[ https://issues.apache.org/jira/browse/WW-5385?focusedWorklogId=898354=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898354 ] ASF GitHub Bot logged work on WW-5385: -- Author: ASF GitHub Bot Created on: 08/Jan/24 07:27 Start Date: 08/Jan/24 07:27 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #839: URL: https://github.com/apache/struts/pull/839#issuecomment-1880496512 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_struts=839) **Quality Gate failed** Failed conditions [B Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts=839) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=839) ![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png 'idea') Catch issues before they fail your Quality Gate with our IDE extension ![SonarLint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png 'SonarLint') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) Issue Time Tracking --- Worklog Id: (was: 898354) Time Spent: 20m (was: 10m) > Decompose StrutsVelocityContext for better reuse > > > Key: WW-5385 > URL: https://issues.apache.org/jira/browse/WW-5385 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5385) Decompose StrutsVelocityContext for better reuse
[ https://issues.apache.org/jira/browse/WW-5385?focusedWorklogId=898352=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898352 ] ASF GitHub Bot logged work on WW-5385: -- Author: ASF GitHub Bot Created on: 08/Jan/24 07:18 Start Date: 08/Jan/24 07:18 Worklog Time Spent: 10m Work Description: kusalk opened a new pull request, #839: URL: https://github.com/apache/struts/pull/839 WW-5385 -- Issue Time Tracking --- Worklog Id: (was: 898352) Remaining Estimate: 0h Time Spent: 10m > Decompose StrutsVelocityContext for better reuse > > > Key: WW-5385 > URL: https://issues.apache.org/jira/browse/WW-5385 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.4.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)