[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12865161#action_12865161 ] Wes Wannemacher commented on WW-2754: - You're right Benjamin... A quick google search verifies that they are indeed sync'd. Lukasz and I have been working a bit on the build and getting some other mechanical things done, but we should be getting close to attempting a release real soon. As far as I can tell, your plugin will be included! Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.x Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12865322#action_12865322 ] Benjamin McCann commented on WW-2754: - Thanks. That's awesome. Let me know if there's a date you have in mind and I can push harder to see whether we can get GXP into the Maven repository by then (I've been pinging people internally about it). I'll also write up a tutorial for people to be able to easily get started with it. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.x Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12865409#action_12865409 ] Lukasz Lenart commented on WW-2754: --- As soon as Nexus will be configured to release Struts ;-) Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.x Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12864830#action_12864830 ] Benjamin McCann commented on WW-2754: - Yep, I agree: http://groups.google.com/group/gxp-users/browse_thread/thread/f6003cf2856823a4 http://code.google.com/p/gxp/issues/detail?id=5 There are still a couple files missing from the source repository (at least the ones you mentioned in your earlier comment: struts-plugin.xml and InjectedObjectContainer.java) Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.x Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12864876#action_12864876 ] Wes Wannemacher commented on WW-2754: - Benjamin, why only shoot for the Google Maven repo... I'd prefer to see it in the central repository... You can get the main steps here - http://maven.apache.org/guides/mini/guide-central-repository-upload.html Basically, make sure you have a properly formatted pom file (with all the required config elements), then fill out a request at the Codehaus JIRA. I'd imagine that from there, they'll provide the upload details (I could be wrong, but I think what they'll do is give you an account on the sonatype-hosted nexus instance, and you can just configure your pom to stage releases there). If you're not a maven buff, email me (w...@wantii.com | w...@wantii.com) and I can checkout the GXP code from the googlecode project and create some patches for you to make it easier. BTW, i could be wrong, but I think it's a requirement for us (apache projects) to stay away from non-central maven repos... This is good practice in general (nothing against google). And since GXP is ASL2 licensed, there's no reason that it can't go into central. -Wes Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.x Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12865007#action_12865007 ] Benjamin McCann commented on WW-2754: - Hey Wes, I believe the Google Maven repository is synced with the central repository. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.x Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12862068#action_12862068 ] Benjamin McCann commented on WW-2754: - All the paperwork issues should be resolved now. Can we get the rest of the source code checked in? Thanks! Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.x Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12836126#action_12836126 ] Benjamin McCann commented on WW-2754: - Martin responded to me by email that Apache doesn't have the paperwork. This information would have been helpful earlier. I was under the impression that you had the paperwork already. I'm not sure how this code would have been released without it. Anyway, I'll talk to the folks at Google and get another copy. It'll probably be a couple weeks. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.0 Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12832498#action_12832498 ] Benjamin McCann commented on WW-2754: - Ok, well let me know if you need my help. It can take a couple of weeks to get a VP to sign the code donation form and I'd like to get this in. Any idea what the timeline is from the PMC? Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.0 Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12832409#action_12832409 ] Benjamin McCann commented on WW-2754: - Lukasz, what's the legal concern with the code? Everything donated by Google was checked in, which is what I'd have expected would have the most legal CYAs. Is there anything you need from me? I've already signed a few contributor license agreements for Apache in the past (last were for Commons Math). Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.0 Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12832415#action_12832415 ] Lukasz Lenart commented on WW-2754: --- I'm waiting for clarification from PMC, what should we do. Martin Cooper has some doubts about that code donation . Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.0 Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829004#action_12829004 ] Lukasz Lenart commented on WW-2754: --- We need to wait for some law clarification about it. I can put the code on Google Code site if you need. Regards -- Lukasz Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.0 Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828669#action_12828669 ] Ben McCann commented on WW-2754: The struts-plugin.xml file will need to be checked in. Can someone with commit privileges take a look? Thanks. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.0 Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/jira/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828701#action_12828701 ] John Krueger commented on WW-2754: -- I also noticed that the class, InjectedObjectContainer, is not checked in. This is referenced in the struts-plugin.xml and is needed for the GxpResult to have access to the value stack. In case it helps here is the xml from the version of the struts-plugin.xml that I am using. It has been modified to reflect the new package names. I assume this goes in ../src/main/resources like it is in other plugins. I use ant instead of maven so I don't know if anything in the pom needs to change. ?xml version=1.0 encoding=UTF-8 ? !DOCTYPE struts PUBLIC -//Apache Software Foundation//DTD Struts Configuration 2.0//EN http://struts.apache.org/dtds/struts-2.0.dtd; struts bean type=org.apache.struts2.views.gxp.inject.InjectedObjectContainer class=org.apache.struts2.views.gxp.inject.InjectedObjectContainer static=true / package name=gxp-default extends=struts-default result-types result-type name=gxp class=org.apache.struts2.views.gxp.GxpResult/ /result-types /package /struts Thanks, John Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/jira/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: musachy Assignee: Lukasz Lenart Fix For: 2.2.0 Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47267#action_47267 ] John Krueger commented on WW-2754: -- I think the struts-plugin.xml file needs to be checked in. I can't find it in the code that was checked into the sandbox but it is in the zip file. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: Musachy Barroso Assignee: Lukasz Lenart Fix For: 2.2.0 Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47262#action_47262 ] Benjamin McCann commented on WW-2754: - Awesome. Thanks! I'll try to keep things rolling on this plug-in. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Components: New API Reporter: Musachy Barroso Assignee: Lukasz Lenart Fix For: 2.2.0 Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts2-gxp-demo.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47256#action_47256 ] Lukasz Lenart commented on WW-2754: --- Is it possible to use Struts 2 tags with that result? Regards -- Lukasz Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Assignee: Lukasz Lenart Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47258#action_47258 ] Benjamin McCann commented on WW-2754: - I'm guessing you'd have a hard time using Struts tags in a GXP page because the GXP compiler would probably barf on them. I've never tried though as the GXP tags are meant to be a replacement for the Struts tags. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Assignee: Lukasz Lenart Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47250#action_47250 ] Benjamin McCann commented on WW-2754: - Thanks Nuwan. I'm glad you had success with it! The plugin code you shared will be very helpful for me. I wanted to do something along those lines, but am not too familiar with Maven. Hopefully we can get this checked in soon and then I can share this with others I know who would like to continue making improvements such as getting the GXP jar into the Google Maven repository. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Assignee: Lukasz Lenart Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[
https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47249#action_47249
]
Nuwan Chandrasoma commented on WW-2754:
---
Hi Benjamin McCann,
i used the below code in the pom.xml to generate gxp to java in my maven build,
hope this will help you also.
plugin
artifactIdmaven-antrun-plugin/artifactId
executions
execution
phasegenerate-sources/phase
configuration
tasks
taskdef name=gxpc
classname=com.google.gxp.compiler.ant.GxpcTask
classpathref=maven.compile.classpath /
gxpc srcdir=${basedir}\src\main\java
srcpaths=${basedir}\src\main\java
destdir=${basedir}\target\generated-sources
target=com.xxxss.s2.example.message i18nwarn=false /
copy todir=${basedir}\src\main\java
fileset dir=${basedir}\target\generated-sources /
/copy
/tasks
/configuration
goals
goalrun/goal
/goals
/execution
/executions
/plugin
Thanks,
Nuwan C.
Source code for GXP result
---
Key: WW-2754
URL: https://issues.apache.org/struts/browse/WW-2754
Project: Struts 2
Issue Type: Temp
Reporter: Musachy Barroso
Assignee: Lukasz Lenart
Fix For: Future
Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip,
struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip,
struts-gxp-plugin.zip
Thanks to the google and the GXP guys for sending us the code
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47244#action_47244 ] Lukasz Lenart commented on WW-2754: --- I will commit your changes to sandbox and hopefully we will be able to move it to Struts 2 trunk after all. Regards -- Lukasz Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Assignee: Lukasz Lenart Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47210#action_47210 ] Benjamin McCann commented on WW-2754: - Any update on getting this checked in? Thanks. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47160#action_47160 ] Lukasz Lenart commented on WW-2754: --- You must inject Container into GxpResult (define setter with type Container and annotation @Inject), then after checking if gxp is not null call container.inject(gxp) - should work. Is that code committed into Struts2 repo? Regards -- Lukasz Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47161#action_47161 ] Benjamin McCann commented on WW-2754: - Thank you for the reply Lukasz. I'm missing something still though. I don't know how to make the actual injection happen, so I don't know how to inject the container anymore than I know how to inject the ValueStackFactory. Is there an analog to Guice.createInjector()? (Btw, I think it'd be nice if xwork switched to actually using Guice instead of it's own implementation. There's a lot of docs out there on Guice and none on xwork DI, so it'd be easier for newcomers like myself to pickup) This code is not in the Struts2 repo yet, but I would love to get it there. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[
https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47162#action_47162
]
Musachy Barroso commented on WW-2754:
-
we are on the talks to use Guice in the dev mailing list. As to get a reference
to the container, just do (on a container managed class)
@Inject
public void setContaine(Container c) {...}
Source code for GXP result
---
Key: WW-2754
URL: https://issues.apache.org/struts/browse/WW-2754
Project: Struts 2
Issue Type: Temp
Reporter: Musachy Barroso
Fix For: Future
Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip,
struts-gxp-plugin.zip, struts-gxp-plugin.zip
Thanks to the google and the GXP guys for sending us the code
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47163#action_47163 ] Benjamin McCann commented on WW-2754: - Maybe it's the container managed part I'm missing then. I'm not quite sure what that means, but it's doubtful my class is container managed. If I just add a setter currently it will not be called. If it were, couldn't I simple inject the ValueStackFactory itself? I'm not sure how well all this code is setup for DI since it uses a static cache. Does struts have anything like a Guice module's requestStaticInjection? Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47164#action_47164 ] Musachy Barroso commented on WW-2754: - yes, Struts DI is Guice pre 1.0. you need to create a bean for it, to make it managed by the container, like bean name=mybean class=SomeClass / if you just want to inject some static references: bean class=SomeClass static=true / and annotate the static methods with @Inject Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47166#action_47166 ] Benjamin McCann commented on WW-2754: - Well add a +1 from me on the list for using Guice. Sorry to be a pain, but I'm still totally lost. (There's no example or doc is there?) Where do I add this XML? Is it a new file I create for the plugin? How is it consumed? Do I have to create something that reads it in? Is the container the same as the Guice Injector? It sounds like I can reuse an existing container rather than creating my own instance? But I don't understand how I'm supposed to get a reference to it. Simply creating a setter is not going to be enough. How do I have that setter called? Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47167#action_47167 ] Lukasz Lenart commented on WW-2754: --- Just define the setter setContainer() and the rest Struts will do for you ;-) Regards -- Lukasz Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47168#action_47168 ] Musachy Barroso commented on WW-2754: - these beans are defined on the struts.xml file by application developers, or in struts-plugin.xml for plugin developers (you want to use this one). See: http://struts.apache.org/2.x/docs/bean-configuration.html Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[
https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47169#action_47169
]
Benjamin McCann commented on WW-2754:
-
So what I want to do is something like the following then?
struts
bean class=com.opensymphony.xwork2.ognl.OgnlValueStackFactory
static=true /
/struts
public class AbstractGxp {
@Inject static final ValueStackFactory VALUE_STACK_FACTORY;
}
Source code for GXP result
---
Key: WW-2754
URL: https://issues.apache.org/struts/browse/WW-2754
Project: Struts 2
Issue Type: Temp
Reporter: Musachy Barroso
Fix For: Future
Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip,
struts-gxp-plugin.zip, struts-gxp-plugin.zip
Thanks to the google and the GXP guys for sending us the code
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47156#action_47156 ] Benjamin McCann commented on WW-2754: - So I guess the problem is that I need to inject the ValueStackFactory instead of just creating a new one or else it won't have its dependencies available. I don't really know much about Guice though and even less about how Struts does dependency injection which appears to be based off of Guice. I can add an @Inject setValueStackFactory method on Abstract GXP, but then I don't know how to make the magic happens that calls that method. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47150#action_47150 ] Benjamin McCann commented on WW-2754: - Hi Wes, thanks for the quick response. I checked out the code available at http://svn.apache.org/viewvc/struts/sandbox/trunk/struts2-gxp-plugin/ Is that what you were referring to? I'm not real sure what that code is. It doesn't contain any of the files in the attachment on this issue. It looks like it is the beginning of some sort of attempt to reimplement all the Struts tags using GXP as an intermediary? Really I'd just like to be able to use the gxp result type provided here. I can of course compile it on my own, but I'd like to help get it in a place that's more easily usable by others as well. Is there anything I can do to help get this checked in to SVN? It looks like really the only thing that is needed is to put the code in a standard maven directory structure and add a pom.xml. The code itself is solid as it's widely used within Google. If you let me know in fast enough, I've got free time this weekend that I could use to do that. My only question is what would you want me to name this plugin? The code attached here is well tested and has been extensively used with Google, so I'd prefer not to mix it with what's in SVN since that code is only a partial implementation of an idea which is far away from being able to be released. If we keep the code to just what's attached here then we have something that could be released. Maybe we could rename the existing SVN code to something like struts2-gxp-experiment so as to free up struts2-gxp-plugin for the code attached here? I'll write up a blog post to explain how to use the plugin and promote it when we have it checked in (I have the #2 result on Google for struts 2 tutorial). Thanks! Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47151#action_47151 ] Musachy Barroso commented on WW-2754: - Yes Benjamin you are right, that plugin was/is an attempt to write the tags using GXP and provide support for GXP in general, just after it was released. A short time after that the GXP folks donated this code, which we need to test/clean up and make into a proper plugin, if you are up for the task I, feel free to attach a patch or zip here for it. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47153#action_47153 ] Musachy Barroso commented on WW-2754: - Yes, the code was sent to me by har...@gmail.com, post in the gxp group, they are usually pretty responsive. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47154#action_47154 ] Benjamin McCann commented on WW-2754: - Thanks for the help. I'm really close to getting this to compile. OgnlValueStack used to take just a ValueStack as a constructor parameter, but now it takes 4 parameters (http://struts.apache.org/2.1.8/struts2-core/apidocs/com/opensymphony/xwork2/ognl/OgnlValueStack.html). Do you know what I should pass in as the last 3 values? Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz, struts-gxp-plugin.zip Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47147#action_47147 ] Wes Wannemacher commented on WW-2754: - Benjamin, I think this plugin sits in the sandbox currently. If you want to check it out from there and build it, then add enhancements, bugfixes, etc., feel free. You can create JIRAs and add patches as necessary and we'll apply them. Typically, plugins sit in the sandbox because none of us are actively developing, but active community development will get the thing promoted as well. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2754) Source code for GXP result
[ https://issues.apache.org/struts/browse/WW-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=47146#action_47146 ] Benjamin McCann commented on WW-2754: - What's the status of the GXP plugin? I'd like to use it, but don't see it listed on the plugins page (http://cwiki.apache.org/S2PLUGINS/home.html). I can probably do some small tasks to help. For example, I was thinking about trying to get gxp into the Google Maven repository, which should make life a little easier. Let me know what's going on. Thanks. Source code for GXP result --- Key: WW-2754 URL: https://issues.apache.org/struts/browse/WW-2754 Project: Struts 2 Issue Type: Temp Reporter: Musachy Barroso Fix For: Future Attachments: gxp.webwork.tar.gz Thanks to the google and the GXP guys for sending us the code -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
