[jira] [Updated] (WW-4697) Warn about excluded action|method when DMI is disabled

2016-10-11 Thread Lukasz Lenart (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WW-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lukasz Lenart updated WW-4697:
--
Summary: Warn about excluded action|method when DMI is disabled  (was: Do 
not warn about excluded action|method when DMI is disabled)

> Warn about excluded action|method when DMI is disabled
> --
>
> Key: WW-4697
> URL: https://issues.apache.org/jira/browse/WW-4697
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.5.2
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 2.5.4
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (WW-4697) Warn about excluded action|method only when DMI is disabled

2016-10-11 Thread Lukasz Lenart (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WW-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lukasz Lenart updated WW-4697:
--
Summary: Warn about excluded action|method only when DMI is disabled  (was: 
Warn about excluded action|method when DMI is disabled)

> Warn about excluded action|method only when DMI is disabled
> ---
>
> Key: WW-4697
> URL: https://issues.apache.org/jira/browse/WW-4697
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.5.2
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 2.5.4
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (WW-4697) Warn about excluded action|method only when DMI is disabled

2016-10-11 Thread Lukasz Lenart (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WW-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lukasz Lenart updated WW-4697:
--
Description: Right now {{^(action|method):.*}} are always excluded, even 
when user is using DMI and in such case it's a proper use case. This pattern 
must be only applied in case when DMI is disabled.

> Warn about excluded action|method only when DMI is disabled
> ---
>
> Key: WW-4697
> URL: https://issues.apache.org/jira/browse/WW-4697
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.5.2
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 2.5.4
>
>
> Right now {{^(action|method):.*}} are always excluded, even when user is 
> using DMI and in such case it's a proper use case. This pattern must be only 
> applied in case when DMI is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4697) Warn about excluded action|method only when DMI is disabled

2016-10-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/WW-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564864#comment-15564864
 ] 

ASF subversion and git services commented on WW-4697:
-

Commit 580163880c11af3b0f41538c93af5930ba41ab14 in struts's branch 
refs/heads/master from [~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=5801638 ]

WW-4697 If DMI is enabled, exclude action|method params


> Warn about excluded action|method only when DMI is disabled
> ---
>
> Key: WW-4697
> URL: https://issues.apache.org/jira/browse/WW-4697
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.5.2
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 2.5.4
>
>
> Right now {{^(action|method):.*}} are always excluded, even when user is 
> using DMI and in such case it's a proper use case. This pattern must be only 
> applied in case when DMI is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (WW-4697) Warn about excluded action|method only when DMI is disabled

2016-10-11 Thread Lukasz Lenart (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WW-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lukasz Lenart resolved WW-4697.
---
Resolution: Fixed
  Assignee: Lukasz Lenart

> Warn about excluded action|method only when DMI is disabled
> ---
>
> Key: WW-4697
> URL: https://issues.apache.org/jira/browse/WW-4697
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.5.2
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 2.5.4
>
>
> Right now {{^(action|method):.*}} are always excluded, even when user is 
> using DMI and in such case it's a proper use case. This pattern must be only 
> applied in case when DMI is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4697) Warn about excluded action|method only when DMI is disabled

2016-10-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/WW-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564865#comment-15564865
 ] 

ASF subversion and git services commented on WW-4697:
-

Commit 5975b7aac7c9fd933aec80d3d3450190f9c2e8fd in struts's branch 
refs/heads/master from [~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=5975b7a ]

WW-4697 If DMI is sisabled, exclude action|method params


> Warn about excluded action|method only when DMI is disabled
> ---
>
> Key: WW-4697
> URL: https://issues.apache.org/jira/browse/WW-4697
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.5.2
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 2.5.4
>
>
> Right now {{^(action|method):.*}} are always excluded, even when user is 
> using DMI and in such case it's a proper use case. This pattern must be only 
> applied in case when DMI is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4697) Warn about excluded action|method only when DMI is disabled

2016-10-11 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/WW-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564943#comment-15564943
 ] 

Hudson commented on WW-4697:


SUCCESS: Integrated in Jenkins build Struts-JDK7-master #540 (See 
[https://builds.apache.org/job/Struts-JDK7-master/540/])
WW-4697 If DMI is enabled, exclude action|method params (lukaszlenart: rev 
580163880c11af3b0f41538c93af5930ba41ab14)
* (edit) 
core/src/main/java/com/opensymphony/xwork2/security/DefaultExcludedPatternsChecker.java
WW-4697 If DMI is sisabled, exclude action|method params (lukaszlenart: rev 
5975b7aac7c9fd933aec80d3d3450190f9c2e8fd)
* (edit) 
core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/security/DefaultExcludedPatternsChecker.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/config/impl/MockConfiguration.java


> Warn about excluded action|method only when DMI is disabled
> ---
>
> Key: WW-4697
> URL: https://issues.apache.org/jira/browse/WW-4697
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.5.2
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 2.5.4
>
>
> Right now {{^(action|method):.*}} are always excluded, even when user is 
> using DMI and in such case it's a proper use case. This pattern must be only 
> applied in case when DMI is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4695) Upgrade Commons Collections to 4.1

2016-10-11 Thread Markus Fischer (JIRA) 

[ 
https://issues.apache.org/jira/browse/WW-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566414#comment-15566414
 ] 

Markus Fischer commented on WW-4695:


In standalone artifacts https://dist.apache.org/repos/dist/dev/struts/2.5.5/ 
there seems to be a downgrade to commons-collections-3.2.1 where in 2.5.2 we 
were on commons-collections-3.2.2? Shouldn't this be now  4.1?

No blocking issue at all though ;-)

Thanks!
Markus

> Upgrade Commons Collections to 4.1
> --
>
> Key: WW-4695
> URL: https://issues.apache.org/jira/browse/WW-4695
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core, Unit Tests
>Affects Versions: 2.5.2
>Reporter: Markus Fischer
>Priority: Trivial
>  Labels: easyfix, features
> Fix For: 2.5.5
>
>
> Would it be possible to upgrade Commons Collections 3.2.2 to 4.1? Apache POI 
> 3.15 will rely on 4.1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4695) Upgrade Commons Collections to 4.1

2016-10-11 Thread Lukasz Lenart (JIRA) 

[ 
https://issues.apache.org/jira/browse/WW-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567654#comment-15567654
 ] 

Lukasz Lenart commented on WW-4695:
---

It's a transitive dependency of the {{[INFO] +- 
org.apache.velocity:velocity:jar:1.7:compile}} - nothing that we can do about 
it for now :\

> Upgrade Commons Collections to 4.1
> --
>
> Key: WW-4695
> URL: https://issues.apache.org/jira/browse/WW-4695
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core, Unit Tests
>Affects Versions: 2.5.2
>Reporter: Markus Fischer
>Priority: Trivial
>  Labels: easyfix, features
> Fix For: 2.5.5
>
>
> Would it be possible to upgrade Commons Collections 3.2.2 to 4.1? Apache POI 
> 3.15 will rely on 4.1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)