[jira] [Commented] (WW-5238) Strict Method Invocation (SMI) too strict?
[ https://issues.apache.org/jira/browse/WW-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611833#comment-17611833 ] Lukasz Lenart commented on WW-5238: --- {{}} won't change where the {{}} is submitted, it's impossible because browser will submit the {{}} always to where the {{action}} attribute points it. The case with {{}} will also submit a value {{action:cancel}} and based on that the mapper will decide to use a different action then. So because of that the action defined with {{}} must be in the same {{namespace}}, if you want to use a different {{namespace}} then you must enable {{struts.mapper.action.prefix.crossNamespaces}} and probably {{struts.enable.SlashesInActionNames}}. > Strict Method Invocation (SMI) too strict? > -- > > Key: WW-5238 > URL: https://issues.apache.org/jira/browse/WW-5238 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 6.0.3 >Reporter: Daniel Wu >Priority: Critical > > Got the following error (Error No. 2) when trying to create one record. The > prompt method is not supposed to be invoked for aSbmt1. Before that, the > aSbmt1 was not accepted (Error No. 1). I tried several ways to try to > overwrite the regular expression without success. Was something strange > introduced into the Struts 2 version 6.0.3? Is Strict Method Invocation (SMI) > in a dead loop? I am surprised at that there is no issue reported for the > Struts 2 version 6.0.3 yet. > 1. com.opensymphony.xwork2.interceptor.ParametersInterceptor - > *{color:#ff}Parameter [action:aSbmt1] didn't match accepted > pattern{color}* > [[\w+((\.\w+)|(\[\d+])|((\d+))|(['(\w-?|[\u4e00-\u9fa5]{-}?){+}'])|(('(\w{+}{-}?|[\u4e00-\u9fa5]-?)')))*]]! > See Accepted / Excluded patterns at > [https://struts.apache.org/security/#accepted--excluded-patterns] > *{color:#ff}2. com.opensymphony.xwork2.config.ConfigurationException: > Method prompt for action aSbmt1 is not allowed!{color}* > at > com.opensymphony.xwork2.DefaultActionProxy.prepare(DefaultActionProxy.java:191) > ~[struts2-core-6.0.3.jar:6.0.3] > at > org.apache.struts2.factory.StrutsActionProxy.prepare(StrutsActionProxy.java:57) > ~[struts2-core-6.0.3.jar:6.0.3] > at > org.apache.struts2.factory.StrutsActionProxyFactory.createActionProxy(StrutsActionProxyFactory.java:32) > ~[struts2-core-6.0.3.jar:6.0.3] > at > com.opensymphony.xwork2.DefaultActionProxyFactory.createActionProxy(DefaultActionProxyFactory.java:60) > ~[struts2-core-6.0.3.jar:6.0.3] > at > org.apache.struts2.dispatcher.Dispatcher.createActionProxy(Dispatcher.java:673) > ~[struts2-core-6.0.3.jar:6.0.3] > at > org.apache.struts2.dispatcher.Dispatcher.prepareActionProxy(Dispatcher.java:658) > ~[struts2-core-6.0.3.jar:6.0.3] > at > org.apache.struts2.dispatcher.Dispatcher.serviceAction(Dispatcher.java:621) > ~[struts2-core-6.0.3.jar:6.0.3] > at > org.apache.struts2.dispatcher.ExecuteOperations.executeAction(ExecuteOperations.java:79) > ~[struts2-core-6.0.3.jar:6.0.3] > at > org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:140) > ~[struts2-core-6.0.3.jar:6.0.3] > at > weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:78) ~ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5233) Include Apache Tiles code base in the Tiles plugin
[ https://issues.apache.org/jira/browse/WW-5233?focusedWorklogId=813870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813870 ] ASF GitHub Bot logged work on WW-5233: -- Author: ASF GitHub Bot Created on: 01/Oct/22 14:49 Start Date: 01/Oct/22 14:49 Worklog Time Spent: 10m Work Description: lukaszlenart opened a new pull request, #608: URL: https://github.com/apache/struts/pull/608 Fixes [WW-5233](https://issues.apache.org/jira/browse/WW-5233) Issue Time Tracking --- Worklog Id: (was: 813870) Remaining Estimate: 0h Time Spent: 10m > Include Apache Tiles code base in the Tiles plugin > -- > > Key: WW-5233 > URL: https://issues.apache.org/jira/browse/WW-5233 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Tiles >Reporter: Lukasz Lenart >Priority: Major > Fix For: 6.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Apache Tiles has retired and it isn't maintained anymore. There are some > outstanding security issues that can be addressed right now. It will be > easier to maintain the code base as a part of the Tiles plugin instead of > taking the project back from attick. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5233) Include Apache Tiles code base in the Tiles plugin
[ https://issues.apache.org/jira/browse/WW-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611919#comment-17611919 ] ASF subversion and git services commented on WW-5233: - Commit 3189fe84f87fa9a45ced9b9dc8b166f3e470e0b8 in struts's branch refs/heads/WW-5233-tiles from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=3189fe84f ] WW-5233 Copies a based set of Tiles classes used by Struts > Include Apache Tiles code base in the Tiles plugin > -- > > Key: WW-5233 > URL: https://issues.apache.org/jira/browse/WW-5233 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Tiles >Reporter: Lukasz Lenart >Priority: Major > Fix For: 6.1.0 > > > Apache Tiles has retired and it isn't maintained anymore. There are some > outstanding security issues that can be addressed right now. It will be > easier to maintain the code base as a part of the Tiles plugin instead of > taking the project back from attick. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5233) Include Apache Tiles code base in the Tiles plugin
[ https://issues.apache.org/jira/browse/WW-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611924#comment-17611924 ] ASF subversion and git services commented on WW-5233: - Commit 017a2e30b1752864a0c9fc6ab162b05182d4b5c8 in struts's branch refs/heads/WW-5233-tiles from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=017a2e30b ] WW-5233 Copies Portlet related Tiles code base > Include Apache Tiles code base in the Tiles plugin > -- > > Key: WW-5233 > URL: https://issues.apache.org/jira/browse/WW-5233 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Tiles >Reporter: Lukasz Lenart >Priority: Major > Fix For: 6.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Apache Tiles has retired and it isn't maintained anymore. There are some > outstanding security issues that can be addressed right now. It will be > easier to maintain the code base as a part of the Tiles plugin instead of > taking the project back from attick. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [struts] sonarcloud[bot] commented on pull request #608: [WW-5233] Include Apache Tiles code base in the Tiles plugin
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1264404867 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=608) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [22 Bugs](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [3 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [118 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_coverage&view=list) [2.5% Coverage](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_duplicated_lines_density&view=list) [2.6% Duplication](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (WW-5233) Include Apache Tiles code base in the Tiles plugin
[ https://issues.apache.org/jira/browse/WW-5233?focusedWorklogId=813881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813881 ] ASF GitHub Bot logged work on WW-5233: -- Author: ASF GitHub Bot Created on: 01/Oct/22 15:59 Start Date: 01/Oct/22 15:59 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1264404867 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=608) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [22 Bugs](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [3 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [118 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_coverage&view=list) [2.5% Coverage](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_duplicated_lines_density&view=list) [2.6% Duplication](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_duplicated_lines_density&view=list) Issue Time Tracking --- Worklog Id: (was: 813881) Time Spent: 20m (was: 10m) > Include Apache Tiles code base in the Tiles plugin > -- > > Key: WW-5233 > URL: https://issues.apache.org/jira/browse/WW-5233 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Tiles >Reporter: Lukasz Lenart >Priority: Major > Fix For: 6.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Tiles has retired and it isn't maintained anymore. There are some > outstanding security issues that can be addressed right now. It will be > easier to maintain the code base as a part of the Tiles plugin instead of > taking the project back from attick. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5233) Include Apache Tiles code base in the Tiles plugin
[ https://issues.apache.org/jira/browse/WW-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17612036#comment-17612036 ] ASF subversion and git services commented on WW-5233: - Commit ba7ef186f8f0222937853fae49fe831198548c59 in struts's branch refs/heads/WW-5233-tiles from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=ba7ef186f ] WW-5233 Copies Tiles API related tests > Include Apache Tiles code base in the Tiles plugin > -- > > Key: WW-5233 > URL: https://issues.apache.org/jira/browse/WW-5233 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Tiles >Reporter: Lukasz Lenart >Priority: Major > Fix For: 6.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Tiles has retired and it isn't maintained anymore. There are some > outstanding security issues that can be addressed right now. It will be > easier to maintain the code base as a part of the Tiles plugin instead of > taking the project back from attick. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [struts] sonarcloud[bot] commented on pull request #608: [WW-5233] Include Apache Tiles code base in the Tiles plugin
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1264566780 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=608) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [22 Bugs](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [3 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [121 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_coverage&view=list) [11.5% Coverage](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_duplicated_lines_density&view=list) [2.4% Duplication](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (WW-5233) Include Apache Tiles code base in the Tiles plugin
[ https://issues.apache.org/jira/browse/WW-5233?focusedWorklogId=813910&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813910 ] ASF GitHub Bot logged work on WW-5233: -- Author: ASF GitHub Bot Created on: 02/Oct/22 06:45 Start Date: 02/Oct/22 06:45 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/struts/pull/608#issuecomment-1264566780 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=608) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [22 Bugs](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [3 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=608&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [121 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=608&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_coverage&view=list) [11.5% Coverage](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_duplicated_lines_density&view=list) [2.4% Duplication](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=608&metric=new_duplicated_lines_density&view=list) Issue Time Tracking --- Worklog Id: (was: 813910) Time Spent: 0.5h (was: 20m) > Include Apache Tiles code base in the Tiles plugin > -- > > Key: WW-5233 > URL: https://issues.apache.org/jira/browse/WW-5233 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Tiles >Reporter: Lukasz Lenart >Priority: Major > Fix For: 6.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Apache Tiles has retired and it isn't maintained anymore. There are some > outstanding security issues that can be addressed right now. It will be > easier to maintain the code base as a part of the Tiles plugin instead of > taking the project back from attick. -- This message was sent by Atlassian Jira (v8.20.10#820010)