[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-29 Thread jihoonson 
Github user jihoonson commented on the pull request:

https://github.com/apache/tajo/pull/870#issuecomment-160416423
  
Thanks. Would you close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-29 Thread eminency 
Github user eminency commented on the pull request:

https://github.com/apache/tajo/pull/870#issuecomment-160502247
  
Sure, I close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-29 Thread eminency 
Github user eminency closed the pull request at:

https://github.com/apache/tajo/pull/870


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-26 Thread eminency 
Github user eminency commented on the pull request:

https://github.com/apache/tajo/pull/870#issuecomment-160034320
  
@jihoonson I submitted new PR : https://github.com/apache/tajo/pull/881


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-25 Thread hyunsik 
Github user hyunsik commented on a diff in the pull request:

https://github.com/apache/tajo/pull/870#discussion_r45934726
  
--- Diff: tajo-docs/src/main/sphinx/table_management/compression.rst ---
@@ -1,5 +1,23 @@
-*
+***
 Compression
-*
+***
 
-.. todo::
\ No newline at end of file
+Using compression can make data size compact, thereby enabling efficient 
use of network bandwidth and storage. Most of Tajo data formats support data 
compression feature.
+Currently, compression configuration affects only for stored data format 
and it is specified when a table is created as table meta information(See 
`Create Table <../sql_language/ddl.html#create-table>`_).
--- End diff --

I suggest ``it is enabled when a table is created with the proper table 
property.``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-25 Thread jihoonson 
Github user jihoonson commented on the pull request:

https://github.com/apache/tajo/pull/870#issuecomment-159767211
  
+1 LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-25 Thread hyunsik 
Github user hyunsik commented on a diff in the pull request:

https://github.com/apache/tajo/pull/870#discussion_r45934744
  
--- Diff: tajo-docs/src/main/sphinx/table_management/compression.rst ---
@@ -1,5 +1,23 @@
-*
+***
 Compression
-*
+***
 
-.. todo::
\ No newline at end of file
+Using compression can make data size compact, thereby enabling efficient 
use of network bandwidth and storage. Most of Tajo data formats support data 
compression feature.
+Currently, compression configuration affects only for stored data format 
and it is specified when a table is created as table meta information(See 
`Create Table <../sql_language/ddl.html#create-table>`_).
+Compression for intermidate data or others is not supported now.
--- End diff --

I think it is not necessary here because this section addresses tables.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-25 Thread hyunsik 
Github user hyunsik commented on the pull request:

https://github.com/apache/tajo/pull/870#issuecomment-159767610
  
I leaved some comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-25 Thread jihoonson 
Github user jihoonson commented on the pull request:

https://github.com/apache/tajo/pull/870#issuecomment-159774134
  
@hyunsik, I'm sorry, but have already committed this patch. 
@eminency, would you open a new Jira issue to address his comment? When you 
make a PR for the new issue, I'll review ASAP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-23 Thread jihoonson 
Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/870#discussion_r45601276
  
--- Diff: tajo-docs/src/main/sphinx/table_management/compression.rst ---
@@ -1,5 +1,23 @@
-*
+***
 Compression
-*
+***
 
-.. todo::
\ No newline at end of file
+Using compression makes data size compact and network traffic low. Most of 
Tajo data types support data compression feature.
--- End diff --

You may mean ```data formats``` instead of ```data types```. 
Also, ```network traffic low``` seems to be ambiguous. How about changing 
the first sentence to ```Using compression can make data size compact, thereby 
enabling efficient use of network bandwidth and storage.```?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-23 Thread jihoonson 
Github user jihoonson commented on the pull request:

https://github.com/apache/tajo/pull/870#issuecomment-158933396
  
@eminency, thanks for your patch. I left some comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-23 Thread jihoonson 
Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/870#discussion_r45602368
  
--- Diff: tajo-docs/src/main/sphinx/table_management/compression.rst ---
@@ -1,5 +1,23 @@
-*
+***
 Compression
-*
+***
 
-.. todo::
\ No newline at end of file
+Using compression makes data size compact and network traffic low. Most of 
Tajo data types support data compression feature.
+Currently, compression configuration affcts only for stored data format 
and it is specified when a table is created as table meta information.
--- End diff --

```affcts``` -> ```affects```. 
In addition, it would be good if you add a link to the 
```sql_language/ddl.html#create-table``` page.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-23 Thread jihoonson 
Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/870#discussion_r45602281
  
--- Diff: tajo-docs/src/main/sphinx/table_management/compression.rst ---
@@ -1,5 +1,23 @@
-*
+***
 Compression
-*
+***
 
-.. todo::
\ No newline at end of file
+Using compression makes data size compact and network traffic low. Most of 
Tajo data types support data compression feature.
+Currently, compression configuration affcts only for stored data format 
and it is specified when a table is created as table meta information.
+Compression for intermidate data or others is not supported now.
+
+===
+Compression Properties for each Data Format
+===
+
+ .. csv-table:: Compression Properties and Codec Class
--- End diff --

Looks very clear!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-23 Thread eminency 
Github user eminency commented on the pull request:

https://github.com/apache/tajo/pull/870#issuecomment-159132318
  
@jihoonson ,
I updated what you mentioned and a bit further.
Please check it out.

Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1857: Rename the section of 'File Formats'...

2015-11-20 Thread eminency 
GitHub user eminency opened a pull request:

https://github.com/apache/tajo/pull/870

TAJO-1857: Rename the section of 'File Formats' to 'Data Formats' and fill 
compression section of the 'Table Management' chapter

Hi, @jihoonson.
I modified docs and wrote a compression doc newly.
Please check them out.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eminency/tajo TAJO-1857

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tajo/pull/870.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #870


commit 3ca5b9fdcd56a70aaa32df1cedfe689fc48559a3
Author: Jongyoung Park 
Date:   2015-11-20T08:05:22Z

use 'data format' instead of 'file format'

commit 334ac58d59e4100f8cb79f5b14cf4e23a7125d39
Author: Jongyoung Park 
Date:   2015-11-20T08:05:51Z

compression document is written roughly




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---