[jira] [Commented] (TEZ-3985) Correctness: Throw a clear exception for DMEs sent during cleanup
[ https://issues.apache.org/jira/browse/TEZ-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763925#comment-16763925 ] Gopal V commented on TEZ-3985: -- Fixed minor nits. > Correctness: Throw a clear exception for DMEs sent during cleanup > - > > Key: TEZ-3985 > URL: https://issues.apache.org/jira/browse/TEZ-3985 > Project: Apache Tez > Issue Type: Bug >Reporter: Gopal V >Assignee: Jaume M >Priority: Major > Attachments: TEZ-3985.1.patch, TEZ-3985.2.patch, TEZ-3985.3.patch, > TEZ-3985.3.patch, TEZ-3985.4.patch > > > If a DME is sent during cleanup, that implies that the .close() of the > LogicalIOProcessorRuntimeTask did not succeed and therefore these events are > an error condition. > These events should not be sent and more importantly should be received by > the AM. > Throw a clear exception, in case of this & allow the developers to locate the > extraneous event from the backtrace. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (TEZ-4038) Add a /prof profiler endpoint like HiveServer2 has
[ https://issues.apache.org/jira/browse/TEZ-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gopal V reassigned TEZ-4038: Assignee: Gopal V > Add a /prof profiler endpoint like HiveServer2 has > -- > > Key: TEZ-4038 > URL: https://issues.apache.org/jira/browse/TEZ-4038 > Project: Apache Tez > Issue Type: New Feature >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > > HIVE-20202 makes it very easy to generate flamegraph profiles for Hive > queries. > Extending the same to Tez would be helpful (the profiler toolkit is already > Apache licensed). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (TEZ-4038) Add a /prof profiler endpoint like HiveServer2 has
Gopal V created TEZ-4038: Summary: Add a /prof profiler endpoint like HiveServer2 has Key: TEZ-4038 URL: https://issues.apache.org/jira/browse/TEZ-4038 Project: Apache Tez Issue Type: New Feature Reporter: Gopal V HIVE-20202 makes it very easy to generate flamegraph profiles for Hive queries. Extending the same to Tez would be helpful (the profiler toolkit is already Apache licensed). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TEZ-3985) Correctness: Throw a clear exception for DMEs sent during cleanup
[
https://issues.apache.org/jira/browse/TEZ-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763890#comment-16763890
]
TezQA commented on TEZ-3985:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 8m
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 21s{color}
| {color:red} tez-runtime-internals generated 4 new + 2 unchanged - 0 fixed = 6
total (was 2) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 24s{color} | {color:orange} tez-runtime-internals: The patch generated 2 new
+ 326 unchanged - 2 fixed = 328 total (was 328) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
53s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} tez-runtime-internals in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
40s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 5s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/tez:d4a62de |
| JIRA Issue | TEZ-3985 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12958085/TEZ-3985.3.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux 8cf8de717853 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | master / 3162aab |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.0.1 |
| javac |
https://builds.apache.org/job/PreCommit-TEZ-Build/84/artifact/out/diff-compile-javac-tez-runtime-internals.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-TEZ-Build/84/artifact/out/diff-checkstyle-tez-runtime-internals.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-TEZ-Build/84/testReport/ |
| Max. process+thread count | 253 (vs. ulimit of 1) |
| modules | C: tez-api tez-runtime-internals U: . |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/84/console
|
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Correctness: Throw a clear exception for DMEs sent during cleanup
>
[jira] [Updated] (TEZ-3985) Correctness: Throw a clear exception for DMEs sent during cleanup
[ https://issues.apache.org/jira/browse/TEZ-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gopal V updated TEZ-3985: - Attachment: TEZ-3985.3.patch > Correctness: Throw a clear exception for DMEs sent during cleanup > - > > Key: TEZ-3985 > URL: https://issues.apache.org/jira/browse/TEZ-3985 > Project: Apache Tez > Issue Type: Bug >Reporter: Gopal V >Assignee: Jaume M >Priority: Major > Attachments: TEZ-3985.1.patch, TEZ-3985.2.patch, TEZ-3985.3.patch, > TEZ-3985.3.patch > > > If a DME is sent during cleanup, that implies that the .close() of the > LogicalIOProcessorRuntimeTask did not succeed and therefore these events are > an error condition. > These events should not be sent and more importantly should be received by > the AM. > Throw a clear exception, in case of this & allow the developers to locate the > extraneous event from the backtrace. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
