[jira] [Commented] (TEZ-2056) Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid
[ https://issues.apache.org/jira/browse/TEZ-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311522#comment-14311522 ] Hitesh Shah commented on TEZ-2056: -- +1. Committing shortly. > Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid > - > > Key: TEZ-2056 > URL: https://issues.apache.org/jira/browse/TEZ-2056 > Project: Apache Tez > Issue Type: Bug >Reporter: Prakash Ramachandran >Assignee: Prakash Ramachandran > Attachments: TEZ-2056.1.patch, TEZ-2056.2.patch > > > * Searching by a vertexId is broken on dag tasks view. > * Configuration shows all settings in alphabetical order instead of showing > only tez.* at the top > * When status is not Finished, app attempt id shows up with a "-" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2056) Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid
[ https://issues.apache.org/jira/browse/TEZ-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311523#comment-14311523 ] Hitesh Shah commented on TEZ-2056: -- Unit test failure is unrelated. > Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid > - > > Key: TEZ-2056 > URL: https://issues.apache.org/jira/browse/TEZ-2056 > Project: Apache Tez > Issue Type: Bug >Reporter: Prakash Ramachandran >Assignee: Prakash Ramachandran > Attachments: TEZ-2056.1.patch, TEZ-2056.2.patch > > > * Searching by a vertexId is broken on dag tasks view. > * Configuration shows all settings in alphabetical order instead of showing > only tez.* at the top > * When status is not Finished, app attempt id shows up with a "-" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2056) Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid
[ https://issues.apache.org/jira/browse/TEZ-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310728#comment-14310728 ] Hadoop QA commented on TEZ-2056: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697256/TEZ-2056.2.patch against master revision 2b5eeea. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in : org.apache.tez.test.TestTezJobs Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/143//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/143//console This message is automatically generated. > Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid > - > > Key: TEZ-2056 > URL: https://issues.apache.org/jira/browse/TEZ-2056 > Project: Apache Tez > Issue Type: Bug >Reporter: Prakash Ramachandran >Assignee: Prakash Ramachandran > Attachments: TEZ-2056.1.patch, TEZ-2056.2.patch > > > * Searching by a vertexId is broken on dag tasks view. > * Configuration shows all settings in alphabetical order instead of showing > only tez.* at the top > * When status is not Finished, app attempt id shows up with a "-" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2056) Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid
[ https://issues.apache.org/jira/browse/TEZ-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310717#comment-14310717 ] Sreenath Somarajapuram commented on TEZ-2056: - +1 LGTM > Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid > - > > Key: TEZ-2056 > URL: https://issues.apache.org/jira/browse/TEZ-2056 > Project: Apache Tez > Issue Type: Bug >Reporter: Prakash Ramachandran >Assignee: Prakash Ramachandran > Attachments: TEZ-2056.1.patch, TEZ-2056.2.patch > > > * Searching by a vertexId is broken on dag tasks view. > * Configuration shows all settings in alphabetical order instead of showing > only tez.* at the top > * When status is not Finished, app attempt id shows up with a "-" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2056) Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid
[ https://issues.apache.org/jira/browse/TEZ-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310700#comment-14310700 ] Sreenath Somarajapuram commented on TEZ-2056: - Trailing space in dag_tasks.js Its not ideal to use id for styling. display doesn't have a property value hidden, better to use .no-display class from shared.less to hide. When the text box is in focus, bootstrap adds a blue hallow. input-wrapper is clipping this to the left, top and bottom leaving a blue line to the right, making the ui look unfinished. > Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid > - > > Key: TEZ-2056 > URL: https://issues.apache.org/jira/browse/TEZ-2056 > Project: Apache Tez > Issue Type: Bug >Reporter: Prakash Ramachandran >Assignee: Prakash Ramachandran > Attachments: TEZ-2056.1.patch > > > * Searching by a vertexId is broken on dag tasks view. > * Configuration shows all settings in alphabetical order instead of showing > only tez.* at the top > * When status is not Finished, app attempt id shows up with a "-" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2056) Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid
[ https://issues.apache.org/jira/browse/TEZ-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310574#comment-14310574 ] Hadoop QA commented on TEZ-2056: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697228/TEZ-2056.1.patch against master revision 2b5eeea. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/142//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/142//console This message is automatically generated. > Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid > - > > Key: TEZ-2056 > URL: https://issues.apache.org/jira/browse/TEZ-2056 > Project: Apache Tez > Issue Type: Bug >Reporter: Prakash Ramachandran >Assignee: Prakash Ramachandran > Attachments: TEZ-2056.1.patch > > > * Searching by a vertexId is broken on dag tasks view. > * Configuration shows all settings in alphabetical order instead of showing > only tez.* at the top > * When status is not Finished, app attempt id shows up with a "-" -- This message was sent by Atlassian JIRA (v6.3.4#6332)