[jira] [Commented] (TEZ-2129) Task and Attempt views should contain links to the logs
[ https://issues.apache.org/jira/browse/TEZ-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089781#comment-15089781 ] Jonathan Eagles commented on TEZ-2129: -- Thanks, [~Sreenath]. committing to master and branch-0.7. > Task and Attempt views should contain links to the logs > --- > > Key: TEZ-2129 > URL: https://issues.apache.org/jira/browse/TEZ-2129 > Project: Apache Tez > Issue Type: Improvement > Components: UI >Reporter: Kevin J. Price >Assignee: Jonathan Eagles >Priority: Minor > Attachments: TEZ-2129.1.patch, TEZ-2129.2.patch > > > Currently, the actual task or attempt view does not contain a link to get to > the container logs. That link exists on the list view page, but not the view > page for a specific task/attempt. There should be a direct link to the logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2129) Task and Attempt views should contain links to the logs
[ https://issues.apache.org/jira/browse/TEZ-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089246#comment-15089246 ] Sreenath Somarajapuram commented on TEZ-2129: - Yup, the changes are just in the UI and failure looks unrelated. > Task and Attempt views should contain links to the logs > --- > > Key: TEZ-2129 > URL: https://issues.apache.org/jira/browse/TEZ-2129 > Project: Apache Tez > Issue Type: Improvement > Components: UI >Reporter: Kevin J. Price >Assignee: Jonathan Eagles >Priority: Minor > Attachments: TEZ-2129.1.patch, TEZ-2129.2.patch > > > Currently, the actual task or attempt view does not contain a link to get to > the container logs. That link exists on the list view page, but not the view > page for a specific task/attempt. There should be a direct link to the logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2129) Task and Attempt views should contain links to the logs
[ https://issues.apache.org/jira/browse/TEZ-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088106#comment-15088106 ] Jonathan Eagles commented on TEZ-2129: -- [~Sreenath], The above test failure is unrelated to the patch. Can you have another look? > Task and Attempt views should contain links to the logs > --- > > Key: TEZ-2129 > URL: https://issues.apache.org/jira/browse/TEZ-2129 > Project: Apache Tez > Issue Type: Improvement > Components: UI >Reporter: Kevin J. Price >Assignee: Jonathan Eagles >Priority: Minor > Attachments: TEZ-2129.1.patch, TEZ-2129.2.patch > > > Currently, the actual task or attempt view does not contain a link to get to > the container logs. That link exists on the list view page, but not the view > page for a specific task/attempt. There should be a direct link to the logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2129) Task and Attempt views should contain links to the logs
[
https://issues.apache.org/jira/browse/TEZ-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082106#comment-15082106
]
TezQA commented on TEZ-2129:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12780410/TEZ-2129.2.patch
against master revision 9816a49.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.test.TestFaultTolerance
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1402//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1402//console
This message is automatically generated.
> Task and Attempt views should contain links to the logs
> ---
>
> Key: TEZ-2129
> URL: https://issues.apache.org/jira/browse/TEZ-2129
> Project: Apache Tez
> Issue Type: Improvement
> Components: UI
>Reporter: Kevin J. Price
>Assignee: Jonathan Eagles
>Priority: Minor
> Attachments: TEZ-2129.1.patch, TEZ-2129.2.patch
>
>
> Currently, the actual task or attempt view does not contain a link to get to
> the container logs. That link exists on the list view page, but not the view
> page for a specific task/attempt. There should be a direct link to the logs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2129) Task and Attempt views should contain links to the logs
[
https://issues.apache.org/jira/browse/TEZ-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065375#comment-15065375
]
Sreenath Somarajapuram commented on TEZ-2129:
-
Thanks [~jeagles]
Feel it might be a better approach to use an observer than overwriting logsLink
from inside.
Something like
{code}
logsLink: null,
logsLinkObserver: function(key, value) {
that.set('logsLink', cellContent);
}.observes('id', 'successfulAttemptId')
{code}
> Task and Attempt views should contain links to the logs
> ---
>
> Key: TEZ-2129
> URL: https://issues.apache.org/jira/browse/TEZ-2129
> Project: Apache Tez
> Issue Type: Improvement
> Components: UI
>Reporter: Kevin J. Price
>Assignee: Jonathan Eagles
>Priority: Minor
> Attachments: TEZ-2129.1.patch
>
>
> Currently, the actual task or attempt view does not contain a link to get to
> the container logs. That link exists on the list view page, but not the view
> page for a specific task/attempt. There should be a direct link to the logs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2129) Task and Attempt views should contain links to the logs
[
https://issues.apache.org/jira/browse/TEZ-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064923#comment-15064923
]
TezQA commented on TEZ-2129:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12778595/TEZ-2129.1.patch
against master revision 4ed7d1a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.test.TestFaultTolerance
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1390//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/1390//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1390//console
This message is automatically generated.
> Task and Attempt views should contain links to the logs
> ---
>
> Key: TEZ-2129
> URL: https://issues.apache.org/jira/browse/TEZ-2129
> Project: Apache Tez
> Issue Type: Improvement
> Components: UI
>Reporter: Kevin J. Price
>Assignee: Jonathan Eagles
>Priority: Minor
> Attachments: TEZ-2129.1.patch
>
>
> Currently, the actual task or attempt view does not contain a link to get to
> the container logs. That link exists on the list view page, but not the view
> page for a specific task/attempt. There should be a direct link to the logs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2129) Task and Attempt views should contain links to the logs
[ https://issues.apache.org/jira/browse/TEZ-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064811#comment-15064811 ] Jonathan Eagles commented on TEZ-2129: -- [~Sreenath], another cosmetic Tez UI fix. I did have one complication with regards to using promises in handlebars. I overcame that issue using a lazy setting/getter technique I found on stackoverflow. http://stackoverflow.com/questions/20623027/rendering-resolved-promise-value-in-ember-handlebars-template Please, have a look as it is great to be able to see the diagnostics as well as click the logs links on the same page. > Task and Attempt views should contain links to the logs > --- > > Key: TEZ-2129 > URL: https://issues.apache.org/jira/browse/TEZ-2129 > Project: Apache Tez > Issue Type: Improvement > Components: UI >Reporter: Kevin J. Price >Assignee: Jonathan Eagles >Priority: Minor > Attachments: TEZ-2129.1.patch > > > Currently, the actual task or attempt view does not contain a link to get to > the container logs. That link exists on the list view page, but not the view > page for a specific task/attempt. There should be a direct link to the logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
