[jira] [Commented] (TEZ-2363) Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
[
https://issues.apache.org/jira/browse/TEZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515996#comment-14515996
]
Rajesh Balamohan commented on TEZ-2363:
---
lgtm. +1.
I believe the javac warning can be addressed by adding
"@SuppressWarnings("unchecked")" near TestValuesIterator.createCountedIterator?
> Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
>
>
> Key: TEZ-2363
> URL: https://issues.apache.org/jira/browse/TEZ-2363
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Minor
> Attachments: TEZ-2363.1.patch
>
>
> The reduce input key groups are not incremented for the first key in
> operation, only for the second key does it increment in moveToNext() ->
> nextKey() -> inputKeyCounter.increment(1);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2363) Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
[
https://issues.apache.org/jira/browse/TEZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514916#comment-14514916
]
TezQA commented on TEZ-2363:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12727922/TEZ-2363.1.patch
against master revision 21d4e2d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 161 javac
compiler warnings (more than the master's current 160 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/550//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/550//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/550//console
This message is automatically generated.
> Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
>
>
> Key: TEZ-2363
> URL: https://issues.apache.org/jira/browse/TEZ-2363
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Minor
> Attachments: TEZ-2363.1.patch
>
>
> The reduce input key groups are not incremented for the first key in
> operation, only for the second key does it increment in moveToNext() ->
> nextKey() -> inputKeyCounter.increment(1);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2363) Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
[ https://issues.apache.org/jira/browse/TEZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514719#comment-14514719 ] Gopal V commented on TEZ-2363: -- [~hitesh]: the failed test was a network timeout. > Counters: off by 1 error for REDUCE_INPUT_GROUPS counter > > > Key: TEZ-2363 > URL: https://issues.apache.org/jira/browse/TEZ-2363 > Project: Apache Tez > Issue Type: Bug >Affects Versions: 0.7.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Minor > Attachments: TEZ-2363.1.patch > > > The reduce input key groups are not incremented for the first key in > operation, only for the second key does it increment in moveToNext() -> > nextKey() -> inputKeyCounter.increment(1); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2363) Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
[ https://issues.apache.org/jira/browse/TEZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514715#comment-14514715 ] Hitesh Shah commented on TEZ-2363: -- [~rajesh.balamohan] [~sseth] mind reviewing? > Counters: off by 1 error for REDUCE_INPUT_GROUPS counter > > > Key: TEZ-2363 > URL: https://issues.apache.org/jira/browse/TEZ-2363 > Project: Apache Tez > Issue Type: Bug >Affects Versions: 0.7.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Minor > Attachments: TEZ-2363.1.patch > > > The reduce input key groups are not incremented for the first key in > operation, only for the second key does it increment in moveToNext() -> > nextKey() -> inputKeyCounter.increment(1); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2363) Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
[ https://issues.apache.org/jira/browse/TEZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514714#comment-14514714 ] Hitesh Shah commented on TEZ-2363: -- Re-triggerred precommit to see if failing test is related or a random error. > Counters: off by 1 error for REDUCE_INPUT_GROUPS counter > > > Key: TEZ-2363 > URL: https://issues.apache.org/jira/browse/TEZ-2363 > Project: Apache Tez > Issue Type: Bug >Affects Versions: 0.7.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Minor > Attachments: TEZ-2363.1.patch > > > The reduce input key groups are not incremented for the first key in > operation, only for the second key does it increment in moveToNext() -> > nextKey() -> inputKeyCounter.increment(1); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2363) Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
[ https://issues.apache.org/jira/browse/TEZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511173#comment-14511173 ] Gopal V commented on TEZ-2363: -- The warning diffs are due to the code shifting lines - pre-existing warning moves from TestValuesIterator.java:[244,67] to TestValuesIterator.java:[278,67] > Counters: off by 1 error for REDUCE_INPUT_GROUPS counter > > > Key: TEZ-2363 > URL: https://issues.apache.org/jira/browse/TEZ-2363 > Project: Apache Tez > Issue Type: Bug >Affects Versions: 0.7.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Minor > Attachments: TEZ-2363.1.patch > > > The reduce input key groups are not incremented for the first key in > operation, only for the second key does it increment in moveToNext() -> > nextKey() -> inputKeyCounter.increment(1); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2363) Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
[
https://issues.apache.org/jira/browse/TEZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511162#comment-14511162
]
TezQA commented on TEZ-2363:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12727922/TEZ-2363.1.patch
against master revision 778c1f5.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 161 javac
compiler warnings (more than the master's current 160 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.runtime.library.common.shuffle.TestFetcher
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/528//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/528//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/528//console
This message is automatically generated.
> Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
>
>
> Key: TEZ-2363
> URL: https://issues.apache.org/jira/browse/TEZ-2363
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Minor
> Attachments: TEZ-2363.1.patch
>
>
> The reduce input key groups are not incremented for the first key in
> operation, only for the second key does it increment in moveToNext() ->
> nextKey() -> inputKeyCounter.increment(1);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2363) Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
[ https://issues.apache.org/jira/browse/TEZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511137#comment-14511137 ] Gopal V commented on TEZ-2363: -- [~zjffdu]/[~rajesh.balamohan]: was a missing TODO: item - can you review? > Counters: off by 1 error for REDUCE_INPUT_GROUPS counter > > > Key: TEZ-2363 > URL: https://issues.apache.org/jira/browse/TEZ-2363 > Project: Apache Tez > Issue Type: Bug >Affects Versions: 0.7.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Minor > Attachments: TEZ-2363.1.patch > > > The reduce input key groups are not incremented for the first key in > operation, only for the second key does it increment in moveToNext() -> > nextKey() -> inputKeyCounter.increment(1); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2363) Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
[ https://issues.apache.org/jira/browse/TEZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511056#comment-14511056 ] Gopal V commented on TEZ-2363: -- Yes, I have a fix - resolving that as duplicate. > Counters: off by 1 error for REDUCE_INPUT_GROUPS counter > > > Key: TEZ-2363 > URL: https://issues.apache.org/jira/browse/TEZ-2363 > Project: Apache Tez > Issue Type: Bug >Affects Versions: 0.7.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Minor > > The reduce input key groups are not incremented for the first key in > operation, only for the second key does it increment in moveToNext() -> > nextKey() -> inputKeyCounter.increment(1); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2363) Counters: off by 1 error for REDUCE_INPUT_GROUPS counter
[ https://issues.apache.org/jira/browse/TEZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511052#comment-14511052 ] Rajesh Balamohan commented on TEZ-2363: --- Same as https://issues.apache.org/jira/browse/TEZ-2208 ? > Counters: off by 1 error for REDUCE_INPUT_GROUPS counter > > > Key: TEZ-2363 > URL: https://issues.apache.org/jira/browse/TEZ-2363 > Project: Apache Tez > Issue Type: Bug >Affects Versions: 0.7.0 >Reporter: Gopal V >Assignee: Gopal V >Priority: Minor > > The reduce input key groups are not incremented for the first key in > operation, only for the second key does it increment in moveToNext() -> > nextKey() -> inputKeyCounter.increment(1); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
