[jira] [Commented] (TEZ-2756) MergeManager close should not try merging files on close if invoked after a shuffle exception

2016-03-03 Thread Tsuyoshi Ozawa (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179517#comment-15179517
 ] 

Tsuyoshi Ozawa commented on TEZ-2756:
-

[~rajesh.balamohan] thanks Rajesh for the reviewing and committing this.

> MergeManager close should not try merging files on close if invoked after a 
> shuffle exception
> -
>
> Key: TEZ-2756
> URL: https://issues.apache.org/jira/browse/TEZ-2756
> Project: Apache Tez
>  Issue Type: Improvement
>Affects Versions: 0.5.0
>Reporter: Siddharth Seth
>Assignee: Tsuyoshi Ozawa
> Fix For: 0.8.3
>
> Attachments: TEZ-2756.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-2756) MergeManager close should not try merging files on close if invoked after a shuffle exception

2016-03-03 Thread Rajesh Balamohan (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179111#comment-15179111
 ] 

Rajesh Balamohan commented on TEZ-2756:
---

lgtm. +1

Can you please remove TezRawKeyValueIterator import in TestMergeManager before 
committing? Thanks.

> MergeManager close should not try merging files on close if invoked after a 
> shuffle exception
> -
>
> Key: TEZ-2756
> URL: https://issues.apache.org/jira/browse/TEZ-2756
> Project: Apache Tez
>  Issue Type: Improvement
>Affects Versions: 0.5.0
>Reporter: Siddharth Seth
>Assignee: Tsuyoshi Ozawa
> Attachments: TEZ-2756.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-2756) MergeManager close should not try merging files on close if invoked after a shuffle exception

2016-03-03 Thread Hitesh Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179076#comment-15179076
 ] 

Hitesh Shah commented on TEZ-2756:
--

\cc [~rajesh.balamohan]

> MergeManager close should not try merging files on close if invoked after a 
> shuffle exception
> -
>
> Key: TEZ-2756
> URL: https://issues.apache.org/jira/browse/TEZ-2756
> Project: Apache Tez
>  Issue Type: Improvement
>Affects Versions: 0.5.0
>Reporter: Siddharth Seth
>Assignee: Tsuyoshi Ozawa
> Attachments: TEZ-2756.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-2756) MergeManager close should not try merging files on close if invoked after a shuffle exception

2016-03-03 Thread Tsuyoshi Ozawa (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179041#comment-15179041
 ] 

Tsuyoshi Ozawa commented on TEZ-2756:
-

[~sseth] could you take a look?

> MergeManager close should not try merging files on close if invoked after a 
> shuffle exception
> -
>
> Key: TEZ-2756
> URL: https://issues.apache.org/jira/browse/TEZ-2756
> Project: Apache Tez
>  Issue Type: Improvement
>Affects Versions: 0.5.0
>Reporter: Siddharth Seth
>Assignee: Tsuyoshi Ozawa
> Attachments: TEZ-2756.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-2756) MergeManager close should not try merging files on close if invoked after a shuffle exception

2016-02-28 Thread TezQA (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171060#comment-15171060
 ] 

TezQA commented on TEZ-2756:


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12790359/TEZ-2756.001.patch
  against master revision 18398c8.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/1524//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1524//console

This message is automatically generated.

> MergeManager close should not try merging files on close if invoked after a 
> shuffle exception
> -
>
> Key: TEZ-2756
> URL: https://issues.apache.org/jira/browse/TEZ-2756
> Project: Apache Tez
>  Issue Type: Improvement
>Affects Versions: 0.5.0
>Reporter: Siddharth Seth
>Assignee: Tsuyoshi Ozawa
> Attachments: TEZ-2756.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)