[jira] [Commented] (TEZ-2780) Tez UI: Update All Tasks page while in progress.
[ https://issues.apache.org/jira/browse/TEZ-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740510#comment-14740510 ] Prakash Ramachandran commented on TEZ-2780: --- +1 LGTM pending pre-commit. tested with older version of yarn which had issues. > Tez UI: Update All Tasks page while in progress. > > > Key: TEZ-2780 > URL: https://issues.apache.org/jira/browse/TEZ-2780 > Project: Apache Tez > Issue Type: Sub-task > Components: UI >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-2780.1.patch, TEZ-2780.2.patch, TEZ-2780.3.patch, > TEZ-2780.4.patch, TEZ-2780.wip.1.patch > > > Modify table component to automatically update cell based on in-progress data. > #. Upgrade polling logic to manage a specific entity. > #. Added progress column to All Tasks table. > #. Updated table to automatically reflect model change - Just need to set > observePath to true in defaultColumnConfigs. > #. Updated table logic to send action on row change - so that polling logic > can query for fresh records. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2780) Tez UI: Update All Tasks page while in progress.
[
https://issues.apache.org/jira/browse/TEZ-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740685#comment-14740685
]
TezQA commented on TEZ-2780:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12755349/TEZ-2780.4.patch
against master revision b288be7.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1113//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1113//console
This message is automatically generated.
> Tez UI: Update All Tasks page while in progress.
>
>
> Key: TEZ-2780
> URL: https://issues.apache.org/jira/browse/TEZ-2780
> Project: Apache Tez
> Issue Type: Sub-task
> Components: UI
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-2780.1.patch, TEZ-2780.2.patch, TEZ-2780.3.patch,
> TEZ-2780.4.patch, TEZ-2780.wip.1.patch
>
>
> Modify table component to automatically update cell based on in-progress data.
> #. Upgrade polling logic to manage a specific entity.
> #. Added progress column to All Tasks table.
> #. Updated table to automatically reflect model change - Just need to set
> observePath to true in defaultColumnConfigs.
> #. Updated table logic to send action on row change - so that polling logic
> can query for fresh records.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2780) Tez UI: Update All Tasks page while in progress.
[
https://issues.apache.org/jira/browse/TEZ-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738592#comment-14738592
]
TezQA commented on TEZ-2780:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12755097/TEZ-2780.3.patch
against master revision 00508f8.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1104//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1104//console
This message is automatically generated.
> Tez UI: Update All Tasks page while in progress.
>
>
> Key: TEZ-2780
> URL: https://issues.apache.org/jira/browse/TEZ-2780
> Project: Apache Tez
> Issue Type: Sub-task
> Components: UI
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-2780.1.patch, TEZ-2780.2.patch, TEZ-2780.3.patch,
> TEZ-2780.wip.1.patch
>
>
> Modify table component to automatically update cell based on in-progress data.
> #. Upgrade polling logic to manage a specific entity.
> #. Added progress column to All Tasks table.
> #. Updated table to automatically reflect model change - Just need to set
> observePath to true in defaultColumnConfigs.
> #. Updated table logic to send action on row change - so that polling logic
> can query for fresh records.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2780) Tez UI: Update All Tasks page while in progress.
[ https://issues.apache.org/jira/browse/TEZ-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736687#comment-14736687 ] Sreenath Somarajapuram commented on TEZ-2780: - [~hitesh] Sure. Moving the API part to TEZ-2792. This ticket would be just for UI changes. > Tez UI: Update All Tasks page while in progress. > > > Key: TEZ-2780 > URL: https://issues.apache.org/jira/browse/TEZ-2780 > Project: Apache Tez > Issue Type: Sub-task > Components: UI >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-2780.1.patch, TEZ-2780.wip.1.patch > > > Modify table component to automatically update cell based on model change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2780) Tez UI: Update All Tasks page while in progress.
[ https://issues.apache.org/jira/browse/TEZ-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737324#comment-14737324 ] Sreenath Somarajapuram commented on TEZ-2780: - [~pramachandran] - The mixin was created for all table pages with the assumption that only the respective entity type would have to be polled. - It was created with the intention to add polling functionality to a table controller with the least amount of code. - That said, I totally agree that on considering a future use-case of multiple polling this would be of less use. Hence I have moved all the functionalities into a new class named EntityArrayPollster (inherited from pollster). The changes can be found in patch 2. Please review. > Tez UI: Update All Tasks page while in progress. > > > Key: TEZ-2780 > URL: https://issues.apache.org/jira/browse/TEZ-2780 > Project: Apache Tez > Issue Type: Sub-task > Components: UI >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-2780.1.patch, TEZ-2780.2.patch, TEZ-2780.wip.1.patch > > > Modify table component to automatically update cell based on model change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2780) Tez UI: Update All Tasks page while in progress.
[ https://issues.apache.org/jira/browse/TEZ-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735223#comment-14735223 ] Prakash Ramachandran commented on TEZ-2780: --- [~Sreenath] still reviewing the changes, one quick question though. Why does the polling class need to be a mixin? this has two disadvantages. 1. there can be only a single instance of the polling. 2. its tied to the type of controller it is used in. IMHO it would be better if its not a mixin, instantiate it in init. and depending on if polling is required, do a start/stop. if you are concerned about code reuse across task/task attempts write a helper function that takes in the required arguments. > Tez UI: Update All Tasks page while in progress. > > > Key: TEZ-2780 > URL: https://issues.apache.org/jira/browse/TEZ-2780 > Project: Apache Tez > Issue Type: Sub-task > Components: UI >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-2780.1.patch, TEZ-2780.wip.1.patch > > > Add AM API for fetching realtime tasks info: > - API endpoint : /ws/v2/tez/tasksInfo > - Query Params: > -- dagID: The complete dagID, (mandatory). > -- vertexMinID: A comma separated list. vertexMinID = vertexIndex. > -- taskMinID: A comma separated list. taskMinID = vertexIndex_taskIndex > -- limit: Maximum number of items to be returned (Defaults to 100). > - If taskMinID is passed: All (capped by limit) the specified tasks will be > returned. vertexMinID if present wont be considered. > - IF vertexMinID is passed: All (capped by limit) tasks under the vertices > will be returned. > - If just dagID is passed: All (capped by limit) tasks under the DAG will be > returned. > - Data returned: complete task id, progress, status > Modify table component to automatically update cell based on model change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2780) Tez UI: Update All Tasks page while in progress.
[
https://issues.apache.org/jira/browse/TEZ-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735303#comment-14735303
]
TezQA commented on TEZ-2780:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12754671/TEZ-2780.1.patch
against master revision c07d6b7.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1086//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1086//console
This message is automatically generated.
> Tez UI: Update All Tasks page while in progress.
>
>
> Key: TEZ-2780
> URL: https://issues.apache.org/jira/browse/TEZ-2780
> Project: Apache Tez
> Issue Type: Sub-task
> Components: UI
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-2780.1.patch, TEZ-2780.wip.1.patch
>
>
> Add AM API for fetching realtime tasks info:
> - API endpoint : /ws/v2/tez/tasksInfo
> - Query Params:
> -- dagID: The complete dagID, (mandatory).
> -- vertexMinID: A comma separated list. vertexMinID = vertexIndex.
> -- taskMinID: A comma separated list. taskMinID = vertexIndex_taskIndex
> -- limit: Maximum number of items to be returned (Defaults to 100).
> - If taskMinID is passed: All (capped by limit) the specified tasks will be
> returned. vertexMinID if present wont be considered.
> - IF vertexMinID is passed: All (capped by limit) tasks under the vertices
> will be returned.
> - If just dagID is passed: All (capped by limit) tasks under the DAG will be
> returned.
> - Data returned: complete task id, progress, status
> Modify table component to automatically update cell based on model change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2780) Tez UI: Update All Tasks page while in progress.
[ https://issues.apache.org/jira/browse/TEZ-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735305#comment-14735305 ] Hitesh Shah commented on TEZ-2780: -- It would be good if the AM webservices and the UI changes could be split out into 2 jiras. > Tez UI: Update All Tasks page while in progress. > > > Key: TEZ-2780 > URL: https://issues.apache.org/jira/browse/TEZ-2780 > Project: Apache Tez > Issue Type: Sub-task > Components: UI >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-2780.1.patch, TEZ-2780.wip.1.patch > > > Add AM API for fetching realtime tasks info: > - API endpoint : /ws/v2/tez/tasksInfo > - Query Params: > -- dagID: The complete dagID, (mandatory). > -- vertexMinID: A comma separated list. vertexMinID = vertexIndex. > -- taskMinID: A comma separated list. taskMinID = vertexIndex_taskIndex > -- limit: Maximum number of items to be returned (Defaults to 100). > - If taskMinID is passed: All (capped by limit) the specified tasks will be > returned. vertexMinID if present wont be considered. > - IF vertexMinID is passed: All (capped by limit) tasks under the vertices > will be returned. > - If just dagID is passed: All (capped by limit) tasks under the DAG will be > returned. > - Data returned: complete task id, progress, status > Modify table component to automatically update cell based on model change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
