[jira] [Commented] (TEZ-2784) optimize TaskImpl.isFinished()

2015-09-09 Thread Bikas Saha (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737250#comment-14737250
 ] 

Bikas Saha commented on TEZ-2784:
-

does this need a backport to branch 7?

> optimize TaskImpl.isFinished()
> --
>
> Key: TEZ-2784
> URL: https://issues.apache.org/jira/browse/TEZ-2784
> Project: Apache Tez
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
> Fix For: 0.8.1
>
> Attachments: AM_Profiler_snapshot.jpg, TEZ-2784.1.patch
>
>
> getInternalState() gets called multiple times within the same method within 
> read lock. This shows up in the AM profiler when executing large jobs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-2784) optimize TaskImpl.isFinished()

2015-09-08 Thread TezQA (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736060#comment-14736060
 ] 

TezQA commented on TEZ-2784:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12754581/TEZ-2784.1.patch
  against master revision 56f7847.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/1095//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1095//console

This message is automatically generated.

> optimize TaskImpl.isFinished()
> --
>
> Key: TEZ-2784
> URL: https://issues.apache.org/jira/browse/TEZ-2784
> Project: Apache Tez
>  Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
> Attachments: AM_Profiler_snapshot.jpg, TEZ-2784.1.patch
>
>
> getInternalState() gets called multiple times within the same method within 
> read lock. This shows up in the AM profiler when executing large jobs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)