[jira] [Commented] (TEZ-2799) SimpleHistoryParser NPE
[
https://issues.apache.org/jira/browse/TEZ-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738843#comment-14738843
]
TezQA commented on TEZ-2799:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12755130/TEZ-2799.2.patch
against master revision 00508f8.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1105//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1105//console
This message is automatically generated.
> SimpleHistoryParser NPE
> ---
>
> Key: TEZ-2799
> URL: https://issues.apache.org/jira/browse/TEZ-2799
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Bikas Saha
>Assignee: Rajesh Balamohan
> Attachments: TEZ-2799.1.patch, TEZ-2799.2.patch,
> history.txt.appattempt_1441839730184_0001_01
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2799) SimpleHistoryParser NPE
[ https://issues.apache.org/jira/browse/TEZ-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737828#comment-14737828 ] Bikas Saha commented on TEZ-2799: - java.lang.NullPointerException at org.apache.tez.history.parser.SimpleHistoryParser.parseContents(SimpleHistoryParser.java:208) at org.apache.tez.history.parser.SimpleHistoryParser.getDAGData(SimpleHistoryParser.java:77) at org.apache.tez.analyzer.plugins.TezAnalyzerBase.run(TezAnalyzerBase.java:170) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) at org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.main(CriticalPathAnalyzer.java:473) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:72) at org.apache.hadoop.util.ProgramDriver.run(ProgramDriver.java:145) at org.apache.tez.analyzer.plugins.AnalyzerDriver.main(AnalyzerDriver.java:51) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.apache.hadoop.util.RunJar.main(RunJar.java:212) > SimpleHistoryParser NPE > --- > > Key: TEZ-2799 > URL: https://issues.apache.org/jira/browse/TEZ-2799 > Project: Apache Tez > Issue Type: Bug >Reporter: Bikas Saha >Assignee: Rajesh Balamohan > Attachments: history.txt.appattempt_1441839730184_0001_01 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2799) SimpleHistoryParser NPE
[ https://issues.apache.org/jira/browse/TEZ-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737830#comment-14737830 ] Bikas Saha commented on TEZ-2799: - Looks like a simple null check is missing, but I could be wrong. There object might be expected to not be null ever. [~rajesh.balamohan] Could you please check? > SimpleHistoryParser NPE > --- > > Key: TEZ-2799 > URL: https://issues.apache.org/jira/browse/TEZ-2799 > Project: Apache Tez > Issue Type: Bug >Reporter: Bikas Saha >Assignee: Rajesh Balamohan > Attachments: history.txt.appattempt_1441839730184_0001_01 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2799) SimpleHistoryParser NPE
[ https://issues.apache.org/jira/browse/TEZ-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737829#comment-14737829 ] Bikas Saha commented on TEZ-2799: - hadoop jar tez-0.8.1-SNAPSHOT/tez-job-analyzer-0.8.1-SNAPSHOT.jar CriticalPath --dagId=dag_1441839730184_0001_16 --eventFileName=history.txt.appattempt_1441839730184_0001_01 --outputDir=/tmp > SimpleHistoryParser NPE > --- > > Key: TEZ-2799 > URL: https://issues.apache.org/jira/browse/TEZ-2799 > Project: Apache Tez > Issue Type: Bug >Reporter: Bikas Saha >Assignee: Rajesh Balamohan > Attachments: history.txt.appattempt_1441839730184_0001_01 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2799) SimpleHistoryParser NPE
[
https://issues.apache.org/jira/browse/TEZ-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737995#comment-14737995
]
Bikas Saha commented on TEZ-2799:
-
lgtm. minor. if {==null} else {} may be better than if {==null} if {!=null}
> SimpleHistoryParser NPE
> ---
>
> Key: TEZ-2799
> URL: https://issues.apache.org/jira/browse/TEZ-2799
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Bikas Saha
>Assignee: Rajesh Balamohan
> Attachments: TEZ-2799.1.patch,
> history.txt.appattempt_1441839730184_0001_01
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
