[jira] [Commented] (TEZ-3311) ATSFileParser resource leak: InputStream should be closed

[Tsuyoshi Ozawa (JIRA)]

[ 
https://issues.apache.org/jira/browse/TEZ-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348961#comment-15348961
 ] 

Tsuyoshi Ozawa commented on TEZ-3311:
-

[~rajesh.balamohan] thank you for the review. You're right, I checked 
ZipFile.getInputStream just only call ensureOpen function internally, and it 
doesn't touch any file descriptor. Closing this as Not a problem.

> ATSFileParser resource leak: InputStream should be closed 
> --
>
> Key: TEZ-3311
> URL: https://issues.apache.org/jira/browse/TEZ-3311
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Hitesh Shah
>Assignee: Tsuyoshi Ozawa
>Priority: Minor
>  Labels: newbie
> Attachments: TEZ-3311.001.patch
>
>
> Discovered in a coverity scan that inputstream is never closed: 
> 189InputStream inputStream = atsZipFile.getInputStream(zipEntry);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-3311) ATSFileParser resource leak: InputStream should be closed

[Rajesh Balamohan (JIRA)]

[ 
https://issues.apache.org/jira/browse/TEZ-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348930#comment-15348930
 ] 

Rajesh Balamohan commented on TEZ-3311:
---

Thanks for sharing the patch [~ozawa]. 

Is coverity report a false alarm, as the closing the zipFile in finally block 
automatically closes the opened up streams internally.

> ATSFileParser resource leak: InputStream should be closed 
> --
>
> Key: TEZ-3311
> URL: https://issues.apache.org/jira/browse/TEZ-3311
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Hitesh Shah
>Assignee: Tsuyoshi Ozawa
>Priority: Minor
>  Labels: newbie
> Attachments: TEZ-3311.001.patch
>
>
> Discovered in a coverity scan that inputstream is never closed: 
> 189InputStream inputStream = atsZipFile.getInputStream(zipEntry);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-3311) ATSFileParser resource leak: InputStream should be closed

[TezQA (JIRA)]

[ 
https://issues.apache.org/jira/browse/TEZ-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348867#comment-15348867
 ] 

TezQA commented on TEZ-3311:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12813137/TEZ-3311.001.patch
  against master revision 1264d5d.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/1812//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1812//console

This message is automatically generated.

> ATSFileParser resource leak: InputStream should be closed 
> --
>
> Key: TEZ-3311
> URL: https://issues.apache.org/jira/browse/TEZ-3311
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Hitesh Shah
>Assignee: Tsuyoshi Ozawa
>Priority: Minor
>  Labels: newbie
> Attachments: TEZ-3311.001.patch
>
>
> Discovered in a coverity scan that inputstream is never closed: 
> 189InputStream inputStream = atsZipFile.getInputStream(zipEntry);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)