[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[ https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586674#comment-15586674 ] Hitesh Shah commented on TEZ-3419: -- +1 > Tez UI: Applications page shows error, for users with only DAG level ACL > permission. > > > Key: TEZ-3419 > URL: https://issues.apache.org/jira/browse/TEZ-3419 > Project: Apache Tez > Issue Type: Sub-task >Affects Versions: 0.7.0 >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, Screen Shot > 2016-10-13 at 4.37.09 PM.png, Screen Shot 2016-10-17 at 4.11.29 PM.png, > Screen Shot 2016-10-17 at 4.11.59 PM.png, Screen Shot 2016-10-17 at 4.12.23 > PM.png, TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, > TEZ-3419.4.patch, TEZ-3419.5.patch, TEZ-3419.6.patch, TEZ-3419.wip.1.patch, > Tez data missing.png, YARN & Tez data missing.png, YARN data missing.png > > > Follow this logic and display better message: > On loading app details page, send a request to > /ws/v1/timeline/TEZ_APPLICATION/tez_ > - If it succeed, display the details page as we do now. > - If it fails, send a request to > /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A > -- If it succeed, then we know that DAGs under the app are available and > assume that the user doesn't have permission to access app level data. > --- If AHS is accessible, display application data from there in the details > page. > --- else if AHS is not accessible, display a message in app details tab, > something like "Data is not available. Check if you are authorized to access > application data!". > --- Also display the DAGs tab, for the user to see DAGs under that app. > -- If it fails, display error message as we do now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585304#comment-15585304
]
TezQA commented on TEZ-3419:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12833926/TEZ-3419.6.patch
against master revision 48208dc.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2043//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2043//console
This message is automatically generated.
> Tez UI: Applications page shows error, for users with only DAG level ACL
> permission.
>
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
> Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, Screen Shot
> 2016-10-13 at 4.37.09 PM.png, Screen Shot 2016-10-17 at 4.11.29 PM.png,
> Screen Shot 2016-10-17 at 4.11.59 PM.png, Screen Shot 2016-10-17 at 4.12.23
> PM.png, TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch,
> TEZ-3419.4.patch, TEZ-3419.5.patch, TEZ-3419.6.patch, TEZ-3419.wip.1.patch,
> Tez data missing.png, YARN & Tez data missing.png, YARN data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details
> page.
> --- else if AHS is not accessible, display a message in app details tab,
> something like "Data is not available. Check if you are authorized to access
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583718#comment-15583718
]
TezQA commented on TEZ-3419:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12833806/TEZ-3419.5.patch
against master revision 48208dc.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2041//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2041//console
This message is automatically generated.
> Tez UI: Applications page shows error, for users with only DAG level ACL
> permission.
>
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
> Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, Screen Shot
> 2016-10-13 at 4.37.09 PM.png, TEZ-3419.1.patch, TEZ-3419.2.patch,
> TEZ-3419.3.patch, TEZ-3419.4.patch, TEZ-3419.5.patch, TEZ-3419.wip.1.patch,
> Tez data missing.png, YARN & Tez data missing.png, YARN data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details
> page.
> --- else if AHS is not accessible, display a message in app details tab,
> something like "Data is not available. Check if you are authorized to access
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573549#comment-15573549
]
TezQA commented on TEZ-3419:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12833240/Screen%20Shot%202016-10-13%20at%204.37.09%20PM.png
against master revision 43f7b5e.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2038//console
This message is automatically generated.
> Tez UI: Applications page shows error, for users with only DAG level ACL
> permission.
>
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
> Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, Screen Shot
> 2016-10-13 at 4.37.09 PM.png, TEZ-3419.1.patch, TEZ-3419.2.patch,
> TEZ-3419.3.patch, TEZ-3419.4.patch, TEZ-3419.wip.1.patch, Tez data
> missing.png, YARN & Tez data missing.png, YARN data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details
> page.
> --- else if AHS is not accessible, display a message in app details tab,
> something like "Data is not available. Check if you are authorized to access
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[ https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573544#comment-15573544 ] Hitesh Shah commented on TEZ-3419: -- In the future if needed based on feedback we can consider enhancing the error message to indicate what data is not visible. > Tez UI: Applications page shows error, for users with only DAG level ACL > permission. > > > Key: TEZ-3419 > URL: https://issues.apache.org/jira/browse/TEZ-3419 > Project: Apache Tez > Issue Type: Sub-task >Affects Versions: 0.7.0 >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, > TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, TEZ-3419.4.patch, > TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN > data missing.png > > > Follow this logic and display better message: > On loading app details page, send a request to > /ws/v1/timeline/TEZ_APPLICATION/tez_ > - If it succeed, display the details page as we do now. > - If it fails, send a request to > /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A > -- If it succeed, then we know that DAGs under the app are available and > assume that the user doesn't have permission to access app level data. > --- If AHS is accessible, display application data from there in the details > page. > --- else if AHS is not accessible, display a message in app details tab, > something like "Data is not available. Check if you are authorized to access > application data!". > --- Also display the DAGs tab, for the user to see DAGs under that app. > -- If it fails, display error message as we do now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[ https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573541#comment-15573541 ] Hitesh Shah commented on TEZ-3419: -- In any case, I think this patch can go in. +1 after addressing the minor nit on the error message which can be changed to say "Some data is not available". > Tez UI: Applications page shows error, for users with only DAG level ACL > permission. > > > Key: TEZ-3419 > URL: https://issues.apache.org/jira/browse/TEZ-3419 > Project: Apache Tez > Issue Type: Sub-task >Affects Versions: 0.7.0 >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, > TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, TEZ-3419.4.patch, > TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN > data missing.png > > > Follow this logic and display better message: > On loading app details page, send a request to > /ws/v1/timeline/TEZ_APPLICATION/tez_ > - If it succeed, display the details page as we do now. > - If it fails, send a request to > /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A > -- If it succeed, then we know that DAGs under the app are available and > assume that the user doesn't have permission to access app level data. > --- If AHS is accessible, display application data from there in the details > page. > --- else if AHS is not accessible, display a message in app details tab, > something like "Data is not available. Check if you are authorized to access > application data!". > --- Also display the DAGs tab, for the user to see DAGs under that app. > -- If it fails, display error message as we do now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[ https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573532#comment-15573532 ] Hitesh Shah commented on TEZ-3419: -- Can you clarify what data is missing on the app details page? > Tez UI: Applications page shows error, for users with only DAG level ACL > permission. > > > Key: TEZ-3419 > URL: https://issues.apache.org/jira/browse/TEZ-3419 > Project: Apache Tez > Issue Type: Sub-task >Affects Versions: 0.7.0 >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, > TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, TEZ-3419.4.patch, > TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN > data missing.png > > > Follow this logic and display better message: > On loading app details page, send a request to > /ws/v1/timeline/TEZ_APPLICATION/tez_ > - If it succeed, display the details page as we do now. > - If it fails, send a request to > /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A > -- If it succeed, then we know that DAGs under the app are available and > assume that the user doesn't have permission to access app level data. > --- If AHS is accessible, display application data from there in the details > page. > --- else if AHS is not accessible, display a message in app details tab, > something like "Data is not available. Check if you are authorized to access > application data!". > --- Also display the DAGs tab, for the user to see DAGs under that app. > -- If it fails, display error message as we do now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565683#comment-15565683
]
TezQA commented on TEZ-3419:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12832671/TEZ-3419.4.patch
against master revision ead4c0a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2030//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2030//console
This message is automatically generated.
> Tez UI: Applications page shows error, for users with only DAG level ACL
> permission.
>
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
> Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch,
> TEZ-3419.4.patch, TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data
> missing.png, YARN data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details
> page.
> --- else if AHS is not accessible, display a message in app details tab,
> something like "Data is not available. Check if you are authorized to access
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[ https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546929#comment-15546929 ] Hitesh Shah commented on TEZ-3419: -- I think for now, a simple message that the data is not visible due to ACLs is probably sufficient. Beyond that, we should fix our documentation to explain all the config knobs that the users can try. Additionally, given that the UI does not really link to any docs/FAQ today, there is no need to fix this linking in this jira. > Tez UI: Applications page shows error, for users with only DAG level ACL > permission. > > > Key: TEZ-3419 > URL: https://issues.apache.org/jira/browse/TEZ-3419 > Project: Apache Tez > Issue Type: Sub-task >Affects Versions: 0.7.0 >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, > TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN > data missing.png > > > Follow this logic and display better message: > On loading app details page, send a request to > /ws/v1/timeline/TEZ_APPLICATION/tez_ > - If it succeed, display the details page as we do now. > - If it fails, send a request to > /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A > -- If it succeed, then we know that DAGs under the app are available and > assume that the user doesn't have permission to access app level data. > --- If AHS is accessible, display application data from there in the details > page. > --- else if AHS is not accessible, display a message in app details tab, > something like "Data is not available. Check if you are authorized to access > application data!". > --- Also display the DAGs tab, for the user to see DAGs under that app. > -- If it fails, display error message as we do now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[ https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546927#comment-15546927 ] Hitesh Shah commented on TEZ-3419: -- Comments: If yarn data for the app is missing, why does the user need to be a yarn admin to be able to view it? Shouldnt the owner of the app ( or the user specified in tez.am.view-acls ) be sufficient to view the info? Telling the user that they need to be a yarn admin or disable yarn acls seems to give a very bad impression. Normal users should never be told that they need to be on the admin acl list to view their own app data. > Tez UI: Applications page shows error, for users with only DAG level ACL > permission. > > > Key: TEZ-3419 > URL: https://issues.apache.org/jira/browse/TEZ-3419 > Project: Apache Tez > Issue Type: Sub-task >Affects Versions: 0.7.0 >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, > TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN > data missing.png > > > Follow this logic and display better message: > On loading app details page, send a request to > /ws/v1/timeline/TEZ_APPLICATION/tez_ > - If it succeed, display the details page as we do now. > - If it fails, send a request to > /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A > -- If it succeed, then we know that DAGs under the app are available and > assume that the user doesn't have permission to access app level data. > --- If AHS is accessible, display application data from there in the details > page. > --- else if AHS is not accessible, display a message in app details tab, > something like "Data is not available. Check if you are authorized to access > application data!". > --- Also display the DAGs tab, for the user to see DAGs under that app. > -- If it fails, display error message as we do now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[ https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537976#comment-15537976 ] Sreenath Somarajapuram commented on TEZ-3419: - Its a UI only patch and the failure is not related. > Tez UI: Applications page shows error, for users with only DAG level ACL > permission. > > > Key: TEZ-3419 > URL: https://issues.apache.org/jira/browse/TEZ-3419 > Project: Apache Tez > Issue Type: Sub-task >Affects Versions: 0.7.0 >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, > TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN > data missing.png > > > Follow this logic and display better message: > On loading app details page, send a request to > /ws/v1/timeline/TEZ_APPLICATION/tez_ > - If it succeed, display the details page as we do now. > - If it fails, send a request to > /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A > -- If it succeed, then we know that DAGs under the app are available and > assume that the user doesn't have permission to access app level data. > --- If AHS is accessible, display application data from there in the details > page. > --- else if AHS is not accessible, display a message in app details tab, > something like "Data is not available. Check if you are authorized to access > application data!". > --- Also display the DAGs tab, for the user to see DAGs under that app. > -- If it fails, display error message as we do now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532954#comment-15532954
]
TezQA commented on TEZ-3419:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12830887/TEZ-3419.3.patch
against master revision 5c2f893.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.dag.history.utils.TestDAGUtils
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1994//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1994//console
This message is automatically generated.
> Tez UI: Applications page shows error, for users with only DAG level ACL
> permission.
>
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
> Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch,
> TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN
> data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details
> page.
> --- else if AHS is not accessible, display a message in app details tab,
> something like "Data is not available. Check if you are authorized to access
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530961#comment-15530961
]
TezQA commented on TEZ-3419:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12830788/YARN%20%26%20Tez%20data%20missing.png
against master revision 5c2f893.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1992//console
This message is automatically generated.
> Tez UI: Applications page shows error, for users with only DAG level ACL
> permission.
>
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
> Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-3419.1.patch, TEZ-3419.2.patch,
> TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN
> data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details
> page.
> --- else if AHS is not accessible, display a message in app details tab,
> something like "Data is not available. Check if you are authorized to access
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483089#comment-15483089
]
Sreenath Somarajapuram commented on TEZ-3419:
-
bq. in the case the call to ATS fails, the desc mentions displaying an error
message but at the same time displaying data from AHS if available. How is this
being reconciled i.e. showing details from AHS as well as displaying an error?
- In the current implementation we display error-bar only if DAG details are
not available. If either/both of tez_application or applicationhistory data is
available, we display what ever is available. If both are missing we show the
message.
{code}
Data not available!
Please verify if you are authorised to view application details.
{code}
- Will correct the description.
bq. "Please verify if you are authorised to view application details." ~ how
exactly would a user verify the above?
- "Please contact your admin, and verify if you are authorised to view
application details." would this message be fine.
> Tez UI: Applications page shows error, for users with only DAG level ACL
> permission.
>
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
> Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-3419.1.patch, TEZ-3419.wip.1.patch
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and
> assume that the user doesn't have permission to access app level data.
> --- So display a message in app details tab, something like "Data is not
> available. Check if you are authorized to access application data!".
> --- If AHS is accessible, display application data from there in the details
> page.
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478448#comment-15478448
]
Hitesh Shah commented on TEZ-3419:
--
Comments:
{code}
Please verify if you are authorised to view application details.
{code}
- how exactly would a user verify the above?
> Tez UI: Applications page shows error, for users with only DAG level ACL
> permission.
>
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
> Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-3419.1.patch, TEZ-3419.wip.1.patch
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and
> assume that the user doesn't have permission to access app level data.
> --- So display a message in app details tab, something like "Data is not
> available. Check if you are authorized to access application data!".
> --- If AHS is accessible, display application data from there in the details
> page.
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478364#comment-15478364
]
TezQA commented on TEZ-3419:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12827824/TEZ-3419.1.patch
against master revision c07ec7b.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/1962//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1962//console
This message is automatically generated.
> Tez UI: Applications page shows error, for users with only DAG level ACL
> permission.
>
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
> Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-3419.1.patch, TEZ-3419.wip.1.patch
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and
> assume that the user doesn't have permission to access app level data.
> --- So display a message in app details tab, something like "Data is not
> available. Check if you are authorized to access application data!".
> --- If AHS is accessible, display application data from there in the details
> page.
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.
[ https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478270#comment-15478270 ] Hitesh Shah commented on TEZ-3419: -- [~Sreenath] A question on the description of the jira: - in the case the call to ATS fails, the desc mentions displaying an error message but at the same time displaying data from AHS if available. How is this being reconciled i.e. showing details from AHS as well as displaying an error? > Tez UI: Applications page shows error, for users with only DAG level ACL > permission. > > > Key: TEZ-3419 > URL: https://issues.apache.org/jira/browse/TEZ-3419 > Project: Apache Tez > Issue Type: Sub-task >Affects Versions: 0.7.0 >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-3419.1.patch, TEZ-3419.wip.1.patch > > > Follow this logic and display better message: > On loading app details page, send a request to > /ws/v1/timeline/TEZ_APPLICATION/tez_ > - If it succeed, display the details page as we do now. > - If it fails, send a request to > /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A > -- If it succeed, then we know that DAGs under the app are available and > assume that the user doesn't have permission to access app level data. > --- So display a message in app details tab, something like "Data is not > available. Check if you are authorized to access application data!". > --- If AHS is accessible, display application data from there in the details > page. > --- Also display the DAGs tab, for the user to see DAGs under that app. > -- If it fails, display error message as we do now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
