[jira] [Commented] (TEZ-3450) Avoid reading Max Failed Attempts from configuration for each task
[ https://issues.apache.org/jira/browse/TEZ-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538357#comment-15538357 ] TezQA commented on TEZ-3450: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12831214/TEZ-3450.1.patch against master revision 5c2f893. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 javac{color:red}. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2005//console This message is automatically generated. > Avoid reading Max Failed Attempts from configuration for each task > -- > > Key: TEZ-3450 > URL: https://issues.apache.org/jira/browse/TEZ-3450 > Project: Apache Tez > Issue Type: Improvement >Reporter: darion yaphet >Assignee: darion yaphet > Attachments: TEZ-3450.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3450) Avoid reading Max Failed Attempts from configuration for each task
[ https://issues.apache.org/jira/browse/TEZ-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538344#comment-15538344 ] darion yaphet commented on TEZ-3450: Thans [Hitesh Shah|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=hitesh] , update read max failed attempts after vertexConf have been updated . > Avoid reading Max Failed Attempts from configuration for each task > -- > > Key: TEZ-3450 > URL: https://issues.apache.org/jira/browse/TEZ-3450 > Project: Apache Tez > Issue Type: Improvement >Reporter: darion yaphet >Assignee: darion yaphet > Attachments: TEZ-3450.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3450) Avoid reading Max Failed Attempts from configuration for each task
[ https://issues.apache.org/jira/browse/TEZ-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534372#comment-15534372 ] Siddharth Seth commented on TEZ-3450: - Good catch. Thought we had already cleaned up all such config lookups. Think the patch will need some test changes to compile. > Avoid reading Max Failed Attempts from configuration for each task > -- > > Key: TEZ-3450 > URL: https://issues.apache.org/jira/browse/TEZ-3450 > Project: Apache Tez > Issue Type: Improvement >Reporter: darion yaphet >Assignee: darion yaphet > Attachments: TEZ-3450.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3450) Avoid reading Max Failed Attempts from configuration for each task
[ https://issues.apache.org/jira/browse/TEZ-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532993#comment-15532993 ] TezQA commented on TEZ-3450: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12830441/TEZ-3450.1.patch against master revision 5c2f893. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 javac{color:red}. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1995//console This message is automatically generated. > Avoid reading Max Failed Attempts from configuration for each task > -- > > Key: TEZ-3450 > URL: https://issues.apache.org/jira/browse/TEZ-3450 > Project: Apache Tez > Issue Type: Improvement >Reporter: darion yaphet >Assignee: darion yaphet > Attachments: TEZ-3450.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)