[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-30 Thread Jira


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168413#comment-17168413
 ] 

László Bodor commented on TEZ-4204:
---

ok, resolving this, thanks again for the patch and [~ashutoshc] for the review!

> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Blocker
> Attachments: TEZ-4204.1.patch, TEZ-4204.1.patch, TEZ-4204.2.patch
>
>
> After https://issues.apache.org/jira/browse/TEZ-4170 there is a data race for 
> initializerMap in RootInputInitializerManager. initializerMap should be 
> initialized before vertex state is set to initializing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-30 Thread Mustafa Iman (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168087#comment-17168087
 ] 

Mustafa Iman commented on TEZ-4204:
---

[~abstractdog] since branch-0.9 does not contain TEZ-4170, this patch is not 
needed there.

> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Blocker
> Attachments: TEZ-4204.1.patch, TEZ-4204.1.patch, TEZ-4204.2.patch
>
>
> After https://issues.apache.org/jira/browse/TEZ-4170 there is a data race for 
> initializerMap in RootInputInitializerManager. initializerMap should be 
> initialized before vertex state is set to initializing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-30 Thread Jira


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168065#comment-17168065
 ] 

László Bodor commented on TEZ-4204:
---

pushed to master, thanks [~mustafaiman]!
also, I'm about to push it to branch-0.9 but found some conflicts while 
cherry-picking..could you please apply and attach a branch-0.9 version as 
you're more familiar with the patch?

> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Blocker
> Attachments: TEZ-4204.1.patch, TEZ-4204.1.patch, TEZ-4204.2.patch
>
>
> After https://issues.apache.org/jira/browse/TEZ-4170 there is a data race for 
> initializerMap in RootInputInitializerManager. initializerMap should be 
> initialized before vertex state is set to initializing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-28 Thread Jira


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166421#comment-17166421
 ] 

László Bodor commented on TEZ-4204:
---

[~mustafaiman]: we've already ignored TestSpeculation failures for the last few 
months, so I think this patch could be merged as you have the +1 review (even 
if you were very unlucky to have failures for all of your precommit tests :) it 
still doesn't look related)

I'm about to merge this to master / branch-0.9 later today

> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Blocker
> Attachments: TEZ-4204.1.patch, TEZ-4204.1.patch, TEZ-4204.2.patch
>
>
> After https://issues.apache.org/jira/browse/TEZ-4170 there is a data race for 
> initializerMap in RootInputInitializerManager. initializerMap should be 
> initialized before vertex state is set to initializing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-27 Thread Mustafa Iman (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165830#comment-17165830
 ] 

Mustafa Iman commented on TEZ-4204:
---

Failed unit test is a known flaky test: 
https://issues.apache.org/jira/browse/TEZ-4206 . Can we merge a patch in this 
case or do we need to wait for green build?

> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Blocker
> Attachments: TEZ-4204.1.patch, TEZ-4204.1.patch, TEZ-4204.2.patch
>
>
> After https://issues.apache.org/jira/browse/TEZ-4170 there is a data race for 
> initializerMap in RootInputInitializerManager. initializerMap should be 
> initialized before vertex state is set to initializing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-23 Thread Ashutosh Chauhan (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163997#comment-17163997
 ] 

Ashutosh Chauhan commented on TEZ-4204:
---

+1

> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Blocker
> Attachments: TEZ-4204.1.patch, TEZ-4204.1.patch, TEZ-4204.2.patch
>
>
> After https://issues.apache.org/jira/browse/TEZ-4170 there is a data race for 
> initializerMap in RootInputInitializerManager. initializerMap should be 
> initialized before vertex state is set to initializing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-22 Thread TezQA (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163068#comment-17163068
 ] 

TezQA commented on TEZ-4204:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  1m 
49s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
47s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
18s{color} | {color:green} tez-dag: The patch generated 0 new + 17 unchanged - 
2 fixed = 17 total (was 19) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  4m 37s{color} 
| {color:red} tez-dag in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m  2s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | tez.dag.app.TestSpeculation |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://builds.apache.org/job/PreCommit-TEZ-Build/493/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4204 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13008198/TEZ-4204.2.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
checkstyle compile |
| uname | Linux 2d20955213e2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 2d7c60849 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| unit | 
https://builds.apache.org/job/PreCommit-TEZ-Build/493/artifact/out/patch-unit-tez-dag.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-TEZ-Build/493/testReport/ |
| Max. process+thread count | 188 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | 
https://builds.apache.org/job/PreCommit-TEZ-Build/493/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
>  

[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-22 Thread TezQA (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162991#comment-17162991
 ] 

TezQA commented on TEZ-4204:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  1m  
7s{color} | {color:blue} Used deprecated FindBugs config; considering switching 
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} tez-dag: The patch generated 0 new + 17 unchanged - 
2 fixed = 17 total (was 19) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  4m 22s{color} 
| {color:red} tez-dag in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 41s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | tez.dag.app.TestSpeculation |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://builds.apache.org/job/PreCommit-TEZ-Build/492/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4204 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13008192/TEZ-4204.2.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
checkstyle compile |
| uname | Linux 08d9af63f457 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 2d7c60849 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| unit | 
https://builds.apache.org/job/PreCommit-TEZ-Build/492/artifact/out/patch-unit-tez-dag.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-TEZ-Build/492/testReport/ |
| Max. process+thread count | 234 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | 
https://builds.apache.org/job/PreCommit-TEZ-Build/492/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
>  

[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-22 Thread TezQA (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162973#comment-17162973
 ] 

TezQA commented on TEZ-4204:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
33s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  1m  
8s{color} | {color:blue} Used deprecated FindBugs config; considering switching 
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
7s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} tez-dag: The patch generated 0 new + 17 unchanged - 
2 fixed = 17 total (was 19) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  4m 40s{color} 
| {color:red} tez-dag in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 59s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | tez.dag.app.TestSpeculation |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://builds.apache.org/job/PreCommit-TEZ-Build/491/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4204 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13008189/TEZ-4204.2.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
checkstyle compile |
| uname | Linux f549927d0152 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 2d7c60849 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| unit | 
https://builds.apache.org/job/PreCommit-TEZ-Build/491/artifact/out/patch-unit-tez-dag.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-TEZ-Build/491/testReport/ |
| Max. process+thread count | 188 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | 
https://builds.apache.org/job/PreCommit-TEZ-Build/491/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
>  

[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-22 Thread TezQA (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162942#comment-17162942
 ] 

TezQA commented on TEZ-4204:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 11m 
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m 
 2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  2m 
12s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 22s{color} | {color:orange} tez-dag: The patch generated 4 new + 17 
unchanged - 2 fixed = 21 total (was 19) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 
32s{color} | {color:green} tez-dag in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 15s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://builds.apache.org/job/PreCommit-TEZ-Build/490/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4204 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13008182/TEZ-4204.1.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
checkstyle compile |
| uname | Linux 29c3eec4d7fe 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 
10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 2d7c60849 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-TEZ-Build/490/artifact/out/diff-checkstyle-tez-dag.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-TEZ-Build/490/testReport/ |
| Max. process+thread count | 209 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | 
https://builds.apache.org/job/PreCommit-TEZ-Build/490/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
> Project: Apache Tez
>  Issue Type: Bug
> 

[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-22 Thread TezQA (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162561#comment-17162561
 ] 

TezQA commented on TEZ-4204:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red}  5m 
21s{color} | {color:red} Docker failed to build yetus/tez:474bb22ba. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | TEZ-4204 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13008135/TEZ-4204.1.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-TEZ-Build/487/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Mustafa Iman
>Assignee: Rajesh Balamohan
>Priority: Major
> Attachments: TEZ-4204.1.patch
>
>
> After https://issues.apache.org/jira/browse/TEZ-4170 there is a data race for 
> initializerMap in RootInputInitializerManager. initializerMap should be 
> initialized before vertex state is set to initializing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (TEZ-4204) Data race in RootInputInitializerManager

2020-07-22 Thread Mustafa Iman (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162559#comment-17162559
 ] 

Mustafa Iman commented on TEZ-4204:
---

Patch was provided by [~rajesh.balamohan]

cc: [~hashutosh]

> Data race in RootInputInitializerManager
> 
>
> Key: TEZ-4204
> URL: https://issues.apache.org/jira/browse/TEZ-4204
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Mustafa Iman
>Assignee: Mustafa Iman
>Priority: Major
> Attachments: TEZ-4204.1.patch
>
>
> After https://issues.apache.org/jira/browse/TEZ-4170 there is a data race for 
> initializerMap in RootInputInitializerManager. initializerMap should be 
> initialized before vertex state is set to initializing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)