[jira] [Commented] (TEZ-4215) Address findbugs warnings in analyzers

2020-12-14 Thread Jira 


[ 
https://issues.apache.org/jira/browse/TEZ-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249539#comment-17249539
 ] 

László Bodor commented on TEZ-4215:
---

[~jeagles]: please take a look at my patch (see comment above)? as we're moving 
to github, let's have findbugs clean for that

> Address findbugs warnings in analyzers
> --
>
> Key: TEZ-4215
> URL: https://issues.apache.org/jira/browse/TEZ-4215
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Jonathan Turner Eagles
>Assignee: Jonathan Turner Eagles
>Priority: Major
> Attachments: TEZ-4215.01.patch, TEZ-4215.WIP.patch
>
>
> {code}
> NPNull passed for non-null parameter of 
> com.google.common.base.Strings.isNullOrEmpty(String) in 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 576]
> NPNull passed for non-null parameter of 
> com.google.common.base.Strings.isNullOrEmpty(String) in 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 519]
> NPNull passed for non-null parameter of 
> com.google.common.base.Strings.isNullOrEmpty(String) in 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 532]
> NPNull passed for non-null parameter of 
> com.google.common.base.Functions.forMap(Map, Object) in 
> org.apache.tez.analyzer.plugins.VertexLevelCriticalPathAnalyzer.sortByValues(Map)
> Bug type NP_NONNULL_PARAM_VIOLATION (click for details)
> In class org.apache.tez.analyzer.plugins.VertexLevelCriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.VertexLevelCriticalPathAnalyzer.sortByValues(Map)
> Called method com.google.common.base.Functions.forMap(Map, Object)
> Argument 2 is definitely null but must not be null
> At VertexLevelCriticalPathAnalyzer.java:[line 116]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (TEZ-4215) Address findbugs warnings in analyzers

2020-11-01 Thread Hadoop QA (Jira) 


[ 
https://issues.apache.org/jira/browse/TEZ-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224275#comment-17224275
 ] 

Hadoop QA commented on TEZ-4215:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  1m  2s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/51/artifact/out/Dockerfile 
|
| JIRA Issue | TEZ-4215 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13014509/TEZ-4215.01.patch |
| Optional Tests | dupname asflicense xml |
| uname | Linux 7641751558d9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 6c53307ad |
| Max. process+thread count | 46 (vs. ulimit of 5500) |
| modules | C: tez-tools/analyzers/job-analyzer U: 
tez-tools/analyzers/job-analyzer |
| Console output | 
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/51/console |
| versions | git=2.17.1 maven=3.6.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Address findbugs warnings in analyzers
> --
>
> Key: TEZ-4215
> URL: https://issues.apache.org/jira/browse/TEZ-4215
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Jonathan Turner Eagles
>Assignee: Jonathan Turner Eagles
>Priority: Major
> Attachments: TEZ-4215.01.patch, TEZ-4215.WIP.patch
>
>
> {code}
> NPNull passed for non-null parameter of 
> com.google.common.base.Strings.isNullOrEmpty(String) in 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 576]
> NPNull passed for non-null parameter of 
> com.google.common.base.Strings.isNullOrEmpty(String) in 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 519]
> NPNull passed for non-null parameter of 
> com.google.common.base.Strings.isNullOrEmpty(String) in 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method

[jira] [Commented] (TEZ-4215) Address findbugs warnings in analyzers

2020-11-01 Thread Jira 


[ 
https://issues.apache.org/jira/browse/TEZ-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224272#comment-17224272
 ] 

László Bodor commented on TEZ-4215:
---

this warning is indeed annoying, as guava27 has @Nullable annotation in the 
called methods' signature (both Strings.isNullOrEmpty and Functions.forMap)
this is similar to HADOOP-16210, where it was solved by findbugs exclude, I'm 
afraid that's the only possible solution at the moment here too, attached  
[^TEZ-4215.01.patch] 

> Address findbugs warnings in analyzers
> --
>
> Key: TEZ-4215
> URL: https://issues.apache.org/jira/browse/TEZ-4215
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Jonathan Turner Eagles
>Assignee: Jonathan Turner Eagles
>Priority: Major
> Attachments: TEZ-4215.01.patch, TEZ-4215.WIP.patch
>
>
> {code}
> NPNull passed for non-null parameter of 
> com.google.common.base.Strings.isNullOrEmpty(String) in 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 576]
> NPNull passed for non-null parameter of 
> com.google.common.base.Strings.isNullOrEmpty(String) in 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 519]
> NPNull passed for non-null parameter of 
> com.google.common.base.Strings.isNullOrEmpty(String) in 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
>  TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 532]
> NPNull passed for non-null parameter of 
> com.google.common.base.Functions.forMap(Map, Object) in 
> org.apache.tez.analyzer.plugins.VertexLevelCriticalPathAnalyzer.sortByValues(Map)
> Bug type NP_NONNULL_PARAM_VIOLATION (click for details)
> In class org.apache.tez.analyzer.plugins.VertexLevelCriticalPathAnalyzer
> In method 
> org.apache.tez.analyzer.plugins.VertexLevelCriticalPathAnalyzer.sortByValues(Map)
> Called method com.google.common.base.Functions.forMap(Map, Object)
> Argument 2 is definitely null but must not be null
> At VertexLevelCriticalPathAnalyzer.java:[line 116]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (TEZ-4215) Address findbugs warnings in analyzers

2020-08-04 Thread Jonathan Turner Eagles (Jira) 


[ 
https://issues.apache.org/jira/browse/TEZ-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170988#comment-17170988
 ] 

Jonathan Turner Eagles commented on TEZ-4215:
-

Empty WIP Patch shows 4 existing findbugs warnings in the code base. Will 
provide a patch to fix these warnings.

> Address findbugs warnings in analyzers
> --
>
> Key: TEZ-4215
> URL: https://issues.apache.org/jira/browse/TEZ-4215
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Jonathan Turner Eagles
>Assignee: Jonathan Turner Eagles
>Priority: Major
> Attachments: TEZ-4215.WIP.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (TEZ-4215) Address findbugs warnings in analyzers

2020-08-04 Thread TezQA (Jira) 


[ 
https://issues.apache.org/jira/browse/TEZ-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170986#comment-17170986
 ] 

TezQA commented on TEZ-4215:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  3m 
41s{color} | {color:red} root in master failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m 
40s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
37s{color} | {color:red} tez-tools/analyzers/job-analyzer in master has 4 
extant findbugs warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
23s{color} | {color:green} job-analyzer in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 10m 47s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://builds.apache.org/job/PreCommit-TEZ-Build/513/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4215 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13009051/TEZ-4215.WIP.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
checkstyle compile |
| uname | Linux e809ea2a425d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 5f3cac509 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-TEZ-Build/513/artifact/out/branch-mvninstall-root.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-TEZ-Build/513/artifact/out/branch-findbugs-tez-tools_analyzers_job-analyzer-warnings.html
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-TEZ-Build/513/testReport/ |
| Max. process+thread count | 832 (vs. ulimit of 5500) |
| modules | C: tez-tools/analyzers/job-analyzer U: 
tez-tools/analyzers/job-analyzer |
| Console output | 
https://builds.apache.org/job/PreCommit-TEZ-Build/513/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Address findbugs warnings in analyzers
>