[jira] [Updated] (TEZ-1274) Remove Key/Value type checks in IFile

2015-01-08 Thread Rajesh Balamohan (JIRA)

 [ 
https://issues.apache.org/jira/browse/TEZ-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajesh Balamohan updated TEZ-1274:
--
Fix Version/s: 0.7.0

 Remove Key/Value type checks in IFile
 -

 Key: TEZ-1274
 URL: https://issues.apache.org/jira/browse/TEZ-1274
 Project: Apache Tez
  Issue Type: Improvement
Reporter: Siddharth Seth
Assignee: Rajesh Balamohan
 Fix For: 0.7.0

 Attachments: TEZ-1274.1.patch


 We check key and value types for each record - this should be removed from 
 the tight loop. Maybe an assertion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TEZ-1274) Remove Key/Value type checks in IFile

2015-01-08 Thread Rajesh Balamohan (JIRA)

 [ 
https://issues.apache.org/jira/browse/TEZ-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajesh Balamohan updated TEZ-1274:
--
Attachment: TEZ-1274.1.patch

[~sseth] Please review when you find time.

Removed unwanted checks.  It is left to the caller to ensure that proper type 
checks and length checks are done (since its all in tez code, it should be fine 
removing these checks).  We also don't want the length checks (if negative 
key/value lengths are passed, outputstream would anyways throw 
IndexOutOfBoundsException).

 Remove Key/Value type checks in IFile
 -

 Key: TEZ-1274
 URL: https://issues.apache.org/jira/browse/TEZ-1274
 Project: Apache Tez
  Issue Type: Improvement
Reporter: Siddharth Seth
Assignee: Rajesh Balamohan
 Attachments: TEZ-1274.1.patch


 We check key and value types for each record - this should be removed from 
 the tight loop. Maybe an assertion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TEZ-1274) Remove Key/Value type checks in IFile

2015-01-07 Thread Siddharth Seth (JIRA)

 [ 
https://issues.apache.org/jira/browse/TEZ-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Siddharth Seth updated TEZ-1274:

Target Version/s: 0.7.0

 Remove Key/Value type checks in IFile
 -

 Key: TEZ-1274
 URL: https://issues.apache.org/jira/browse/TEZ-1274
 Project: Apache Tez
  Issue Type: Improvement
Reporter: Siddharth Seth

 We check key and value types for each record - this should be removed from 
 the tight loop. Maybe an assertion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)