[jira] [Updated] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles updated TEZ-3684: - Attachment: TEZ-3684.3.patch [~jlowe], fixed the logging statement in v3 > Incorporate first pass non-essential TEZ-3334 pre-merge feedback > > > Key: TEZ-3684 > URL: https://issues.apache.org/jira/browse/TEZ-3684 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3684.1.patch, TEZ-3684.2.patch, TEZ-3684.3.patch > > > Incorporates this feedback from TEZ-3334 > https://issues.apache.org/jira/browse/TEZ-3334?focusedCommentId=15950550=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15950550 > - TezContainerLauncherImpl - ByteBuffer portInfo > =response.getAllServicesMetaData().get(conf.get(TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID,TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID_DEFAULT)); > - Could be split into multiple calls, in case there's a possibility of a NPE. > - TestShuffleHandlerJobs. Parameter name mrrTez - should really be tez*. > - Variable renames. pendingInputsOfOnePartition is no longer a valid name. > - InputHost.clearAndGetOnePartition - rename. This is no longer giving back a > single partition only. > - pendingInputsOfOnePartition - name is likely not valid any longer -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles updated TEZ-3684: - Attachment: TEZ-3684.2.patch [~jlowe], patch v2 add two warnings regarding the cause of not finding the shuffle port. > Incorporate first pass non-essential TEZ-3334 pre-merge feedback > > > Key: TEZ-3684 > URL: https://issues.apache.org/jira/browse/TEZ-3684 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3684.1.patch, TEZ-3684.2.patch > > > Incorporates this feedback from TEZ-3334 > https://issues.apache.org/jira/browse/TEZ-3334?focusedCommentId=15950550=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15950550 > - TezContainerLauncherImpl - ByteBuffer portInfo > =response.getAllServicesMetaData().get(conf.get(TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID,TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID_DEFAULT)); > - Could be split into multiple calls, in case there's a possibility of a NPE. > - TestShuffleHandlerJobs. Parameter name mrrTez - should really be tez*. > - Variable renames. pendingInputsOfOnePartition is no longer a valid name. > - InputHost.clearAndGetOnePartition - rename. This is no longer giving back a > single partition only. > - pendingInputsOfOnePartition - name is likely not valid any longer -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles updated TEZ-3684: - Attachment: TEZ-3684.1.patch > Incorporate first pass non-essential TEZ-3334 pre-merge feedback > > > Key: TEZ-3684 > URL: https://issues.apache.org/jira/browse/TEZ-3684 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3684.1.patch > > > Incorporates this feedback from TEZ-3334 > https://issues.apache.org/jira/browse/TEZ-3334?focusedCommentId=15950550=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15950550 > - TezContainerLauncherImpl - ByteBuffer portInfo > =response.getAllServicesMetaData().get(conf.get(TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID,TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID_DEFAULT)); > - Could be split into multiple calls, in case there's a possibility of a NPE. > - TestShuffleHandlerJobs. Parameter name mrrTez - should really be tez*. > - Variable renames. pendingInputsOfOnePartition is no longer a valid name. > - InputHost.clearAndGetOnePartition - rename. This is no longer giving back a > single partition only. > - pendingInputsOfOnePartition - name is likely not valid any longer -- This message was sent by Atlassian JIRA (v6.3.15#6346)
