[GitHub] dangogh commented on a change in pull request #2673: adds a simple PR template

[GitBox]

dangogh commented on a change in pull request #2673: adds a simple PR template
URL: https://github.com/apache/trafficcontrol/pull/2673#discussion_r209819601
 
 

 ##
 File path: PULL_REQUEST_TEMPLATE.md
 ##
 @@ -0,0 +1,27 @@
+ What does this PR do?
+
+Fixes #(issue_number)
+
+ Which TC components are affected by this PR?
+
+- [ ] Grove
+- [ ] Traffic Analytics
+- [ ] Traffic Monitor
+- [ ] Traffic Ops
+- [ ] Traffic Ops ORT
+- [ ] Traffic Portal
+- [ ] Traffic Router
+- [ ] Traffic Stats
+- [ ] Traffic Vault
+- [ ] Other _
+
+ What is the best way to verify this PR?
+
+
+ Check any that apply
+
+- [ ] This PR does *NOT* fix a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
+- [ ] This PR includes tests
+- [ ] This PR includes documentation updates
+- [ ] This PR includes an update to CHANGELOG.md
+
 
 Review comment:
   does it need to mention newly introduced files that require a license header 
(like this one?) :-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR-rat #1517

[Apache Jenkins Server]

See 

--
Started by upstream project "trafficcontrol-PR" build number 2254
originally caused by:
 GitHub pull request #2673 of commit 48debc81ad8d9f500f5e9f63fcffd836bb03f016, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H29 (ubuntu xenial) in workspace 

[trafficcontrol-PR-rat] $ /bin/bash -xe /tmp/jenkins7914507528161801808.sh
+ rm -rf 

 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of trafficcontrol-PR
[operations-center-context] Copied 2 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-3.0.0-docs.tar.gz
[operations-center-context]   apache-trafficcontrol-3.0.0.tar.gz
[trafficcontrol-PR-rat] $ /bin/bash -xe /tmp/jenkins7192518806662576750.sh
+ set -exu
++ grep -v docs
++ ls apache-trafficcontrol-3.0.0-docs.tar.gz apache-trafficcontrol-3.0.0.tar.gz
+ tarball=apache-trafficcontrol-3.0.0.tar.gz
+ tar xzf apache-trafficcontrol-3.0.0.tar.gz
++ pwd
++ basename apache-trafficcontrol-3.0.0.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ grep -ve md5 -e sha1
++ sort -r
++ cut -d / -f 12
++ awk -F '"' '{print $2}'
++ head -n 1
+ ratver=apache-rat-0.13-20180723.191718-104.jar
++ mktemp -d
+ ratdir=/tmp/tmp.wlXeq77ERA
+ ratjar=/tmp/tmp.wlXeq77ERA/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.wlXeq77ERA/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180723.191718-104.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0 93 
1587k   93 1488k0 0  1446k  0  0:00:01  0:00:01 --:--:-- 1446k100 
1587k  100 1587k0 0  1541k  0  0:00:01  0:00:01 --:--:-- 1541k
+ curl -L -o /tmp/tmp.wlXeq77ERA/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180723.191718-104.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
010040  100400 0 74  0 --:--:-- --:--:-- --:--:--74
++ sha1sum /tmp/tmp.wlXeq77ERA/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.wlXeq77ERA/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 946deda5bffb3869b9984135ed5c17c1810181cb == 
946deda5bffb3869b9984135ed5c17c1810181cb ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.wlXeq77ERA/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.wlXeq77ERA
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=1
+ [[ 1 != 0 ]]
+ echo '1 Unknown Licenses'
1 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  apache-trafficcontrol-3.0.0/PULL_REQUEST_TEMPLATE.md

*
+ exit 1
Build step 'Execute shell' marked build as failure
Archiving artifacts
[Fast Archiver] Compressed 446.47 KB of artifacts by 71.7% relative to #1516

[GitHub] asfgit commented on issue #2673: adds a simple PR template

[GitBox]

asfgit commented on issue #2673: adds a simple PR template
URL: https://github.com/apache/trafficcontrol/pull/2673#issuecomment-412735203
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2254/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-PR #2254

[Apache Jenkins Server]

See 

Build failed in Jenkins: trafficcontrol-PR #2252

[Apache Jenkins Server]

See 


Changes:

[Rawlin.Peters] fix origin api tests -- add a tenantId

[Rawlin.Peters] add not null constraint to deep_caching_type

[jeffrey_elsloo] Initial commit for upgrading TR from Tomcat 6.0.33 to tomcat 
8.5.15

[jeffrey_elsloo] changes to support an OpenSSL Implementation

[jeffrey_elsloo] Added bouncy castle provider to help convert PKCS1 keys to 
PKCS8. 

[jeffrey_elsloo] cleaned up PMD warnings

[jeffrey_elsloo] fixed typo in log statement

[jeffrey_elsloo] Changed TR Software Requirements to Java 8

[jeffrey_elsloo] Initial commit for upgrading TR from Tomcat 6.0.33 to tomcat 
8.5.15

[jeffrey_elsloo] changes to support an OpenSSL Implementation

[jeffrey_elsloo] Added bouncy castle provider to help convert PKCS1 keys to 
PKCS8. 

[jeffrey_elsloo] Changed TR Software Requirements to Java 8

[jeffrey_elsloo] fixed broken lookups for ~/build/pmd/ruleset.xml

[jeffrey_elsloo] changed war name to traffic_router_core and assinged to ROOT 
context

[jeffrey_elsloo] Integrated TR with OpenSSL and tcNative and adjusted test 
cases.

[jeffrey_elsloo] reorganized for deployment to CATALINA_BASE 
'/opt/traffic_router'

[jeffrey_elsloo] fixed tomcat-tr dependency in traffic_router build

[jeffrey_elsloo] Moved common classes from core/jdnssec to shared

[jeffrey_elsloo] updated traffic_router docs for the Tomcat/OpenSSL upgrade.

[jeffrey_elsloo] addded tomcat_tr module for building Tomcat RPM

[jeffrey_elsloo] fixed tomcat_tr dependency in traffic_router build

[jeffrey_elsloo] Added tomcat_tr to the Docker build

[jeffrey_elsloo] added versions to rpm dependencies

[jeffrey_elsloo] changed core artifact to ROOT

[jeffrey_elsloo] updated logging to match previous version

[jeffrey_elsloo] Moved tomcat_tr to traffic_router/tomcat-rpm and fixed

[jeffrey_elsloo] moved tomcat_tr to traffic_router/tomcat-rpm

[jeffrey_elsloo] fixed build number on tomcat rpm

[jeffrey_elsloo] added rpm update ability and support for CentOS6

[jeffrey_elsloo] restored ROOT.war dependency in pom.xml

[jeffrey_elsloo] added rpm update ability and support for CentOS6 to the 
tomcat-rpm

[jeffrey_elsloo] Corrected documentation per some recent changes

[jeffrey_elsloo] fixed a couple of small bugs in the buildRpm for tr and tomcat

[jeffrey_elsloo] Updated Docs to match Traffic Router 2.3

[jeffrey_elsloo] temporarily updated version to 2.3.1 for integration testing 
purposes

[jeffrey_elsloo] fixed quote syntax in document traffic_router/migration2-3.repo

[jeffrey_elsloo] temporarily upgraded to tr 2.3.1 and moved obsoletes to tr 
instead of

[jeffrey_elsloo] temporarily upgraded to tr 2.3.1 and moved obsoletes to tr 
instead of

[jeffrey_elsloo] temporarily upgraded to tr 2.3.1 and moved obsoletes to tr 
instead of

[jeffrey_elsloo] upgrade to tomcat 8.5.29

[jeffrey_elsloo] upgrade to tomcat 8.5.30 and fixed some edge cases in the rpm 
deploy

[jeffrey_elsloo] fixed some edge cases in the rpm deploy

[jeffrey_elsloo] fixed some edge cases in the rpm deploy

[jeffrey_elsloo] correct merge mistake in RouterSslImplementationTest

[jeffrey_elsloo] Tomcat 8.5.x branch cleanup.

[jeffrey_elsloo] Updated the documentation to reference version 3.0

[jeffrey_elsloo] Added Apache License header to tomcat.service and tomcat.spec

[jeffrey_elsloo] moved java command line props to startup.properties

[jeffrey_elsloo] fixed bug in server.xml overrides in RouterNioEndpoint

[jeffrey_elsloo] changed build to preserve the systemctl unit file on the 
server if one

[jeffrey_elsloo] Changed default config files to match production settings

[jeffrey_elsloo] modified build process to lock the dependency between the

[jeffrey_elsloo] Changed default config files to match production settings

[jeffrey_elsloo] updated to tomcat 8.5.32

[jeffrey_elsloo] Restored VERSION file

[mitchell852] adds a simple PR template

--
[...truncated 21.04 MB...]
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.2 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.0 
traffic_portal_build_1   | | +-- ajv@5.5.2 
traffic_portal_build_1   | | | +-- co@4.6.0 
traffic_portal_build_1   | | | +-- fast-deep-equal@1.1.0 
traffic_portal_build_1   | | | +-- fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | `-- json-schema-traverse@0.3.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- 

[GitHub] asfgit commented on issue #2673: adds a simple PR template

[GitBox]

asfgit commented on issue #2673: adds a simple PR template
URL: https://github.com/apache/trafficcontrol/pull/2673#issuecomment-412731254
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2253/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #2253

[Apache Jenkins Server]

See 

--
GitHub pull request #2673 of commit 88385511e7c5a4685b0965e3683a0f1c7b67fdd3, 
no merge conflicts.
Setting status of 88385511e7c5a4685b0965e3683a0f1c7b67fdd3 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/2253/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H27 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 88385511e7c5a4685b0965e3683a0f1c7b67fdd3^{commit} # timeout=10
 > git rev-parse origin/88385511e7c5a4685b0965e3683a0f1c7b67fdd3^{commit} # 
 > timeout=10
 > git rev-parse 88385511e7c5a4685b0965e3683a0f1c7b67fdd3^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 88385511e7c5a4685b0965e3683a0f1c7b67fdd3^{commit} # timeout=10
 > git rev-parse origin/88385511e7c5a4685b0965e3683a0f1c7b67fdd3^{commit} # 
 > timeout=10
 > git rev-parse 88385511e7c5a4685b0965e3683a0f1c7b67fdd3^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 88385511e7c5a4685b0965e3683a0f1c7b67fdd3^{commit} # timeout=10
 > git rev-parse origin/88385511e7c5a4685b0965e3683a0f1c7b67fdd3^{commit} # 
 > timeout=10
 > git rev-parse 88385511e7c5a4685b0965e3683a0f1c7b67fdd3^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Skipped archiving because build is not successful

[GitHub] asfgit commented on issue #2673: adds a simple PR template

[GitBox]

asfgit commented on issue #2673: adds a simple PR template
URL: https://github.com/apache/trafficcontrol/pull/2673#issuecomment-412731155
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2252/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #2251

[Apache Jenkins Server]

See 

--
GitHub pull request #2673 of commit e16901de1a547384a1b9a71ebc02546e82d46209, 
no merge conflicts.
Setting status of e16901de1a547384a1b9a71ebc02546e82d46209 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/2251/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H21 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse e16901de1a547384a1b9a71ebc02546e82d46209^{commit} # timeout=10
 > git rev-parse origin/e16901de1a547384a1b9a71ebc02546e82d46209^{commit} # 
 > timeout=10
 > git rev-parse e16901de1a547384a1b9a71ebc02546e82d46209^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse e16901de1a547384a1b9a71ebc02546e82d46209^{commit} # timeout=10
 > git rev-parse origin/e16901de1a547384a1b9a71ebc02546e82d46209^{commit} # 
 > timeout=10
 > git rev-parse e16901de1a547384a1b9a71ebc02546e82d46209^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse e16901de1a547384a1b9a71ebc02546e82d46209^{commit} # timeout=10
 > git rev-parse origin/e16901de1a547384a1b9a71ebc02546e82d46209^{commit} # 
 > timeout=10
 > git rev-parse e16901de1a547384a1b9a71ebc02546e82d46209^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Skipped archiving because build is not successful

[GitHub] asfgit commented on issue #2673: adds a simple PR template

[GitBox]

asfgit commented on issue #2673: adds a simple PR template
URL: https://github.com/apache/trafficcontrol/pull/2673#issuecomment-412727546
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2251/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 opened a new pull request #2673: adds a simple PR template

[GitBox]

mitchell852 opened a new pull request #2673: adds a simple PR template
URL: https://github.com/apache/trafficcontrol/pull/2673
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

[GitBox]

mitchell852 commented on a change in pull request #2665: Add TO old UI 
deprecation bar
URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209806785
 
 

 ##
 File path: traffic_ops/app/conf/cdn.conf
 ##
 @@ -43,6 +43,7 @@
 },
 "portal" : {
 "base_url" : "http://localhost:8080/!#/;,
+"external_url" : 
"https://traffic-control-cdn.readthedocs.io/en/latest/overview/traffic_portal.html;,
 
 Review comment:
   base_url is the url where TP is running. by default, it would typically be 
running on localhost in a dev enviro, but this will always be changed in a prod 
enviro to something like tp.cdn.com/!#/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #856

[Apache Jenkins Server]

See 


Changes:

[jeffrey_elsloo] Initial commit for upgrading TR from Tomcat 6.0.33 to tomcat 
8.5.15

[jeffrey_elsloo] changes to support an OpenSSL Implementation

[jeffrey_elsloo] Added bouncy castle provider to help convert PKCS1 keys to 
PKCS8. 

[jeffrey_elsloo] cleaned up PMD warnings

[jeffrey_elsloo] fixed typo in log statement

[jeffrey_elsloo] Changed TR Software Requirements to Java 8

[jeffrey_elsloo] Initial commit for upgrading TR from Tomcat 6.0.33 to tomcat 
8.5.15

[jeffrey_elsloo] changes to support an OpenSSL Implementation

[jeffrey_elsloo] Added bouncy castle provider to help convert PKCS1 keys to 
PKCS8. 

[jeffrey_elsloo] Changed TR Software Requirements to Java 8

[jeffrey_elsloo] fixed broken lookups for ~/build/pmd/ruleset.xml

[jeffrey_elsloo] changed war name to traffic_router_core and assinged to ROOT 
context

[jeffrey_elsloo] Integrated TR with OpenSSL and tcNative and adjusted test 
cases.

[jeffrey_elsloo] reorganized for deployment to CATALINA_BASE 
'/opt/traffic_router'

[jeffrey_elsloo] fixed tomcat-tr dependency in traffic_router build

[jeffrey_elsloo] Moved common classes from core/jdnssec to shared

[jeffrey_elsloo] updated traffic_router docs for the Tomcat/OpenSSL upgrade.

[jeffrey_elsloo] addded tomcat_tr module for building Tomcat RPM

[jeffrey_elsloo] fixed tomcat_tr dependency in traffic_router build

[jeffrey_elsloo] Added tomcat_tr to the Docker build

[jeffrey_elsloo] added versions to rpm dependencies

[jeffrey_elsloo] changed core artifact to ROOT

[jeffrey_elsloo] updated logging to match previous version

[jeffrey_elsloo] Moved tomcat_tr to traffic_router/tomcat-rpm and fixed

[jeffrey_elsloo] moved tomcat_tr to traffic_router/tomcat-rpm

[jeffrey_elsloo] fixed build number on tomcat rpm

[jeffrey_elsloo] added rpm update ability and support for CentOS6

[jeffrey_elsloo] restored ROOT.war dependency in pom.xml

[jeffrey_elsloo] added rpm update ability and support for CentOS6 to the 
tomcat-rpm

[jeffrey_elsloo] Corrected documentation per some recent changes

[jeffrey_elsloo] fixed a couple of small bugs in the buildRpm for tr and tomcat

[jeffrey_elsloo] Updated Docs to match Traffic Router 2.3

[jeffrey_elsloo] temporarily updated version to 2.3.1 for integration testing 
purposes

[jeffrey_elsloo] fixed quote syntax in document traffic_router/migration2-3.repo

[jeffrey_elsloo] temporarily upgraded to tr 2.3.1 and moved obsoletes to tr 
instead of

[jeffrey_elsloo] temporarily upgraded to tr 2.3.1 and moved obsoletes to tr 
instead of

[jeffrey_elsloo] temporarily upgraded to tr 2.3.1 and moved obsoletes to tr 
instead of

[jeffrey_elsloo] upgrade to tomcat 8.5.29

[jeffrey_elsloo] upgrade to tomcat 8.5.30 and fixed some edge cases in the rpm 
deploy

[jeffrey_elsloo] fixed some edge cases in the rpm deploy

[jeffrey_elsloo] fixed some edge cases in the rpm deploy

[jeffrey_elsloo] correct merge mistake in RouterSslImplementationTest

[jeffrey_elsloo] Tomcat 8.5.x branch cleanup.

[jeffrey_elsloo] Updated the documentation to reference version 3.0

[jeffrey_elsloo] Added Apache License header to tomcat.service and tomcat.spec

[jeffrey_elsloo] moved java command line props to startup.properties

[jeffrey_elsloo] fixed bug in server.xml overrides in RouterNioEndpoint

[jeffrey_elsloo] changed build to preserve the systemctl unit file on the 
server if one

[jeffrey_elsloo] Changed default config files to match production settings

[jeffrey_elsloo] modified build process to lock the dependency between the

[jeffrey_elsloo] Changed default config files to match production settings

[jeffrey_elsloo] updated to tomcat 8.5.32

[jeffrey_elsloo] Restored VERSION file

--
[...truncated 106.04 KB...]
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api 0.011s  
coverage: 44.6% of statements
unit_golang_1  | ?  
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/apiriak [no 
test files]
unit_golang_1  | === RUN   TestGetASNs
unit_golang_1  | --- PASS: TestGetASNs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 19.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/asn 0.011s  
coverage: 19.9% of statements
unit_golang_1  | === RUN   TestGetConfigFile
unit_golang_1  | --- PASS: TestGetConfigFile (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 100.0% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/ats 0.035s  
coverage: 100.0% of statements
unit_golang_1  | === RUN   TestDeriveGoodPassword
unit_golang_1  | --- PASS: TestDeriveGoodPassword (0.35s)

Build failed in Jenkins: trafficcontrol-traffic_ops-test #855

[Apache Jenkins Server]

See 


Changes:

[Rawlin.Peters] add not null constraint to deep_caching_type

--
[...truncated 104.40 KB...]
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api 0.008s  
coverage: 44.6% of statements
unit_golang_1  | ?  
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/apiriak [no 
test files]
unit_golang_1  | === RUN   TestGetASNs
unit_golang_1  | --- PASS: TestGetASNs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 19.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/asn 0.017s  
coverage: 19.9% of statements
unit_golang_1  | === RUN   TestGetConfigFile
unit_golang_1  | --- PASS: TestGetConfigFile (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 100.0% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/ats 0.026s  
coverage: 100.0% of statements
unit_golang_1  | === RUN   TestDeriveGoodPassword
unit_golang_1  | --- PASS: TestDeriveGoodPassword (0.42s)
unit_golang_1  | === RUN   TestDeriveBadPassword
unit_golang_1  | --- PASS: TestDeriveBadPassword (0.23s)
unit_golang_1  | === RUN   TestScryptPasswordIsRequired
unit_golang_1  | --- PASS: TestScryptPasswordIsRequired (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 32.8% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth0.669s  
coverage: 32.8% of statements
unit_golang_1  | === RUN   TestReadCacheGroups
unit_golang_1  | --- PASS: TestReadCacheGroups (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 13.6% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cachegroup  
0.008s  coverage: 13.6% of statements
unit_golang_1  | === RUN   TestReadCDNs
unit_golang_1  | --- PASS: TestReadCDNs (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 11.8% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cdn 0.008s  
coverage: 11.8% of statements
unit_golang_1  | ?  
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cdnfederation   
[no test files]
unit_golang_1  | === RUN   TestLogLocation
unit_golang_1  | --- PASS: TestLogLocation (0.00s)
unit_golang_1  | === RUN   TestLoadConfig
unit_golang_1  | --- PASS: TestLoadConfig (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 67.6% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/config  0.012s  
coverage: 67.6% of statements
unit_golang_1  | === RUN   TestReadCoordinates
unit_golang_1  | --- PASS: TestReadCoordinates (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 33.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/coordinate  
0.016s  coverage: 33.9% of statements
unit_golang_1  | FAIL   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/crconfig [build 
failed]
unit_golang_1  | === RUN   TestBuildQuery
unit_golang_1  | --- PASS: TestBuildQuery (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 29.0% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers   
0.026s  coverage: 29.0% of statements
unit_golang_1  | === RUN   TestVerifyAndEncodeCertificate
unit_golang_1  | --- PASS: TestVerifyAndEncodeCertificate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 2.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice 
0.011s  coverage: 2.9% of statements
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestGetDeliveryServiceRequest
unit_golang_1  | --- PASS: TestGetDeliveryServiceRequest 

[GitHub] rawlinp closed pull request #2672: TO Go: add not null constraint to deep_caching_type

[GitBox]

rawlinp closed pull request #2672: TO Go: add not null constraint to 
deep_caching_type
URL: https://github.com/apache/trafficcontrol/pull/2672
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/app/db/patches.sql b/traffic_ops/app/db/patches.sql
index a72cd72e0..b7d892d1a 100644
--- a/traffic_ops/app/db/patches.sql
+++ b/traffic_ops/app/db/patches.sql
@@ -72,3 +72,7 @@ ALTER TABLE deliveryservice ALTER COLUMN tenant_id SET NOT 
NULL;
 ALTER TABLE origin ALTER COLUMN tenant SET NOT NULL;
 -- get rid of the use_tenancy flag
 DELETE FROM parameter WHERE name = 'use_tenancy' AND config_file = 'global';
+
+-- never allow deep_caching_type to be NULL
+UPDATE deliveryservice SET deep_caching_type = 'NEVER' WHERE deep_caching_type 
IS NULL;
+ALTER TABLE deliveryservice ALTER COLUMN deep_caching_type SET NOT NULL;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2672: TO Go: add not null constraint to deep_caching_type

[GitBox]

asfgit commented on issue #2672: TO Go: add not null constraint to 
deep_caching_type
URL: https://github.com/apache/trafficcontrol/pull/2672#issuecomment-412701165
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2250/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new pull request #2672: TO Go: add not null constraint to deep_caching_type

[GitBox]

dangogh opened a new pull request #2672: TO Go: add not null constraint to 
deep_caching_type
URL: https://github.com/apache/trafficcontrol/pull/2672
 
 
   related to #2654 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #854

[Apache Jenkins Server]

See 


Changes:

[Rawlin.Peters] fix origin api tests -- add a tenantId

--
[...truncated 104.23 KB...]
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api 0.009s  
coverage: 44.6% of statements
unit_golang_1  | ?  
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/apiriak [no 
test files]
unit_golang_1  | === RUN   TestGetASNs
unit_golang_1  | --- PASS: TestGetASNs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 19.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/asn 0.017s  
coverage: 19.9% of statements
unit_golang_1  | === RUN   TestGetConfigFile
unit_golang_1  | --- PASS: TestGetConfigFile (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 100.0% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/ats 0.005s  
coverage: 100.0% of statements
unit_golang_1  | === RUN   TestDeriveGoodPassword
unit_golang_1  | --- PASS: TestDeriveGoodPassword (0.34s)
unit_golang_1  | === RUN   TestDeriveBadPassword
unit_golang_1  | --- PASS: TestDeriveBadPassword (0.21s)
unit_golang_1  | === RUN   TestScryptPasswordIsRequired
unit_golang_1  | --- PASS: TestScryptPasswordIsRequired (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 32.8% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth0.573s  
coverage: 32.8% of statements
unit_golang_1  | === RUN   TestReadCacheGroups
unit_golang_1  | --- PASS: TestReadCacheGroups (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 13.6% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cachegroup  
0.009s  coverage: 13.6% of statements
unit_golang_1  | === RUN   TestReadCDNs
unit_golang_1  | --- PASS: TestReadCDNs (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 11.8% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cdn 0.009s  
coverage: 11.8% of statements
unit_golang_1  | ?  
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cdnfederation   
[no test files]
unit_golang_1  | === RUN   TestLogLocation
unit_golang_1  | --- PASS: TestLogLocation (0.00s)
unit_golang_1  | === RUN   TestLoadConfig
unit_golang_1  | --- PASS: TestLoadConfig (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 67.6% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/config  0.021s  
coverage: 67.6% of statements
unit_golang_1  | === RUN   TestReadCoordinates
unit_golang_1  | --- PASS: TestReadCoordinates (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 33.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/coordinate  
0.014s  coverage: 33.9% of statements
unit_golang_1  | FAIL   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/crconfig [build 
failed]
unit_golang_1  | === RUN   TestBuildQuery
unit_golang_1  | --- PASS: TestBuildQuery (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 29.0% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers   
0.022s  coverage: 29.0% of statements
unit_golang_1  | === RUN   TestVerifyAndEncodeCertificate
unit_golang_1  | --- PASS: TestVerifyAndEncodeCertificate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 2.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice 
0.012s  coverage: 2.9% of statements
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestGetDeliveryServiceRequest
unit_golang_1  | --- PASS: TestGetDeliveryServiceRequest (0.00s)

[GitHub] asfgit commented on issue #2671: TO Go API: fix origin api tests -- add a tenantId

[GitBox]

asfgit commented on issue #2671: TO Go API: fix origin api tests -- add a 
tenantId
URL: https://github.com/apache/trafficcontrol/pull/2671#issuecomment-412696687
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2249/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp closed pull request #2671: TO Go API: fix origin api tests -- add a tenantId

[GitBox]

rawlinp closed pull request #2671: TO Go API: fix origin api tests -- add a 
tenantId
URL: https://github.com/apache/trafficcontrol/pull/2671
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/testing/api/v13/tc-fixtures.json 
b/traffic_ops/testing/api/v13/tc-fixtures.json
index 7cd85aaca..870021a08 100644
--- a/traffic_ops/testing/api/v13/tc-fixtures.json
+++ b/traffic_ops/testing/api/v13/tc-fixtures.json
@@ -351,7 +351,8 @@
 "ipAddress": "1.2.3.4",
 "ip6Address": "dead:beef:cafe::42",
 "port": 1234,
-"protocol": "http"
+"protocol": "http",
+"tenantId": 2
 },
 {
 "name": "origin2",
@@ -359,7 +360,8 @@
 "ipAddress": "5.6.7.8",
 "ip6Address": "cafe::42",
 "port": 5678,
-"protocol": "https"
+"protocol": "https",
+"tenantId": 2
 }
 ],
 "parameters": [


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new pull request #2671: TO Go API: fix origin api tests -- add a tenantId

[GitBox]

dangogh opened a new pull request #2671: TO Go API: fix origin api tests -- add 
a tenantId
URL: https://github.com/apache/trafficcontrol/pull/2671
 
 
   api test for origins is missing tenant id which causes it to fail on the new 
not-null db constraint.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #853

[Apache Jenkins Server]

See 


Changes:

[rob05c] properly handle db timeouts in when checking user during authorization

--
[...truncated 104.38 KB...]
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api 0.026s  
coverage: 44.6% of statements
unit_golang_1  | ?  
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/apiriak [no 
test files]
unit_golang_1  | === RUN   TestGetASNs
unit_golang_1  | --- PASS: TestGetASNs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 19.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/asn 0.010s  
coverage: 19.9% of statements
unit_golang_1  | === RUN   TestGetConfigFile
unit_golang_1  | --- PASS: TestGetConfigFile (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 100.0% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/ats 0.005s  
coverage: 100.0% of statements
unit_golang_1  | === RUN   TestDeriveGoodPassword
unit_golang_1  | --- PASS: TestDeriveGoodPassword (0.27s)
unit_golang_1  | === RUN   TestDeriveBadPassword
unit_golang_1  | --- PASS: TestDeriveBadPassword (0.27s)
unit_golang_1  | === RUN   TestScryptPasswordIsRequired
unit_golang_1  | --- PASS: TestScryptPasswordIsRequired (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 32.8% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth0.558s  
coverage: 32.8% of statements
unit_golang_1  | === RUN   TestReadCacheGroups
unit_golang_1  | --- PASS: TestReadCacheGroups (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 13.6% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cachegroup  
0.018s  coverage: 13.6% of statements
unit_golang_1  | === RUN   TestReadCDNs
unit_golang_1  | --- PASS: TestReadCDNs (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 11.8% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cdn 0.009s  
coverage: 11.8% of statements
unit_golang_1  | ?  
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cdnfederation   
[no test files]
unit_golang_1  | === RUN   TestLogLocation
unit_golang_1  | --- PASS: TestLogLocation (0.00s)
unit_golang_1  | === RUN   TestLoadConfig
unit_golang_1  | --- PASS: TestLoadConfig (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 67.6% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/config  0.048s  
coverage: 67.6% of statements
unit_golang_1  | === RUN   TestReadCoordinates
unit_golang_1  | --- PASS: TestReadCoordinates (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 33.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/coordinate  
0.010s  coverage: 33.9% of statements
unit_golang_1  | FAIL   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/crconfig [build 
failed]
unit_golang_1  | === RUN   TestBuildQuery
unit_golang_1  | --- PASS: TestBuildQuery (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 29.0% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers   
0.009s  coverage: 29.0% of statements
unit_golang_1  | === RUN   TestVerifyAndEncodeCertificate
unit_golang_1  | --- PASS: TestVerifyAndEncodeCertificate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 2.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice 
0.013s  coverage: 2.9% of statements
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestGetDeliveryServiceRequest
unit_golang_1  | --- PASS: 

[GitHub] rob05c commented on issue #2656: properly handle db timeouts in when checking user during authorization

[GitBox]

rob05c commented on issue #2656: properly handle db timeouts in when checking 
user during authorization
URL: https://github.com/apache/trafficcontrol/pull/2656#issuecomment-412685361
 
 
   Tested, works.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization

[GitBox]

asfgit commented on issue #2656: properly handle db timeouts in when checking 
user during authorization
URL: https://github.com/apache/trafficcontrol/pull/2656#issuecomment-412683290
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2248/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #852

[Apache Jenkins Server]

See 


Changes:

[mitchell852] Update version of Traffic Control to 3.0.0.

--
[...truncated 104.50 KB...]
unit_golang_1  | coverage: 44.6% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api 0.019s  
coverage: 44.6% of statements
unit_golang_1  | ?  
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/apiriak [no 
test files]
unit_golang_1  | === RUN   TestGetASNs
unit_golang_1  | --- PASS: TestGetASNs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 19.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/asn 0.010s  
coverage: 19.9% of statements
unit_golang_1  | === RUN   TestGetConfigFile
unit_golang_1  | --- PASS: TestGetConfigFile (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 100.0% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/ats 0.003s  
coverage: 100.0% of statements
unit_golang_1  | === RUN   TestDeriveGoodPassword
unit_golang_1  | --- PASS: TestDeriveGoodPassword (0.32s)
unit_golang_1  | === RUN   TestDeriveBadPassword
unit_golang_1  | --- PASS: TestDeriveBadPassword (0.25s)
unit_golang_1  | === RUN   TestScryptPasswordIsRequired
unit_golang_1  | --- PASS: TestScryptPasswordIsRequired (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 27.3% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth0.590s  
coverage: 27.3% of statements
unit_golang_1  | === RUN   TestReadCacheGroups
unit_golang_1  | --- PASS: TestReadCacheGroups (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 13.6% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cachegroup  
0.009s  coverage: 13.6% of statements
unit_golang_1  | === RUN   TestReadCDNs
unit_golang_1  | --- PASS: TestReadCDNs (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 11.8% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cdn 0.007s  
coverage: 11.8% of statements
unit_golang_1  | ?  
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/cdnfederation   
[no test files]
unit_golang_1  | === RUN   TestLogLocation
unit_golang_1  | --- PASS: TestLogLocation (0.00s)
unit_golang_1  | === RUN   TestLoadConfig
unit_golang_1  | --- PASS: TestLoadConfig (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 67.6% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/config  0.013s  
coverage: 67.6% of statements
unit_golang_1  | === RUN   TestReadCoordinates
unit_golang_1  | --- PASS: TestReadCoordinates (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 33.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/coordinate  
0.014s  coverage: 33.9% of statements
unit_golang_1  | FAIL   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/crconfig [build 
failed]
unit_golang_1  | === RUN   TestBuildQuery
unit_golang_1  | --- PASS: TestBuildQuery (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 29.0% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers   
0.015s  coverage: 29.0% of statements
unit_golang_1  | === RUN   TestVerifyAndEncodeCertificate
unit_golang_1  | --- PASS: TestVerifyAndEncodeCertificate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 2.9% of statements
unit_golang_1  | ok 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice 
0.015s  coverage: 2.9% of statements
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestGetDeliveryServiceRequest
unit_golang_1  | 

[GitHub] mitchell852 closed pull request #2660: Update version of Traffic Control to 3.0.0.

[GitBox]

mitchell852 closed pull request #2660: Update version of Traffic Control to 
3.0.0.
URL: https://github.com/apache/trafficcontrol/pull/2660
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/VERSION b/VERSION
index 276cbf9e2..4a36342fc 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.3.0
+3.0.0


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2660: Update version of Traffic Control to 3.0.0.

[GitBox]

asfgit commented on issue #2660: Update version of Traffic Control to 3.0.0.
URL: https://github.com/apache/trafficcontrol/pull/2660#issuecomment-412677518
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2247/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2659: Add Monitor poll plugins

[GitBox]

rob05c commented on issue #2659: Add Monitor poll plugins
URL: https://github.com/apache/trafficcontrol/pull/2659#issuecomment-412674113
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #1301: Manage delivery service static dns entries

[GitBox]

mitchell852 commented on issue #1301: Manage delivery service static dns entries
URL: https://github.com/apache/trafficcontrol/issues/1301#issuecomment-412672217
 
 
   this is all done and merged


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed issue #1301: Manage delivery service static dns entries

[GitBox]

mitchell852 closed issue #1301: Manage delivery service static dns entries
URL: https://github.com/apache/trafficcontrol/issues/1301
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2660: Update version of Traffic Control to 3.0.0.

[GitBox]

asfgit commented on issue #2660: Update version of Traffic Control to 3.0.0.
URL: https://github.com/apache/trafficcontrol/pull/2660#issuecomment-412670177
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2246/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #2246

[Apache Jenkins Server]

See 


Changes:

[jeffrey_elsloo] Update version of Traffic Control to 3.0.0.

--
[...truncated 20.50 MB...]
traffic_portal_build_1   | | | |   +-- jsonify@0.0.0 
traffic_portal_build_1   | | | |   +-- resumer@0.0.0 
traffic_portal_build_1   | | | |   `-- through@2.3.8 
traffic_portal_build_1   | | | `-- strip-json-comments@0.1.3 
traffic_portal_build_1   | | +-- timespan@2.3.0 
traffic_portal_build_1   | | +-- utile@0.2.1 
traffic_portal_build_1   | | | +-- async@0.2.10 
traffic_portal_build_1   | | | +-- deep-equal@1.0.1 
traffic_portal_build_1   | | | +-- i@0.3.6 
traffic_portal_build_1   | | | +-- mkdirp@0.5.1 
traffic_portal_build_1   | | | | `-- minimist@0.0.8 
traffic_portal_build_1   | | | +-- ncp@0.4.2 
traffic_portal_build_1   | | | `-- rimraf@2.6.2 
traffic_portal_build_1   | | |   `-- glob@7.1.2 
traffic_portal_build_1   | | | +-- fs.realpath@1.0.0 
traffic_portal_build_1   | | | +-- inflight@1.0.6 
traffic_portal_build_1   | | | | `-- wrappy@1.0.2 
traffic_portal_build_1   | | | `-- once@1.4.0 
traffic_portal_build_1   | | `-- winston@0.8.3 
traffic_portal_build_1   | |   +-- cycle@1.0.3 
traffic_portal_build_1   | |   +-- isstream@0.1.2 
traffic_portal_build_1   | |   +-- pkginfo@0.3.1 
traffic_portal_build_1   | |   `-- stack-trace@0.0.10 
traffic_portal_build_1   | +-- morgan@1.7.0 
traffic_portal_build_1   | | `-- basic-auth@1.0.4 
traffic_portal_build_1   | +-- requirejs@2.1.22 
traffic_portal_build_1   | `-- ssl-root-cas@1.1.10 
traffic_portal_build_1   |   +-- es6-promise@2.3.0 
traffic_portal_build_1   |   `-- request@2.88.0 
traffic_portal_build_1   | +-- aws-sign2@0.7.0 
traffic_portal_build_1   | +-- aws4@1.8.0 
traffic_portal_build_1   | +-- caseless@0.12.0 
traffic_portal_build_1   | +-- combined-stream@1.0.6 
traffic_portal_build_1   | | `-- delayed-stream@1.0.0 
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.2 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.0 
traffic_portal_build_1   | | +-- ajv@5.5.2 
traffic_portal_build_1   | | | +-- co@4.6.0 
traffic_portal_build_1   | | | +-- fast-deep-equal@1.1.0 
traffic_portal_build_1   | | | +-- fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | `-- json-schema-traverse@0.3.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.14.2 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   +-- safer-buffer@2.1.2 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- safe-buffer@5.1.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.1.29 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.2 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL DEPENDENCY: 
fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: 
Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} 
(current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done, without errors.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2018-08-13 21:24:53 UTC)
traffic_portal_build_1   | loading tasks  1.1s  ▇▇ 4%
traffic_portal_build_1   | compass:prod 8s  
▇▇▇▇▇▇▇▇▇ 28%
traffic_portal_build_1   | 

[GitHub] dewrich opened a new issue #2670: /api/1.3/servers error - "getting servers: sql: Rows are closed"

[GitBox]

dewrich opened a new issue #2670: /api/1.3/servers error - "getting servers: 
sql: Rows are closed"
URL: https://github.com/apache/trafficcontrol/issues/2670
 
 
   `/api/1.3/servers` returning alert error
   
   ```{
   alerts: [
   {
   text: "getting servers: sql: Rows are closed",
   level: "error"
   }
   ]
   }```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #851

[Apache Jenkins Server]

See 


Changes:

[dylan.volz] Fix TO Go endpoints to use tx

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-4 (ubuntu trusty) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision a5442bddb0323db7ef48b9e64e9b77026701f904 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f a5442bddb0323db7ef48b9e64e9b77026701f904
Commit message: "Fix TO Go endpoints to use tx"
 > git rev-list --no-walk 898667c7e9744c6ed1446efc74f1974d07885108 # timeout=10
[trafficcontrol-traffic_ops-test] $ /bin/bash /tmp/jenkins8983648602440587628.sh
docker-compose version 1.22.0, build f46880f
docker-py version: 3.4.1
CPython version: 2.7.6
OpenSSL version: OpenSSL 1.0.1f 6 Jan 2014
+ trap finish EXIT
+ proj=jenkins-trafficcontrol-traffic_ops-test-851
++ pwd
+ 
compose=
+ cfile=traffic_ops/app/bin/tests/docker-compose.yml
+ [[ -z 

 ]]
+ [[ ! -x 

 ]]
+ 

 -p jenkins-trafficcontrol-traffic_ops-test-851 -f 
traffic_ops/app/bin/tests/docker-compose.yml up --build --exit-code-from 
unit_golang unit_golang
using --exit-code-from implies --abort-on-container-exit
Creating network "jenkinstrafficcontroltrafficopstest851_default" with the 
default driver
Creating volume "jenkinstrafficcontroltrafficopstest851_traffic_ops" with 
default driver
Creating volume "jenkinstrafficcontroltrafficopstest851_traffic_ops_golang" 
with default driver
Building unit_golang
Step 1/7 : FROM golang:1.9.4
1.9.4: Pulling from library/golang
Service 'unit_golang' failed to build: failed to register layer: open 
/var/lib/docker/aufs/layers/83a107c8fc91504f2c1a7f644d5a9cdb007207c663347eec797e30f17d8f36a7:
 no such file or directory
+ exit 1
+ finish
+ local st=1
+ [[ 1 -ne 0 ]]
+ echo 'Exiting with status 1'
Exiting with status 1
+ 

 -p jenkins-trafficcontrol-traffic_ops-test-851 -f 
traffic_ops/app/bin/tests/docker-compose.yml down -v
Removing network jenkinstrafficcontroltrafficopstest851_default
Removing volume jenkinstrafficcontroltrafficopstest851_traffic_ops
Removing volume jenkinstrafficcontroltrafficopstest851_traffic_ops_golang
Build step 'Execute shell' marked build as failure

[GitHub] DylanVolz opened a new issue #2669: use enums instead of raw strings

[GitBox]

DylanVolz opened a new issue #2669: use enums instead of raw strings
URL: https://github.com/apache/trafficcontrol/issues/2669
 
 
   everywhere we use raw strings that can be enums we should convert them.
   For example in cachegroup/queueupdate.go on line 47 "queue" and "dequeue" 
can be converted to string enums.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #2660: Update version of Traffic Control to 3.0.0.

[GitBox]

mitchell852 commented on issue #2660: Update version of Traffic Control to 
3.0.0.
URL: https://github.com/apache/trafficcontrol/pull/2660#issuecomment-412663073
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

[GitBox]

rob05c commented on a change in pull request #2653: Fix TO Go routes to all use 
transactions and timeouts
URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209757007
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/crconfig/handler.go
 ##
 @@ -20,223 +20,146 @@ package crconfig
  */
 
 import (
-   "encoding/json"
"errors"
"net/http"
"net/url"
-   "strconv"
"time"
 
"github.com/apache/trafficcontrol/lib/go-log"
"github.com/apache/trafficcontrol/lib/go-tc"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
-   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth"
-   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/config"
-
-   "github.com/jmoiron/sqlx"
 )
 
 // Handler creates and serves the CRConfig from the raw SQL data.
 // This MUST only be used for debugging or previewing, the raw un-snapshotted 
data MUST NOT be used by any component of the CDN.
-func Handler(db *sqlx.DB, cfg config.Config) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   start := time.Now()
-   handleErrs := tc.GetHandleErrorsFunc(w, r)
-
-   params, err := api.GetCombinedParams(r)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-
-   cdn, ok := params["cdn"]
-   if !ok {
-   handleErrs(http.StatusInternalServerError, 
errors.New("params missing CDN"))
-   return
-   }
-
-   ctx := r.Context()
-   user, err := auth.GetCurrentUser(ctx)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-
-   crConfig, err := Make(db.DB, cdn, user.UserName, r.Host, 
r.URL.Path, cfg.Version)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
+func Handler(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"cdn"}, nil)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
 
-   resp := struct {
-   Response *tc.CRConfig `json:"response"`
-   }{crConfig}
-   respBts, err := json.Marshal(resp)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-   log.Infof("CRConfig time to generate: %+v\n", time.Since(start))
-   w.Header().Set("Content-Type", "application/json")
-   w.Write(respBts)
+   start := time.Now()
+   crConfig, err := Make(inf.Tx.Tx, inf.Params["cdn"], inf.User.UserName, 
r.Host, r.URL.Path, inf.Config.Version)
+   if err != nil {
+   api.HandleErr(w, r, http.StatusInternalServerError, nil, err)
+   return
}
+   log.Infof("CRConfig time to generate: %+v\n", time.Since(start))
+   api.WriteResp(w, r, crConfig)
 }
 
 // SnapshotGetHandler gets and serves the CRConfig from the snapshot table.
-func SnapshotGetHandler(db *sqlx.DB, cfg config.Config) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   handleErrs := tc.GetHandleErrorsFunc(w, r)
-   params, err := api.GetCombinedParams(r)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-   cdn, ok := params["cdn"]
-   if !ok {
-   handleErrs(http.StatusInternalServerError, 
errors.New("params missing CDN"))
-   return
-   }
+func SnapshotGetHandler(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"cdn"}, nil)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
 
-   snapshot, cdnExists, err := GetSnapshot(db.DB, cdn)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, 
errors.New("getting snapshot: "+err.Error()))
-   return
-   }
-   if !cdnExists {
-   handleErrs(http.StatusNotFound, errors.New("CDN not 
found"))
-   return
-   }
-   w.Header().Set("Content-Type", "application/json")
-   w.Write([]byte(`{"response":` + snapshot + `}`))
+   snapshot, cdnExists, 

[GitHub] rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

[GitBox]

rob05c commented on a change in pull request #2653: Fix TO Go routes to all use 
transactions and timeouts
URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209757007
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/crconfig/handler.go
 ##
 @@ -20,223 +20,146 @@ package crconfig
  */
 
 import (
-   "encoding/json"
"errors"
"net/http"
"net/url"
-   "strconv"
"time"
 
"github.com/apache/trafficcontrol/lib/go-log"
"github.com/apache/trafficcontrol/lib/go-tc"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
-   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth"
-   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/config"
-
-   "github.com/jmoiron/sqlx"
 )
 
 // Handler creates and serves the CRConfig from the raw SQL data.
 // This MUST only be used for debugging or previewing, the raw un-snapshotted 
data MUST NOT be used by any component of the CDN.
-func Handler(db *sqlx.DB, cfg config.Config) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   start := time.Now()
-   handleErrs := tc.GetHandleErrorsFunc(w, r)
-
-   params, err := api.GetCombinedParams(r)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-
-   cdn, ok := params["cdn"]
-   if !ok {
-   handleErrs(http.StatusInternalServerError, 
errors.New("params missing CDN"))
-   return
-   }
-
-   ctx := r.Context()
-   user, err := auth.GetCurrentUser(ctx)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-
-   crConfig, err := Make(db.DB, cdn, user.UserName, r.Host, 
r.URL.Path, cfg.Version)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
+func Handler(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"cdn"}, nil)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
 
-   resp := struct {
-   Response *tc.CRConfig `json:"response"`
-   }{crConfig}
-   respBts, err := json.Marshal(resp)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-   log.Infof("CRConfig time to generate: %+v\n", time.Since(start))
-   w.Header().Set("Content-Type", "application/json")
-   w.Write(respBts)
+   start := time.Now()
+   crConfig, err := Make(inf.Tx.Tx, inf.Params["cdn"], inf.User.UserName, 
r.Host, r.URL.Path, inf.Config.Version)
+   if err != nil {
+   api.HandleErr(w, r, http.StatusInternalServerError, nil, err)
+   return
}
+   log.Infof("CRConfig time to generate: %+v\n", time.Since(start))
+   api.WriteResp(w, r, crConfig)
 }
 
 // SnapshotGetHandler gets and serves the CRConfig from the snapshot table.
-func SnapshotGetHandler(db *sqlx.DB, cfg config.Config) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   handleErrs := tc.GetHandleErrorsFunc(w, r)
-   params, err := api.GetCombinedParams(r)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-   cdn, ok := params["cdn"]
-   if !ok {
-   handleErrs(http.StatusInternalServerError, 
errors.New("params missing CDN"))
-   return
-   }
+func SnapshotGetHandler(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"cdn"}, nil)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
 
-   snapshot, cdnExists, err := GetSnapshot(db.DB, cdn)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, 
errors.New("getting snapshot: "+err.Error()))
-   return
-   }
-   if !cdnExists {
-   handleErrs(http.StatusNotFound, errors.New("CDN not 
found"))
-   return
-   }
-   w.Header().Set("Content-Type", "application/json")
-   w.Write([]byte(`{"response":` + snapshot + `}`))
+   snapshot, cdnExists, 

[GitHub] rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

[GitBox]

rob05c commented on a change in pull request #2653: Fix TO Go routes to all use 
transactions and timeouts
URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209756497
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/monitoring/monitoring.go
 ##
 @@ -110,56 +86,70 @@ type Monitoring struct {
Config   map[string]interface{} `json:"config"`
 }
 
-// MonitoringResponse ...
 type MonitoringResponse struct {
Response Monitoring `json:"response"`
 }
 
-// Router ...
 type Router struct {
Typestring
Profile string
 }
 
-// DeliveryService ...
 type DeliveryService struct {
XMLID  string  `json:"xmlId"`
TotalTPSThreshold  float64 `json:"totalTpsThreshold"`
Status string  `json:"status"`
TotalKBPSThreshold float64 `json:"totalKbpsThreshold"`
 }
 
-// TODO change to use the PathParams, instead of parsing the URL
-func monitoringHandler(db *sqlx.DB) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   handleErrs := tc.GetHandleErrorsFunc(w, r)
+func Get(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"cdn"}, nil)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
+   *inf.CommitTx = true
+   api.RespWriter(w, r)(getMonitoringJSON(inf.Tx.Tx, inf.Params["cdn"]))
 
 Review comment:
   As below, `RespWriter` -> `WriteResp` -> `WriteRespRaw` -> 
`w.Header().Set("Content-Type"` 
`https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/api/api.go#L67`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

[GitBox]

rob05c commented on a change in pull request #2653: Fix TO Go routes to all use 
transactions and timeouts
URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209756497
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/monitoring/monitoring.go
 ##
 @@ -110,56 +86,70 @@ type Monitoring struct {
Config   map[string]interface{} `json:"config"`
 }
 
-// MonitoringResponse ...
 type MonitoringResponse struct {
Response Monitoring `json:"response"`
 }
 
-// Router ...
 type Router struct {
Typestring
Profile string
 }
 
-// DeliveryService ...
 type DeliveryService struct {
XMLID  string  `json:"xmlId"`
TotalTPSThreshold  float64 `json:"totalTpsThreshold"`
Status string  `json:"status"`
TotalKBPSThreshold float64 `json:"totalKbpsThreshold"`
 }
 
-// TODO change to use the PathParams, instead of parsing the URL
-func monitoringHandler(db *sqlx.DB) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   handleErrs := tc.GetHandleErrorsFunc(w, r)
+func Get(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"cdn"}, nil)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
+   *inf.CommitTx = true
+   api.RespWriter(w, r)(getMonitoringJSON(inf.Tx.Tx, inf.Params["cdn"]))
 
 Review comment:
   As below, `RespWriter` -> `WriteResp` -> `WriteRespRaw` -> 
`w.Header().Set("Content-Type"` 
   
   
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/api/api.go#L67


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DylanVolz commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

[GitBox]

DylanVolz commented on a change in pull request #2656: properly handle db 
timeouts in when checking user during authorization
URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209756347
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/auth/authorize.go
 ##
 @@ -39,6 +43,13 @@ type CurrentUser struct {
Capabilities pq.StringArray `json:"capabilities" db:"capabilities"`
 }
 
+type PasswordForm struct {
+   Username string `json:"u"`
+   Password string `json:"p"`
+}
+
+const disallowed = "disallowed"
 
 Review comment:
   no, unless we made the role names fixed, this is an assumption made on line 
125, and noted in a comment, that should be fixed to use the DB in some way 
most likely.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

[GitBox]

rob05c commented on a change in pull request #2653: Fix TO Go routes to all use 
transactions and timeouts
URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209756203
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/profileparameter/unassignedparams.go
 ##
 @@ -32,24 +32,24 @@ import (
 
 // my $rs_data = $self->db->resultset("Parameter")->search( 'me.id' => { 'not 
in' => \@assigned_params } );
 
-func GetUnassigned(db *sql.DB) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   _, intParams, userErr, sysErr, errCode := api.AllParams(r, 
[]string{"id"}, []string{"id"})
-   if userErr != nil || sysErr != nil {
-   api.HandleErr(w, r, errCode, userErr, sysErr)
-   return
-   }
-   api.RespWriter(w, 
r)(getUnassignedParametersByProfileID(intParams["id"], db))
+func GetUnassigned(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"id"}, 
[]string{"id"})
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
}
+   defer inf.Close()
+   *inf.CommitTx = true
+   api.RespWriter(w, r)(getUnassignedParametersByProfileID(inf.Tx.Tx, 
inf.IntParams["id"]))
 
 Review comment:
   They do 
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/api/api.go#L67


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2665: Add TO old UI deprecation bar

[GitBox]

rob05c commented on a change in pull request #2665: Add TO old UI deprecation 
bar
URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209755686
 
 

 ##
 File path: traffic_ops/app/templates/navbar.html.ep
 ##
 @@ -14,6 +14,7 @@
  -->
 
 
+WARNING: This old interface is deprecated! It will 
be removed in Traffic Control 4.0! Please migrate to  Traffic Portal soon!
 
 Review comment:
   Yes, we really want to commit to a release. It has taken extensive 
negotiating to get agreement to deprecate and remove. We are deprecating in 3.0 
and removing in 4.0. The banner should explicitly state that. There should be 
no ambiguity, or argument that the deprecation deadline was unclear.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

[GitBox]

DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all 
use transactions and timeouts
URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209730554
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/monitoring/monitoring.go
 ##
 @@ -110,56 +86,70 @@ type Monitoring struct {
Config   map[string]interface{} `json:"config"`
 }
 
-// MonitoringResponse ...
 type MonitoringResponse struct {
Response Monitoring `json:"response"`
 }
 
-// Router ...
 type Router struct {
Typestring
Profile string
 }
 
-// DeliveryService ...
 type DeliveryService struct {
XMLID  string  `json:"xmlId"`
TotalTPSThreshold  float64 `json:"totalTpsThreshold"`
Status string  `json:"status"`
TotalKBPSThreshold float64 `json:"totalKbpsThreshold"`
 }
 
-// TODO change to use the PathParams, instead of parsing the URL
-func monitoringHandler(db *sqlx.DB) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   handleErrs := tc.GetHandleErrorsFunc(w, r)
+func Get(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"cdn"}, nil)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
+   *inf.CommitTx = true
+   api.RespWriter(w, r)(getMonitoringJSON(inf.Tx.Tx, inf.Params["cdn"]))
 
 Review comment:
   I think this misses setting the Content-Type header.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

[GitBox]

DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all 
use transactions and timeouts
URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209664633
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/crconfig/handler.go
 ##
 @@ -20,223 +20,146 @@ package crconfig
  */
 
 import (
-   "encoding/json"
"errors"
"net/http"
"net/url"
-   "strconv"
"time"
 
"github.com/apache/trafficcontrol/lib/go-log"
"github.com/apache/trafficcontrol/lib/go-tc"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
-   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth"
-   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/config"
-
-   "github.com/jmoiron/sqlx"
 )
 
 // Handler creates and serves the CRConfig from the raw SQL data.
 // This MUST only be used for debugging or previewing, the raw un-snapshotted 
data MUST NOT be used by any component of the CDN.
-func Handler(db *sqlx.DB, cfg config.Config) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   start := time.Now()
-   handleErrs := tc.GetHandleErrorsFunc(w, r)
-
-   params, err := api.GetCombinedParams(r)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-
-   cdn, ok := params["cdn"]
-   if !ok {
-   handleErrs(http.StatusInternalServerError, 
errors.New("params missing CDN"))
-   return
-   }
-
-   ctx := r.Context()
-   user, err := auth.GetCurrentUser(ctx)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-
-   crConfig, err := Make(db.DB, cdn, user.UserName, r.Host, 
r.URL.Path, cfg.Version)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
+func Handler(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"cdn"}, nil)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
 
-   resp := struct {
-   Response *tc.CRConfig `json:"response"`
-   }{crConfig}
-   respBts, err := json.Marshal(resp)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-   log.Infof("CRConfig time to generate: %+v\n", time.Since(start))
-   w.Header().Set("Content-Type", "application/json")
-   w.Write(respBts)
+   start := time.Now()
+   crConfig, err := Make(inf.Tx.Tx, inf.Params["cdn"], inf.User.UserName, 
r.Host, r.URL.Path, inf.Config.Version)
+   if err != nil {
+   api.HandleErr(w, r, http.StatusInternalServerError, nil, err)
+   return
}
+   log.Infof("CRConfig time to generate: %+v\n", time.Since(start))
+   api.WriteResp(w, r, crConfig)
 }
 
 // SnapshotGetHandler gets and serves the CRConfig from the snapshot table.
-func SnapshotGetHandler(db *sqlx.DB, cfg config.Config) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   handleErrs := tc.GetHandleErrorsFunc(w, r)
-   params, err := api.GetCombinedParams(r)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, err)
-   return
-   }
-   cdn, ok := params["cdn"]
-   if !ok {
-   handleErrs(http.StatusInternalServerError, 
errors.New("params missing CDN"))
-   return
-   }
+func SnapshotGetHandler(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"cdn"}, nil)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
 
-   snapshot, cdnExists, err := GetSnapshot(db.DB, cdn)
-   if err != nil {
-   handleErrs(http.StatusInternalServerError, 
errors.New("getting snapshot: "+err.Error()))
-   return
-   }
-   if !cdnExists {
-   handleErrs(http.StatusNotFound, errors.New("CDN not 
found"))
-   return
-   }
-   w.Header().Set("Content-Type", "application/json")
-   w.Write([]byte(`{"response":` + snapshot + `}`))
+   snapshot, cdnExists, 

[GitHub] DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

[GitBox]

DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all 
use transactions and timeouts
URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209753130
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/profileparameter/unassignedparams.go
 ##
 @@ -32,24 +32,24 @@ import (
 
 // my $rs_data = $self->db->resultset("Parameter")->search( 'me.id' => { 'not 
in' => \@assigned_params } );
 
-func GetUnassigned(db *sql.DB) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   _, intParams, userErr, sysErr, errCode := api.AllParams(r, 
[]string{"id"}, []string{"id"})
-   if userErr != nil || sysErr != nil {
-   api.HandleErr(w, r, errCode, userErr, sysErr)
-   return
-   }
-   api.RespWriter(w, 
r)(getUnassignedParametersByProfileID(intParams["id"], db))
+func GetUnassigned(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"id"}, 
[]string{"id"})
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
}
+   defer inf.Close()
+   *inf.CommitTx = true
+   api.RespWriter(w, r)(getUnassignedParametersByProfileID(inf.Tx.Tx, 
inf.IntParams["id"]))
 
 Review comment:
   Same Content-Type issue here, I think api.RespWriter or api.WriteResp should 
add the Content-Type json header.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2665: Add TO old UI deprecation bar

[GitBox]

rob05c commented on a change in pull request #2665: Add TO old UI deprecation 
bar
URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209755248
 
 

 ##
 File path: traffic_ops/app/conf/cdn.conf
 ##
 @@ -43,6 +43,7 @@
 },
 "portal" : {
 "base_url" : "http://localhost:8080/!#/;,
+"external_url" : 
"https://traffic-control-cdn.readthedocs.io/en/latest/overview/traffic_portal.html;,
 
 Review comment:
   The `base_url` is the local URL, e.g. `https://localhost`, this needs to be 
the external url, e.g. `https://cdn.example.net`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

[GitBox]

mitchell852 commented on a change in pull request #2665: Add TO old UI 
deprecation bar
URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209752698
 
 

 ##
 File path: traffic_ops/app/conf/cdn.conf
 ##
 @@ -43,6 +43,7 @@
 },
 "portal" : {
 "base_url" : "http://localhost:8080/!#/;,
+"external_url" : 
"https://traffic-control-cdn.readthedocs.io/en/latest/overview/traffic_portal.html;,
 
 Review comment:
   actually, the "base_url" is the url of TP


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on a change in pull request #2665: Add TO old UI deprecation bar

[GitBox]

rawlinp commented on a change in pull request #2665: Add TO old UI deprecation 
bar
URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209749372
 
 

 ##
 File path: traffic_ops/app/conf/cdn.conf
 ##
 @@ -43,6 +43,7 @@
 },
 "portal" : {
 "base_url" : "http://localhost:8080/!#/;,
+"external_url" : 
"https://traffic-control-cdn.readthedocs.io/en/latest/overview/traffic_portal.html;,
 
 Review comment:
   by default it will be the docs URL, but we'll override the default with the 
actual TP URL that we want people to use instead of the old mojolicious UI


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

[GitBox]

mitchell852 commented on a change in pull request #2665: Add TO old UI 
deprecation bar
URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209747676
 
 

 ##
 File path: traffic_ops/app/templates/navbar.html.ep
 ##
 @@ -14,6 +14,7 @@
  -->
 
 
+WARNING: This old interface is deprecated! It will 
be removed in Traffic Control 4.0! Please migrate to  Traffic Portal soon!
 
 Review comment:
   Do you really want to commit to a release? how about just:
   
   WARNING: This old interface is deprecated! Functionality may or may not work 
as expected. If installed, please use the `` Traffic Portal (`Traffic Portal Docs`).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

[GitBox]

mitchell852 commented on a change in pull request #2665: Add TO old UI 
deprecation bar
URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209747676
 
 

 ##
 File path: traffic_ops/app/templates/navbar.html.ep
 ##
 @@ -14,6 +14,7 @@
  -->
 
 
+WARNING: This old interface is deprecated! It will 
be removed in Traffic Control 4.0! Please migrate to  Traffic Portal soon!
 
 Review comment:
   Do you really want to commit to a release? how about just:
   
   WARNING: This old interface is deprecated! Functionality may or may not work 
as expected. If installed, please use the  Traffic Portal (Traffic Portal Docs).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

[GitBox]

mitchell852 commented on a change in pull request #2665: Add TO old UI 
deprecation bar
URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209746977
 
 

 ##
 File path: traffic_ops/app/conf/cdn.conf
 ##
 @@ -43,6 +43,7 @@
 },
 "portal" : {
 "base_url" : "http://localhost:8080/!#/;,
+"external_url" : 
"https://traffic-control-cdn.readthedocs.io/en/latest/overview/traffic_portal.html;,
 
 Review comment:
   i know i'm nitpicking here but it's not really an "external url" but more of 
a "docs url", right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

[GitBox]

dewrich commented on a change in pull request #2656: properly handle db 
timeouts in when checking user during authorization
URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209742387
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/auth/authorize.go
 ##
 @@ -39,6 +43,13 @@ type CurrentUser struct {
Capabilities pq.StringArray `json:"capabilities" db:"capabilities"`
 }
 
+type PasswordForm struct {
+   Username string `json:"u"`
+   Password string `json:"p"`
+}
+
+const disallowed = "disallowed"
 
 Review comment:
   Shouldn't this be an Enum of the "roles" somewhere?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich edited a comment on issue #2655: [Issue 2654] fix deepcachingtype retrieval in users/xx/deliveryservices

[GitBox]

dewrich edited a comment on issue #2655: [Issue 2654] fix deepcachingtype 
retrieval in users/xx/deliveryservices
URL: https://github.com/apache/trafficcontrol/pull/2655#issuecomment-412640942
 
 
   @dangogh Should there be an API test that shows the breakage is fixed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich commented on issue #2655: [Issue 2654] fix deepcachingtype retrieval in users/xx/deliveryservices

[GitBox]

dewrich commented on issue #2655: [Issue 2654] fix deepcachingtype retrieval in 
users/xx/deliveryservices
URL: https://github.com/apache/trafficcontrol/pull/2655#issuecomment-412640942
 
 
   @dangogh Should there be an API test that shows the breakage too?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #2245

[Apache Jenkins Server]

See 


Changes:

[mrdgelinas] Add TM poller plugins

[mrdgelinas] Add TM noop stat parser type

[rob] Add TO old UI deprecation bar

--
[...truncated 19.77 MB...]
traffic_portal_build_1   | | | |   +-- jsonify@0.0.0 
traffic_portal_build_1   | | | |   +-- resumer@0.0.0 
traffic_portal_build_1   | | | |   `-- through@2.3.8 
traffic_portal_build_1   | | | `-- strip-json-comments@0.1.3 
traffic_portal_build_1   | | +-- timespan@2.3.0 
traffic_portal_build_1   | | +-- utile@0.2.1 
traffic_portal_build_1   | | | +-- async@0.2.10 
traffic_portal_build_1   | | | +-- deep-equal@1.0.1 
traffic_portal_build_1   | | | +-- i@0.3.6 
traffic_portal_build_1   | | | +-- mkdirp@0.5.1 
traffic_portal_build_1   | | | | `-- minimist@0.0.8 
traffic_portal_build_1   | | | +-- ncp@0.4.2 
traffic_portal_build_1   | | | `-- rimraf@2.6.2 
traffic_portal_build_1   | | |   `-- glob@7.1.2 
traffic_portal_build_1   | | | +-- fs.realpath@1.0.0 
traffic_portal_build_1   | | | +-- inflight@1.0.6 
traffic_portal_build_1   | | | | `-- wrappy@1.0.2 
traffic_portal_build_1   | | | `-- once@1.4.0 
traffic_portal_build_1   | | `-- winston@0.8.3 
traffic_portal_build_1   | |   +-- cycle@1.0.3 
traffic_portal_build_1   | |   +-- isstream@0.1.2 
traffic_portal_build_1   | |   +-- pkginfo@0.3.1 
traffic_portal_build_1   | |   `-- stack-trace@0.0.10 
traffic_portal_build_1   | +-- morgan@1.7.0 
traffic_portal_build_1   | | `-- basic-auth@1.0.4 
traffic_portal_build_1   | +-- requirejs@2.1.22 
traffic_portal_build_1   | `-- ssl-root-cas@1.1.10 
traffic_portal_build_1   |   +-- es6-promise@2.3.0 
traffic_portal_build_1   |   `-- request@2.88.0 
traffic_portal_build_1   | +-- aws-sign2@0.7.0 
traffic_portal_build_1   | +-- aws4@1.8.0 
traffic_portal_build_1   | +-- caseless@0.12.0 
traffic_portal_build_1   | +-- combined-stream@1.0.6 
traffic_portal_build_1   | | `-- delayed-stream@1.0.0 
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.2 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.0 
traffic_portal_build_1   | | +-- ajv@5.5.2 
traffic_portal_build_1   | | | +-- co@4.6.0 
traffic_portal_build_1   | | | +-- fast-deep-equal@1.1.0 
traffic_portal_build_1   | | | +-- fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | `-- json-schema-traverse@0.3.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.14.2 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   +-- safer-buffer@2.1.2 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- safe-buffer@5.1.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.1.29 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.2 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL DEPENDENCY: 
fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: 
Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} 
(current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done, without errors.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2018-08-13 19:18:27 UTC)
traffic_portal_build_1   | loading tasks  1.3s  ▇▇ 4%
traffic_portal_build_1   | compass:prod   8.8s  

[GitHub] asfgit commented on issue #2665: Add TO old UI deprecation bar

[GitBox]

asfgit commented on issue #2665: Add TO old UI deprecation bar
URL: https://github.com/apache/trafficcontrol/pull/2665#issuecomment-412632969
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2245/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

[GitBox]

asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit 
codes and eval
URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-412630078
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2244/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #2244

[Apache Jenkins Server]

See 


Changes:

[Jeffrey_Bevill] Traffic Ops - admin.pl load_schema proper SQL statement eval 
and exit

--
[...truncated 18.59 MB...]
traffic_portal_build_1   | | | |   +-- jsonify@0.0.0 
traffic_portal_build_1   | | | |   +-- resumer@0.0.0 
traffic_portal_build_1   | | | |   `-- through@2.3.8 
traffic_portal_build_1   | | | `-- strip-json-comments@0.1.3 
traffic_portal_build_1   | | +-- timespan@2.3.0 
traffic_portal_build_1   | | +-- utile@0.2.1 
traffic_portal_build_1   | | | +-- async@0.2.10 
traffic_portal_build_1   | | | +-- deep-equal@1.0.1 
traffic_portal_build_1   | | | +-- i@0.3.6 
traffic_portal_build_1   | | | +-- mkdirp@0.5.1 
traffic_portal_build_1   | | | | `-- minimist@0.0.8 
traffic_portal_build_1   | | | +-- ncp@0.4.2 
traffic_portal_build_1   | | | `-- rimraf@2.6.2 
traffic_portal_build_1   | | |   `-- glob@7.1.2 
traffic_portal_build_1   | | | +-- fs.realpath@1.0.0 
traffic_portal_build_1   | | | +-- inflight@1.0.6 
traffic_portal_build_1   | | | | `-- wrappy@1.0.2 
traffic_portal_build_1   | | | `-- once@1.4.0 
traffic_portal_build_1   | | `-- winston@0.8.3 
traffic_portal_build_1   | |   +-- cycle@1.0.3 
traffic_portal_build_1   | |   +-- isstream@0.1.2 
traffic_portal_build_1   | |   +-- pkginfo@0.3.1 
traffic_portal_build_1   | |   `-- stack-trace@0.0.10 
traffic_portal_build_1   | +-- morgan@1.7.0 
traffic_portal_build_1   | | `-- basic-auth@1.0.4 
traffic_portal_build_1   | +-- requirejs@2.1.22 
traffic_portal_build_1   | `-- ssl-root-cas@1.1.10 
traffic_portal_build_1   |   +-- es6-promise@2.3.0 
traffic_portal_build_1   |   `-- request@2.88.0 
traffic_portal_build_1   | +-- aws-sign2@0.7.0 
traffic_portal_build_1   | +-- aws4@1.8.0 
traffic_portal_build_1   | +-- caseless@0.12.0 
traffic_portal_build_1   | +-- combined-stream@1.0.6 
traffic_portal_build_1   | | `-- delayed-stream@1.0.0 
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.2 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.0 
traffic_portal_build_1   | | +-- ajv@5.5.2 
traffic_portal_build_1   | | | +-- co@4.6.0 
traffic_portal_build_1   | | | +-- fast-deep-equal@1.1.0 
traffic_portal_build_1   | | | +-- fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | `-- json-schema-traverse@0.3.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.14.2 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   +-- safer-buffer@2.1.2 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- safe-buffer@5.1.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.1.29 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.2 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL DEPENDENCY: 
fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: 
Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} 
(current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done, without errors.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2018-08-13 19:08:33 UTC)
traffic_portal_build_1   | loading tasks  1.2s  ▇▇ 4%
traffic_portal_build_1   | compass:prod   8.9s  
▇▇▇▇▇▇▇▇▇▇ 31%

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

[GitBox]

mitchell852 commented on a change in pull request #2665: Add TO old UI 
deprecation bar
URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209723176
 
 

 ##
 File path: traffic_ops/app/conf/cdn.conf
 ##
 @@ -47,6 +47,7 @@
 "pass_reset_path" : "user",
 "user_register_path" : "user"
 },
+"portal_url" : 
"https://traffic-control-cdn.readthedocs.io/en/latest/overview/traffic_portal.html;,
 
 Review comment:
   there's already a "portal" key in this file. you want to just put this under 
that? i.e. portal.docs?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

[GitBox]

dangogh commented on issue #2668: Traffic Ops - Admin.pl load_schema proper 
exit codes and eval
URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-412627849
 
 
   add to whitelist
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

[GitBox]

asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit 
codes and eval
URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-412615559
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JBevillC opened a new pull request #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

[GitBox]

JBevillC opened a new pull request #2668: Traffic Ops - Admin.pl load_schema 
proper exit codes and eval
URL: https://github.com/apache/trafficcontrol/pull/2668
 
 
   This PR will fix the following related to issue #2667 in the traffic_ops 
component:
   
   - Update admin.pl load_schema function to use ON_ERROR_STOP=1 so that each 
SQL statement is evaluated for an error and to exit with retcode >0 if one is 
found.
   - Update the create_tables.sql schema and remove the updated comment to 
extension plpgsql which always results in a SQL error (traffic_ops user does 
not own the plpgsql extension). 
   
   Note: Issue #2006 is related and has already been fixed in a similar manner 
by adding ON_ERROR_STOP=1 to the psql command line.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2666: TO Golang: api.NewInfo Close() deferral postpones DB transaction commit until after API response is written

[GitBox]

rob05c commented on issue #2666: TO Golang: api.NewInfo Close() deferral 
postpones DB transaction commit until after API response is written
URL: https://github.com/apache/trafficcontrol/issues/2666#issuecomment-412601783
 
 
   Yeah, I've been considering changing `*inf.CommitTx = true` to a function,` 
inf.Commit()`, which actually commits, and then the deferred `Close` will do 
nothing if it's already been committed.
   
   That will let it be committed as soon as possible, which is good for 
integrity, committing before it's returned to the user. I'm skeptical whether 
it's a performance issue, but it'll address that as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JBevillC opened a new issue #2667: Traffic Ops - admin.pl load_schema function does not return proper exit codes

[GitBox]

JBevillC opened a new issue #2667: Traffic Ops - admin.pl load_schema function 
does not return proper exit codes
URL: https://github.com/apache/trafficcontrol/issues/2667
 
 
   **Traffic Ops**
   The admin.pl load_schema function does not correctly evaluate for sql error 
conditions for each individual DDL statement of create_tables.sql.  At the 
beginning of create_tables.sql, there are two SQL statements related to the 
plpgsql extension: 
   ```
   CREATE EXTENSION IF NOT EXISTS plpgsql WITH SCHEMA pg_catalog;
   COMMENT ON EXTENSION plpgsql IS 'PL/pgSQL procedural language';
   ```
   
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/db/create_tables.sql#L31-L42
   The CREATE EXTENSION statement can stay since the extension is always 
created by default (by createdb utility or by just a standard CREATE TABLE 
statement) and will indicate that the extension is being used in the DDL.  The 
second statement to update the comment field of the plpgsql extension must be 
removed as the traffic_ops user is not the owner of the plpgsql extension:
   ```
   # User: traffic_ops
   traffic_ops=> COMMENT ON EXTENSION plpgsql IS 'PL/pgSQL procedural language';
   ERROR:  must be owner of extension plpgsql
   ```
   ```
   # User: postgres
   postgres=# select pg_authid.rolname as role_owner, pg_extension.extname as 
extension_name from pg_authid, pg_extension where pg_extension.extowner = 
pg_authid.oid\g
role_owner | extension_name 
   +
postgres   | plpgsql
   (1 row)
   ```
   The traffic_ops admin.pl load_schema function needs the ON_ERROR_STOP=1 
variable added to correctly evaluate each DDL statement for any SQL errors.  If 
any errors are found the ON_ERROR_STOP=1 will ensure that a script will exit 
with retcode > 0
   
   
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/db/admin.pl#L207


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp opened a new issue #2666: TO Golang: api.NewInfo Close() deferral postpones DB transaction commit until after API response is written

[GitBox]

rawlinp opened a new issue #2666: TO Golang: api.NewInfo Close() deferral 
postpones DB transaction commit until after API response is written
URL: https://github.com/apache/trafficcontrol/issues/2666
 
 
   General usage of `api.NewInfo()` [1] is that the `APIInfo.Close()` method is 
immediately deferred in the request handler that uses it (example: [2]). This 
keeps the DB transaction from committing until _after_ the handler writes the 
API response. Since a DB transaction uses limited shared resources, it should 
be closed as soon as possible after the required DB operation in order to 
return the used DB connection back to the pool for other request handlers to 
use.
   
   Performance testing may be needed in order to prioritize this based upon 
performance impact. A good place to start would be with shared_handlers.go 
which would affect all the CRUD handlers.
   
   [1] 
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/api/api.go#L268
   [2] 
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/api/shared_handlers.go#L130


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2665: Add TO old UI deprecation bar

[GitBox]

asfgit commented on issue #2665: Add TO old UI deprecation bar
URL: https://github.com/apache/trafficcontrol/pull/2665#issuecomment-412600556
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2243/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #2243

[Apache Jenkins Server]

See 


Changes:

[rob] Add TO old UI deprecation bar

--
[...truncated 20.36 MB...]
traffic_portal_build_1   | | | |   +-- jsonify@0.0.0 
traffic_portal_build_1   | | | |   +-- resumer@0.0.0 
traffic_portal_build_1   | | | |   `-- through@2.3.8 
traffic_portal_build_1   | | | `-- strip-json-comments@0.1.3 
traffic_portal_build_1   | | +-- timespan@2.3.0 
traffic_portal_build_1   | | +-- utile@0.2.1 
traffic_portal_build_1   | | | +-- async@0.2.10 
traffic_portal_build_1   | | | +-- deep-equal@1.0.1 
traffic_portal_build_1   | | | +-- i@0.3.6 
traffic_portal_build_1   | | | +-- mkdirp@0.5.1 
traffic_portal_build_1   | | | | `-- minimist@0.0.8 
traffic_portal_build_1   | | | +-- ncp@0.4.2 
traffic_portal_build_1   | | | `-- rimraf@2.6.2 
traffic_portal_build_1   | | |   `-- glob@7.1.2 
traffic_portal_build_1   | | | +-- fs.realpath@1.0.0 
traffic_portal_build_1   | | | +-- inflight@1.0.6 
traffic_portal_build_1   | | | | `-- wrappy@1.0.2 
traffic_portal_build_1   | | | `-- once@1.4.0 
traffic_portal_build_1   | | `-- winston@0.8.3 
traffic_portal_build_1   | |   +-- cycle@1.0.3 
traffic_portal_build_1   | |   +-- isstream@0.1.2 
traffic_portal_build_1   | |   +-- pkginfo@0.3.1 
traffic_portal_build_1   | |   `-- stack-trace@0.0.10 
traffic_portal_build_1   | +-- morgan@1.7.0 
traffic_portal_build_1   | | `-- basic-auth@1.0.4 
traffic_portal_build_1   | +-- requirejs@2.1.22 
traffic_portal_build_1   | `-- ssl-root-cas@1.1.10 
traffic_portal_build_1   |   +-- es6-promise@2.3.0 
traffic_portal_build_1   |   `-- request@2.88.0 
traffic_portal_build_1   | +-- aws-sign2@0.7.0 
traffic_portal_build_1   | +-- aws4@1.8.0 
traffic_portal_build_1   | +-- caseless@0.12.0 
traffic_portal_build_1   | +-- combined-stream@1.0.6 
traffic_portal_build_1   | | `-- delayed-stream@1.0.0 
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.2 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.0 
traffic_portal_build_1   | | +-- ajv@5.5.2 
traffic_portal_build_1   | | | +-- co@4.6.0 
traffic_portal_build_1   | | | +-- fast-deep-equal@1.1.0 
traffic_portal_build_1   | | | +-- fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | `-- json-schema-traverse@0.3.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.14.2 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   +-- safer-buffer@2.1.2 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- safe-buffer@5.1.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.1.29 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.2 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL DEPENDENCY: 
fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: 
Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} 
(current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done, without errors.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2018-08-13 17:33:51 UTC)
traffic_portal_build_1   | loading tasks  1.2s  ▇▇ 4%
traffic_portal_build_1   | compass:prod   9.3s  
▇▇▇▇▇▇▇▇▇▇ 31%
traffic_portal_build_1   | browserify2:app-prod   1.7s  

[GitHub] rob05c opened a new pull request #2665: Add TO old UI deprecation bar

[GitBox]

rob05c opened a new pull request #2665: Add TO old UI deprecation bar
URL: https://github.com/apache/trafficcontrol/pull/2665
 
 
   Fixes #2662


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed pull request #2609: Manage Static DNS Entries - front end CRUD implementation

[GitBox]

mitchell852 closed pull request #2609: Manage Static DNS Entries - front end 
CRUD implementation
URL: https://github.com/apache/trafficcontrol/pull/2609
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/app/templates/static_dns_entry/edit.html.ep 
b/traffic_ops/app/templates/static_dns_entry/edit.html.ep
index ded8155ab..2702c092a 100644
--- a/traffic_ops/app/templates/static_dns_entry/edit.html.ep
+++ b/traffic_ops/app/templates/static_dns_entry/edit.html.ep
@@ -139,7 +139,7 @@ function deleteStaticDnsEntry(staticDnsId, staticDnsName) {
 
 <%= $dns->host %>
 <%= $dns->type->name %>
-<%= $dns->cachegroup->name %>
+<%= defined $dns->cachegroup && 
$dns->cachegroup->name %>
 <%= $dns->ttl %>
 <%= $dns->address %>
 remove
diff --git a/traffic_ops/client/v13/staticdnsentry.go 
b/traffic_ops/client/v13/staticdnsentry.go
index 15e1a42c7..94e927c3b 100644
--- a/traffic_ops/client/v13/staticdnsentry.go
+++ b/traffic_ops/client/v13/staticdnsentry.go
@@ -49,23 +49,25 @@ func (to *Session) CreateStaticDNSEntry(cdn 
v13.StaticDNSEntry) (tc.Alerts, ReqI
 }
 
 // Update a StaticDNSEntry by ID
-func (to *Session) UpdateStaticDNSEntryByID(id int, cdn v13.StaticDNSEntry) 
(tc.Alerts, ReqInf, error) {
+func (to *Session) UpdateStaticDNSEntryByID(id int, cdn v13.StaticDNSEntry) 
(tc.Alerts, ReqInf, int, error) {
 
var remoteAddr net.Addr
reqBody, err := json.Marshal(cdn)
reqInf := ReqInf{CacheHitStatus: CacheHitStatusMiss, RemoteAddr: 
remoteAddr}
if err != nil {
-   return tc.Alerts{}, reqInf, err
+   return tc.Alerts{}, reqInf, 0, err
}
route := fmt.Sprintf("%s?id=%d", API_v13_StaticDNSEntries, id)
-   resp, remoteAddr, err := to.request(http.MethodPut, route, reqBody)
-   if err != nil {
-   return tc.Alerts{}, reqInf, err
+   resp, remoteAddr, errClient := to.rawRequest(http.MethodPut, route, 
reqBody)
+   if resp != nil {
+   defer resp.Body.Close()
+   var alerts tc.Alerts
+   if err = json.NewDecoder(resp.Body).Decode(); err != nil 
{
+   return alerts, reqInf, resp.StatusCode, err
+   }
+   return alerts, reqInf, resp.StatusCode, errClient
}
-   defer resp.Body.Close()
-   var alerts tc.Alerts
-   err = json.NewDecoder(resp.Body).Decode()
-   return alerts, reqInf, nil
+   return tc.Alerts{}, reqInf, 0, errClient
 }
 
 // Returns a list of StaticDNSEntrys
diff --git a/traffic_ops/testing/api/v13/staticdnsentries_test.go 
b/traffic_ops/testing/api/v13/staticdnsentries_test.go
index 3ca74cbfd..db8948c3d 100644
--- a/traffic_ops/testing/api/v13/staticdnsentries_test.go
+++ b/traffic_ops/testing/api/v13/staticdnsentries_test.go
@@ -20,6 +20,7 @@ import (
 
"github.com/apache/trafficcontrol/lib/go-log"
tc "github.com/apache/trafficcontrol/lib/go-tc"
+   "reflect"
 )
 
 func TestStaticDNSEntries(t *testing.T) {
@@ -37,6 +38,7 @@ func TestStaticDNSEntries(t *testing.T) {
CreateTestStaticDNSEntries(t)
GetTestStaticDNSEntries(t)
UpdateTestStaticDNSEntries(t)
+   UpdateTestStaticDNSEntriesInvalidAddress(t)
DeleteTestStaticDNSEntries(t)
DeleteTestDeliveryServices(t)
DeleteTestServers(t)
@@ -97,10 +99,12 @@ func UpdateTestStaticDNSEntries(t *testing.T) {
t.Errorf("cannot GET StaticDNSEntries by name: '%s', %v\n", 
firstStaticDNSEntry.Host, err)
}
remoteStaticDNSEntry := resp[0]
-   expectedAddress := "192.168.0.1"
+   expectedAddress := "192.168.0.2"
remoteStaticDNSEntry.Address = expectedAddress
var alert tc.Alerts
-   alert, _, err = 
TOSession.UpdateStaticDNSEntryByID(remoteStaticDNSEntry.ID, 
remoteStaticDNSEntry)
+   var status int
+   alert, _, status, err = 
TOSession.UpdateStaticDNSEntryByID(remoteStaticDNSEntry.ID, 
remoteStaticDNSEntry)
+   log.Debugln("Status Code: ", status)
if err != nil {
t.Errorf("cannot UPDATE StaticDNSEntries using url: %v - %v\n", 
err, alert)
}
@@ -117,6 +121,70 @@ func UpdateTestStaticDNSEntries(t *testing.T) {
 
 }
 
+func UpdateTestStaticDNSEntriesInvalidAddress(t *testing.T) {
+
+   expectedAlerts := []tc.Alerts{tc.Alerts{[]tc.Alert{tc.Alert{"'address' 
must be a valid IPv4 address","error"}}}, 
tc.Alerts{[]tc.Alert{tc.Alert{"'address' must be a valid DNS name","error"}}}, 
tc.Alerts{[]tc.Alert{tc.Alert{"'address' must be a valid IPv6 
address","error"
+
+   // A_RECORD
+   firstStaticDNSEntry 

[GitHub] mitchell852 commented on a change in pull request #2609: Manage Static DNS Entries - front end CRUD implementation

[GitBox]

mitchell852 commented on a change in pull request #2609: Manage Static DNS 
Entries - front end CRUD implementation
URL: https://github.com/apache/trafficcontrol/pull/2609#discussion_r209687022
 
 

 ##
 File path: traffic_portal/app/src/common/api/StaticDnsEntryService.js
 ##
 @@ -17,13 +17,69 @@
  * under the License.
  */
 
-var StaticDnsEntryService = function(Restangular) {
+var StaticDnsEntryService = function($http, $q, Restangular, locationUtils, 
messageModel, ENV) {
 
this.getStaticDnsEntries = function(queryParams) {
return Restangular.all('staticdnsentries').getList(queryParams);
};
 
+   this.getStaticDnsEntry = function(id) {
 
 Review comment:
   k
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp opened a new issue #2664: TO Golang: Use standard format for "handled (req-id) in " info log

[GitBox]

rawlinp opened a new issue #2664: TO Golang: Use standard format for "handled 
(req-id) in " info log
URL: https://github.com/apache/trafficcontrol/issues/2664
 
 
   Currently, traffic_ops_golang generates info logs like the following:
   ```
   GET /api/1.3/cdns/name/foo/dnsseckeys.json handled (reqid 2614344) in 
1m10.030919457s
   GET /api/1.2/ping handled (reqid 2762751) in 1.1264ms
   ```
   
   This format is nice for humans to read, but it makes it difficult for 
scripts/machines to parse to answer questions like "what are my slowest request 
handlers?". I think we should change this to just a count of milliseconds 
similar to `ttms` used by Traffic Router and Apache Traffic Server, making it 
easier to run log queries against.
   
   
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/routing.go#L180


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #2657: TO API: unable to write a null or blank value to IPv6

[GitBox]

mitchell852 commented on issue #2657: TO API: unable to write a null or blank 
value to IPv6
URL: https://github.com/apache/trafficcontrol/issues/2657#issuecomment-412585025
 
 
   if my memory serves me correctly, ipv6 addresses must be unique per profile. 
for example
   
   server 1 has profile A which has ipv6=2001:::::
   server 2 has profile B which has ipv6=2001:::::
   
   ^^ this is fine but if 
   
   server 3 has profile B which has ipv6=2001::::: <-- that won't 
work. 
   
   anyhow, my guess is that this constraint is kicking in on a null or blank 
value. i.e.
   
   server 1 has profile A which has ipv6=null
   server 2 has profile A which has ipv6=null <-- the system thinks that null 
is already taken so it's throwing the unique constraint error.
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

[GitBox]

dewrich commented on a change in pull request #2653: Fix TO Go routes to all 
use transactions and timeouts
URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209677920
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/cachegroup/queueupdate.go
 ##
 @@ -29,71 +29,66 @@ import (
"github.com/apache/trafficcontrol/lib/go-tc"
tcv13 "github.com/apache/trafficcontrol/lib/go-tc/v13"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
-   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth"
 )
 
-func QueueUpdates(db *sql.DB) http.HandlerFunc {
-   return func(w http.ResponseWriter, r *http.Request) {
-   user, err := auth.GetCurrentUser(r.Context())
-   if err != nil {
-   api.HandleErr(w, r, http.StatusInternalServerError, 
nil, errors.New("getting user: "+err.Error()))
-   return
-   }
-   params, intParams, userErr, sysErr, errCode := api.AllParams(r, 
[]string{"id"}, []string{"id"})
-   if userErr != nil || sysErr != nil {
-   api.HandleErr(w, r, errCode, userErr, sysErr)
-   return
-   }
-   reqObj := tcv13.CachegroupQueueUpdatesRequest{}
-   if err := json.NewDecoder(r.Body).Decode(); err != nil {
-   api.HandleErr(w, r, http.StatusBadRequest, 
errors.New("malformed JSON: "+err.Error()), nil)
-   return
-   }
-   if reqObj.Action != "queue" && reqObj.Action != "dequeue" {
-   api.HandleErr(w, r, http.StatusBadRequest, 
errors.New("action must be 'queue' or 'dequeue'"), nil)
-   return
-   }
-   if reqObj.CDN == nil && reqObj.CDNID == nil {
-   api.HandleErr(w, r, http.StatusBadRequest, 
errors.New("cdn does not exist"), nil)
-   return
-   }
-   if reqObj.CDN == nil || *reqObj.CDN == "" {
-   cdn, ok, err := getCDNNameFromID(db, 
int64(*reqObj.CDNID))
-   if err != nil {
-   api.HandleErr(w, r, 
http.StatusInternalServerError, nil, errors.New("getting CDN name from ID 
'"+strconv.Itoa(int(*reqObj.CDNID))+"': "+err.Error()))
-   return
-   }
-   if !ok {
-   api.HandleErr(w, r, http.StatusBadRequest, 
errors.New("cdn "+strconv.Itoa(int(*reqObj.CDNID))+" does not exist"), nil)
-   return
-   }
-   reqObj.CDN = 
-   }
-   cgID := int64(intParams["id"])
-   cgName, ok, err := getCGNameFromID(db, cgID)
+func QueueUpdates(w http.ResponseWriter, r *http.Request) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"id"}, 
[]string{"id"})
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
+
+   reqObj := tcv13.CachegroupQueueUpdatesRequest{}
+   if err := json.NewDecoder(r.Body).Decode(); err != nil {
+   api.HandleErr(w, r, http.StatusBadRequest, 
errors.New("malformed JSON: "+err.Error()), nil)
+   return
+   }
+   if reqObj.Action != "queue" && reqObj.Action != "dequeue" {
 
 Review comment:
   Should "queue" and "dequeue" be an enum?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-master-build #989

[Apache Jenkins Server]

See 

[GitHub] rob05c opened a new issue #2662: Add Traffic Ops UI Deprecated Banner

[GitBox]

rob05c opened a new issue #2662: Add Traffic Ops UI Deprecated Banner
URL: https://github.com/apache/trafficcontrol/issues/2662
 
 
   The old Perl Traffic Ops UI will be deprecated in Traffic Control 3.0, and 
removed in 4.0.
   
   We need to add some kind of banner to the old GUI, indicating it's now 
deprecated and will be removed in 4.0.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2660: Update version of Traffic Control to 3.0.0.

[GitBox]

asfgit commented on issue #2660: Update version of Traffic Control to 3.0.0.
URL: https://github.com/apache/trafficcontrol/pull/2660#issuecomment-412549710
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2242/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh closed pull request #2661: Added copyright

[GitBox]

dangogh closed pull request #2661: Added copyright
URL: https://github.com/apache/trafficcontrol/pull/2661
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go 
b/traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go
index 97fe5f142..455b694c8 100644
--- a/traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go
+++ b/traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go
@@ -1,5 +1,24 @@
 package cdnfederation
 
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
 import (
"database/sql"
"errors"


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #2242

[Apache Jenkins Server]

See 


Changes:

[dewrich] move context to allow to-access.sh funcs in all containers

[dewrich] need placeholder file to include this empty dir and not accept any 
other

[dewrich] fix rpm path

[dewrich] adjust trafficmonitor file locations

[dewrich] add back initial data to TO container

[dewrich] adds traffic_ops_data to load json to running TO

[dewrich] fix references to TO host in mid/edge/trafficmonitor containers

[dewrich] add to-ping

[mrdgelinas] Add TM poller plugins

[mrdgelinas] Add TM noop stat parser type

[jeffrey_elsloo] Update version of Traffic Control to 3.0.0.

--
[...truncated 14.55 MB...]
traffic_portal_build_1   | | | |   +-- jsonify@0.0.0 
traffic_portal_build_1   | | | |   +-- resumer@0.0.0 
traffic_portal_build_1   | | | |   `-- through@2.3.8 
traffic_portal_build_1   | | | `-- strip-json-comments@0.1.3 
traffic_portal_build_1   | | +-- timespan@2.3.0 
traffic_portal_build_1   | | +-- utile@0.2.1 
traffic_portal_build_1   | | | +-- async@0.2.10 
traffic_portal_build_1   | | | +-- deep-equal@1.0.1 
traffic_portal_build_1   | | | +-- i@0.3.6 
traffic_portal_build_1   | | | +-- mkdirp@0.5.1 
traffic_portal_build_1   | | | | `-- minimist@0.0.8 
traffic_portal_build_1   | | | +-- ncp@0.4.2 
traffic_portal_build_1   | | | `-- rimraf@2.6.2 
traffic_portal_build_1   | | |   `-- glob@7.1.2 
traffic_portal_build_1   | | | +-- fs.realpath@1.0.0 
traffic_portal_build_1   | | | +-- inflight@1.0.6 
traffic_portal_build_1   | | | | `-- wrappy@1.0.2 
traffic_portal_build_1   | | | `-- once@1.4.0 
traffic_portal_build_1   | | `-- winston@0.8.3 
traffic_portal_build_1   | |   +-- cycle@1.0.3 
traffic_portal_build_1   | |   +-- isstream@0.1.2 
traffic_portal_build_1   | |   +-- pkginfo@0.3.1 
traffic_portal_build_1   | |   `-- stack-trace@0.0.10 
traffic_portal_build_1   | +-- morgan@1.7.0 
traffic_portal_build_1   | | `-- basic-auth@1.0.4 
traffic_portal_build_1   | +-- requirejs@2.1.22 
traffic_portal_build_1   | `-- ssl-root-cas@1.1.10 
traffic_portal_build_1   |   +-- es6-promise@2.3.0 
traffic_portal_build_1   |   `-- request@2.88.0 
traffic_portal_build_1   | +-- aws-sign2@0.7.0 
traffic_portal_build_1   | +-- aws4@1.8.0 
traffic_portal_build_1   | +-- caseless@0.12.0 
traffic_portal_build_1   | +-- combined-stream@1.0.6 
traffic_portal_build_1   | | `-- delayed-stream@1.0.0 
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.2 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.0 
traffic_portal_build_1   | | +-- ajv@5.5.2 
traffic_portal_build_1   | | | +-- co@4.6.0 
traffic_portal_build_1   | | | +-- fast-deep-equal@1.1.0 
traffic_portal_build_1   | | | +-- fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | `-- json-schema-traverse@0.3.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.14.2 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   +-- safer-buffer@2.1.2 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- safe-buffer@5.1.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.1.29 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.2 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL DEPENDENCY: 
fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: 
Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} 
(current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN 

[GitHub] moltzaum commented on issue #2661: Added copyright

[GitBox]

moltzaum commented on issue #2661: Added copyright
URL: https://github.com/apache/trafficcontrol/pull/2661#issuecomment-412549430
 
 
   @dangogh 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] moltzaum opened a new pull request #2661: Added copyright

[GitBox]

moltzaum opened a new pull request #2661: Added copyright
URL: https://github.com/apache/trafficcontrol/pull/2661
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-master-build #988

[Apache Jenkins Server]

See 


Changes:

[mrdgelinas] Add TM poller plugins

[mrdgelinas] Add TM noop stat parser type

--
[...truncated 15.62 MB...]
traffic_portal_build_1   | | | +-- deep-equal@1.0.1 
traffic_portal_build_1   | | | +-- i@0.3.6 
traffic_portal_build_1   | | | +-- mkdirp@0.5.1 
traffic_portal_build_1   | | | | `-- minimist@0.0.8 
traffic_portal_build_1   | | | +-- ncp@0.4.2 
traffic_portal_build_1   | | | `-- rimraf@2.6.2 
traffic_portal_build_1   | | |   `-- glob@7.1.2 
traffic_portal_build_1   | | | +-- fs.realpath@1.0.0 
traffic_portal_build_1   | | | +-- inflight@1.0.6 
traffic_portal_build_1   | | | | `-- wrappy@1.0.2 
traffic_portal_build_1   | | | `-- once@1.4.0 
traffic_portal_build_1   | | `-- winston@0.8.3 
traffic_portal_build_1   | |   +-- cycle@1.0.3 
traffic_portal_build_1   | |   +-- isstream@0.1.2 
traffic_portal_build_1   | |   +-- pkginfo@0.3.1 
traffic_portal_build_1   | |   `-- stack-trace@0.0.10 
traffic_portal_build_1   | +-- morgan@1.7.0 
traffic_portal_build_1   | | `-- basic-auth@1.0.4 
traffic_portal_build_1   | +-- requirejs@2.1.22 
traffic_portal_build_1   | `-- ssl-root-cas@1.1.10 
traffic_portal_build_1   |   +-- es6-promise@2.3.0 
traffic_portal_build_1   |   `-- request@2.88.0 
traffic_portal_build_1   | +-- aws-sign2@0.7.0 
traffic_portal_build_1   | +-- aws4@1.8.0 
traffic_portal_build_1   | +-- caseless@0.12.0 
traffic_portal_build_1   | +-- combined-stream@1.0.6 
traffic_portal_build_1   | | `-- delayed-stream@1.0.0 
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.2 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.0 
traffic_portal_build_1   | | +-- ajv@5.5.2 
traffic_portal_build_1   | | | +-- co@4.6.0 
traffic_portal_build_1   | | | +-- fast-deep-equal@1.1.0 
traffic_portal_build_1   | | | +-- fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | `-- json-schema-traverse@0.3.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.14.2 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   +-- safer-buffer@2.1.2 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- safe-buffer@5.1.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.1.29 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.2 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL DEPENDENCY: 
fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: 
Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} 
(current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done, without errors.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2018-08-13 14:40:52 UTC)
traffic_portal_build_1   | loading tasks  1.3s  ▇▇ 3%
traffic_portal_build_1   | compass:prod   9.4s  
▇▇▇▇▇▇▇▇ 24%
traffic_portal_build_1   | browserify2:app-prod 2s  ▇▇ 5%
traffic_portal_build_1   | browserify2:shared-libs-prod   3.3s  ▇▇▇ 9%
traffic_portal_build_1   | install-dependencies  22.4s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 58%
traffic_portal_build_1   | Total 38.8s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0

[GitHub] elsloo opened a new pull request #2660: Update version of Traffic Control to 3.0.0.

[GitBox]

elsloo opened a new pull request #2660: Update version of Traffic Control to 
3.0.0.
URL: https://github.com/apache/trafficcontrol/pull/2660
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rivasj commented on a change in pull request #2609: Manage Static DNS Entries - front end CRUD implementation

[GitBox]

rivasj commented on a change in pull request #2609: Manage Static DNS Entries - 
front end CRUD implementation
URL: https://github.com/apache/trafficcontrol/pull/2609#discussion_r209634436
 
 

 ##
 File path: traffic_portal/app/src/common/api/StaticDnsEntryService.js
 ##
 @@ -17,13 +17,69 @@
  * under the License.
  */
 
-var StaticDnsEntryService = function(Restangular) {
+var StaticDnsEntryService = function($http, $q, Restangular, locationUtils, 
messageModel, ENV) {
 
this.getStaticDnsEntries = function(queryParams) {
return Restangular.all('staticdnsentries').getList(queryParams);
};
 
+   this.getStaticDnsEntry = function(id) {
 
 Review comment:
   I added the 2nd method so that a single SDE would be returned rather than an 
array containing a single element, it was a more straightforward response to 
handle in the EditController.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dg4prez closed pull request #2659: Add Monitor poll plugins

[GitBox]

dg4prez closed pull request #2659: Add Monitor poll plugins
URL: https://github.com/apache/trafficcontrol/pull/2659
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/lib/go-tc/traffic_monitor.go b/lib/go-tc/traffic_monitor.go
index 2597ed5c3..f789214a3 100644
--- a/lib/go-tc/traffic_monitor.go
+++ b/lib/go-tc/traffic_monitor.go
@@ -97,6 +97,7 @@ type TMParameters struct {
HealthConnectionTimeout int`json:"health.connection.timeout"`
HealthPollingURLstring `json:"health.polling.url"`
HealthPollingFormat string `json:"health.polling.format"`
+   HealthPollingType   string `json:"health.polling.type"`
HistoryCountint`json:"history.count"`
MinFreeKbps int64
Thresholds  map[string]HealthThreshold 
`json:"health_threshold"`
@@ -150,6 +151,22 @@ func (params *TMParameters) UnmarshalJSON(bytes []byte) 
(err error) {
}
}
 
+   if vi, ok := raw["health.polling.format"]; ok {
+   if v, ok := vi.(string); !ok {
+   return fmt.Errorf("Unmarshalling TMParameters 
health.polling.format expected string, got %v", vi)
+   } else {
+   params.HealthPollingFormat = v
+   }
+   }
+
+   if vi, ok := raw["health.polling.type"]; ok {
+   if v, ok := vi.(string); !ok {
+   return fmt.Errorf("Unmarshalling TMParameters 
health.polling.type expected string, got %v", vi)
+   } else {
+   params.HealthPollingType = v
+   }
+   }
+
if vi, ok := raw["history.count"]; ok {
if v, ok := vi.(float64); !ok {
return fmt.Errorf("Unmarshalling TMParameters 
history.count expected integer, got %v", vi)
diff --git a/traffic_monitor/cache/cache.go b/traffic_monitor/cache/cache.go
index d40a340aa..5e01015d3 100644
--- a/traffic_monitor/cache/cache.go
+++ b/traffic_monitor/cache/cache.go
@@ -272,7 +272,7 @@ func StatsMarshall(statResultHistory ResultStatHistory, 
statInfo ResultInfoHisto
 }
 
 // Handle handles results fetched from a cache, parsing the raw Reader data 
and passing it along to a chan for further processing.
-func (handler Handler) Handle(id string, r io.Reader, format string, reqTime 
time.Duration, reqEnd time.Time, reqErr error, pollID uint64, pollFinished 
chan<- uint64) {
+func (handler Handler) Handle(id string, rdr io.Reader, format string, reqTime 
time.Duration, reqEnd time.Time, reqErr error, pollID uint64, pollFinished 
chan<- uint64) {
log.Debugf("poll %v %v (format '%v') handle start\n", pollID, 
time.Now(), format)
result := Result{
ID:   tc.CacheName(id),
@@ -289,13 +289,6 @@ func (handler Handler) Handle(id string, r io.Reader, 
format string, reqTime tim
return
}
 
-   if r == nil {
-   log.Warnf("%v handle reader nil\n", id)
-   result.Error = fmt.Errorf("handler got nil reader")
-   handler.resultChan <- result
-   return
-   }
-
statDecoder, ok := StatsTypeDecoders[format]
if !ok {
log.Errorf("Handler cache '%s' stat type '%s' not found! 
Returning handle error for this cache poll.\n", id, format)
@@ -305,7 +298,7 @@ func (handler Handler) Handle(id string, r io.Reader, 
format string, reqTime tim
}
 
decodeErr := error(nil)
-   if decodeErr, result.Astats.Ats, result.Astats.System = 
statDecoder.Parse(result.ID, r); decodeErr != nil {
+   if decodeErr, result.Astats.Ats, result.Astats.System = 
statDecoder.Parse(result.ID, rdr); decodeErr != nil {
log.Warnf("%s decode error '%v'\n", id, decodeErr)
result.Error = decodeErr
handler.resultChan <- result
diff --git a/traffic_monitor/cache/stats_type_astats.go 
b/traffic_monitor/cache/stats_type_astats.go
index 81588f5c2..11a1917f0 100644
--- a/traffic_monitor/cache/stats_type_astats.go
+++ b/traffic_monitor/cache/stats_type_astats.go
@@ -30,6 +30,7 @@ package cache
 
 import (
"encoding/json"
+   "errors"
"fmt"
"io"
"strconv"
@@ -45,9 +46,13 @@ func init() {
AddStatsType("astats", astatsParse, astatsPrecompute)
 }
 
-func astatsParse(cache tc.CacheName, r io.Reader) (error, 
map[string]interface{}, AstatsSystem) {
+func astatsParse(cache tc.CacheName, rdr io.Reader) (error, 
map[string]interface{}, AstatsSystem) {
+   if rdr == nil {
+   log.Warnln(string(cache) + " handle reader nil")
+   return errors.New("handler got nil reader"), nil, AstatsSystem{}
+   }
astats := Astats{}
-  

[GitHub] rob05c edited a comment on issue #2659: Add Monitor poll plugins

[GitBox]

rob05c edited a comment on issue #2659: Add Monitor poll plugins
URL: https://github.com/apache/trafficcontrol/pull/2659#issuecomment-412379466
 
 
   @dg4prez This should solve the issue you were having, needing to mark caches 
Available without actually polling them.
   
   With this installed, you should be able to create parameters on the cache's 
profile with the names `health.polling.format` and `health.polling.type` config 
file `rascal.properties` value `noop`, and that should do it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on issue #2658: Cache script improvements

[GitBox]

ocket commented on issue #2658: Cache script improvements
URL: https://github.com/apache/trafficcontrol/pull/2658#issuecomment-412515367
 
 
   In which file? Everything I changed has license info...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services