[GitHub] [trafficcontrol] rob05c opened a new pull request #4256: Fix atscfg meta to omit config files for nonexistent delivery services

[GitBox]

rob05c opened a new pull request #4256: Fix atscfg meta to omit config files 
for nonexistent delivery services
URL: https://github.com/apache/trafficcontrol/pull/4256
 
 
   This fixes atscfg to omit files with location parameters for config
   files, hdr_rw_, regex_remap_, url_sig_, and uri_signing_ for DSes
   which don't exist (typically after deleting a DS but forgetting to
   delete the corresponding location Parameters).
   
   This is important to make atstccfg work because without it, ORT will
   request url_sig_ files for DSes which don't exist, and the API
   endpoint to get the keys will fail. Because atstccfg uses the API,
   there's no reasonable way to make it work, except to fix the meta
   config to omit those nonexistent files.
   
   In addition to nonexistent files, this also omits files for DSes
   not assigned to the server. There won't even be remap lines for
   those DSes anyway, so it's better and safer to omit the ancillary
   files altogether.
   
   Tagged major, because it causes bad data to break ORT, where it previously 
didn't and doesn't need to.
   
   Includes tests.
   Includes changelog.
   No documentation, bug fix.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run tests. Request meta config `/api/1.4/servers/{id}/configfiles/ats` on a 
TO with location parameters for a nonexistent DS (the odds are good your 
Production environment has some), and verify those files are no longer in the 
returned JSON.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - 4.0.x RC0
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   ## Additional Information


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #2455: Add TO Go put deliveryservices/id/safe

[GitBox]

ocket commented on a change in pull request #2455: Add TO Go put 
deliveryservices/id/safe
URL: https://github.com/apache/trafficcontrol/pull/2455#discussion_r362998903
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/deliveryservice/safe.go
 ##
 @@ -0,0 +1,128 @@
+package deliveryservice
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+   "database/sql"
+   "errors"
+   "fmt"
+   "net/http"
+
+   "github.com/apache/trafficcontrol/lib/go-tc"
+   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
+   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
+)
+
+func UpdateSafeV14(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV14{tc.DeliveryServiceNullableV14(ds)})
+}
+
+func UpdateSafeV13(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV13{ds.DeliveryServiceNullableV13})
+}
+
+func UpdateSafeV12(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV12{ds.DeliveryServiceNullableV12})
+}
+
+// UpdateSafe updates the delivery service, writing any errors. Returns true 
on success, or false on error. If an error occured, it will be written to the 
client and logged appropriately, and the caller shouldn't write anything 
further. On success, the caller should write the delivery service response to 
the client.
+func UpdateSafe(w http.ResponseWriter, r *http.Request) 
(tc.DeliveryServiceNullable, bool) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"id"}, 
[]string{"id"})
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+   defer inf.Close()
+
+   dsID := inf.IntParams["id"]
+
+   userErr, sysErr, errCode = tenant.CheckID(inf.Tx.Tx, inf.User, dsID)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   ds := tc.DeliveryServiceSafeUpdate{}
+   if err := api.Parse(r.Body, inf.Tx.Tx, &ds); err != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest, 
errors.New("decoding: "+err.Error()), nil)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   ok, err := updateDSSafe(inf.Tx.Tx, dsID, ds)
+   if err != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, 
nil, errors.New("updating delivery service safe: "+err.Error()))
+   return tc.DeliveryServiceNullable{}, false
+   }
+   if !ok {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusNotFound, nil, nil)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   dses, userErr, sysErr, errCode := readGetDeliveryServices(inf.Params, 
inf.Tx, inf.User)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+   if len(dses) != 1 {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, 
nil, fmt.Errorf("delivery service safe update, read expected 1 delivery 
service, got %v", len(dses)))
+   return tc.DeliveryServiceNullable{}, false
+   }
+   return dses[0], true
+}
+
+// updateDSSafe updates the given delivery service in the database. Returns 
whether the DS existed, and any error.
+func updateDSSafe(tx *sql.Tx, dsID int, ds tc.DeliveryServiceSafeUpdate) 
(bool, error) {
+   q :

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #2455: Add TO Go put deliveryservices/id/safe

[GitBox]

rawlinp commented on a change in pull request #2455: Add TO Go put 
deliveryservices/id/safe
URL: https://github.com/apache/trafficcontrol/pull/2455#discussion_r362989476
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/deliveryservice/safe.go
 ##
 @@ -0,0 +1,128 @@
+package deliveryservice
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+   "database/sql"
+   "errors"
+   "fmt"
+   "net/http"
+
+   "github.com/apache/trafficcontrol/lib/go-tc"
+   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
+   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
+)
+
+func UpdateSafeV14(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV14{tc.DeliveryServiceNullableV14(ds)})
+}
+
+func UpdateSafeV13(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV13{ds.DeliveryServiceNullableV13})
+}
+
+func UpdateSafeV12(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV12{ds.DeliveryServiceNullableV12})
+}
+
+// UpdateSafe updates the delivery service, writing any errors. Returns true 
on success, or false on error. If an error occured, it will be written to the 
client and logged appropriately, and the caller shouldn't write anything 
further. On success, the caller should write the delivery service response to 
the client.
+func UpdateSafe(w http.ResponseWriter, r *http.Request) 
(tc.DeliveryServiceNullable, bool) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"id"}, 
[]string{"id"})
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+   defer inf.Close()
+
+   dsID := inf.IntParams["id"]
+
+   userErr, sysErr, errCode = tenant.CheckID(inf.Tx.Tx, inf.User, dsID)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   ds := tc.DeliveryServiceSafeUpdate{}
+   if err := api.Parse(r.Body, inf.Tx.Tx, &ds); err != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest, 
errors.New("decoding: "+err.Error()), nil)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   ok, err := updateDSSafe(inf.Tx.Tx, dsID, ds)
+   if err != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, 
nil, errors.New("updating delivery service safe: "+err.Error()))
+   return tc.DeliveryServiceNullable{}, false
+   }
+   if !ok {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusNotFound, nil, nil)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   dses, userErr, sysErr, errCode := readGetDeliveryServices(inf.Params, 
inf.Tx, inf.User)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+   if len(dses) != 1 {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, 
nil, fmt.Errorf("delivery service safe update, read expected 1 delivery 
service, got %v", len(dses)))
+   return tc.DeliveryServiceNullable{}, false
+   }
+   return dses[0], true
+}
+
+// updateDSSafe updates the given delivery service in the database. Returns 
whether the DS existed, and any error.
+func updateDSSafe(tx *sql.Tx, dsID int, ds tc.DeliveryServiceSafeUpdate) 
(bool, error) {
+   q := 

[GitHub] [trafficcontrol] ocket8888 edited a comment on issue #4254: updated TP to use API 1.5 and TO perl to use 1.5

[GitBox]

ocket edited a comment on issue #4254: updated TP to use API 1.5 and TO 
perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#issuecomment-570723754
 
 
   > _"TO-Go doesn't yet serve any 1.5 routes yet"_
   
   That's right, idk what's wrong with me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4254: updated TP to use API 1.5 and TO perl to use 1.5

[GitBox]

ocket commented on issue #4254: updated TP to use API 1.5 and TO perl to 
use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#issuecomment-570723754
 
 
   > _"TO-Go doesn't yet serve any 1.5 routes yet"_
   That's right, idk what's wrong with me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-PR #5003

[Apache Jenkins Server]

See 

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #2455: Add TO Go put deliveryservices/id/safe

[GitBox]

ocket commented on a change in pull request #2455: Add TO Go put 
deliveryservices/id/safe
URL: https://github.com/apache/trafficcontrol/pull/2455#discussion_r362987955
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/deliveryservice/safe.go
 ##
 @@ -0,0 +1,128 @@
+package deliveryservice
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+   "database/sql"
+   "errors"
+   "fmt"
+   "net/http"
+
+   "github.com/apache/trafficcontrol/lib/go-tc"
+   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
+   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
+)
+
+func UpdateSafeV14(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV14{tc.DeliveryServiceNullableV14(ds)})
+}
+
+func UpdateSafeV13(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV13{ds.DeliveryServiceNullableV13})
+}
+
+func UpdateSafeV12(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV12{ds.DeliveryServiceNullableV12})
+}
+
+// UpdateSafe updates the delivery service, writing any errors. Returns true 
on success, or false on error. If an error occured, it will be written to the 
client and logged appropriately, and the caller shouldn't write anything 
further. On success, the caller should write the delivery service response to 
the client.
+func UpdateSafe(w http.ResponseWriter, r *http.Request) 
(tc.DeliveryServiceNullable, bool) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"id"}, 
[]string{"id"})
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+   defer inf.Close()
+
+   dsID := inf.IntParams["id"]
+
+   userErr, sysErr, errCode = tenant.CheckID(inf.Tx.Tx, inf.User, dsID)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   ds := tc.DeliveryServiceSafeUpdate{}
+   if err := api.Parse(r.Body, inf.Tx.Tx, &ds); err != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest, 
errors.New("decoding: "+err.Error()), nil)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   ok, err := updateDSSafe(inf.Tx.Tx, dsID, ds)
+   if err != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, 
nil, errors.New("updating delivery service safe: "+err.Error()))
+   return tc.DeliveryServiceNullable{}, false
+   }
+   if !ok {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusNotFound, nil, nil)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   dses, userErr, sysErr, errCode := readGetDeliveryServices(inf.Params, 
inf.Tx, inf.User)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+   if len(dses) != 1 {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, 
nil, fmt.Errorf("delivery service safe update, read expected 1 delivery 
service, got %v", len(dses)))
+   return tc.DeliveryServiceNullable{}, false
+   }
+   return dses[0], true
+}
+
+// updateDSSafe updates the given delivery service in the database. Returns 
whether the DS existed, and any error.
+func updateDSSafe(tx *sql.Tx, dsID int, ds tc.DeliveryServiceSafeUpdate) 
(bool, error) {
+   q :

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #2455: Add TO Go put deliveryservices/id/safe

[GitBox]

ocket commented on a change in pull request #2455: Add TO Go put 
deliveryservices/id/safe
URL: https://github.com/apache/trafficcontrol/pull/2455#discussion_r362987955
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/deliveryservice/safe.go
 ##
 @@ -0,0 +1,128 @@
+package deliveryservice
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+   "database/sql"
+   "errors"
+   "fmt"
+   "net/http"
+
+   "github.com/apache/trafficcontrol/lib/go-tc"
+   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
+   "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
+)
+
+func UpdateSafeV14(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV14{tc.DeliveryServiceNullableV14(ds)})
+}
+
+func UpdateSafeV13(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV13{ds.DeliveryServiceNullableV13})
+}
+
+func UpdateSafeV12(w http.ResponseWriter, r *http.Request) {
+   ds, ok := UpdateSafe(w, r)
+   if !ok {
+   return
+   }
+   api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice safe 
update was successful.", 
[]tc.DeliveryServiceNullableV12{ds.DeliveryServiceNullableV12})
+}
+
+// UpdateSafe updates the delivery service, writing any errors. Returns true 
on success, or false on error. If an error occured, it will be written to the 
client and logged appropriately, and the caller shouldn't write anything 
further. On success, the caller should write the delivery service response to 
the client.
+func UpdateSafe(w http.ResponseWriter, r *http.Request) 
(tc.DeliveryServiceNullable, bool) {
+   inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"id"}, 
[]string{"id"})
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+   defer inf.Close()
+
+   dsID := inf.IntParams["id"]
+
+   userErr, sysErr, errCode = tenant.CheckID(inf.Tx.Tx, inf.User, dsID)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   ds := tc.DeliveryServiceSafeUpdate{}
+   if err := api.Parse(r.Body, inf.Tx.Tx, &ds); err != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest, 
errors.New("decoding: "+err.Error()), nil)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   ok, err := updateDSSafe(inf.Tx.Tx, dsID, ds)
+   if err != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, 
nil, errors.New("updating delivery service safe: "+err.Error()))
+   return tc.DeliveryServiceNullable{}, false
+   }
+   if !ok {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusNotFound, nil, nil)
+   return tc.DeliveryServiceNullable{}, false
+   }
+
+   dses, userErr, sysErr, errCode := readGetDeliveryServices(inf.Params, 
inf.Tx, inf.User)
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+   return tc.DeliveryServiceNullable{}, false
+   }
+   if len(dses) != 1 {
+   api.HandleErr(w, r, inf.Tx.Tx, http.StatusInternalServerError, 
nil, fmt.Errorf("delivery service safe update, read expected 1 delivery 
service, got %v", len(dses)))
+   return tc.DeliveryServiceNullable{}, false
+   }
+   return dses[0], true
+}
+
+// updateDSSafe updates the given delivery service in the database. Returns 
whether the DS existed, and any error.
+func updateDSSafe(tx *sql.Tx, dsID int, ds tc.DeliveryServiceSafeUpdate) 
(bool, error) {
+   q :

[GitHub] [trafficcontrol] rawlinp commented on issue #4254: updated TP to use API 1.5 and TO perl to use 1.5

[GitBox]

rawlinp commented on issue #4254: updated TP to use API 1.5 and TO perl to use 
1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#issuecomment-570721674
 
 
   > IDK if that's necessarily true, TO (go) already serves 1.5 and making TO 
(perl) do it rounds out that support, so TP should be fine. Anything else is 
pinned to <= 1.4 so it won't care.
   
   TO-Go doesn't yet serve any 1.5 routes yet


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4254: updated TP to use API 1.5 and TO perl to use 1.5

[GitBox]

ocket commented on issue #4254: updated TP to use API 1.5 and TO perl to 
use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#issuecomment-570721048
 
 
   IDK if that's necessarily true, TO (go) already serves 1.5 and making TO 
(perl) do it rounds out that support, so TP should be fine. Anything else is 
pinned to <= 1.4 so it won't care.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4254: updated TP to use API 1.5 and TO perl to use 1.5

[GitBox]

mattjackson220 commented on a change in pull request #4254: updated TP to use 
API 1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#discussion_r362985423
 
 

 ##
 File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
 ##
 @@ -64,6 +64,12 @@ sub define {
# Traffic Stats Extension 1.4
$self->traffic_stats_routes( $r, $version );
 
+   # 1.5 Routes
 
 Review comment:
   fixed. sorry about that


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4255: Fix incorrect documented roles

[GitBox]

ocket opened a new pull request #4255: Fix incorrect documented roles
URL: https://github.com/apache/trafficcontrol/pull/4255
 
 
   ## What does this PR (Pull Request) do?
   - [x] This PR fixes #4238
   
   ## Which Traffic Control components are affected by this PR?
   - Documentation
   
   ## What is the best way to verify this PR?
   Build the documentation, ensure no warnings/errors, read the output to 
ensure it's now correct
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   - 4.0.0 (RC1)
   
   ## The following criteria are ALL met by this PR
   - [x] Tests are unnecessary
   - [x] This PR includes documentation
   - [ ] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4254: updated TP to use API 1.5 and TO perl to use 1.5

[GitBox]

rawlinp commented on a change in pull request #4254: updated TP to use API 1.5 
and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#discussion_r362983784
 
 

 ##
 File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
 ##
 @@ -64,6 +64,12 @@ sub define {
# Traffic Stats Extension 1.4
$self->traffic_stats_routes( $r, $version );
 
+   # 1.5 Routes
 
 Review comment:
   🚨 wee woo 🚨 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4254: updated TP to use API 1.5 and TO perl to use 1.5

[GitBox]

mitchell852 commented on issue #4254: updated TP to use API 1.5 and TO perl to 
use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#issuecomment-570718993
 
 
   Pretty sure this PR can NOT be merged until #4198 is merged. #4198 is the PR 
that introduces api 1.5 and is necessary before you can make calls to 1.5.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #2455: Add TO Go put deliveryservices/id/safe

[GitBox]

rawlinp commented on a change in pull request #2455: Add TO Go put 
deliveryservices/id/safe
URL: https://github.com/apache/trafficcontrol/pull/2455#discussion_r362983524
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/routing/routes.go
 ##
 @@ -544,6 +544,10 @@ func Routes(d ServerData) ([]Route, []RawRoute, 
http.Handler, error) {
{1.3, http.MethodPost, `deliveryservices/?(\.json)?$`, 
deliveryservice.CreateV13, auth.PrivLevelOperations, Authenticated, nil, 
1705681904, noPerlBypass},
{1.1, http.MethodPost, `deliveryservices/?(\.json)?$`, 
deliveryservice.CreateV12, auth.PrivLevelOperations, Authenticated, nil, 
652813412, noPerlBypass},
 
+   {1.4, http.MethodPut, `deliveryservices/{id}/safe/?(\.json)?$`, 
deliveryservice.UpdateSafeV14, auth.PrivLevelOperations, Authenticated, nil, 
547210934, noPerlBypass},
+   {1.3, http.MethodPut, `deliveryservices/{id}/safe/?(\.json)?$`, 
deliveryservice.UpdateSafeV13, auth.PrivLevelOperations, Authenticated, nil, 
547210933, noPerlBypass},
+   {1.1, http.MethodPut, `deliveryservices/{id}/safe/?(\.json)?$`, 
deliveryservice.UpdateSafeV12, auth.PrivLevelOperations, Authenticated, nil, 
547210931, noPerlBypass},
 
 Review comment:
   Would you be opposed to keeping this API "unversioned" or pinned to one 
particular minor version? It would be nice to keep the minor version overhead 
down where possible, and this API is designed to be safe enough to not need 
minor versioning promises (since it only cares about those 4 "safe" fields). If 
we added another "safe" field, we could add a new minor version for that 
instead?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4254: updated TP to use API 1.5 and TO perl to use 1.5

[GitBox]

mitchell852 commented on a change in pull request #4254: updated TP to use API 
1.5 and TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254#discussion_r362983171
 
 

 ##
 File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
 ##
 @@ -64,6 +64,12 @@ sub define {
# Traffic Stats Extension 1.4
$self->traffic_stats_routes( $r, $version );
 
+   # 1.5 Routes
 
 Review comment:
   the formatting police are going to get you :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1735

[Apache Jenkins Server]

See 

[GitHub] [trafficcontrol] mattjackson220 edited a comment on issue #4198: EDNS0 Client Subnet for Delivery Services

[GitBox]

mattjackson220 edited a comment on issue #4198: EDNS0 Client Subnet for 
Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/4198#issuecomment-570715788
 
 
   > Also, I'm not sure if you want to do this as a follow-up PR or in this 
one, but in order for TP to work with the new DS field, it needs to be pointed 
to 1.5 now -- which I'm pretty sure is this:
   > 
   > ```
   > traffic_portal/app/src/scripts/config.js:.constant('ENV', { api: { 
root:'/api/1.4/' } })
   > ```
   > 
   > With TP making 1.5 requests, I think TO-Perl also needs updated to have a 
1.5 section so that any remaining Perl routes will be found when requesting 
1.5, like there are for 1.4:
   > 
   > ```
   > TrafficOpsRoutes.pm: # 1.4 Routes
   > TrafficOpsRoutes.pm:$version = "1.4";
   > ```
   
   I'll open a new PR for this so it isn't tied up with this one.  Here's the 
new one: PR #4254 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1734

[Apache Jenkins Server]

See 


Changes:


--
[...truncated 91 B...]
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://github.com/apache/trafficcontrol.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Error performing git command
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2181)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2140)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2136)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1741)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1753)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.setRemoteUrl(CliGitAPIImpl.java:1387)
at hudson.plugins.git.GitAPI.setRemoteUrl(GitAPI.java:160)
at sun.reflect.GeneratedMethodAccessor47.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:929)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:903)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:855)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H30
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:957)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:283)
at com.sun.proxy.$Proxy120.setRemoteUrl(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.setRemoteUrl(RemoteGitImpl.java:295)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:882)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
at java.lang.Thread.start(Thread.java:

[GitHub] [trafficcontrol] mattjackson220 opened a new pull request #4254: updated TP to use API 1.5 and TO perl to use 1.5

[GitBox]

mattjackson220 opened a new pull request #4254: updated TP to use API 1.5 and 
TO perl to use 1.5
URL: https://github.com/apache/trafficcontrol/pull/4254
 
 
   
   ## What does this PR (Pull Request) do?
   
   
   - [x] This PR is not related to any Issue 
   
   
   ## Which Traffic Control components are affected by this PR?
   
   
   - Traffic Ops
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   
   Verify that requests from TP go to the 1.5 API and that TO perl accepts 
requests to the 1.5 API
   
   
   ## The following criteria are ALL met by this PR
   
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1733

[Apache Jenkins Server]

See 


Changes:


--
Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on H30 (ubuntu) in workspace 

using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://github.com/apache/trafficcontrol.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress -- git://github.com/apache/trafficcontrol.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: remote: Enumerating objects: 1, done.
remote: Counting objects: 100% (1/1)remote: Counting objects: 100% 
(1/1), done.
Receiving objects:   0% (1/110231)   Receiving objects:   1% (1103/110231)   
Receiving objects:   2% (2205/110231)   Receiving objects:   3% (3307/110231)   
Receiving objects:   4% (4410/110231)   Receiving objects:   5% (5512/110231)   
Receiving objects:   6% (6614/110231)   Receiving objects:   7% (7717/110231)   
Receiving objects:   8% (8819/110231)   Receiving objects:   9% (9921/110231)   
Receiving objects:  10% (11024/110231)   Receiving objects:  11% 
(12126/110231), 5.73 MiB | 11.45 MiB/s   Receiving objects:  12% 
(13228/110231), 5.73 MiB | 11.45 MiB/s   Receiving objects:  13% 
(14331/110231), 5.73 MiB | 11.45 MiB/s   Receiving objects:  13% 
(14805/110231), 5.73 MiB | 11.45 MiB/s   Receiving objects:  14% 
(15433/110231), 13.71 MiB | 13.70 MiB/s   Receiving objects:  15% 
(16535/110231), 13.71 MiB | 13.70 MiB/s   Receiving objects:  16% 
(17637/110231), 13.71 MiB | 13.70 MiB/s   Receiving objects:  17% 
(18740/110231), 13.71 MiB | 13.70 MiB/s   Receiving objects:  18% 
(19842/110231), 13.71 MiB | 13.70 MiB/s   Receiving objects:  19% 
(20944/110231), 13.71 MiB | 13.70 MiB/s   Receiving objects:  20% 
(22047/110231), 13.71 MiB | 13.70 MiB/s   Receiving objects:  20% 
(22935/110231), 30.57 MiB | 15.28 MiB/s   Receiving objects:  21% 
(23149/110231), 43.09 MiB | 17.24 MiB/s   Receiving objects:  22% 
(24251/110231), 43.09 MiB | 17.24 MiB/s   Receiving objects:  23% 
(25354/110231), 43.09 MiB | 17.24 MiB/s   Receiving objects:  24% 
(26456/110231), 43.09 MiB | 17.24 MiB/s   Receiving objects:  25% 
(27558/110231), 43.09 MiB | 17.24 MiB/s   Receiving objects:  25% 
(28246/110231), 43.09 MiB | 17.24 MiB/s   Receiving objects:  26% 
(28661/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  27% 
(29763/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  28% 
(30865/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  29% 
(31967/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  30% 
(33070/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  31% 
(34172/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  32% 
(35274/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  33% 
(36377/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  34% 
(37479/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  35% 
(38581/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  36% 
(39684/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  37% 
(40786/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  38% 
(41888/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  39% 
(42991/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  40% 
(44093/110231), 52.09 MiB | 17.36 MiB/s   Receiving objects:  41% 
(45195/110231), 58.95 MiB | 16.84 MiB/s   Receiving objects:  42% 
(46298/110231), 58.95 MiB | 16.84 MiB/s   Receiving object

[GitHub] [trafficcontrol] ocket8888 commented on issue #4238: Incorrect roles required in deliveryservices/id/ documentation

[GitBox]

ocket commented on issue #4238: Incorrect roles required in 
deliveryservices/id/ documentation
URL: https://github.com/apache/trafficcontrol/issues/4238#issuecomment-570716204
 
 
   err, actually that's not true. `deliveryservices/{{ID}}/routing`, 
`deliveryservices/{{ID}}/health`, and `deliveryservices/{{ID}}/capacity` all 
allow you to bypass *Delivery Service-to-user* assignments with >= operator 
permissions. Not tenancy restrictions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mattjackson220 commented on issue #4198: EDNS0 Client Subnet for Delivery Services

[GitBox]

mattjackson220 commented on issue #4198: EDNS0 Client Subnet for Delivery 
Services
URL: https://github.com/apache/trafficcontrol/pull/4198#issuecomment-570715788
 
 
   > Also, I'm not sure if you want to do this as a follow-up PR or in this 
one, but in order for TP to work with the new DS field, it needs to be pointed 
to 1.5 now -- which I'm pretty sure is this:
   > 
   > ```
   > traffic_portal/app/src/scripts/config.js:.constant('ENV', { api: { 
root:'/api/1.4/' } })
   > ```
   > 
   > With TP making 1.5 requests, I think TO-Perl also needs updated to have a 
1.5 section so that any remaining Perl routes will be found when requesting 
1.5, like there are for 1.4:
   > 
   > ```
   > TrafficOpsRoutes.pm: # 1.4 Routes
   > TrafficOpsRoutes.pm:$version = "1.4";
   > ```
   
   I'll open a new PR for this so it isn't tied up with this one


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4198: EDNS0 Client Subnet for Delivery Services

[GitBox]

mattjackson220 commented on a change in pull request #4198: EDNS0 Client Subnet 
for Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/4198#discussion_r362980367
 
 

 ##
 File path: CHANGELOG.md
 ##
 @@ -10,6 +10,9 @@ The format is based on [Keep a 
Changelog](http://keepachangelog.com/en/1.0.0/).
 
 ### Deprecated/Removed
 - The TO API `servers/totals` endpoint is now deprecated
+- Added a boolean to delivery service in Traffic Portal and Traffic Ops to 
enable EDNS0 client subnet at the delivery service level and include it in the 
cr-config.
 
 Review comment:
   done. sorry about that


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4238: Incorrect roles required in deliveryservices/id/ documentation

[GitBox]

ocket commented on issue #4238: Incorrect roles required in 
deliveryservices/id/ documentation
URL: https://github.com/apache/trafficcontrol/issues/4238#issuecomment-570715312
 
 
   `deliveryservices/{{ID}}/routing` is a special case; it allows the user to 
bypass tenancy restrictions if they have the "operator" or "admin" Role. Which 
is interesting. I've made note of it in a PR I'm working on to address this 
issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1732

[Apache Jenkins Server]

See 


Changes:


--
Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on H30 (ubuntu) in workspace 

using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://github.com/apache/trafficcontrol.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress -- git://github.com/apache/trafficcontrol.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: remote: Enumerating objects: 1, done.
remote: Counting objects: 100% (1/1)remote: Counting objects: 100% 
(1/1), done.
error: cannot fork() for index-pack: Resource temporarily unavailable
fatal: fetch-pack: unable to fork off index-pack

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2172)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1864)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:78)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:545)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H30
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:957)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
at sun.reflect.GeneratedMethodAccessor975.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
at com.sun.proxy.$Proxy137.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:892)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.ja

[GitHub] [trafficcontrol] rawlinp closed issue #4244: GET /api/1.x/api_capabilities returns `route` instead of `httpRoute`

[GitBox]

rawlinp closed issue #4244: GET /api/1.x/api_capabilities returns `route` 
instead of `httpRoute`
URL: https://github.com/apache/trafficcontrol/issues/4244
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp merged pull request #4253: Fixed improperly labeled 'httpRoute' field in api_capabilities responses

[GitBox]

rawlinp merged pull request #4253: Fixed improperly labeled 'httpRoute' field 
in api_capabilities responses
URL: https://github.com/apache/trafficcontrol/pull/4253
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp commented on issue #4198: EDNS0 Client Subnet for Delivery Services

[GitBox]

rawlinp commented on issue #4198: EDNS0 Client Subnet for Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/4198#issuecomment-570714016
 
 
   Also, I'm not sure if you want to do this as a follow-up PR or in this one, 
but in order for TP to work with the new DS field, it needs to be pointed to 
1.5 now -- which I'm pretty sure is this: 
   ```
   traffic_portal/app/src/scripts/config.js:.constant('ENV', { api: { 
root:'/api/1.4/' } })
   ```
   With TP making 1.5 requests, I think TO-Perl also needs updated to have a 
1.5 section so that any remaining Perl routes will be found when requesting 
1.5, like there are for 1.4:
   ```
   TrafficOpsRoutes.pm: # 1.4 Routes
   TrafficOpsRoutes.pm:$version = "1.4";
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1731

[Apache Jenkins Server]

See 


Changes:


--
Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on H30 (ubuntu) in workspace 

using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://github.com/apache/trafficcontrol.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress -- git://github.com/apache/trafficcontrol.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: remote: Enumerating objects: 110222, done.
error: cannot fork() for index-pack: Resource temporarily unavailable
fatal: fetch-pack: unable to fork off index-pack

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2172)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1864)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:78)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:545)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H30
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:957)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
at sun.reflect.GeneratedMethodAccessor975.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
at com.sun.proxy.$Proxy137.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:892)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBui

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1730

[Apache Jenkins Server]

See 


Changes:


--
Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on H30 (ubuntu) in workspace 

using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://github.com/apache/trafficcontrol.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress -- git://github.com/apache/trafficcontrol.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: remote: Enumerating objects: 110222, done.
Receiving objects:   0% (1/110222)   Receiving objects:   1% (1103/110222)   
Receiving objects:   2% (2205/110222)   Receiving objects:   3% (3307/110222)   
Receiving objects:   4% (4409/110222)   Receiving objects:   5% (5512/110222)   
Receiving objects:   6% (6614/110222)   Receiving objects:   7% (7716/110222)   
Receiving objects:   8% (8818/110222)   Receiving objects:   9% (9920/110222)   
Receiving objects:  10% (11023/110222)   Receiving objects:  11% 
(12125/110222), 5.68 MiB | 11.36 MiB/s   Receiving objects:  12% 
(13227/110222), 5.68 MiB | 11.36 MiB/s   Receiving objects:  12% 
(14308/110222), 5.68 MiB | 11.36 MiB/s   Receiving objects:  13% 
(14329/110222), 13.43 MiB | 13.42 MiB/s   Receiving objects:  14% 
(15432/110222), 13.43 MiB | 13.42 MiB/s   Receiving objects:  15% 
(16534/110222), 13.43 MiB | 13.42 MiB/s   Receiving objects:  16% 
(17636/110222), 13.43 MiB | 13.42 MiB/s   Receiving objects:  17% 
(18738/110222), 13.43 MiB | 13.42 MiB/s   Receiving objects:  18% 
(19840/110222), 13.43 MiB | 13.42 MiB/s   Receiving objects:  19% 
(20943/110222), 13.43 MiB | 13.42 MiB/s   Receiving objects:  20% 
(22045/110222), 13.43 MiB | 13.42 MiB/s   Receiving objects:  20% 
(22932/110222), 29.60 MiB | 14.80 MiB/s   Receiving objects:  21% 
(23147/110222), 40.63 MiB | 16.25 MiB/s   Receiving objects:  22% 
(24249/110222), 40.63 MiB | 16.25 MiB/s   Receiving objects:  23% 
(25352/110222), 40.63 MiB | 16.25 MiB/s   Receiving objects:  23% 
(26378/110222), 40.63 MiB | 16.25 MiB/s   Receiving objects:  24% 
(26454/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  25% 
(27556/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  26% 
(28658/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  27% 
(29760/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  28% 
(30863/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  29% 
(31965/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  30% 
(33067/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  31% 
(34169/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  32% 
(35272/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  33% 
(36374/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  34% 
(37476/110222), 50.86 MiB | 16.95 MiB/s   Receiving objects:  35% 
(38578/110222), 57.59 MiB | 16.45 MiB/s   Receiving objects:  36% 
(39680/110222), 57.59 MiB | 16.45 MiB/s   Receiving objects:  37% 
(40783/110222), 57.59 MiB | 16.45 MiB/s   Receiving objects:  38% 
(41885/110222), 57.59 MiB | 16.45 MiB/s   Receiving objects:  39% 
(42987/110222), 57.59 MiB | 16.45 MiB/s   Receiving objects:  40% 
(44089/110222), 57.59 MiB | 16.45 MiB/s   Receiving objects:  41% 
(45192/110222), 57.59 MiB | 16.45 MiB/s   Receiving objects:  42% 
(46294/110222), 57.59 MiB | 16.45 MiB/s   Receiving objects:  43% 
(47396/110222), 57.59 MiB | 16.45 MiB/s   Receiving objects:  44% 
(48498/110222),

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1729

[Apache Jenkins Server]

See 


Changes:


--
[...truncated 91 B...]
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
ERROR: Workspace has a .git repository, but it appears to be corrupt.
hudson.plugins.git.GitException: Error performing git command
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2181)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2140)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2136)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1741)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1753)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.hasGitRepo(CliGitAPIImpl.java:329)
at hudson.plugins.git.GitAPI.hasGitRepo(GitAPI.java:232)
at sun.reflect.GeneratedMethodAccessor46.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:929)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:903)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:855)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
at java.lang.Thread.start(Thread.java:717)
at hudson.Proc$LocalProc.(Proc.java:282)
at hudson.Proc$LocalProc.(Proc.java:219)
at hudson.Launcher$LocalLauncher.launch(Launcher.java:937)
at hudson.Launcher$ProcStarter.start(Launcher.java:455)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2168)
... 20 more
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  
 > # timeout=10
ERROR: Error cloning remote repo 'origin'
hudson.plugins.git.GitException: Could not init 

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:916)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:708)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H30
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:957)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
at sun.reflect.GeneratedMethodAccessor975.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
at com.sun.proxy.$Proxy144.execute(Unknown Source)
at hu

[GitHub] [trafficcontrol] ocket8888 closed issue #3832: Rewrite /stats_summary to Go

[GitBox]

ocket closed issue #3832: Rewrite /stats_summary to Go
URL: https://github.com/apache/trafficcontrol/issues/3832
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 merged pull request #4127: Rewrite GET stats_summary from Perl to Golang

[GitBox]

ocket merged pull request #4127: Rewrite GET stats_summary from Perl to 
Golang
URL: https://github.com/apache/trafficcontrol/pull/4127
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4198: EDNS0 Client Subnet for Delivery Services

[GitBox]

rawlinp commented on a change in pull request #4198: EDNS0 Client Subnet for 
Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/4198#discussion_r362970655
 
 

 ##
 File path: CHANGELOG.md
 ##
 @@ -10,6 +10,9 @@ The format is based on [Keep a 
Changelog](http://keepachangelog.com/en/1.0.0/).
 
 ### Deprecated/Removed
 - The TO API `servers/totals` endpoint is now deprecated
+- Added a boolean to delivery service in Traffic Portal and Traffic Ops to 
enable EDNS0 client subnet at the delivery service level and include it in the 
cr-config.
 
 Review comment:
   these should go under the `Added` section


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #5002

[Apache Jenkins Server]

See 


Changes:

[Michael_Hoppal] Rewrite stats_summary from Perl to Golang

[Michael_Hoppal] Add API tests

[Michael_Hoppal] Update Changelog

[github] Update traffic_stats.go

[Michael_Hoppal] Merge conflict

[Michael_Hoppal] Address comments

[Michael_Hoppal] Fix API tests

[Michael_Hoppal] Match perl implementation on stats_summary last updated

[Michael_Hoppal] Fix docs


--
[...truncated 2.90 MB...]
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.3 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.3 
traffic_portal_build_1   | | +-- ajv@6.10.2 
traffic_portal_build_1   | | | +-- fast-deep-equal@2.0.1 
traffic_portal_build_1   | | | +-- 
fast-json-stable-stringify@2.1.0 
traffic_portal_build_1   | | | +-- json-schema-traverse@0.4.1 
traffic_portal_build_1   | | | `-- uri-js@4.2.2 
traffic_portal_build_1   | | |   `-- punycode@2.1.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.16.1 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.7.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.3 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.11: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2020-01-03 21:53:44 UTC)
traffic_portal_build_1   | loading tasks  1.3s  ▇▇ 
3%
traffic_portal_build_1   | compass:prod   9.7s  
▇▇▇▇▇▇▇▇ 24%
traffic_portal_build_1   | browserify2:app-prod   2.1s  ▇▇ 
5%
traffic_portal_build_1   | browserify2:shared-libs-prod   2.7s  
▇▇▇ 7%
traffic_portal_build_1   | install-dependencies  23.7s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 60%
traffic_portal_build_1   | Total 39.9s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0
traffic_portal_build_1   | Executing(%install): /bin/sh -e 
/var/tmp/rpm-tmp.6n3cAh
traffic_portal_build_1   | + umask 022
traffic_portal_build_1   | + cd 
/tmp/go/src/github.com/apache/trafficcontrol/rpmbuild/BUILD
traffic_portal_build_1   | + '[' 
/tmp/go/src/github.com/apache/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-4.0.0-10424.59650a57.el7.x86_64
 '!=' / ']'
traffic_portal_build_1   | + rm -rf 
/tmp/go/src/github.com/apache/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-4.0.0-10424.59650a57.el7.x86_64
traffic_portal_build_1   | ++ dirname 
/tmp/go/src/github.com/apache/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-4.0.0-10424.59650a57.el7.x86_64
traffic

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #2455: Add TO Go put deliveryservices/id/safe

[GitBox]

ocket commented on a change in pull request #2455: Add TO Go put 
deliveryservices/id/safe
URL: https://github.com/apache/trafficcontrol/pull/2455#discussion_r362969100
 
 

 ##
 File path: traffic_ops/testing/api/v14/deliveryservicesafe_test.go
 ##
 @@ -0,0 +1,75 @@
+package v14
+
+/*
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+*/
+
+import (
+   "strconv"
+   "testing"
+
+   "github.com/apache/trafficcontrol/lib/go-tc"
+   "github.com/apache/trafficcontrol/lib/go-util"
+)
+
+func TestPutDeliveryServiceSafe(t *testing.T) {
+   WithObjs(t, []TCObj{CDNs, Types, Tenants, Users, Parameters, Profiles, 
Statuses, Divisions, Regions, PhysLocations, CacheGroups, Servers, 
DeliveryServices}, func() {
+   UpdateTestDeliveryServiceSafe(t)
+   })
+}
+
+func UpdateTestDeliveryServiceSafe(t *testing.T) {
+   firstDS := testData.DeliveryServices[0]
+
+   dses, _, err := TOSession.GetDeliveryServices()
+   if err != nil {
+   t.Fatalf("cannot GET Delivery Services: %v\n", err)
+   }
+
+   remoteDS := tc.DeliveryService{}
+   found := false
+   for _, ds := range dses {
+   if ds.XMLID == firstDS.XMLID {
+   found = true
+   remoteDS = ds
+   break
+   }
+   }
+   if !found {
+   t.Fatalf("GET Delivery Services missing: %v\n", firstDS.XMLID)
+   }
+
+   req := tc.DeliveryServiceSafeUpdate{
+   DisplayName: util.StrPtr("safe update display name"),
+   InfoURL: util.StrPtr("safe update info URL"),
+   LongDesc:util.StrPtr("safe update long desc"),
+   LongDesc1:   util.StrPtr("safe update long desc one"),
+   }
+
+   if _, err := TOSession.UpdateDeliveryServiceSafe(remoteDS.ID, &req); 
err != nil {
+   t.Fatalf("cannot UPDATE DeliveryService safe: %v\n", err)
+   }
+
+   updatedDS, _, err := 
TOSession.GetDeliveryService(strconv.Itoa(remoteDS.ID))
+   if err != nil {
+   t.Fatalf("cannot GET Delivery Service by ID: id %v xmlid '%v' - 
%v\n", remoteDS.ID, remoteDS.XMLID, err)
+   }
+   if updatedDS == nil {
+   t.Fatalf("GET Delivery Service by ID returned nil err, but nil 
DS: %v - nil\n", remoteDS.XMLID)
+   }
+
+   if *req.DisplayName != updatedDS.DisplayName || *req.InfoURL != 
updatedDS.InfoURL || *req.LongDesc != updatedDS.LongDesc || *req.LongDesc1 != 
updatedDS.LongDesc1 {
+   t.Fatalf("ds safe update succeeded, but get delivery service 
didn't match. expected: {'%v' '%v' '%v' '%v'} actual: {'%v' '%v' '%v' '%v'}\n", 
*req.DisplayName, *req.InfoURL, *req.LongDesc, *req.LongDesc1, 
updatedDS.DisplayName, updatedDS.InfoURL, updatedDS.LongDesc, 
updatedDS.LongDesc1)
 
 Review comment:
   nit: you don't need to add `\n` to `t.Fatalf`'s first argument; it'll do 
that itself if necessary. We did just get this cleaned up through most of the 
codebase, so it seems a shame to re-introduce it even if it's harmless.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on a change in pull request #3768: Codecov

[GitBox]

lbathina commented on a change in pull request #3768: Codecov
URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r362965121
 
 

 ##
 File path: traffic_monitor/tests/gocover.bash
 ##
 @@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#
+set -e
+
+coverage_out=()
+i=1
+
+for d in $(go list ./... ../lib/... | grep -v vendor); do
+   file="$i.out"
+   go test -v -coverprofile="$file" "$d"
+   if [ -f "$file" ]; then
+   coverage_out+=($file)
+   fi
+   ((i++))
+done
+
+gocovmerge ${coverage_out[*]} > coverage.out
+go tool cover -func=coverage.out
+go-junit-report --package-name=golang.test.tm --set-exit-code > 
/junit/golang.test.tm.xml
+touch coverage_out1
+for pkg in $(go list ./... ../lib/... | grep -v ); do
+   tmp="$(mktemp)"
+   go test -v -coverprofile covProfile "$pkg" > "$tmp"
+   mv -f "$tmp" coverage_out1
+done
 
 Review comment:
   @ocket i better leave it to you. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina closed pull request #3768: Codecov

[GitBox]

lbathina closed pull request #3768: Codecov
URL: https://github.com/apache/trafficcontrol/pull/3768
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3768: Codecov

[GitBox]

ocket commented on a change in pull request #3768: Codecov
URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r362959470
 
 

 ##
 File path: traffic_monitor/tests/gocover.bash
 ##
 @@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#
+set -e
+
+coverage_out=()
+i=1
+
+for d in $(go list ./... ../lib/... | grep -v vendor); do
+   file="$i.out"
+   go test -v -coverprofile="$file" "$d"
+   if [ -f "$file" ]; then
+   coverage_out+=($file)
+   fi
+   ((i++))
+done
+
+gocovmerge ${coverage_out[*]} > coverage.out
+go tool cover -func=coverage.out
+go-junit-report --package-name=golang.test.tm --set-exit-code > 
/junit/golang.test.tm.xml
+touch coverage_out1
+for pkg in $(go list ./... ../lib/... | grep -v ); do
+   tmp="$(mktemp)"
+   go test -v -coverprofile covProfile "$pkg" > "$tmp"
+   mv -f "$tmp" coverage_out1
+done
 
 Review comment:
   It looks like you're now building the coverage profiles twice but only 
reading the results once, and you're no longer writing anything into 
`result.txt` (which might be okay - is it?). My script that I posted in a 
comment on my earlier review wasn't meant as a verbatim example of how to 
accomplish what you're trying to do, merely show that the two ways of getting a 
coverage profile would produce equivalent results.
   
   All you gotta do here is take that bottom `for` loop and paste it over the 
top one, I think. But it is missing some things, including a line which I 
missed in my comment originally (which I think is why). The actual loop should 
look like:
   
   ```bash
   touch coverage_out
   covtmp="$(mktemp)"
   covMergeTmp="$(mktemp)"
   for pkg in $(go list $@ | grep -v vendor); do
tmp="$(mktemp)"
go test -v -coverprofile "$covtmp" | tee -a result.txt
gocovmerge coverage_out "$covtmp" > "$covMergeTmp"
mv -f "$covMergeTmp" coverage_out
   done;
   ```
   which gets you what you're looking for in `result.txt` as well as 
`coverage_out`.
   Then, of course, there's no need to initialize `coverage_out` as a variable 
(since it's a file now) or `i`, and the `gocovmerge` line can be deleted.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #5001

[Apache Jenkins Server]

See 


Changes:

[ocket] TO image: Copy files from a previous build stage instead of

[ocket] Rewrote /federation_resolvers - POST

[ocket] Rewrote /federation_resolvers - GET

[ocket] fix queries

[ocket] Fixed query again

[ocket] Added Go client methods

[ocket] Added client tests

[ocket] go fmt

[ocket] Added DELETE handler

[ocket] Added route

[ocket] Added deprecation notice to path-parameter endpoint

[ocket] Added docs

[ocket] fixed route

[ocket] Fixed missing field

[ocket] Fixed client method to use new endpoint

[ocket] Fix struct tags

[ocket] fix function name to not shadow builtin

[ocket] Change order of data/error returns

[ocket] Added GoDocs

[ocket] More appropriate API version checks

[ocket] go fmt


--
[...truncated 4.13 MB...]
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.3 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.3 
traffic_portal_build_1   | | +-- ajv@6.10.2 
traffic_portal_build_1   | | | +-- fast-deep-equal@2.0.1 
traffic_portal_build_1   | | | +-- 
fast-json-stable-stringify@2.1.0 
traffic_portal_build_1   | | | +-- json-schema-traverse@0.4.1 
traffic_portal_build_1   | | | `-- uri-js@4.2.2 
traffic_portal_build_1   | | |   `-- punycode@2.1.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.16.1 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.7.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.3 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.11: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2020-01-03 20:29:56 UTC)
traffic_portal_build_1   | loading tasks1s  ▇ 3%
traffic_portal_build_1   | compass:prod   8.5s  
▇▇▇▇▇▇▇▇ 25%
traffic_portal_build_1   | browserify2:app-prod   1.9s  ▇▇ 
6%
traffic_portal_build_1   | browserify2:shared-libs-prod   2.5s  
▇▇▇ 7%
traffic_portal_build_1   | install-dependencies  20.2s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 59%
traffic_portal_build_1   | Total 34.4s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0
traffic_portal_build_1   | Executing(%install): /bin/sh -e 
/var/tmp/rpm-tmp.v1D4mY
traffic_portal_build_1   | + umask 022
traffic_portal_build_1   | + cd 
/tmp/go/src/github.com/apache/trafficcontrol/rpmbuild/BUILD
[35

[GitHub] [trafficcontrol] ocket8888 commented on issue #4253: Fixed improperly labeled 'httpRoute' field in api_capabilities responses

[GitBox]

ocket commented on issue #4253: Fixed improperly labeled 'httpRoute' field 
in api_capabilities responses
URL: https://github.com/apache/trafficcontrol/pull/4253#issuecomment-570679266
 
 
   Yeah, you're right, it's not in there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1728

[Apache Jenkins Server]

See 

[GitHub] [trafficcontrol] mitchell852 commented on issue #4253: Fixed improperly labeled 'httpRoute' field in api_capabilities responses

[GitBox]

mitchell852 commented on issue #4253: Fixed improperly labeled 'httpRoute' 
field in api_capabilities responses
URL: https://github.com/apache/trafficcontrol/pull/4253#issuecomment-570676850
 
 
   actually i don't think this bug made it into 4.0


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1727

[Apache Jenkins Server]

See 


Changes:


--
[...truncated 91 B...]
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://github.com/apache/trafficcontrol.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Error performing git command
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2181)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2140)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2136)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1741)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1753)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.setRemoteUrl(CliGitAPIImpl.java:1387)
at hudson.plugins.git.GitAPI.setRemoteUrl(GitAPI.java:160)
at sun.reflect.GeneratedMethodAccessor47.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:929)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:903)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:855)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H30
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:957)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:283)
at com.sun.proxy.$Proxy120.setRemoteUrl(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.setRemoteUrl(RemoteGitImpl.java:295)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:882)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
at java.lang.Thread.start(Thread.java:

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1726

[Apache Jenkins Server]

See 


Changes:


--
[...truncated 23 B...]
[EnvInject] - Loading node environment variables.
Building remotely on H30 (ubuntu) in workspace 

using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://github.com/apache/trafficcontrol.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress -- git://github.com/apache/trafficcontrol.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: remote: Enumerating objects: 29, done.
remote: Counting objects:   3% (1/29)remote: Counting objects:   6% 
(2/29)remote: Counting objects:  10% (3/29)remote: Counting 
objects:  13% (4/29)remote: Counting objects:  17% (5/29)
remote: Counting objects:  20% (6/29)remote: Counting objects:  24% 
(7/29)remote: Counting objects:  27% (8/29)remote: Counting 
objects:  31% (9/29)remote: Counting objects:  34% (10/29)
remote: Counting objects:  37% (11/29)remote: Counting objects:  41% 
(12/29)remote: Counting objects:  44% (13/29)remote: Counting 
objects:  48% (14/29)remote: Counting objects:  51% (15/29)
remote: Counting objects:  55% (16/29)remote: Counting objects:  58% 
(17/29)remote: Counting objects:  62% (18/29)remote: Counting 
objects:  65% (19/29)remote: Counting objects:  68% (20/29)
remote: Counting objects:  72% (21/29)remote: Counting objects:  75% 
(22/29)remote: Counting objects:  79% (23/29)remote: Counting 
objects:  82% (24/29)remote: Counting objects:  86% (25/29)
remote: Counting objects:  89% (26/29)remote: Counting objects:  93% 
(27/29)remote: Counting objects:  96% (28/29)remote: Counting 
objects: 100% (29/29)remote: Counting objects: 100% (29/29), done.  
  
remote: Compressing objects:   3% (1/28)remote: Compressing objects:   
7% (2/28)remote: Compressing objects:  10% (3/28)remote: 
Compressing objects:  14% (4/28)remote: Compressing objects:  17% 
(5/28)remote: Compressing objects:  21% (6/28)remote: 
Compressing objects:  25% (7/28)remote: Compressing objects:  28% 
(8/28)remote: Compressing objects:  32% (9/28)remote: 
Compressing objects:  35% (10/28)remote: Compressing objects:  39% 
(11/28)remote: Compressing objects:  42% (12/28)remote: 
Compressing objects:  46% (13/28)remote: Compressing objects:  50% 
(14/28)remote: Compressing objects:  53% (15/28)remote: 
Compressing objects:  57% (16/28)remote: Compressing objects:  60% 
(17/28)remote: Compressing objects:  64% (18/28)remote: 
Compressing objects:  67% (19/28)remote: Compressing objects:  71% 
(20/28)remote: Compressing objects:  75% (21/28)remote: 
Compressing objects:  78% (22/28)remote: Compressing objects:  82% 
(23/28)remote: Compressing objects:  85% (24/28)remote: 
Compressing objects:  89% (25/28)remote: Compressing objects:  92% 
(26/28)remote: Compressing objects:  96% (27/28)remote: 
Compressing objects: 100% (28/28)remote: Compressing objects: 100% 
(28/28), done.
error: cannot fork() for index-pack: Resource temporarily unavailable
fatal: fet

[GitHub] [trafficcontrol] ocket8888 merged pull request #4247: TO image: Copy files from a previous build stage instead of trafficops-perl

[GitBox]

ocket merged pull request #4247: TO image: Copy files from a previous build 
stage instead of trafficops-perl
URL: https://github.com/apache/trafficcontrol/pull/4247
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #5000

[Apache Jenkins Server]

See 


Changes:

[zach] Add Apache License header


--
[...truncated 2.98 MB...]
traffic_portal_build_1   | + /usr/lib/rpm/check-buildroot
traffic_portal_build_1   | + /usr/lib/rpm/redhat/brp-compress
traffic_portal_build_1   | + /usr/lib/rpm/redhat/brp-strip 
/usr/bin/strip
traffic_portal_build_1   | + 
/usr/lib/rpm/redhat/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump
traffic_portal_build_1   | + 
/usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip
traffic_portal_build_1   | + /usr/lib/rpm/brp-python-bytecompile 
/usr/bin/python 1
traffic_portal_build_1   | + /usr/lib/rpm/redhat/brp-python-hardlink
traffic_portal_build_1   | + /usr/lib/rpm/redhat/brp-java-repack-jars
traffic_portal_build_1   | Processing files: 
traffic_portal-4.0.0-10423.e6dd4533.el7.x86_64
traffic_portal_build_1   | warning: File listed twice: 
/etc/init.d/traffic_portal
traffic_portal_build_1   | warning: File listed twice: 
/opt/traffic_portal/node_modules/forever/bin/forever
traffic_portal_build_1   | warning: File listed twice: 
/opt/traffic_portal/node_modules/forever/bin/monitor
traffic_portal_build_1   | warning: File listed twice: 
/opt/traffic_portal/public/traffic_portal_properties.json
traffic_portal_build_1   | Provides: traffic_portal = 
4.0.0-10423.e6dd4533.el7 traffic_portal(x86-64) = 4.0.0-10423.e6dd4533.el7
traffic_portal_build_1   | Requires(interp): /bin/sh
traffic_portal_build_1   | Requires(rpmlib): rpmlib(FileDigests) <= 
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 
3.0.4-1
traffic_portal_build_1   | Requires(post): /bin/sh
traffic_portal_build_1   | Checking for unpackaged file(s): 
/usr/lib/rpm/check-files 
/tmp/go/src/github.com/apache/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-4.0.0-10423.e6dd4533.el7.x86_64
traffic_portal_build_1   | Wrote: 
/tmp/go/src/github.com/apache/trafficcontrol/rpmbuild/SRPMS/traffic_portal-4.0.0-10423.e6dd4533.el7.src.rpm
traffic_router_build_1   | [INFO] Wrote: 
/tmp/go/src/github.com/apache/trafficcontrol/traffic_router/build/target/rpm/traffic_router/RPMS/x86_64/traffic_router-4.0.0-10423.e6dd4533.el7.x86_64.rpm
traffic_router_build_1   | [INFO] Executing(%clean): /bin/sh -e 
/var/tmp/rpm-tmp.GNVCVR
traffic_router_build_1   | [INFO] + umask 022
traffic_router_build_1   | [INFO] + cd 
/tmp/go/src/github.com/apache/trafficcontrol/traffic_router/build/target/rpm/traffic_router/BUILD
traffic_router_build_1   | [INFO] + /usr/bin/rm -rf 
/tmp/go/src/github.com/apache/trafficcontrol/traffic_router/build/target/rpm/traffic_router/buildroot
traffic_router_build_1   | [INFO] + exit 0
traffic_router_build_1   | [INFO] 

traffic_router_build_1   | [INFO] Reactor Summary for traffic_router 
4.0.0:
traffic_router_build_1   | [INFO] 
traffic_router_build_1   | [INFO] traffic_router 
. SUCCESS [  1.975 s]
traffic_router_build_1   | [INFO] traffic_router_shared 
.. SUCCESS [ 28.010 s]
traffic_router_build_1   | [INFO] traffic_router_connector 
... SUCCESS [ 10.894 s]
traffic_router_build_1   | [INFO] traffic_router_config 
.. SUCCESS [  0.069 s]
traffic_router_build_1   | [INFO] traffic_router_geolocation 
. SUCCESS [  0.118 s]
traffic_router_build_1   | [INFO] ROOT 
... SUCCESS [ 30.462 s]
traffic_router_build_1   | [INFO] traffic_router_rpm 
. SUCCESS [ 20.414 s]
traffic_router_build_1   | [INFO] 

traffic_router_build_1   | [INFO] BUILD SUCCESS
traffic_router_build_1   | [INFO] 

traffic_router_build_1   | [INFO] Total time:  01:33 min
traffic_router_build_1   | [INFO] Finished at: 2020-01-03T19:12:07Z
traffic_router_build_1   | [INFO] 

traffic_router_build_1   | 

traffic_router_build_1   | RPM BUILD SUCCEEDED, See 
/tmp/go/src/github.com/apache/trafficcontrol/dist/traffic_router-4.0.0-10423.e6dd4533.x86_64.rpm
 for the newly built rpm.
traffic_router_build_1   | 
=

Build failed in Jenkins: trafficcontrol-PR #4999

[Apache Jenkins Server]

See 


Changes:

[mitchell852] Fixed CiaB build issue (#4251)

[zach] Copy files from a previous build stage instead of trafficops-perl

[zach] Remove unused traffic_ops_golang binary from trafficops-perl to save 18M

[zach] Avoid RPM spec %post warning warnings about /etc/cron.d not existing

[zach] Ensure that $TRAFFIC_OPS_RPM is defined

[zach] Reduce trafficops-go to a single build stage

[zach] Make TRAFFIC_OPS_RPM an environment variable so trafficops-perl can

[zach] Use trafficops-go as a base image

[zach] Do not copy in files that trafficops-go already added

[zach] Use COPY instead of ADD for local files

[zach] Install Perl modules and goose after Traffic Ops RPM + dependencies

[zach] Omit packages that are installed earlier or later

[zach] Revert "Omit packages that are installed earlier or later"

[zach] Revert "Install Perl modules and goose after Traffic Ops RPM +

[zach] Revert "Use COPY instead of ADD for local files"

[zach] Revert "Do not copy in files that trafficops-go already added"

[zach] Revert "Use trafficops-go as a base image"

[zach] Revert "Make TRAFFIC_OPS_RPM an environment variable so trafficops-perl

[zach] Add dockerignores for trafficops-go and trafficops-perl Dockerfiles


--
[...truncated 3.03 MB...]
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.16.1 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.7.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.3 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.11: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2020-01-03 19:07:48 UTC)
traffic_portal_build_1   | loading tasks  1.2s  ▇ 
3%
traffic_portal_build_1   | compass:prod  10.4s  
▇▇▇▇▇▇▇▇ 25%
traffic_portal_build_1   | browserify2:app-prod   2.3s  
▇▇ 6%
traffic_portal_build_1   | browserify2:shared-libs-prod   3.2s  
▇▇▇ 8%
traffic_portal_build_1   | install-dependencies  24.5s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 58%
traffic_portal_build_1   | Total 42.1s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0
traffic_portal_build_1   | Executing(%install): /bin/sh -e 
/var/tmp/rpm-tmp.raVZK0
traffic_portal_build_1   | + umask 022
traffic_portal_build_1   | + cd 
/tmp/go/src/github.com/apache/trafficcontrol/rpmbuild/BUILD
traffic_portal_build_1   | + '[' 
/tmp/go/src/github.com/apache/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-4.0.0-10422.7e96aaa6.el7.x86_64
 '!=' / ']'
traffic_portal_build_1   | + rm -rf 
/tmp/go/src/github.com/apache/trafficcontrol/rpmbuild/BUILDROOT/traffic_p

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4247: TO image: Copy files from a previous build stage instead of trafficops-perl

[GitBox]

zrhoffman commented on a change in pull request #4247: TO image: Copy files 
from a previous build stage instead of trafficops-perl
URL: https://github.com/apache/trafficcontrol/pull/4247#discussion_r362919538
 
 

 ##
 File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile-go.dockerignore
 ##
 @@ -0,0 +1,10 @@
+# To use this dockerignore:
 
 Review comment:
   Added in e6dd453


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4247: TO image: Copy files from a previous build stage instead of trafficops-perl

[GitBox]

zrhoffman commented on a change in pull request #4247: TO image: Copy files 
from a previous build stage instead of trafficops-perl
URL: https://github.com/apache/trafficcontrol/pull/4247#discussion_r362919557
 
 

 ##
 File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile.dockerignore
 ##
 @@ -0,0 +1,12 @@
+# To use this dockerignore:
 
 Review comment:
   Added in e6dd453


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4247: TO image: Copy files from a previous build stage instead of trafficops-perl

[GitBox]

ocket commented on a change in pull request #4247: TO image: Copy files 
from a previous build stage instead of trafficops-perl
URL: https://github.com/apache/trafficcontrol/pull/4247#discussion_r362917695
 
 

 ##
 File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile.dockerignore
 ##
 @@ -0,0 +1,12 @@
+# To use this dockerignore:
 
 Review comment:
   same as above RE license header


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4247: TO image: Copy files from a previous build stage instead of trafficops-perl

[GitBox]

ocket commented on a change in pull request #4247: TO image: Copy files 
from a previous build stage instead of trafficops-perl
URL: https://github.com/apache/trafficcontrol/pull/4247#discussion_r362917634
 
 

 ##
 File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile-go.dockerignore
 ##
 @@ -0,0 +1,10 @@
+# To use this dockerignore:
 
 Review comment:
   missing license header


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4247: TO image: Copy files from a previous build stage instead of trafficops-perl

[GitBox]

zrhoffman commented on a change in pull request #4247: TO image: Copy files 
from a previous build stage instead of trafficops-perl
URL: https://github.com/apache/trafficcontrol/pull/4247#discussion_r362916701
 
 

 ##
 File path: infrastructure/cdn-in-a-box/docker-compose.yml
 ##
 @@ -58,8 +58,10 @@ services:
   # defined below
   trafficops:
 build:
-  context: .
-  dockerfile: traffic_ops/Dockerfile-go
+  context: ../..
 
 Review comment:
   Added in 7e96aaa. For me, `trafficops-perl` built ~3.5 minutes faster and 
`trafficops-go` built 7 seconds faster. Note that use of these dockerignores 
requires Docker Buildkit. Without it, a limitation of `docker-compose` is only 
one dockerignore per build context. That means we would need to use a single 
dockerignore for all `docker-compose` projects in the repo that use the repo's 
base path as a build context, which IMO is not worth maintaining.
   
   Somewhere down the road, it would be nice to update the Makefile to copy in 
files that CDN-in-a-Box Dockerfiles add to somewhere within the CiaB directory 
itself so we can use the CiaB directory as a build context for all of the 
images.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4198: EDNS0 Client Subnet for Delivery Services

[GitBox]

mattjackson220 commented on a change in pull request #4198: EDNS0 Client Subnet 
for Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/4198#discussion_r362915979
 
 

 ##
 File path: lib/go-tc/deliveryservices.go
 ##
 @@ -164,6 +164,7 @@ type DeliveryServiceNullable struct {
DeliveryServiceNullableV13
ConsistentHashRegex   *string  `json:"consistentHashRegex"`
ConsistentHashQueryParams []string `json:"consistentHashQueryParams"`
+   EcsEnabledbool `json:"ecsEnabled" db:"ecs_enabled"`
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4198: EDNS0 Client Subnet for Delivery Services

[GitBox]

mattjackson220 commented on a change in pull request #4198: EDNS0 Client Subnet 
for Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/4198#discussion_r362916025
 
 

 ##
 File path: 
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/NameServer.java
 ##
 @@ -162,6 +162,34 @@ private void addAnswers(final Message request, final 
Message response, final Ine
}
}
 
+   @SuppressWarnings({"PMD.UseStringBufferForStringAppends"})
+   private boolean isDeliveryServiceEcsEnabled(final Name name) { //, int 
qtype, InetAddress clientAddress) {
 
 Review comment:
   removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4198: EDNS0 Client Subnet for Delivery Services

[GitBox]

mattjackson220 commented on a change in pull request #4198: EDNS0 Client Subnet 
for Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/4198#discussion_r362915930
 
 

 ##
 File path: docs/source/api/deliveryservices.rst
 ##
 @@ -90,6 +90,10 @@ Response Structure
 :dnsBypassIp6:  A :ref:`ds-dns-bypass-ipv6`
 :dnsBypassTtl:  The :ref:`ds-dns-bypass-ttl`
 :dscp:  A :ref:`ds-dscp` to be used within the :term:`Delivery 
Service`
+:ecsEnabled:A boolean that defines the :ref:`ds-ecs` setting on this 
:term:`Delivery Service`
+
+   .. versionadded:: 1.4
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4198: EDNS0 Client Subnet for Delivery Services

[GitBox]

mattjackson220 commented on a change in pull request #4198: EDNS0 Client Subnet 
for Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/4198#discussion_r362916094
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
 ##
 @@ -255,7 +255,8 @@ func createV14(w http.ResponseWriter, r *http.Request, inf 
*api.APIInfo, reqDS t
&ds.TRRequestHeaders,
&ds.TRResponseHeaders,
&ds.TypeID,
-   &ds.XMLID)
+   &ds.XMLID,
 
 Review comment:
   done. thanks for the steps!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4127: Rewrite GET stats_summary from Perl to Golang

[GitBox]

ocket commented on a change in pull request #4127: Rewrite GET 
stats_summary from Perl to Golang
URL: https://github.com/apache/trafficcontrol/pull/4127#discussion_r362893961
 
 

 ##
 File path: docs/source/api/stats_summary.rst
 ##
 @@ -0,0 +1,178 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-stats-summary:
+
+*
+``stats_summary``
+*
+
+``GET``
+===
+Either retrieve a list of summary stats or the timestamp of the latest 
recorded stats summary.
+
+What is returned is driven by the query parameter ``lastSummaryDate``.
+
+If the parameter is set it will return an object with the latest timestamp, 
else an array of summary stats will be returned.
+
+:Auth. Required: Yes
+:Roles Required: None
+:Response Type:  Array or Object
+
+Request Structure
+-
+
+Summary Stats
+"
+
+.. table:: Request Query Parameters
+
+   
+-+--+---+
+   | Name| Required | Description  
 |
+   
+=+==+===+
+   | deliveryServiceName | no   | Return only summary stats that were 
reported for :term:`Delivery Service` with the given display name |
+   
+-+--+---+
+   | cdnName | no   | Return only summary stats that were 
reported for CDN with the given name  |
+   
+-+--+---+
+   | statName| no   | Return only summary stats that were 
reported for given stat name  |
+   
+-+--+---+
+   | orderby | no   | Choose the ordering of the results - 
can only be one of deliveryServiceName, statName or cdnName  |
+   
+-+--+---+
+   | sortOrder   | no   | Changes the order of sorting. Either 
ascending (default or "asc") or  |
+   | |  | descending ("desc")  
 |
+   
+-+--+---+
+   | limit   | no   | Choose the maximum number of results 
to return|
+   
+-+--+---+
+   | offset  | no   | The number of results to skip before 
beginning to return results. Must use in conjunction with limit  |
+   
+-+--+---+
+   | page| no   | Return the n\ :sup:`th` page of 
results, where "n" is the value of this parameter, pages are  |
+   | |  | ``limit`` long and the first page is 
1. If ``offset`` was defined, this query parameter has no|
+   | |  | effect. ``limit`` must be defined to 
make use of ``page``.|
+   
+-+--+---+
+
+.. code-block:: http
+   :caption: Request Example
+
+   GET /api/1.4/stats_summary HTTP/1.1
+   Host: trafficops.infra.ciab.test
+   User-Agent: curl/7.47.0
+   Accept: */*
+   Cookie: mojolicious=...
+
+Last Updated Summary Stat
+""
+
+

[GitHub] [trafficcontrol] mitchell852 commented on issue #4252: Message does not display properly when user assign Servers to the Delivery Service on the first time

[GitBox]

mitchell852 commented on issue #4252: Message does not display properly when 
user assign Servers to the Delivery Service on the first time
URL: https://github.com/apache/trafficcontrol/issues/4252#issuecomment-570632687
 
 
   > Seems like this issue exists because it is navigating to a different route 
right after the server assignments.
   
   that's exactly the problem. great observation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ZugNZwang commented on issue #4252: Message does not display properly when user assign Servers to the Delivery Service on the first time

[GitBox]

ZugNZwang commented on issue #4252: Message does not display properly when user 
assign Servers to the Delivery Service on the first time
URL: https://github.com/apache/trafficcontrol/issues/4252#issuecomment-570630741
 
 
   So when clicking on a **Delivery Service** and it will go to this route: 
`/#!/delivery-services/124?type=ANY_MAP`
   
   Then click the **More** drop down menu, click on **Manage Servers**, and it 
will go to: `/#!/delivery-services/124/servers?type=ANY_MAP`
   
   When clicking on the **Link Button**, selecting servers, and clicking 
**Submit**. The Servers Table will close. It will briefly display the alert 
message: `server assignements complete`
   And it will end up at this route: `/#!/delivery-services/124/servers`
   
   I noticed this route no longer has the type query parameter. And that also 
this issue only occurs when performing these actions in order, if the user is 
already on the page you don't get this issue.
   
   Seems like this issue exists because it is navigating to a different route 
right after the server assignments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4253: Fixed improperly labeled 'httpRoute' field in api_capabilities responses

[GitBox]

ocket opened a new pull request #4253: Fixed improperly labeled 'httpRoute' 
field in api_capabilities responses
URL: https://github.com/apache/trafficcontrol/pull/4253
 
 
   ## What does this PR (Pull Request) do?
   - [x] This PR fixes #4244
   
   Also includes a single-word edit of the documentation.
   
   ## Which Traffic Control components are affected by this PR?
   - Documentation
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   Ensure all existing unit and API/client integration tests still pass, ensure 
the docs build without warnings.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   - 4.0 (RC1)
   
   ## The following criteria are ALL met by this PR
   
   - [x] I have explained why tests are unnecessary
   - [x] This PR includes documentation
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4240: Can update a user's username to contain spaces

[GitBox]

ZugNZwang opened a new issue #4240: Can update a user's username to contain 
spaces
URL: https://github.com/apache/trafficcontrol/issues/4240
 
 
   
   
   
   
   ## I'm submitting a ...
   
   
   - [X] bug report
   - [ ] new feature / enhancement request
   - [ ] improvement request (usability, performance, tech debt, etc.)
   - [ ] other 
   
   ## Traffic Control components affected ...
   
   - [ ] CDN in a Box
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Control Client
   - [ ] Traffic Monitor
   - [X] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] unknown
   
   ## Current behavior:
   
   When making a `PUT` request to `/user/current` with the following request 
body:
   ```
   {
   "user": {
   "username": "space   test"
   }
   }
   ```
   The response returned is:
   ```
   HTTP/1.1 200 OK
   {
   "alerts": [
   {
   "text": "User profile was successfully updated",
   "level": "success"
   }
   ],
   "response": {
   "username": "spacetest",
.
.
   }
   }
   ```
   ## Expected / new behavior:
   
   Should not be allowed to update a username that contains spaces. 
   Should return:
   ```
   HTTP/1.1 400 Bad Request
   {
   "alerts": [
   {
   "text": "Couldn't parse request: username: cannot contain 
spaces",
   "level": "error"
   }
   ]
   }
   ```
   ## Minimal reproduction of the problem with instructions:
   
   
   ## Anything else:
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4240: Can update a user's username to contain spaces

[GitBox]

ocket commented on issue #4240: Can update a user's username to contain 
spaces
URL: https://github.com/apache/trafficcontrol/issues/4240#issuecomment-570618552
 
 
   Yeah, that sounds appropriate to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4249: Unable to update or remove Traffic Ops in Docker

[GitBox]

ocket commented on issue #4249: Unable to update or remove Traffic Ops in 
Docker
URL: https://github.com/apache/trafficcontrol/issues/4249#issuecomment-570618122
 
 
   CiaB isn't really used for too much testing anyway, as I understand.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4240: Can update a user's username to contain spaces

[GitBox]

mitchell852 commented on issue #4240: Can update a user's username to contain 
spaces
URL: https://github.com/apache/trafficcontrol/issues/4240#issuecomment-570609010
 
 
   @ocket - maybe rather than closing this, it should be reopened and the 
"fix" is to make TP and the TO API consistent. Meaning that TP should allow 
spaces as well. Thoughts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1725

[Apache Jenkins Server]

See 

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1724

[Apache Jenkins Server]

See 


Changes:


--
[...truncated 23 B...]
[EnvInject] - Loading node environment variables.
Building remotely on H30 (ubuntu) in workspace 

using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://github.com/apache/trafficcontrol.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:894)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1161)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress -- git://github.com/apache/trafficcontrol.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: remote: Enumerating objects: 19, done.
remote: Counting objects:   5% (1/19)remote: Counting objects:  10% 
(2/19)remote: Counting objects:  15% (3/19)remote: Counting 
objects:  21% (4/19)remote: Counting objects:  26% (5/19)
remote: Counting objects:  31% (6/19)remote: Counting objects:  36% 
(7/19)remote: Counting objects:  42% (8/19)remote: Counting 
objects:  47% (9/19)remote: Counting objects:  52% (10/19)
remote: Counting objects:  57% (11/19)remote: Counting objects:  63% 
(12/19)remote: Counting objects:  68% (13/19)remote: Counting 
objects:  73% (14/19)remote: Counting objects:  78% (15/19)
remote: Counting objects:  84% (16/19)remote: Counting objects:  89% 
(17/19)remote: Counting objects:  94% (18/19)remote: Counting 
objects: 100% (19/19)remote: Counting objects: 100% (19/19), done.  
  
remote: Compressing objects:   5% (1/19)remote: Compressing objects:  
10% (2/19)remote: Compressing objects:  15% (3/19)remote: 
Compressing objects:  21% (4/19)remote: Compressing objects:  26% 
(5/19)remote: Compressing objects:  31% (6/19)remote: 
Compressing objects:  36% (7/19)remote: Compressing objects:  42% 
(8/19)remote: Compressing objects:  47% (9/19)remote: 
Compressing objects:  52% (10/19)remote: Compressing objects:  57% 
(11/19)remote: Compressing objects:  63% (12/19)remote: 
Compressing objects:  68% (13/19)remote: Compressing objects:  73% 
(14/19)remote: Compressing objects:  78% (15/19)remote: 
Compressing objects:  84% (16/19)remote: Compressing objects:  89% 
(17/19)remote: Compressing objects:  94% (18/19)remote: 
Compressing objects: 100% (19/19)remote: Compressing objects: 100% 
(19/19), done.
error: cannot fork() for index-pack: Resource temporarily unavailable
fatal: fetch-pack: unable to fork off index-pack

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2172)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1864)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:78)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:545)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorServic

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1723

[Apache Jenkins Server]

See 


Changes:


--
[...truncated 1.88 KB...]
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
at java.lang.Thread.start(Thread.java:717)
at hudson.Proc$LocalProc.(Proc.java:258)
at hudson.Proc$LocalProc.(Proc.java:219)
at hudson.Launcher$LocalLauncher.launch(Launcher.java:937)
at hudson.Launcher$ProcStarter.start(Launcher.java:455)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2168)
... 20 more
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  
 > # timeout=10
ERROR: Error cloning remote repo 'origin'
hudson.plugins.git.GitException: Could not init 

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:916)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:708)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H30
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:957)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
at sun.reflect.GeneratedMethodAccessor975.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
at com.sun.proxy.$Proxy144.execute(Unknown Source)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1152)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1192)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1815)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Error performing git command
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2181)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2140)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2136)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1741)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:914)
... 11 more
Caused by: java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
at java.lang.Thread.start(Thread.java:717)
a

[GitHub] [trafficcontrol] mitchell852 closed issue #4246: Service 'trafficops-perl' failed to build: [...] dial tcp: lookup geolite.maxmind.com: No address associated with hostname

[GitBox]

mitchell852 closed issue #4246: Service 'trafficops-perl' failed to build: 
[...] dial tcp: lookup geolite.maxmind.com: No address associated with hostname
URL: https://github.com/apache/trafficcontrol/issues/4246
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 merged pull request #4251: Fixed CiaB build issue

[GitBox]

mitchell852 merged pull request #4251: Fixed CiaB build issue
URL: https://github.com/apache/trafficcontrol/pull/4251
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services