Re: [PR] Bump github.com/lestrrat-go/jwx from 1.2.27 to 1.2.28 [trafficcontrol]
zrhoffman merged PR #7928: URL: https://github.com/apache/trafficcontrol/pull/7928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/lestrrat-go/jwx from 1.2.27 to 1.2.28 [trafficcontrol]
codecov[bot] commented on PR #7928: URL: https://github.com/apache/trafficcontrol/pull/7928#issuecomment-1908484511 ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`96d300e`)](https://app.codecov.io/gh/apache/trafficcontrol/commit/96d300e9d7177dfb98439d18af8ca4f828f33075?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 29.06% compared to head [(`dfdaa6e`)](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 29.09%. > Report is 1 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master#7928 +/- ## + Coverage 29.06% 29.09% +0.02% Complexity 98 98 Files 605 605 Lines 7753577535 Branches 90 90 + Hits 2253922559 +20 + Misses5290852893 -15 + Partials 2088 2083 -5 ``` | [Flag](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [golib_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `53.85% <ø> (ø)` | | | [grove_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `12.02% <ø> (ø)` | | | [t3c_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `5.88% <ø> (ø)` | | | [traffic_monitor_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `25.47% <ø> (ø)` | | | [traffic_ops_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `22.08% <ø> (+0.04%)` | :arrow_up: | | [traffic_stats_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `10.78% <ø> (ø)` | | | [unit_tests](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `25.94% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/trafficcontrol/pull/7928?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump github.com/lestrrat-go/jwx from 1.2.27 to 1.2.28 [trafficcontrol]
dependabot[bot] opened a new pull request, #7928: URL: https://github.com/apache/trafficcontrol/pull/7928 Bumps [github.com/lestrrat-go/jwx](https://github.com/lestrrat-go/jwx) from 1.2.27 to 1.2.28. Release notes Sourced from https://github.com/lestrrat-go/jwx/releases;>github.com/lestrrat-go/jwx's releases. v1.2.28 v1.2.28 09 Jan 2024 [Security Fixes] * [jws] JWS messages formated in full JSON format (i.e. not the compact format, which consists of three base64 strings concatenated with a '.') with missing protected headers could cause a panic, thereby introducing a possiblity of a DoS. This has been fixed so that the `jws.Parse` function succeeds in parsing a JWS message lacking a protected header. Calling `jws.Verify` on this same JWS message will result in a failed verification attempt. Note that this behavior will differ slightly when parsing JWS messages in compact form, which result in an error. Changelog Sourced from https://github.com/lestrrat-go/jwx/blob/v1.2.28/Changes;>github.com/lestrrat-go/jwx's changelog. v1.2.28 09 Jan 2024 [Security Fixes] [jws] JWS messages formated in full JSON format (i.e. not the compact format, which consists of three base64 strings concatenated with a '.') with missing protected headers could cause a panic, thereby introducing a possiblity of a DoS. This has been fixed so that the jws.Parse function succeeds in parsing a JWS message lacking a protected header. Calling jws.Verify on this same JWS message will result in a failed verification attempt. Note that this behavior will differ slightly when parsing JWS messages in compact form, which result in an error. Commits https://github.com/lestrrat-go/jwx/commit/8c53d0ae52d5ab1e2b37c5abb67def9e7958fd65;>8c53d0a v1.2.28 (https://redirect.github.com/lestrrat-go/jwx/issues/1052;>#1052) See full diff in https://github.com/lestrrat-go/jwx/compare/v1.2.27...v1.2.28;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/trafficcontrol/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] cp: cannot stat '../../dist/traffic_ops-8.0.0-0..el8.x86_64.rpm': No such file or directory [trafficcontrol]
rimashah25 closed issue #7921: cp: cannot stat '../../dist/traffic_ops-8.0.0-0..el8.x86_64.rpm': No such file or directory URL: https://github.com/apache/trafficcontrol/issues/7921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Get build number from BUILD_NUMBER file if not in a repo [trafficcontrol]
rimashah25 merged PR #7922: URL: https://github.com/apache/trafficcontrol/pull/7922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Origins page Traffic Portal v2 [trafficcontrol]
ntheanh201 commented on code in PR #7881:
URL: https://github.com/apache/trafficcontrol/pull/7881#discussion_r1465075242
##
experimental/traffic-portal/src/app/core/origins/detail/origin-detail.component.spec.ts:
##
@@ -0,0 +1,124 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { HarnessLoader } from "@angular/cdk/testing";
+import { TestbedHarnessEnvironment } from "@angular/cdk/testing/testbed";
+import { ComponentFixture, TestBed } from "@angular/core/testing";
+import { MatButtonHarness } from "@angular/material/button/testing";
+import { MatDialogModule } from "@angular/material/dialog";
+import { MatDialogHarness } from "@angular/material/dialog/testing";
+import { ActivatedRoute } from "@angular/router";
+import { RouterTestingModule } from "@angular/router/testing";
+import { ReplaySubject } from "rxjs";
+
+import { OriginService } from "src/app/api";
+import { APITestingModule } from "src/app/api/testing";
+import { NavigationService } from
"src/app/shared/navigation/navigation.service";
+
+import { OriginDetailComponent } from "./origin-detail.component";
+
+describe("OriginDetailComponent", () => {
+ let component: OriginDetailComponent;
+ let fixture: ComponentFixture;
+ let route: ActivatedRoute;
+ let paramMap: jasmine.Spy;
+ let loader: HarnessLoader;
+ let service: OriginService;
+
+ const navSvc = jasmine.createSpyObj([], {
+ headerHidden: new ReplaySubject(),
+ headerTitle: new ReplaySubject(),
+ });
+ beforeEach(async () => {
+ await TestBed.configureTestingModule({
+ declarations: [OriginDetailComponent],
+ imports: [APITestingModule, RouterTestingModule,
MatDialogModule],
+ providers: [{provide: NavigationService, useValue:
navSvc}],
+ }).compileComponents();
+
+ route = TestBed.inject(ActivatedRoute);
+ paramMap = spyOn(route.snapshot.paramMap, "get");
+ paramMap.and.returnValue(null);
+ fixture = TestBed.createComponent(OriginDetailComponent);
+ component = fixture.componentInstance;
+ fixture.detectChanges();
+ service = TestBed.inject(OriginService);
+ loader = TestbedHarnessEnvironment.documentRootLoader(fixture);
+ await fixture.whenStable();
+ });
+
+ it("should create", () => {
+ expect(component).toBeTruthy();
+ });
+
+ it("new origin", async () => {
+ paramMap.and.returnValue("new");
+
+ fixture = TestBed.createComponent(OriginDetailComponent);
+ component = fixture.componentInstance;
+ fixture.detectChanges();
+ await fixture.whenStable();
+ expect(paramMap).toHaveBeenCalled();
+ expect(component.origin).not.toBeNull();
+ expect(component.origin.name).toBe("");
+ expect(component.new).toBeTrue();
+ });
+
+ it("existing origin", async () => {
+ const id = 1;
+ paramMap.and.returnValue(id);
+ const origin = await service.getOrigins(id);
+ fixture = TestBed.createComponent(OriginDetailComponent);
+ component = fixture.componentInstance;
+ fixture.detectChanges();
+ await fixture.whenStable();
+ expect(paramMap).toHaveBeenCalled();
+ expect(component.origin).not.toBeNull();
+ expect(component.origin.name).toBe(origin.name);
+ expect(component.new).toBeFalse();
+ });
+
+ it("deletes existing Origins", async () => {
Review Comment:
@ocket I've added the test for delete origin but I still have no idea
why this.originService.deleteOrigin wasn't to be called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Migrate dynamic scripted Grafana Dashboards to Scenes [trafficcontrol]
ntheanh201 commented on PR #7927: URL: https://github.com/apache/trafficcontrol/pull/7927#issuecomment-1908229914 https://github.com/apache/trafficcontrol/assets/29043139/cec09d6c-d913-426b-9ed8-7dce4a1d9d3b;> Server dashboard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Migrate dynamic scripted Grafana Dashboards to Scenes [trafficcontrol]
ntheanh201 commented on PR #7927: URL: https://github.com/apache/trafficcontrol/pull/7927#issuecomment-1908229399 https://github.com/apache/trafficcontrol/assets/29043139/00ae9c8f-34e1-401e-8eaa-1268c9614d24;> Delivery Service dashboard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Migrate dynamic scripted Grafana Dashboards to Scenes [trafficcontrol]
ntheanh201 commented on PR #7927: URL: https://github.com/apache/trafficcontrol/pull/7927#issuecomment-1908228706 https://github.com/apache/trafficcontrol/assets/29043139/0572fd8b-23e6-4887-b415-7490d2154d37;> Cache Group dashboard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Migrate dynamic scripted Grafana Dashboards to Scenes [trafficcontrol]
ntheanh201 opened a new pull request, #7927: URL: https://github.com/apache/trafficcontrol/pull/7927 1. Upgrade to Grafana v10.2.3 2. Migrate Scripted Dashboards to Grafana Scenes - I've transitioned our existing scripted dashboards to the new Grafana Scenes. The migration also ensures compatibility with future Grafana updates and aligns with Grafana's recommended best practices. Check it here: [New in Grafana 10: Grafana Scenes for building dynamic dashboarding experiences ](https://grafana.com/blog/2023/08/03/new-in-grafana-10-grafana-scenes-for-building-dynamic-dashboarding-experiences/) ## Which Traffic Control components are affected by this PR? - CDN in a Box ## What is the best way to verify this PR? - Run CDN in a Box with Grafana - Go to Grafana, go to Apps -> TrafficControl Grafana Scenes - See the dashboards Check the images below ## If this is a bugfix, which Traffic Control versions contained the bug? ## PR submission checklist - [x] This PR has tests - [x] This PR has documentation - [x] This PR has a CHANGELOG.md entry - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/lestrrat-go/jwx from 1.2.26 to 1.2.27 [trafficcontrol]
zrhoffman merged PR #7924: URL: https://github.com/apache/trafficcontrol/pull/7924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
