[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation
mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation URL: https://github.com/apache/trafficcontrol/pull/3766#discussion_r333126435 ## File path: docs/source/api/cachegroups.rst ## @@ -123,19 +130,25 @@ Creates a :term:`Cache Group` Request Structure - -:fallbackToClosest: If ``true``, the Traffic Router will fall back on the 'closest' :term:`Cache Group` to this one, when this one fails +:fallbacks: An optional field which, when present, should contain an array of names of other :term:`Cache Groups` on which the Traffic Router will fall back in the event that this :term:`Cache Group` fails/becomes unavailable\ [#fallbacks]_ + + .. versionadded:: ATCv4.0 Review comment: agree very confusing to end users This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation
mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation URL: https://github.com/apache/trafficcontrol/pull/3766#discussion_r333110700 ## File path: docs/source/api/cachegroups.rst ## @@ -123,19 +130,25 @@ Creates a :term:`Cache Group` Request Structure - -:fallbackToClosest: If ``true``, the Traffic Router will fall back on the 'closest' :term:`Cache Group` to this one, when this one fails +:fallbacks: An optional field which, when present, should contain an array of names of other :term:`Cache Groups` on which the Traffic Router will fall back in the event that this :term:`Cache Group` fails/becomes unavailable\ [#fallbacks]_ + + .. versionadded:: ATCv4.0 Review comment: should this be API version? same comment in the other places that reference this version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation
mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation URL: https://github.com/apache/trafficcontrol/pull/3766#discussion_r333110506 ## File path: docs/source/api/cachegroup_fallbacks.rst ## @@ -19,6 +19,10 @@ ``cachegroup_fallbacks`` +.. deprecated:: ATCv4.0 Review comment: I have seen in other deprecation notices that we use the API version not the ATC version. Should this match those? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
