[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update
mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#discussion_r333808591 ## File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile ## @@ -105,5 +105,5 @@ ADD infrastructure/cdn-in-a-box/enroller/server_template.json \ ADD infrastructure/cdn-in-a-box/traffic_ops_data /traffic_ops_data -RUN chown -R trafops:trafops /opt/traffic_ops +# RUN chown -R trafops:trafops /opt/traffic_ops Review comment: I would be fine leaving it in this PR if it doesn’t cause issues which sounds like it doesn’t This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update
mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#discussion_r333554022 ## File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile ## @@ -105,5 +105,5 @@ ADD infrastructure/cdn-in-a-box/enroller/server_template.json \ ADD infrastructure/cdn-in-a-box/traffic_ops_data /traffic_ops_data -RUN chown -R trafops:trafops /opt/traffic_ops +# RUN chown -R trafops:trafops /opt/traffic_ops Review comment: ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update
mhoppa commented on a change in pull request #3954: Added deprecation notices
for /user/current/update
URL: https://github.com/apache/trafficcontrol/pull/3954#discussion_r333115367
##
File path: traffic_ops/app/lib/API/User.pm
##
@@ -599,6 +599,123 @@ sub current {
}
}
+# Designated handler for the deprecated path to updating current users
+sub user_current_update {
Review comment:
ugh! i hope that we dont have to do that with a lot of the other endpoints
we want to depreciate. Cool let me pull and test this then!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update
mhoppa commented on a change in pull request #3954: Added deprecation notices
for /user/current/update
URL: https://github.com/apache/trafficcontrol/pull/3954#discussion_r333079221
##
File path: traffic_ops/app/lib/MojoPlugins/Response.pm
##
@@ -119,6 +119,27 @@ sub register {
}
);
+ $app->renderer->add_helper(
+ with_deprecation => sub {
Review comment:
Good work on this!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update
mhoppa commented on a change in pull request #3954: Added deprecation notices
for /user/current/update
URL: https://github.com/apache/trafficcontrol/pull/3954#discussion_r333078932
##
File path: traffic_ops/app/lib/API/User.pm
##
@@ -599,6 +599,123 @@ sub current {
}
}
+# Designated handler for the deprecated path to updating current users
+sub user_current_update {
Review comment:
Why did a new handler needed to be added for deprecation notice? Shouldn't
we just be adding a deprecation message to the response on the current handler?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
