[GitHub] [trafficcontrol] mhoppa commented on issue #3927: Fix using http2 between TO and TM when setting proxy

2019-09-25 Thread GitBox
mhoppa commented on issue #3927: Fix using http2 between TO and TM when setting 
proxy
URL: https://github.com/apache/trafficcontrol/pull/3927#issuecomment-535166579
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [trafficcontrol] mhoppa commented on issue #3927: Fix using http2 between TO and TM when setting proxy

2019-09-20 Thread GitBox
mhoppa commented on issue #3927: Fix using http2 between TO and TM when setting 
proxy
URL: https://github.com/apache/trafficcontrol/pull/3927#issuecomment-533585330
 
 
   Agreed with you @mitchell852. One question is what services besides TM/TR 
does the TO talk to? If we put getting http clients for each of them into a 
common method we can enforce it a little better as 
https://github.com/apache/trafficcontrol/pull/2305/files#diff-6e647a5b8d470f399423ff712efb0050R40
 does.
   
   As we talked we can set it globally per 
https://golang.org/src/net/http/doc.go via `GODEBUG=http2client=0  # disable 
HTTP/2 client support` but I think we have agreed that feels a little 
cumbersome.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services