mitchell852 opened a new pull request #3873: fixes inaccurate change log 
message when queuing/dequeuing server upd…
URL: https://github.com/apache/trafficcontrol/pull/3873
 
 
   …ates for a cdn
   
   ## What does this PR (Pull Request) do?
   Regardless of whether you were queuing or dequeuing (clearing) server 
updates for a cdn, the change log message always said:
   
   "...ACTION: Queue CDN updates"
   
   when, in fact, the message should differ depending on the action, for 
example:
   
   "ACTION: CDN server updates queued"
   "ACTION: CDN server updates dequeued"
   
   change logs messages are not documented so no doc changes
   we don't test the format of change log messages for non-shared handlers
   too small to justify a changelog.md entry
   
   - [x] This PR is not related to any Issue
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   - master (241c537)
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to