[GitHub] rivasj commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries
rivasj commented on a change in pull request #2406: Re-added
anonymous_blocking_enabled field to deliveryservice queries
URL: https://github.com/apache/trafficcontrol/pull/2406#discussion_r195491081
##
File path: lib/go-tc/deliveryservices.go
##
@@ -58,59 +58,60 @@ type DeleteDeliveryServiceResponse struct {
// DeliveryService ...
// TODO move contents to DeliveryServiceV12, fix references, and remove
type DeliveryService struct {
- Active bool `json:"active"`
- CacheURL string `json:"cacheurl"`
- CCRDNSTTLint`json:"ccrDnsTtl"`
- CDNIDint`json:"cdnId"`
- CDNName string `json:"cdnName"`
- CheckPathstring `json:"checkPath"`
- DeepCachingType DeepCachingType`json:"deepCachingType"`
- DisplayName string `json:"displayName"`
- DNSBypassCname string `json:"dnsBypassCname"`
- DNSBypassIP string `json:"dnsBypassIp"`
- DNSBypassIP6 string `json:"dnsBypassIp6"`
- DNSBypassTTL int`json:"dnsBypassTtl"`
- DSCP int`json:"dscp"`
- EdgeHeaderRewritestring `json:"edgeHeaderRewrite"`
- ExampleURLs []string `json:"exampleURLs"`
- GeoLimit int`json:"geoLimit"`
- FQPacingRate int`json:"fqPacingRate"`
- GeoProvider int`json:"geoProvider"`
- GlobalMaxMBPSint`json:"globalMaxMbps"`
- GlobalMaxTPS int`json:"globalMaxTps"`
- HTTPBypassFQDN string `json:"httpBypassFqdn"`
- ID int`json:"id"`
- InfoURL string `json:"infoUrl"`
- InitialDispersionfloat32`json:"initialDispersion"`
- IPV6RoutingEnabled bool `json:"ipv6RoutingEnabled"`
- LastUpdated *TimeNoMod `json:"lastUpdated"
db:"last_updated"`
- LogsEnabled bool `json:"logsEnabled"`
- LongDesc string `json:"longDesc"`
- LongDesc1string `json:"longDesc1"`
- LongDesc2string `json:"longDesc2"`
- MatchList[]DeliveryServiceMatch `json:"matchList,omitempty"`
- MaxDNSAnswersint`json:"maxDnsAnswers"`
- MidHeaderRewrite string `json:"midHeaderRewrite"`
- MissLat float64`json:"missLat"`
- MissLong float64`json:"missLong"`
- MultiSiteOrigin bool `json:"multiSiteOrigin"`
- OrgServerFQDNstring `json:"orgServerFqdn"`
- ProfileDesc string `json:"profileDescription"`
- ProfileIDint`json:"profileId,omitempty"`
- ProfileName string `json:"profileName"`
- Protocol int`json:"protocol"`
- QStringIgnoreint`json:"qstringIgnore"`
- RangeRequestHandling int
`json:"rangeRequestHandling"`
- RegexRemap string `json:"regexRemap"`
- RegionalGeoBlocking bool `json:"regionalGeoBlocking"`
- RemapTextstring `json:"remapText"`
- RoutingName string `json:"routingName"`
- SigningAlgorithm string `json:"signingAlgorithm"
db:"signing_algorithm"`
- TypeID int`json:"typeId"`
- Type string `json:"type"`
- TRResponseHeadersstring `json:"trResponseHeaders"`
- TenantID int`json:"tenantId,omitempty"`
- XMLIDstring `json:"xmlId"`
+ Active bool `json:"active"`
+ AnonymousBlockingEnabled bool
`json:"anonymousBlockingEnabled"`
Review comment:
Given the scenario, I will restore the field in the v12 struct. Thank you
all for the feedback.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] rivasj commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries
rivasj commented on a change in pull request #2406: Re-added
anonymous_blocking_enabled field to deliveryservice queries
URL: https://github.com/apache/trafficcontrol/pull/2406#discussion_r195246642
##
File path: lib/go-tc/deliveryservices.go
##
@@ -58,59 +58,60 @@ type DeleteDeliveryServiceResponse struct {
// DeliveryService ...
// TODO move contents to DeliveryServiceV12, fix references, and remove
type DeliveryService struct {
- Active bool `json:"active"`
- CacheURL string `json:"cacheurl"`
- CCRDNSTTLint`json:"ccrDnsTtl"`
- CDNIDint`json:"cdnId"`
- CDNName string `json:"cdnName"`
- CheckPathstring `json:"checkPath"`
- DeepCachingType DeepCachingType`json:"deepCachingType"`
- DisplayName string `json:"displayName"`
- DNSBypassCname string `json:"dnsBypassCname"`
- DNSBypassIP string `json:"dnsBypassIp"`
- DNSBypassIP6 string `json:"dnsBypassIp6"`
- DNSBypassTTL int`json:"dnsBypassTtl"`
- DSCP int`json:"dscp"`
- EdgeHeaderRewritestring `json:"edgeHeaderRewrite"`
- ExampleURLs []string `json:"exampleURLs"`
- GeoLimit int`json:"geoLimit"`
- FQPacingRate int`json:"fqPacingRate"`
- GeoProvider int`json:"geoProvider"`
- GlobalMaxMBPSint`json:"globalMaxMbps"`
- GlobalMaxTPS int`json:"globalMaxTps"`
- HTTPBypassFQDN string `json:"httpBypassFqdn"`
- ID int`json:"id"`
- InfoURL string `json:"infoUrl"`
- InitialDispersionfloat32`json:"initialDispersion"`
- IPV6RoutingEnabled bool `json:"ipv6RoutingEnabled"`
- LastUpdated *TimeNoMod `json:"lastUpdated"
db:"last_updated"`
- LogsEnabled bool `json:"logsEnabled"`
- LongDesc string `json:"longDesc"`
- LongDesc1string `json:"longDesc1"`
- LongDesc2string `json:"longDesc2"`
- MatchList[]DeliveryServiceMatch `json:"matchList,omitempty"`
- MaxDNSAnswersint`json:"maxDnsAnswers"`
- MidHeaderRewrite string `json:"midHeaderRewrite"`
- MissLat float64`json:"missLat"`
- MissLong float64`json:"missLong"`
- MultiSiteOrigin bool `json:"multiSiteOrigin"`
- OrgServerFQDNstring `json:"orgServerFqdn"`
- ProfileDesc string `json:"profileDescription"`
- ProfileIDint`json:"profileId,omitempty"`
- ProfileName string `json:"profileName"`
- Protocol int`json:"protocol"`
- QStringIgnoreint`json:"qstringIgnore"`
- RangeRequestHandling int
`json:"rangeRequestHandling"`
- RegexRemap string `json:"regexRemap"`
- RegionalGeoBlocking bool `json:"regionalGeoBlocking"`
- RemapTextstring `json:"remapText"`
- RoutingName string `json:"routingName"`
- SigningAlgorithm string `json:"signingAlgorithm"
db:"signing_algorithm"`
- TypeID int`json:"typeId"`
- Type string `json:"type"`
- TRResponseHeadersstring `json:"trResponseHeaders"`
- TenantID int`json:"tenantId,omitempty"`
- XMLIDstring `json:"xmlId"`
+ Active bool `json:"active"`
+ AnonymousBlockingEnabled bool
`json:"anonymousBlockingEnabled"`
Review comment:
Yes, that makes sense. I'll make the change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
