[jira] [Resolved] (TC-257) Traffic Ops GUI: Editing CDN domain_name and dnssecenabled fields have no effect.

[Robert Scrimo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scrimo resolved TC-257.
--
Resolution: Fixed

> Traffic Ops GUI: Editing CDN domain_name and dnssecenabled fields have no 
> effect.
> -
>
> Key: TC-257
> URL: https://issues.apache.org/jira/browse/TC-257
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Robert Scrimo
>Assignee: Robert Scrimo
>
> When editing the CDN domain_name and DNSSEC enabled fields upon submit the 
> values do not stick in the database.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (TC-248) Importing and exporting profiles does not work as expected

[Robert Scrimo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scrimo resolved TC-248.
--
   Resolution: Fixed
Fix Version/s: 2.1.0

> Importing and exporting profiles does not work as expected
> --
>
> Key: TC-248
> URL: https://issues.apache.org/jira/browse/TC-248
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Robert Scrimo
>Assignee: Robert Scrimo
> Fix For: 2.1.0
>
> Attachments: CCR-NABOX9.traffic_ops
>
>
> Centos 7.2; Profile is attached. Issue was confirmed in latest staging build 
> 2.1.0-6034.865c0efd.el7 and in my recently upgraded environment.
> Exporting profiles from Traffic Ops 2.1.0-6027.a62b5f9f.el7 does not include 
> the required profile field "type".
> Importing profiles with or without the profile "type" field produces the 
> following error in Traffic Ops GUI:
> Traffic Ops fatal error occurred while processing your request. 
> Error at line 312 (my $insert = $self->db->resultset('Profile')->create() 
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR: null value in column "type" violates not-null constraint 
> DETAIL: Failing row contains (34, CCR1-NABOX9, Traffic Router Profile for 
> NABOX9, 2017-04-24 20:52:01.999393+00, null, null). [for Statement "INSERT 
> INTO profile ( description, name) VALUES ( ?, ? ) RETURNING id" with 
> ParamValues: 1='Traffic Router Profile for NABOX9', 2='CCR1-NABOX9'] at 
> /opt/traffic_ops/app/lib/UI/Profile.pm line 312



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (TC-248) Importing and exporting profiles does not work as expected

[Robert Scrimo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scrimo closed TC-248.


> Importing and exporting profiles does not work as expected
> --
>
> Key: TC-248
> URL: https://issues.apache.org/jira/browse/TC-248
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Robert Scrimo
>Assignee: Robert Scrimo
> Fix For: 2.1.0
>
> Attachments: CCR-NABOX9.traffic_ops
>
>
> Centos 7.2; Profile is attached. Issue was confirmed in latest staging build 
> 2.1.0-6034.865c0efd.el7 and in my recently upgraded environment.
> Exporting profiles from Traffic Ops 2.1.0-6027.a62b5f9f.el7 does not include 
> the required profile field "type".
> Importing profiles with or without the profile "type" field produces the 
> following error in Traffic Ops GUI:
> Traffic Ops fatal error occurred while processing your request. 
> Error at line 312 (my $insert = $self->db->resultset('Profile')->create() 
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR: null value in column "type" violates not-null constraint 
> DETAIL: Failing row contains (34, CCR1-NABOX9, Traffic Router Profile for 
> NABOX9, 2017-04-24 20:52:01.999393+00, null, null). [for Statement "INSERT 
> INTO profile ( description, name) VALUES ( ?, ? ) RETURNING id" with 
> ParamValues: 1='Traffic Router Profile for NABOX9', 2='CCR1-NABOX9'] at 
> /opt/traffic_ops/app/lib/UI/Profile.pm line 312



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TC-255) Manage SSL Keys button results in an error for a DS that doesn't already have keys.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985813#comment-15985813
 ] 

ASF GitHub Bot commented on TC-255:
---

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/522
  
and for the DS without a profile,  I failed to put in a regex and got a 
crash rather than an error popup:

```Traffic Ops fatal error occurred while processing your request. 
Error at line 28 ($morbo->run($app);) 

Please supply a host regular expression at 
.../incubator-trafficcontrol/traffic_ops/app/lib/MojoPlugins/DeliveryService.pm 
line 178. 

 called at 
.../incubator-trafficcontrol/traffic_ops/app/lib/UI/DeliveryService.pm line 385
```


> Manage SSL Keys button results in an error for a DS that doesn't already have 
> keys.
> ---
>
> Key: TC-255
> URL: https://issues.apache.org/jira/browse/TC-255
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
>Priority: Critical
> Fix For: 2.1.0
>
>
> If you have a deliveryservice that you are migrating to HTTPS or a DS that is 
> HTTPS but doesn't yet have keys, you get an error when you click the "Manage 
> SSL Keys" button.  The issue is that there was a method, get_cdn_domain() 
> that was removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/522
  
and for the DS without a profile,  I failed to put in a regex and got a 
crash rather than an error popup:

```Traffic Ops fatal error occurred while processing your request. 
Error at line 28 ($morbo->run($app);) 

Please supply a host regular expression at 
.../incubator-trafficcontrol/traffic_ops/app/lib/MojoPlugins/DeliveryService.pm 
line 178. 

 called at 
.../incubator-trafficcontrol/traffic_ops/app/lib/UI/DeliveryService.pm line 385
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/522
  
not certain I'm doing it right, but trying to test the manage ssl certs,  I 
hit this error: ```Traffic Ops fatal error occurred while processing your 
request. 
Error at line 242 ( my $profile = $self->db->resultset('Profile')->search( 
{ id => $profile_id }, { prefetch => ['cdn'] } )->single();) 
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st 
execute failed: ERROR: column reference "id" is ambiguous LINE 1: ...e me LEFT 
JOIN cdn cdn ON cdn.id = me.cdn WHERE ( id IS NULL... ^ [for Statement "SELECT 
me.id, me.name, me.description, me.last_updated, me.type, me.cdn, cdn.id, 
cdn.name, cdn.last_updated, cdn.dnssec_enabled, cdn.domain_name FROM profile me 
LEFT JOIN cdn cdn ON cdn.id = me.cdn WHERE ( id IS NULL )"] at 
/home/dkirkw202/incubator-trafficcontrol/traffic_ops/app/lib/UI/DnssecKeys.pm 
line 242```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-255) Manage SSL Keys button results in an error for a DS that doesn't already have keys.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985796#comment-15985796
 ] 

ASF GitHub Bot commented on TC-255:
---

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/522
  
not certain I'm doing it right, but trying to test the manage ssl certs,  I 
hit this error: ```Traffic Ops fatal error occurred while processing your 
request. 
Error at line 242 ( my $profile = $self->db->resultset('Profile')->search( 
{ id => $profile_id }, { prefetch => ['cdn'] } )->single();) 
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st 
execute failed: ERROR: column reference "id" is ambiguous LINE 1: ...e me LEFT 
JOIN cdn cdn ON cdn.id = me.cdn WHERE ( id IS NULL... ^ [for Statement "SELECT 
me.id, me.name, me.description, me.last_updated, me.type, me.cdn, cdn.id, 
cdn.name, cdn.last_updated, cdn.dnssec_enabled, cdn.domain_name FROM profile me 
LEFT JOIN cdn cdn ON cdn.id = me.cdn WHERE ( id IS NULL )"] at 
/home/dkirkw202/incubator-trafficcontrol/traffic_ops/app/lib/UI/DnssecKeys.pm 
line 242```


> Manage SSL Keys button results in an error for a DS that doesn't already have 
> keys.
> ---
>
> Key: TC-255
> URL: https://issues.apache.org/jira/browse/TC-255
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
>Priority: Critical
> Fix For: 2.1.0
>
>
> If you have a deliveryservice that you are migrating to HTTPS or a DS that is 
> HTTPS but doesn't yet have keys, you get an error when you click the "Manage 
> SSL Keys" button.  The issue is that there was a method, get_cdn_domain() 
> that was removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (TC-233) db/admin.pl needs updating to manage the postgres superuser

[Dan Kirkwood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Kirkwood resolved TC-233.
-
Resolution: Fixed

> db/admin.pl needs updating to manage the postgres superuser
> ---
>
> Key: TC-233
> URL: https://issues.apache.org/jira/browse/TC-233
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops
>Reporter: Dewayne Richardson
>Assignee: Dan Kirkwood
> Fix For: 2.0.0
>
>
> The admin.pl with Postgres needed to be updated to support the 'postgres' 
> user and 'traffic_ops' users according to privileges.  This is needed to 
> support the 'postinstall' script so that the TrafficOps rpm can be installed 
> properly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (TC-238) TO API - Add ?limit= query param to GET /api/../logs to limit the results

[Jeremy Mitchell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Mitchell resolved TC-238.

Resolution: Fixed

> TO API - Add ?limit= query param to GET /api/../logs to limit the results
> -
>
> Key: TC-238
> URL: https://issues.apache.org/jira/browse/TC-238
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
> Fix For: 2.1.0
>
>
> Add an optional ?limit query param to limit the number of change logs 
> returned.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (TC-233) db/admin.pl needs updating to manage the postgres superuser

[Dan Kirkwood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Kirkwood reassigned TC-233:
---

Assignee: Dan Kirkwood

> db/admin.pl needs updating to manage the postgres superuser
> ---
>
> Key: TC-233
> URL: https://issues.apache.org/jira/browse/TC-233
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops
>Reporter: Dewayne Richardson
>Assignee: Dan Kirkwood
> Fix For: 2.0.0
>
>
> The admin.pl with Postgres needed to be updated to support the 'postgres' 
> user and 'traffic_ops' users according to privileges.  This is needed to 
> support the 'postinstall' script so that the TrafficOps rpm can be installed 
> properly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #493: [TC-241] - adds api endpoint to ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/493


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-241) TO API - add api endpoint to remove a server from a delivery service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985767#comment-15985767
 ] 

ASF GitHub Bot commented on TC-241:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/493


> TO API - add api endpoint to remove a server from a delivery service
> 
>
> Key: TC-241
> URL: https://issues.apache.org/jira/browse/TC-241
> Project: Traffic Control
>  Issue Type: New Feature
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
> Fix For: 2.1.0
>
>
> Currently, thru the API, you can assign servers in bulk to a delivery service 
> using:
> POST /api/$version/deliveryservices/:xml_id/servers
> However, you can't remove individual servers from a ds. 
> Create an api to remove individual servers from a ds. i.e.
> DELETE /api/$version/deliveryservices/:id/servers/:id which will remove 
> entries from the deliveryservice_server table.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TC-257) Traffic Ops GUI: Editing CDN domain_name and dnssecenabled fields have no effect.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985764#comment-15985764
 ] 

ASF GitHub Bot commented on TC-257:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/525


> Traffic Ops GUI: Editing CDN domain_name and dnssecenabled fields have no 
> effect.
> -
>
> Key: TC-257
> URL: https://issues.apache.org/jira/browse/TC-257
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Robert Scrimo
>Assignee: Robert Scrimo
>
> When editing the CDN domain_name and DNSSEC enabled fields upon submit the 
> values do not stick in the database.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #525: [TC-257] added domain_name and d...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/525


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-64) TO experimental SPA application

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985672#comment-15985672
 ] 

ASF GitHub Bot commented on TC-64:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/524


> TO experimental SPA application
> ---
>
> Key: TC-64
> URL: https://issues.apache.org/jira/browse/TC-64
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> At the 2016 Traffic Control summit, a prototype of a SPA application 
> developed by [~mitchell...@apache.org] using AngularJS was demo'd that works 
> entirely on top of the TO API.
> This issue is a placeholder for any work done to this prototype / 
> experimental UI. The goal is to replicate the functionality of the current 
> MVC TO UI. nothing more, nothing less.
> This will require some additions to the TO API. look for issues regarding 
> each API addition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #524: [TC-64] TOUI experimental - adds...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/524


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-257) Traffic Ops GUI: Editing CDN domain_name and dnssecenabled fields have no effect.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985664#comment-15985664
 ] 

ASF GitHub Bot commented on TC-257:
---

GitHub user rscrimojr opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/525

[TC-257] added domain_name and dnssec_enabled to CDN db update code



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rscrimojr/incubator-trafficcontrol TC257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/525.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #525


commit 142ead368ea26c2fd83cfac7d1019d4da06e91c0
Author: Robert Scrimo 
Date:   2017-04-26T22:20:25Z

added domain_name and dnssec_enabled to ORM update code and updated log 
message.




> Traffic Ops GUI: Editing CDN domain_name and dnssecenabled fields have no 
> effect.
> -
>
> Key: TC-257
> URL: https://issues.apache.org/jira/browse/TC-257
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Robert Scrimo
>Assignee: Robert Scrimo
>
> When editing the CDN domain_name and DNSSEC enabled fields upon submit the 
> values do not stick in the database.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #525: [TC-257] added domain_name and d...

[rscrimojr]

GitHub user rscrimojr opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/525

[TC-257] added domain_name and dnssec_enabled to CDN db update code



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rscrimojr/incubator-trafficcontrol TC257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/525.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #525


commit 142ead368ea26c2fd83cfac7d1019d4da06e91c0
Author: Robert Scrimo 
Date:   2017-04-26T22:20:25Z

added domain_name and dnssec_enabled to ORM update code and updated log 
message.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (TC-257) Traffic Ops GUI: Editing CDN domain_name and dnssecenabled fields have no effect.

[Robert Scrimo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scrimo reassigned TC-257:


 Assignee: Robert Scrimo
Affects Version/s: 2.1.0
  Description: When editing the CDN domain_name and DNSSEC enabled 
fields upon submit the values do not stick in the database.
  Summary: Traffic Ops GUI: Editing CDN domain_name and 
dnssecenabled fields have no effect.  (was: Traffic Ops generateCert utility is 
not showing OpenSSL prompts.)

> Traffic Ops GUI: Editing CDN domain_name and dnssecenabled fields have no 
> effect.
> -
>
> Key: TC-257
> URL: https://issues.apache.org/jira/browse/TC-257
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Robert Scrimo
>Assignee: Robert Scrimo
>
> When editing the CDN domain_name and DNSSEC enabled fields upon submit the 
> values do not stick in the database.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (TC-257) Traffic Ops generateCert utility is not showing OpenSSL prompts.

[Robert Scrimo (JIRA)]

Robert Scrimo created TC-257:


 Summary: Traffic Ops generateCert utility is not showing OpenSSL 
prompts.
 Key: TC-257
 URL: https://issues.apache.org/jira/browse/TC-257
 Project: Traffic Control
  Issue Type: Bug
Reporter: Robert Scrimo






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TC-64) TO experimental SPA application

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985591#comment-15985591
 ] 

ASF GitHub Bot commented on TC-64:
--

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/524

[TC-64] TOUI experimental - adds update status dialog and also changes 
return object of generic d…

…ialog component

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
tc-64-toui-exp-change-server-status

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/524.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #524


commit 7ce06a163b4eeedd56f152a2f7f5e174e4dccc60
Author: Jeremy Mitchell 
Date:   2017-04-26T21:07:08Z

adds update status dialog and also changes return object of generic dialog 
component




> TO experimental SPA application
> ---
>
> Key: TC-64
> URL: https://issues.apache.org/jira/browse/TC-64
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> At the 2016 Traffic Control summit, a prototype of a SPA application 
> developed by [~mitchell...@apache.org] using AngularJS was demo'd that works 
> entirely on top of the TO API.
> This issue is a placeholder for any work done to this prototype / 
> experimental UI. The goal is to replicate the functionality of the current 
> MVC TO UI. nothing more, nothing less.
> This will require some additions to the TO API. look for issues regarding 
> each API addition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #524: [TC-64] TOUI experimental - adds...

[mitchell852]

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/524

[TC-64] TOUI experimental - adds update status dialog and also changes 
return object of generic d…

…ialog component

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
tc-64-toui-exp-change-server-status

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/524.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #524


commit 7ce06a163b4eeedd56f152a2f7f5e174e4dccc60
Author: Jeremy Mitchell 
Date:   2017-04-26T21:07:08Z

adds update status dialog and also changes return object of generic dialog 
component




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #523: BACKPORT - fix fork_and_daemonize to co...

[dneuman64]

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/523
  
@limited can you take a look when you get a chance?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #523: BACKPORT - fix fork_and_daemoniz...

[dneuman64]

GitHub user dneuman64 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/523

BACKPORT - fix fork_and_daemonize to correctly return for parent

This fixes [TC-251](https://issues.apache.org/jira/browse/TC-251).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dneuman64/incubator-trafficcontrol 
TC-251-backport

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/523.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #523


commit 18c21ba9319230e7f8daae111055772584c5971f
Author: David Neuman 
Date:   2017-04-26T14:26:17Z

Change Daemonize so that parent process returns a 1 instead of a 0, also 
remove re-direct of output to /dev/null.  Thanks @oren-shemesh for the help

(cherry picked from commit c1ef4a07d09624832ab4dfe463034492381b5c87)

commit 87c3d2e02ace056551316ad5798301471fe6e823
Author: David Neuman 
Date:   2017-04-26T14:47:01Z

add STDOUT, STDIN, STDERR re-direct back

(cherry picked from commit 8e568ae91742b5b2413016a6712ea67c99eeb88b)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-255) Manage SSL Keys button results in an error for a DS that doesn't already have keys.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985392#comment-15985392
 ] 

ASF GitHub Bot commented on TC-255:
---

GitHub user dneuman64 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/522

[TC-255] and [TC-256] -- Fixes issues with removed method and inability to 
add a DS w/o a profile

This fixes the following issues: 
[TC-255](https://issues.apache.org/jira/browse/TC-255) - Cannot manage SSL 
certs for DSs that don't already have certs.
[TC-256](https://issues.apache.org/jira/browse/TC-256) - Connot add a DS 
without a profile.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dneuman64/incubator-trafficcontrol 
to_fix_cdn_domain_method

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #522


commit 7c13dbcf4e96d33aa9ce10bf50698910bc4cffee
Author: David Neuman 
Date:   2017-04-26T19:09:20Z

Update Dnsseckeys.pm and Sslkeys.pm to no longer us get_cdn_domain method.  
This fixes TC-255

commit 7760368af34e536e59b8c0f4be1cff5cc1016a7b
Author: David Neuman 
Date:   2017-04-26T19:10:04Z

Fixes the ability to add a DS without a profile.  This fixes TC-256




> Manage SSL Keys button results in an error for a DS that doesn't already have 
> keys.
> ---
>
> Key: TC-255
> URL: https://issues.apache.org/jira/browse/TC-255
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
>Priority: Critical
> Fix For: 2.1.0
>
>
> If you have a deliveryservice that you are migrating to HTTPS or a DS that is 
> HTTPS but doesn't yet have keys, you get an error when you click the "Manage 
> SSL Keys" button.  The issue is that there was a method, get_cdn_domain() 
> that was removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #522: [TC-255] and [TC-256] -- Fixes i...

[dneuman64]

GitHub user dneuman64 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/522

[TC-255] and [TC-256] -- Fixes issues with removed method and inability to 
add a DS w/o a profile

This fixes the following issues: 
[TC-255](https://issues.apache.org/jira/browse/TC-255) - Cannot manage SSL 
certs for DSs that don't already have certs.
[TC-256](https://issues.apache.org/jira/browse/TC-256) - Connot add a DS 
without a profile.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dneuman64/incubator-trafficcontrol 
to_fix_cdn_domain_method

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #522


commit 7c13dbcf4e96d33aa9ce10bf50698910bc4cffee
Author: David Neuman 
Date:   2017-04-26T19:09:20Z

Update Dnsseckeys.pm and Sslkeys.pm to no longer us get_cdn_domain method.  
This fixes TC-255

commit 7760368af34e536e59b8c0f4be1cff5cc1016a7b
Author: David Neuman 
Date:   2017-04-26T19:10:04Z

Fixes the ability to add a DS without a profile.  This fixes TC-256




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (TC-255) Manage SSL Keys button results in an error for a DS that doesn't already have keys.

[David Neuman (JIRA)]

David Neuman created TC-255:
---

 Summary: Manage SSL Keys button results in an error for a DS that 
doesn't already have keys.
 Key: TC-255
 URL: https://issues.apache.org/jira/browse/TC-255
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Ops
Affects Versions: 2.1.0
Reporter: David Neuman
Assignee: David Neuman
Priority: Critical
 Fix For: 2.1.0


If you have a deliveryservice that you are migrating to HTTPS or a DS that is 
HTTPS but doesn't yet have keys, you get an error when you click the "Manage 
SSL Keys" button.  The issue is that there was a method, get_cdn_domain() that 
was removed.





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol issue #289: Added license verifier tool.

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/289
  
I agree this might be useful,  but I'm -1 on including this directly in the 
trafficcontrol repo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TC-254) Unable to edit edge DNS record TTLs, possibly other fields, for DNS delivery services

[Jeff Elsloo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Elsloo updated TC-254:
---
Description: There is currently no way to edit the {{ccr_dns_ttl}} field on 
a delivery service. This needs to be fixed, and additionally, we should scour 
the interface to ensure that all fields are editable, for all delivery service 
types. This includes not only DNS, but all DNS types and all HTTP types.  (was: 
There is currently no way to edit the {{ccr_dns_ttl}} field on a delivery 
service. This needs to be fixed, and additionally, we should scour the 
interface to ensure that all fields are editable, for all delivery service 
types. This includes not only DNS, but DNS_*, and HTTP and HTTP_*.)

> Unable to edit edge DNS record TTLs, possibly other fields, for DNS delivery 
> services
> -
>
> Key: TC-254
> URL: https://issues.apache.org/jira/browse/TC-254
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0
>Reporter: Jeff Elsloo
>
> There is currently no way to edit the {{ccr_dns_ttl}} field on a delivery 
> service. This needs to be fixed, and additionally, we should scour the 
> interface to ensure that all fields are editable, for all delivery service 
> types. This includes not only DNS, but all DNS types and all HTTP types.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TC-248) Importing and exporting profiles does not work as expected

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984959#comment-15984959
 ] 

ASF GitHub Bot commented on TC-248:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/519


> Importing and exporting profiles does not work as expected
> --
>
> Key: TC-248
> URL: https://issues.apache.org/jira/browse/TC-248
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Robert Scrimo
>Assignee: Robert Scrimo
> Attachments: CCR-NABOX9.traffic_ops
>
>
> Centos 7.2; Profile is attached. Issue was confirmed in latest staging build 
> 2.1.0-6034.865c0efd.el7 and in my recently upgraded environment.
> Exporting profiles from Traffic Ops 2.1.0-6027.a62b5f9f.el7 does not include 
> the required profile field "type".
> Importing profiles with or without the profile "type" field produces the 
> following error in Traffic Ops GUI:
> Traffic Ops fatal error occurred while processing your request. 
> Error at line 312 (my $insert = $self->db->resultset('Profile')->create() 
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR: null value in column "type" violates not-null constraint 
> DETAIL: Failing row contains (34, CCR1-NABOX9, Traffic Router Profile for 
> NABOX9, 2017-04-24 20:52:01.999393+00, null, null). [for Statement "INSERT 
> INTO profile ( description, name) VALUES ( ?, ? ) RETURNING id" with 
> ParamValues: 1='Traffic Router Profile for NABOX9', 2='CCR1-NABOX9'] at 
> /opt/traffic_ops/app/lib/UI/Profile.pm line 312



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #519: [TC-248] Fixed profile export, i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/519


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-251) DNSSEC keys refresh doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984954#comment-15984954
 ] 

ASF GitHub Bot commented on TC-251:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/521


> DNSSEC keys refresh doesn't work
> 
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0, 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work.  It never returns a reponse to the 
> client, so the client times out, and it also isn't actually updating the 
> expired keys.  I think the client issues was introduced with changes to the 
> "fork_and_daemonize()" method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #521: [TC-251] Fixed an issue where Tr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/521


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #521: [TC-251] Fixed an issue where Traffic O...

[oren-shemesh]

Github user oren-shemesh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/521
  
Thumbs up  :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-251) DNSSEC keys refresh doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984948#comment-15984948
 ] 

ASF GitHub Bot commented on TC-251:
---

Github user oren-shemesh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/521
  
Thumbs up  :-)


> DNSSEC keys refresh doesn't work
> 
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0, 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work.  It never returns a reponse to the 
> client, so the client times out, and it also isn't actually updating the 
> expired keys.  I think the client issues was introduced with changes to the 
> "fork_and_daemonize()" method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #521: [TC-251] Fixed an issue where Tr...

[oren-shemesh]

Github user oren-shemesh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/521#discussion_r113473675
  
--- Diff: traffic_ops/app/lib/MojoPlugins/Daemonize.pm ---
@@ -41,12 +41,6 @@ sub register {
# This is the first child
$self->inactivity_timeout(0);
POSIX::setsid();
-   open( STDIN, "< /dev/null" )
-   || confess("Can't read /dev/null: $!");
--- End diff --

Cool.
If child STD streams are not detached from the parent streams, this could 
be the source of "mysterious" problems in "random" worker processes due to 
child daemons doing IO, down the line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-251) DNSSEC keys refresh doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984944#comment-15984944
 ] 

ASF GitHub Bot commented on TC-251:
---

Github user oren-shemesh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/521#discussion_r113473675
  
--- Diff: traffic_ops/app/lib/MojoPlugins/Daemonize.pm ---
@@ -41,12 +41,6 @@ sub register {
# This is the first child
$self->inactivity_timeout(0);
POSIX::setsid();
-   open( STDIN, "< /dev/null" )
-   || confess("Can't read /dev/null: $!");
--- End diff --

Cool.
If child STD streams are not detached from the parent streams, this could 
be the source of "mysterious" problems in "random" worker processes due to 
child daemons doing IO, down the line.


> DNSSEC keys refresh doesn't work
> 
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0, 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work.  It never returns a reponse to the 
> client, so the client times out, and it also isn't actually updating the 
> expired keys.  I think the client issues was introduced with changes to the 
> "fork_and_daemonize()" method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol issue #520: [TC-251] Fix bug in fork_and_daemonize(...

[dneuman64]

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/520
  
@oren-shemesh can you close this since the same changes are made in #521.  
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-251) DNSSEC keys refresh doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984913#comment-15984913
 ] 

ASF GitHub Bot commented on TC-251:
---

Github user oren-shemesh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/521#discussion_r113468159
  
--- Diff: traffic_ops/app/lib/MojoPlugins/Daemonize.pm ---
@@ -41,12 +41,6 @@ sub register {
# This is the first child
$self->inactivity_timeout(0);
POSIX::setsid();
-   open( STDIN, "< /dev/null" )
-   || confess("Can't read /dev/null: $!");
--- End diff --

Why are you removing these lines ?
They make sure that any accidental input/output activity in the child 
process will not interfere with the parent process.
It is a standard thing to do when spawning child processes.


> DNSSEC keys refresh doesn't work
> 
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0, 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work.  It never returns a reponse to the 
> client, so the client times out, and it also isn't actually updating the 
> expired keys.  I think the client issues was introduced with changes to the 
> "fork_and_daemonize()" method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #521: [TC-251] Fixed an issue where Tr...

[oren-shemesh]

Github user oren-shemesh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/521#discussion_r113468159
  
--- Diff: traffic_ops/app/lib/MojoPlugins/Daemonize.pm ---
@@ -41,12 +41,6 @@ sub register {
# This is the first child
$self->inactivity_timeout(0);
POSIX::setsid();
-   open( STDIN, "< /dev/null" )
-   || confess("Can't read /dev/null: $!");
--- End diff --

Why are you removing these lines ?
They make sure that any accidental input/output activity in the child 
process will not interfere with the parent process.
It is a standard thing to do when spawning child processes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-251) DNSSEC keys refresh doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984914#comment-15984914
 ] 

ASF GitHub Bot commented on TC-251:
---

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/520
  
@oren-shemesh can you close this since the same changes are made in #521.  
Thanks!


> DNSSEC keys refresh doesn't work
> 
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0, 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work.  It never returns a reponse to the 
> client, so the client times out, and it also isn't actually updating the 
> expired keys.  I think the client issues was introduced with changes to the 
> "fork_and_daemonize()" method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #521: [TC-251] Fixed an issue where Tr...

[dneuman64]

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/521#discussion_r113472074
  
--- Diff: traffic_ops/app/lib/MojoPlugins/Daemonize.pm ---
@@ -41,12 +41,6 @@ sub register {
# This is the first child
$self->inactivity_timeout(0);
POSIX::setsid();
-   open( STDIN, "< /dev/null" )
-   || confess("Can't read /dev/null: $!");
--- End diff --

I removed them because they were preventing me from seeing log output from 
the child process (even using $self->app->log).  It's probably just an issue 
with my local env, so I can add them back in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-251) DNSSEC keys refresh doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984901#comment-15984901
 ] 

ASF GitHub Bot commented on TC-251:
---

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/517
  
Closing this as a better solution is provided in #521 


> DNSSEC keys refresh doesn't work
> 
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0, 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work.  It never returns a reponse to the 
> client, so the client times out, and it also isn't actually updating the 
> expired keys.  I think the client issues was introduced with changes to the 
> "fork_and_daemonize()" method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TC-251) DNSSEC keys refresh doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984902#comment-15984902
 ] 

ASF GitHub Bot commented on TC-251:
---

Github user dneuman64 closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/517


> DNSSEC keys refresh doesn't work
> 
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0, 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work.  It never returns a reponse to the 
> client, so the client times out, and it also isn't actually updating the 
> expired keys.  I think the client issues was introduced with changes to the 
> "fork_and_daemonize()" method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #517: [TC-251] Fixed an issue where Tr...

[dneuman64]

Github user dneuman64 closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/517


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-251) DNSSEC keys refresh doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984920#comment-15984920
 ] 

ASF GitHub Bot commented on TC-251:
---

Github user oren-shemesh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/520


> DNSSEC keys refresh doesn't work
> 
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0, 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work.  It never returns a reponse to the 
> client, so the client times out, and it also isn't actually updating the 
> expired keys.  I think the client issues was introduced with changes to the 
> "fork_and_daemonize()" method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol issue #517: [TC-251] Fixed an issue where Traffic O...

[dneuman64]

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/517
  
Closing this as a better solution is provided in #521 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #521: [TC-251] Fixed an issue where Tr...

[dneuman64]

GitHub user dneuman64 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/521

[TC-251] Fixed an issue where Traffic Ops was not correctly refreshing 
DNSSEC keys

This fixes [TC-251](https://issues.apache.org/jira/browse/TC-251)
Thanks to @oren-shemesh for the help!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dneuman64/incubator-trafficcontrol 
TC-251-again

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #521


commit 00ad90659422cd5e6773b31738bb913b3bcc141a
Author: David Neuman 
Date:   2017-04-25T21:00:09Z

Fixed and issue where a search for DSs was using a profile ID instead of 
cdn_id

(cherry picked from commit 3f6f1cc17befc970bc0bf5cff8ff5023bd48c27c)

commit c1ef4a07d09624832ab4dfe463034492381b5c87
Author: David Neuman 
Date:   2017-04-26T14:26:17Z

Change Daemonize so that parent process returns a 1 instead of a 0, also 
remove re-direct of output to /dev/null.  Thanks @oren-shemesh for the help




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TC-253) TO API - create API endpoint for changing server status

[Jeremy Mitchell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Mitchell updated TC-253:
---
Description: 
The API could look like this:

PUT api/$version/servers/:id/status and include a request payload like:

{ "statusId": 1, "offlineReason": "foo bar" }

If status is OFFLINE or ADMIN_DOWN, then offlineReason is required.

This api should be limited to ops or above.

Changing the status of a server should also queue updates on child caches IF 
the server type is ^EDGE* or ^MID*. This is needed because when you change the 
status of server, the parent.config file of the children servers (servers that 
are in a child cache group) is affected.

  was:
The API could look like this:

PUT api/$version/servers/:id/status and include a request payload like:

{ "statusId": 1, "offlineReason": "foo bar" }

If status is OFFLINE or ADMIN_DOWN, then offlineReason is required.

This api should be limited to ops or above.

This api should also queue updates on child caches IF status is "offline" 
(admin_down or offline) and the server type is ^EDGE* or ^MID*


> TO API - create API endpoint for changing server status
> ---
>
> Key: TC-253
> URL: https://issues.apache.org/jira/browse/TC-253
> Project: Traffic Control
>  Issue Type: New Feature
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
> Fix For: 2.1.0
>
> Attachments: screenshot-1.png
>
>
> The API could look like this:
> PUT api/$version/servers/:id/status and include a request payload like:
> { "statusId": 1, "offlineReason": "foo bar" }
> If status is OFFLINE or ADMIN_DOWN, then offlineReason is required.
> This api should be limited to ops or above.
> Changing the status of a server should also queue updates on child caches IF 
> the server type is ^EDGE* or ^MID*. This is needed because when you change 
> the status of server, the parent.config file of the children servers (servers 
> that are in a child cache group) is affected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (TC-253) TO API - create API endpoint for changing server status

[Jeremy Mitchell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Mitchell updated TC-253:
---
Attachment: screenshot-1.png

> TO API - create API endpoint for changing server status
> ---
>
> Key: TC-253
> URL: https://issues.apache.org/jira/browse/TC-253
> Project: Traffic Control
>  Issue Type: New Feature
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
> Fix For: 2.1.0
>
> Attachments: screenshot-1.png
>
>
> The API could look like this:
> PUT api/$version/servers/:id/status and include a request payload like:
> { "statusId": 1, "offlineReason": "foo bar" }
> If status is OFFLINE or ADMIN_DOWN, then offlineReason is required.
> This api should be limited to ops or above.
> Changing the status of a server should also queue updates on child caches IF 
> the server type is ^EDGE* or ^MID*. This is needed because when you change 
> the status of server, the parent.config file of the children servers (servers 
> that are in a child cache group) is affected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TC-251) DNSSEC keys refresh doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984839#comment-15984839
 ] 

ASF GitHub Bot commented on TC-251:
---

Github user dneuman64 closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/518


> DNSSEC keys refresh doesn't work
> 
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0, 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work.  It never returns a reponse to the 
> client, so the client times out, and it also isn't actually updating the 
> expired keys.  I think the client issues was introduced with changes to the 
> "fork_and_daemonize()" method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #518: BACKPORT -- [TC-251] Fixed an is...

[dneuman64]

Github user dneuman64 closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/518


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-251) DNSSEC keys refresh doesn't work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984841#comment-15984841
 ] 

ASF GitHub Bot commented on TC-251:
---

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/518
  
Closing as I think we might go another direction.


> DNSSEC keys refresh doesn't work
> 
>
> Key: TC-251
> URL: https://issues.apache.org/jira/browse/TC-251
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.0.0, 2.1.0
>Reporter: David Neuman
>Assignee: David Neuman
> Fix For: 2.0.0, 2.1.0
>
>
> They DNSSEC keys route doesn't work.  It never returns a reponse to the 
> client, so the client times out, and it also isn't actually updating the 
> expired keys.  I think the client issues was introduced with changes to the 
> "fork_and_daemonize()" method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-trafficcontrol pull request #347: Add global build script.

[limited]

Github user limited commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/347#discussion_r113432531
  
--- Diff: infrastructure/docker/build/clean_build.sh ---
@@ -0,0 +1,8 @@
+#!/usr/bin/env sh
--- End diff --

Needs an AL2 license header


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---