[GitHub] incubator-trafficcontrol issue #553: prevents DB update error when using old...

2017-05-08 Thread dangogh
Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/553
  
is this addressing this error? ```[2017-05-08 23:31:17,160] [ERROR] 
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
failed: ERROR:  null value in column "reval_pending" violates not-null 
constraint```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TC-278) postinstall -defaults should not run carton

2017-05-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001963#comment-16001963
 ] 

ASF GitHub Bot commented on TC-278:
---

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/557

[TC-278] postinstall -defaults option

postinstall -defaults and -h skip all pre-postinstall steps and just pass 
options to the _postinstall perl script.  Also allow -defaults= to specify 
output file to write config.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
postinstall-bypass

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #557


commit 88c43becfc3df0e3062a01ee62e7439ee3e5dfb2
Author: Dan Kirkwood 
Date:   2017-05-08T23:23:12Z

bypass preprocessing for postinstall if -h or -defaults flags passed

commit 6cc07329b372654f6de77064caec8406e7023f33
Author: Dan Kirkwood 
Date:   2017-05-09T00:06:48Z

fix string compare




> postinstall -defaults should not run carton
> ---
>
> Key: TC-278
> URL: https://issues.apache.org/jira/browse/TC-278
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Fix For: 2.1.0
>
>
> `postinstall -defaults` just writes out a .json file with the default values 
> for customization.   It shouldn't try to do anything else (e.g. check 
> postgres installation, check for root, run carton, etc..)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] incubator-trafficcontrol issue #497: [TC-262] Allow specification of the 'id...

2017-05-08 Thread limited
Github user limited commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/497
  

I understand the ATS storage.config parameter, but how is this ID 
configured/generated in Traffic Ops? Is there a per-disk ID parameter (i.e. if 
i have 72 disks there are now 72 new parameters)?

I looked at the referenced PR but it didnt seem to contain API changes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (TC-278) postinstall -defaults should not run carton

2017-05-08 Thread Dan Kirkwood (JIRA)
Dan Kirkwood created TC-278:
---

 Summary: postinstall -defaults should not run carton
 Key: TC-278
 URL: https://issues.apache.org/jira/browse/TC-278
 Project: Traffic Control
  Issue Type: Improvement
  Components: Traffic Ops
Affects Versions: 2.1.0
Reporter: Dan Kirkwood
Assignee: Dan Kirkwood
 Fix For: 2.1.0


`postinstall -defaults` just writes out a .json file with the default values 
for customization.   It shouldn't try to do anything else (e.g. check postgres 
installation, check for root, run carton, etc..)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (TC-277) setting Raik server offline fails with error

2017-05-08 Thread Joseph Pappano (JIRA)
Joseph Pappano created TC-277:
-

 Summary: setting Raik server offline fails with error
 Key: TC-277
 URL: https://issues.apache.org/jira/browse/TC-277
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Ops, Traffic Ops Client 
Affects Versions: 2.1.0
 Environment: Chrome on Mac OS X 
Reporter: Joseph Pappano
Priority: Minor
 Attachments: Screen Shot 2017-05-08 at 3.23.42 PM.png

Setting Riak server offline by clicking edit -> edit -> changing status to 
offline and adding comment -> submit will result in an error. 

clicking edit -> offline server button will succeed. 

attached screenshot of error.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release

2017-05-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001390#comment-16001390
 ] 

ASF GitHub Bot commented on TC-262:
---

Github user jschmerge commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/497
  
The parameter is actually rather nicely documented with examples in the ATS 
documentation: 
https://docs.trafficserver.apache.org/en/latest/admin-guide/files/storage.config.en.html#linux-example

This patch just exposes the configuration item as a knob in traffic-ops.


> Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next 
> release
> ---
>
> Key: TC-262
> URL: https://issues.apache.org/jira/browse/TC-262
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops
>Reporter: John Schmerge
>Priority: Minor
>
> This patch adds three new parameters to control/configure the seed
> strings for the consistent hash used for cachekey->drive mapping in
> ATS... This allows an arbitrary string to be assigned as the key for
> drives instead of relying on the OS's device node name as the seed for
> the hash. The three parameters added are:
> Drive_Hash_Id
> RAM_Drive_Hash_Id
> SSD_Drive_Hash_Id
> And they specify the id keys for spinning, ram, and ssd devices.
> If this parameter is missing from the TO config for a server, the
> generated file ommits any specification of the id parameter (preserving
> the previous file generation behavior).
> Also note that the csv id strings for these three new parameters should
> order their entries to match the order of the Drive_Letters parameter.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (TC-64) TO experimental SPA application

2017-05-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001379#comment-16001379
 ] 

ASF GitHub Bot commented on TC-64:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/549


> TO experimental SPA application
> ---
>
> Key: TC-64
> URL: https://issues.apache.org/jira/browse/TC-64
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> At the 2016 Traffic Control summit, a prototype of a SPA application 
> developed by [~mitchell...@apache.org] using AngularJS was demo'd that works 
> entirely on top of the TO API.
> This issue is a placeholder for any work done to this prototype / 
> experimental UI. The goal is to replicate the functionality of the current 
> MVC TO UI. nothing more, nothing less.
> This will require some additions to the TO API. look for issues regarding 
> each API addition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] incubator-trafficcontrol pull request #549: [TC-64] to ui exp dashboard

2017-05-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/549


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (TC-276) TO API: Expose CDN current stats thru the API

2017-05-08 Thread Jeremy Mitchell (JIRA)
Jeremy Mitchell created TC-276:
--

 Summary: TO API: Expose CDN current stats thru the API
 Key: TC-276
 URL: https://issues.apache.org/jira/browse/TC-276
 Project: Traffic Control
  Issue Type: Improvement
  Components: Traffic Ops API
Reporter: Jeremy Mitchell
Assignee: Jeremy Mitchell
Priority: Minor


Currently, CDN stats (bandwidth, connections and capacity) can be fetched via

internal/api/$version/current_stats without authentication

This data is valuable and should be available through the API once a user is 
"authenticated".

This would simply require creating a route such as:

$r->get("/api/$version/current_stats")->over( authenticated => 1 )->to( 
'CacheStats#current_stats', namespace => $namespace );



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (TC-276) TO API: Expose CDN current stats thru the API

2017-05-08 Thread Jeremy Mitchell (JIRA)

 [ 
https://issues.apache.org/jira/browse/TC-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Mitchell updated TC-276:
---
Description: 
Currently, CDN stats (bandwidth, connections and capacity) can be fetched via

internal/api/$version/current_stats without authentication

This data is valuable and should be available through the API once a user is 
"authenticated".

This would simply require creating a route such as:

$r->get("/api/$version/current_stats") -> over( authenticated => 1 ) -> to( 
'CacheStats#current_stats', namespace => $namespace );

  was:
Currently, CDN stats (bandwidth, connections and capacity) can be fetched via

internal/api/$version/current_stats without authentication

This data is valuable and should be available through the API once a user is 
"authenticated".

This would simply require creating a route such as:

$r->get("/api/$version/current_stats")->over( authenticated => 1 )->to( 
'CacheStats#current_stats', namespace => $namespace );


> TO API: Expose CDN current stats thru the API
> -
>
> Key: TC-276
> URL: https://issues.apache.org/jira/browse/TC-276
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Currently, CDN stats (bandwidth, connections and capacity) can be fetched via
> internal/api/$version/current_stats without authentication
> This data is valuable and should be available through the API once a user is 
> "authenticated".
> This would simply require creating a route such as:
> $r->get("/api/$version/current_stats") -> over( authenticated => 1 ) -> to( 
> 'CacheStats#current_stats', namespace => $namespace );



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] incubator-trafficcontrol issue #347: Add global build script.

2017-05-08 Thread dangogh
Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/347
  
+1 -- add the license headers,  and I also think it should be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-trafficcontrol issue #486: [TC-82] - removes duplicate apis

2017-05-08 Thread dangogh
Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/486
  
do we know if anyone might be using these?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-trafficcontrol pull request #552: [TC-272] Remove ccr and steering...

2017-05-08 Thread mtorluemke
Github user mtorluemke commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/552#discussion_r115272927
  
--- Diff: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm ---
@@ -1470,6 +1473,9 @@ sub ssl_multicert_dot_config {
 
#first one is the one we want
my $hostname = $example_urls[0];
+   if ( $hostname =~ /ccr/ ) {
--- End diff --

default string for open source builds is 'tr'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TC-272) ORT should ignore STEERING deliveryservices

2017-05-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000885#comment-16000885
 ] 

ASF GitHub Bot commented on TC-272:
---

Github user mtorluemke commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/552#discussion_r115272927
  
--- Diff: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm ---
@@ -1470,6 +1473,9 @@ sub ssl_multicert_dot_config {
 
#first one is the one we want
my $hostname = $example_urls[0];
+   if ( $hostname =~ /ccr/ ) {
--- End diff --

default string for open source builds is 'tr'


> ORT should ignore STEERING deliveryservices
> ---
>
> Key: TC-272
> URL: https://issues.apache.org/jira/browse/TC-272
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: David Neuman
>Assignee: Derek Gelinas
>
> With the 2.1 version of Traffic ops ORT, ORT grabs all of the configurations 
> for all of the Delivery services in a CDN and puts it on all caches in the 
> CDN regardless of DS Type and DS server assignments.   This causes an issue 
> with Steering deliveryservice because A) steering DSs shouldn't be on the 
> caches and B) steering DSs are created with certs that start with `ccr.` and 
> ORT does not know how to find those certificates in Traffic Vault which 
> causes ORT to fail.
> ORT should be updated such that Steering delivery service configurations are 
> not put on caches. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] incubator-trafficcontrol pull request #555: run dispersion sleep after updat...

2017-05-08 Thread dg4prez
GitHub user dg4prez opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/555

run dispersion sleep after update check

This runs the dispersion check after we check for an update, rather than 
before.  This will improve the revalidation timing runs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dg4prez/incubator-trafficcontrol 
dispersion_after_check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/555.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #555


commit 28fa0a73ee390259a20fbf409f2425dd3ff8d77c
Author: Derek Gelinas 
Date:   2017-05-08T14:18:14Z

run dispersion sleep after update check




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-trafficcontrol pull request #554: add some sorting to parent confi...

2017-05-08 Thread dg4prez
GitHub user dg4prez opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/554

add some sorting to parent config and metadata

Adds some sorting to parent.config and the ORT metadata.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dg4prez/incubator-trafficcontrol 
sort_api_configs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #554






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-trafficcontrol pull request #553: prevents DB update error when us...

2017-05-08 Thread dg4prez
GitHub user dg4prez opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/553

prevents DB update error when using older syncds versions with reval 
pending…

When updating the status page with use_reval_pending enabled and an older 
version of ORT, we are attempting to push a null value to the DB.  This fixes 
that.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dg4prez/incubator-trafficcontrol fix_db_error

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #553


commit 291c8a31460ccf0317b5a3e20cd4b25c7cc29f3f
Author: Derek Gelinas 
Date:   2017-05-08T11:53:31Z

prevents DB error when using older syncds versions with reval pending 
enabled




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---