[jira] [Commented] (TC-401) Traffic Router Serves OFFLINE Caches

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063811#comment-16063811
 ] 

ASF GitHub Bot commented on TC-401:
---

GitHub user elsloo opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/702

[TC-401] Fixes a race condition related to lazy loading of CacheLocat…

…ions on a NetworkNode when state changes occur from OFFLINE<->ONLINE 
within a CRConfig snapshot.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/elsloo/incubator-trafficcontrol 
2.1.x_fix_network_node_lazy_loading_race

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/702.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #702


commit 37a978e24e2d79b0441a0d3bb3ca2fe9dc6fac66
Author: Jeff Elsloo 
Date:   2017-06-26T21:19:38Z

[TC-401] Fixes a race condition related to lazy loading of CacheLocations 
on a NetworkNode when state changes occur from OFFLINE<->ONLINE within a 
CRConfig snapshot.




> Traffic Router Serves OFFLINE Caches
> 
>
> Key: TC-401
> URL: https://issues.apache.org/jira/browse/TC-401
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Router
>Affects Versions: 2.0.0
>Reporter: Jeff Elsloo
> Fix For: 2.1.0
>
>
> We identified an issue that causes Traffic Router to serve up an {{OFFLINE}} 
> cache indefinitely after a snapshot of the CRConfig. This bug will also do 
> the inverse, where a cache that was previously set to {{OFFLINE}} will never 
> have traffic routed to it when set back to {{ONLINE}} or {{REPORTED}} 
> (referenced only as {{ONLINE}} henceforth).
> The bug is caused by {{ConfigHandler.processConfig()}} clearing the cache 
> locations from the {{NetworkNode}} prior to swapping out the instance of 
> {{CacheRegister}}. When the cache locations have been cleared, but the prior 
> {{CacheRegister}} is still in place, a race condition can occur where the 
> {{CacheLocation}} for a given cache group from the prior config will be set 
> on the recently cleared {{NetworkNode}}. When this happens, the 
> {{List}} contains the prior config's list for that cache group, which 
> means that any host state change from/to {{ONLINE}} or {{OFFLINE}} will not 
> be reflected. This is because when transitioning to {{OFFLINE}} the {{Cache}} 
> drops from the CRConfig and it will reappear when set to {{ONLINE}}. Contrast 
> this with {{ONLINE}} to {{ADMIN_DOWN}}, the {{Cache}} remains in the 
> CRConfig, so we are simply using the status to determine whether the cache is 
> available and the software works as designed.
> This is due to the way we use lazy loading to associate network ranges within 
> the CZF with {{CacheLocations}} within a given {{NetworkNode}} representing 
> that section of the CZF. In {{TrafficRouter}}, during cache selection, if we 
> have a hit in the coverage zone file but the {{CacheLocation}} is 
> uninitialized, we obtain the {{CacheLocation}} from {{CacheRegister}} and set 
> it for that specific {{NetworkNode}}. If our {{NetworkNode}} is cleared but 
> our {{CacheRegister}} has yet to be swapped, we will set the {{NetworkNode}} 
> to the old {{CacheLocation}} and as mentioned, which will have a reference to 
> the prior {{List}}, denying anyone the opportunity to populate that 
> {{NetworkNode}} with the new {{CacheLocation}} and new {{List}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #702: [TC-401] Fixes a race condition ...

[elsloo]

GitHub user elsloo opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/702

[TC-401] Fixes a race condition related to lazy loading of CacheLocat…

…ions on a NetworkNode when state changes occur from OFFLINE<->ONLINE 
within a CRConfig snapshot.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/elsloo/incubator-trafficcontrol 
2.1.x_fix_network_node_lazy_loading_race

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/702.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #702


commit 37a978e24e2d79b0441a0d3bb3ca2fe9dc6fac66
Author: Jeff Elsloo 
Date:   2017-06-26T21:19:38Z

[TC-401] Fixes a race condition related to lazy loading of CacheLocations 
on a NetworkNode when state changes occur from OFFLINE<->ONLINE within a 
CRConfig snapshot.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (TC-401) Traffic Router Serves OFFLINE Caches

[Jeff Elsloo (JIRA)]

Jeff Elsloo created TC-401:
--

 Summary: Traffic Router Serves OFFLINE Caches
 Key: TC-401
 URL: https://issues.apache.org/jira/browse/TC-401
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Router
Affects Versions: 2.0.0
Reporter: Jeff Elsloo
 Fix For: 2.1.0


We identified an issue that causes Traffic Router to serve up an {{OFFLINE}} 
cache indefinitely after a snapshot of the CRConfig. This bug will also do the 
inverse, where a cache that was previously set to {{OFFLINE}} will never have 
traffic routed to it when set back to {{ONLINE}} or {{REPORTED}} (referenced 
only as {{ONLINE}} henceforth).

The bug is caused by {{ConfigHandler.processConfig()}} clearing the cache 
locations from the {{NetworkNode}} prior to swapping out the instance of 
{{CacheRegister}}. When the cache locations have been cleared, but the prior 
{{CacheRegister}} is still in place, a race condition can occur where the 
{{CacheLocation}} for a given cache group from the prior config will be set on 
the recently cleared {{NetworkNode}}. When this happens, the {{List}} 
contains the prior config's list for that cache group, which means that any 
host state change from/to {{ONLINE}} or {{OFFLINE}} will not be reflected. This 
is because when transitioning to {{OFFLINE}} the {{Cache}} drops from the 
CRConfig and it will reappear when set to {{ONLINE}}. Contrast this with 
{{ONLINE}} to {{ADMIN_DOWN}}, the {{Cache}} remains in the CRConfig, so we are 
simply using the status to determine whether the cache is available and the 
software works as designed.

This is due to the way we use lazy loading to associate network ranges within 
the CZF with {{CacheLocations}} within a given {{NetworkNode}} representing 
that section of the CZF. In {{TrafficRouter}}, during cache selection, if we 
have a hit in the coverage zone file but the {{CacheLocation}} is 
uninitialized, we obtain the {{CacheLocation}} from {{CacheRegister}} and set 
it for that specific {{NetworkNode}}. If our {{NetworkNode}} is cleared but our 
{{CacheRegister}} has yet to be swapped, we will set the {{NetworkNode}} to the 
old {{CacheLocation}} and as mentioned, which will have a reference to the 
prior {{List}}, denying anyone the opportunity to populate that 
{{NetworkNode}} with the new {{CacheLocation}} and new {{List}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #701: TPv2 - adds back missing css cha...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/701


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (TC-261) Add ability to configure steering subordinates with 0 weight

[Jeff Elsloo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Elsloo closed TC-261.
--

> Add ability to configure steering subordinates with 0 weight
> 
>
> Key: TC-261
> URL: https://issues.apache.org/jira/browse/TC-261
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Ops API, Traffic Router
>Reporter: Jeff Elsloo
>Assignee: Jeff Elsloo
>Priority: Minor
>  Labels: configuration, steering
> Fix For: 2.1.0
>
>
> Add the ability to use a 0 weight with steering delivery service 
> subordinates, and optionally include the ability to specify an order. We'll 
> need to enhance the TO UI, API and TR. See TC-376 for the TO changes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (TC-261) Add ability to configure steering subordinates with 0 weight

[Jeff Elsloo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Elsloo resolved TC-261.

Resolution: Fixed

> Add ability to configure steering subordinates with 0 weight
> 
>
> Key: TC-261
> URL: https://issues.apache.org/jira/browse/TC-261
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Ops API, Traffic Router
>Reporter: Jeff Elsloo
>Assignee: Jeff Elsloo
>Priority: Minor
>  Labels: configuration, steering
> Fix For: 2.1.0
>
>
> Add the ability to use a 0 weight with steering delivery service 
> subordinates, and optionally include the ability to specify an order. We'll 
> need to enhance the TO UI, API and TR. See TC-376 for the TO changes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #701: TPv2 - adds back missing css cha...

[mitchell852]

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/701

TPv2 - adds back missing css changes when file was deleted



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
theme-scss

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/701.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #701


commit 21dca6bbbe8b0c2a2f544e5c23667b1dd885159a
Author: Jeremy Mitchell 
Date:   2017-06-26T18:52:31Z

adds back missing changes when file was deleted




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-261) Add ability to configure steering subordinates with 0 weight

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063368#comment-16063368
 ] 

ASF GitHub Bot commented on TC-261:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/696


> Add ability to configure steering subordinates with 0 weight
> 
>
> Key: TC-261
> URL: https://issues.apache.org/jira/browse/TC-261
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Ops API, Traffic Router
>Reporter: Jeff Elsloo
>Assignee: Jeff Elsloo
>Priority: Minor
>  Labels: configuration, steering
> Fix For: 2.1.0
>
>
> Add the ability to use a 0 weight with steering delivery service 
> subordinates, and optionally include the ability to specify an order. We'll 
> need to enhance the TO UI, API and TR. See TC-376 for the TO changes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #696: [TC-261] Adds ability to use ste...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/696


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #700: fixes problematic character

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/700


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #700: fixes problematic character

[mitchell852]

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/700

fixes problematic character



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
fixes-character

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/700.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #700


commit 15dad3cf5e2890a7dedd372cefa4779696698936
Author: Jeremy Mitchell 
Date:   2017-06-26T16:33:16Z

fixes problematic character




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : incubator-trafficcontrol-rat #92

[Apache Jenkins Server]

See 

Build failed in Jenkins: incubator-trafficcontrol-rat #91

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-master-build" build 
number 91
originally caused by:
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-4 (ubuntu trusty) in workspace 

[incubator-trafficcontrol-rat] $ /bin/bash -xe /tmp/hudson6205386845536015521.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-master-build
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-master-build:
[operations-center-context]   apache-trafficcontrol-2.1.0-incubating.tar.gz
[incubator-trafficcontrol-rat] $ /bin/bash -xe /tmp/hudson6242437074897814595.sh
+ set -exu
++ ls apache-trafficcontrol-2.1.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.1.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.1.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.1.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ grep 'Copyright 2017 The Apache Software Foundation' NOTICE
Copyright 2017 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
+ ratver=apache-rat-0.13-20170427.032418-37.jar
++ mktemp -d
+ ratdir=/tmp/tmp.pKdqFCzY4y
+ ratjar=/tmp/tmp.pKdqFCzY4y/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.pKdqFCzY4y/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20170427.032418-37.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
1587k  100 1587k0 0  1642k  0 --:--:-- --:--:-- --:--:-- 1641k
+ curl -L -o /tmp/tmp.pKdqFCzY4y/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20170427.032418-37.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
   40  100400 0 94  0 --:--:-- --:--:-- --:--:--94
++ awk '{print $1}'
++ sha1sum /tmp/tmp.pKdqFCzY4y/apache-rat-0.13.SNAPSHOT.jar
++ cat /tmp/tmp.pKdqFCzY4y/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ ac5cfd859902d5c858baed8dbcf91c014ce9ae23 == 
ac5cfd859902d5c858baed8dbcf91c014ce9ae23 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.pKdqFCzY4y/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.pKdqFCzY4y
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=1
+ [[ 1 != 0 ]]
+ echo '1 Unknown Licenses'
1 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.1.0-incubating/traffic_ops/app/db/migrations/20170601183753_steering_target.sql

*
+ exit 1
Build step 'Execute shell' marked build as failure
Archiving artifacts
Compressed 373.11 KB of artifacts by 60.0% relative to #89

[GitHub] incubator-trafficcontrol pull request #697: Adds triggers missed by mysql->p...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/697


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #699: Fix licenses

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/699


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #698: TPv2 - adds the ability to defin...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/698


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #699: Fix licenses

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/699

Fix licenses

- add missing license to migration sql
- re-add scss file previously removed and add to .rat-excludes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol fix-licenses

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/699.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #699


commit 944c5b222489c542bf9a20df870f80a55e6eafb9
Author: Dan Kirkwood 
Date:   2017-06-26T15:20:37Z

re-add scss file -- license covered

commit 0787bab3b7226d0183fc6150073763379ca7736b
Author: Dan Kirkwood 
Date:   2017-06-26T15:20:52Z

add exclusion to rat

commit 68343c1ea4ddcc23a80688fa456f06b15008cb22
Author: Dan Kirkwood 
Date:   2017-06-26T15:21:11Z

add missing license




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #698: TPv2 - adds the ability to defin...

[mitchell852]

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/698

TPv2 - adds the ability to define a custom menu via a json file



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
tc-64-tpv2-custom-menu

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/698.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #698


commit b18980add9955ca4ecf7b939102ec669a7cbed9d
Author: Jeremy Mitchell 
Date:   2017-06-26T15:16:44Z

adds the ability to define a custom menu via a json file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---