[GitHub] incubator-trafficcontrol pull request #779: switch json_is asserts that reli...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/779


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #779: switch json_is asserts that reli...

[DylanVolz]

GitHub user DylanVolz opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/779

switch json_is asserts that relied on ordering to content_like asserts in 
server.t



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DylanVolz/incubator-trafficcontrol 
remove-server-test-flaps

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/779.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #779


commit 3b1bcf8a9b106b80f0d86863e305951bc4d1f4f4
Author: Dylan Volz 
Date:   2017-08-04T21:53:33Z

switch json_is asserts that relied on ordering to content_like asserts




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (TC-499) Traffic Portal logging should be consistent with other TC applications

[David Neuman (JIRA)]

David Neuman created TC-499:
---

 Summary: Traffic Portal logging should be consistent with other TC 
applications
 Key: TC-499
 URL: https://issues.apache.org/jira/browse/TC-499
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Portal
Reporter: David Neuman


Currently, Traffic Portal's logging is different from other TC components.  It 
does not contain a log level or a timestamp.  We should make the logging 
consistent with other TC components so that users can easily discern what is 
going on and when it happened.

Example of the current logging (these messages were over several hours): 


{quote}
Error: ENOENT: no such file or directory, open '/etc/pki/tls/private/ca.crt'
at Error (native)
at Object.fs.openSync (fs.js:641:18)
at Object.fs.readFileSync (fs.js:509:33)
at Object. (/opt/traffic_portal/server.js:148:29)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.runMain (module.js:604:10)
error: Forever detected script exited with code: 1
error: Script restart attempt #116
Traffic Portal Port : 80
Traffic Portal SSL Port : 443
error: Forever detected script was killed by signal: SIGKILL
Traffic Portal Port : 80
Traffic Portal SSL Port : 443
error: Forever detected script was killed by signal: SIGKILL
Traffic Portal Port : 80
Traffic Portal SSL Port : 443
{quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #778: [TC-475] defaults ats_ver to 5 t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/778


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-475) TO integration test warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114939#comment-16114939
 ] 

ASF GitHub Bot commented on TC-475:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/778


> TO integration test warnings
> 
>
> Key: TC-475
> URL: https://issues.apache.org/jira/browse/TC-475
> Project: Traffic Control
>  Issue Type: Test
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
> Environment: see 
> https://builds.apache.org/view/S-Z/view/TrafficControl/job/incubator-trafficcontrol-traffic_ops-test/34/
>Reporter: Dan Kirkwood
>Priority: Minor
>
> while running traffic_ops integration tests, there are a lot of warnings like 
> this:
> {quote}
> Use of uninitialized value $ats_ver in substr at 
> /opt/traffic_ops/app/lib/UI/ConfigFiles.pm line 1099.
> # ... server: atsec-phl-01 CDN1 EDGE1_CDN1_421_SSL
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #778: [TC-475] defaults ats_ver to 5 t...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/778

[TC-475] defaults ats_ver to 5 to eliminate  undef warnings.

also warns user of missing parameter

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
ats-ver-warning

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #778


commit 615943c0345f49e55f4a98416f36aac05f366892
Author: Dan Kirkwood 
Date:   2017-08-04T20:05:24Z

defaults ats_ver to 5.  This eliminates warnings during integration test 
and warns user of missing parameter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[alficles]

Github user alficles commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r131466564
  
--- Diff: traffic_ops/install/bin/_postinstall ---
@@ -218,7 +234,9 @@ sub generateCdnConf {
 $#secrets = $cdnConfiguration{keepSecrets} - 1;
 }
 }
+$cdnConf = setCdnConfGoPort($cdnConf);
--- End diff --

What's the default max_db_connections for the Perl version?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[alficles]

Github user alficles commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r131465943
  
--- Diff: traffic_ops/install/bin/_postinstall ---
@@ -183,6 +183,22 @@ sub generateDbConf {
 return \%todbconf;
 }
 
+sub setCdnConfGoPort {
+my $cdnConf = shift;
+if ( exists $cdnConf->{traffic_ops_golang_port} ) {
--- End diff --

I'm confused as to when the port value might be removed. This should always 
add the port, if it's missing. If the config is regenerated, it might lose the 
value, but I'm not seeing a code path here that causes the port value to go 
missing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-402) xml_id should not be changed after initial Delivery Service Creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114834#comment-16114834
 ] 

ASF GitHub Bot commented on TC-402:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/705


> xml_id should not be changed after initial Delivery Service Creation
> 
>
> Key: TC-402
> URL: https://issues.apache.org/jira/browse/TC-402
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Reporter: Dewayne Richardson
>Assignee: Jeremy Mitchell
>
> Traffic Ops cannot handle changing the xml_id because the parameters for the 
> ATS config files use the xml_id by naming convention.
> Easy fix, just disable the 'xml_id' field for "Edit/Updates"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-498) TO API - when updating current user, full name is required

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114831#comment-16114831
 ] 

ASF GitHub Bot commented on TC-498:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/777


> TO API - when updating current user, full name is required
> --
>
> Key: TC-498
> URL: https://issues.apache.org/jira/browse/TC-498
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> case error caused validation to fail. see fullName vs full_name
> https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/User.pm#L646
> https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/User.pm#L653



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #777: [TC-498] - case mismatch was cau...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/777


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #634: [TC-361] Added a read timeout to...

[elsloo]

Github user elsloo closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/634


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-361) Split DNS thread pools by protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114780#comment-16114780
 ] 

ASF GitHub Bot commented on TC-361:
---

Github user elsloo closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/634


> Split DNS thread pools by protocol
> --
>
> Key: TC-361
> URL: https://issues.apache.org/jira/browse/TC-361
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Router
>Reporter: Jeff Elsloo
>Assignee: Jeff Elsloo
>Priority: Minor
>
> Split DNS thread pools by protocol (tcp, udp).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-361) Split DNS thread pools by protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114779#comment-16114779
 ] 

ASF GitHub Bot commented on TC-361:
---

Github user elsloo commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/634
  
This should have been closed with the merge above, not sure what happened.


> Split DNS thread pools by protocol
> --
>
> Key: TC-361
> URL: https://issues.apache.org/jira/browse/TC-361
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Router
>Reporter: Jeff Elsloo
>Assignee: Jeff Elsloo
>Priority: Minor
>
> Split DNS thread pools by protocol (tcp, udp).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol issue #634: [TC-361] Added a read timeout to TCP DN...

[elsloo]

Github user elsloo commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/634
  
This should have been closed with the merge above, not sure what happened.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-498) TO API - when updating current user, full name is required

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114680#comment-16114680
 ] 

ASF GitHub Bot commented on TC-498:
---

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/777

[TC-498] - case mismatch was causing no validation on fullName when  
updating current user



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
fixes-current-user-full-name

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #777


commit ca74f9313d02f098db05068adb48d64fa37625f8
Author: Jeremy Mitchell 
Date:   2017-08-04T17:32:43Z

case mismatch was causing no validation on fullName




> TO API - when updating current user, full name is required
> --
>
> Key: TC-498
> URL: https://issues.apache.org/jira/browse/TC-498
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> case error caused validation to fail. see fullName vs full_name
> https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/User.pm#L646
> https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/User.pm#L653



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #777: [TC-498] - case mismatch was cau...

[mitchell852]

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/777

[TC-498] - case mismatch was causing no validation on fullName when  
updating current user



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
fixes-current-user-full-name

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #777


commit ca74f9313d02f098db05068adb48d64fa37625f8
Author: Jeremy Mitchell 
Date:   2017-08-04T17:32:43Z

case mismatch was causing no validation on fullName




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (TC-498) TO API - when updating current user, full name is required

[Jeremy Mitchell (JIRA)]

Jeremy Mitchell created TC-498:
--

 Summary: TO API - when updating current user, full name is required
 Key: TC-498
 URL: https://issues.apache.org/jira/browse/TC-498
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Ops API
Reporter: Jeremy Mitchell
Assignee: Jeremy Mitchell
Priority: Minor


case error caused validation to fail. see fullName vs full_name

https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/User.pm#L646

https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/User.pm#L653



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-497) delivery service updates taking >20 secs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114620#comment-16114620
 ] 

ASF GitHub Bot commented on TC-497:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/763


> delivery service updates taking >20 secs
> 
>
> Key: TC-497
> URL: https://issues.apache.org/jira/browse/TC-497
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Reporter: Dylan Volz
>Assignee: Dylan Volz
>
> delivery service updates have begun taking about 25 seconds to finish. 
> I have tracked this down to this call:
> my $rs = $self->db->resultset('DeliveryserviceRegex')->search(undef, 
> {prefetch => [
> {regex => undef}
> ,
> {deliveryservice => undef}
> ]} );
> in the find_existing_host_regex helper defined in 
> MojoPlugins/DeliveryService.pm
> The worker is selected for graceful shutdown due to no heartbeat each time an 
> update is made, but usually completes before the shutdown allowing the update 
> to go through.
> If you add a second host regex to the delivery service the update will always 
> fail because it makes that db call twice and thus the worker is killed before 
> the request finishes, and the request is sent to a new worker, continuing the 
> process until the browser cancels the request.
> Note: delivery service updates via the API do not have this problem because 
> it appears that code path does not check for conflicting regexes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #763: [TC-497] refactor logic to check...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/763


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-187) Update delivery service makes SSL keys invalid

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114618#comment-16114618
 ] 

ASF GitHub Bot commented on TC-187:
---

Github user rawlinp commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/360
  
@zhilhuan can you please rebase this PR?

This PR also seems to fix an issue we'll have once per-DeliveryService 
routing names are implemented soon. Basically, if a DNS DS starts using the DNS 
routing name "my-edge" rather than the default "edge", the new hostname will 
mismatch the hostname used in the SSL cert. Your PR seems to address that 
issue, which is helpful in addition to the issue of changing the xml_id.


> Update delivery service makes SSL keys invalid
> --
>
> Key: TC-187
> URL: https://issues.apache.org/jira/browse/TC-187
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>  Labels: ssl, xml-id
>
> Modify xml-id or subdomain in a https delivery service will make existing SSL 
> keys invalid.
> And there is problem to generate keys if using "http and https" together with 
> 1 host_regex, and 1 path_regex.
> BTW, the certificate returned by RESTful API is not consistent with that GUI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol issue #360: [TC-187] fix HTTPs bugs

[rawlinp]

Github user rawlinp commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/360
  
@zhilhuan can you please rebase this PR?

This PR also seems to fix an issue we'll have once per-DeliveryService 
routing names are implemented soon. Basically, if a DNS DS starts using the DNS 
routing name "my-edge" rather than the default "edge", the new hostname will 
mismatch the hostname used in the SSL cert. Your PR seems to address that 
issue, which is helpful in addition to the issue of changing the xml_id.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #776: fixes tenant test

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/776


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #776: fixes tenant test

[nir-sopher]

Github user nir-sopher commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/776
  
10x!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #776: fixes tenant test

[mitchell852]

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/776

fixes tenant test



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
fixes-tenant-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/776.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #776


commit 0042e205454ff4058ee2fda53f72a3755767cd29
Author: Jeremy Mitchell 
Date:   2017-08-04T16:12:28Z

fixes tenant test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #775: Clear tenants - to operate well ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/775


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #738: make delivery service `MultiSiteOrigin`...

[dneuman64]

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/738
  
@mdb do you see my comment above?  Based on that I think this PR should be 
closed.  Thoughts?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---