[GitHub] asfgit commented on issue #2131: Fix org_server_fqdn trailing slash issue

[GitBox]

asfgit commented on issue #2131: Fix org_server_fqdn trailing slash issue
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2131#issuecomment-380986771
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1409/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2124: Add TO Go GET, POST deliveryservices routes

[GitBox]

asfgit commented on issue #2124: Add TO Go GET, POST deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380978018
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1408/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp opened a new pull request #2131: Fix org_server_fqdn trailing slash issue

[GitBox]

rawlinp opened a new pull request #2131: Fix org_server_fqdn trailing slash 
issue
URL: https://github.com/apache/incubator-trafficcontrol/pull/2131
 
 
   Make the API validation match the form validation of the old TO UI.
   Make TP validation match the API validation.
   Fix issue with existing org_server_fqdns with trailing slashes causing
   an invalid parent.config generation for MSO.
   
   Fixes #2062.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2130: Traffic Ops - golang API servers CRUD tests

[GitBox]

asfgit commented on issue #2130: Traffic Ops - golang API servers CRUD tests
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2130#issuecomment-380957614
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2130: Traffic Ops - golang API servers CRUD tests

[GitBox]

asfgit commented on issue #2130: Traffic Ops - golang API servers CRUD tests
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2130#issuecomment-380957399
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rivasj opened a new pull request #2130: Traffic Ops - golang API servers CRUD tests

[GitBox]

rivasj opened a new pull request #2130: Traffic Ops - golang API servers CRUD 
tests
URL: https://github.com/apache/incubator-trafficcontrol/pull/2130
 
 
   CRUD tests for servers golang endpoints


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2116: TO go: `go get` prior to running unit tests for the golang.org/x dependencies

[GitBox]

asfgit commented on issue #2116: TO go: `go get` prior to running unit tests 
for the golang.org/x dependencies
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2116#issuecomment-380956317
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1407/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #698

[Apache Jenkins Server]

See 

Jenkins build is back to normal : incubator-trafficcontrol-PR #1406

[Apache Jenkins Server]

See 

[GitHub] asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for the servers

[GitBox]

asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for 
the servers
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2128#issuecomment-380931076
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1406/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh commented on issue #2116: TO go: `go get` prior to running unit tests for the golang.org/x dependencies

[GitBox]

dangogh commented on issue #2116: TO go: `go get` prior to running unit tests 
for the golang.org/x dependencies
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2116#issuecomment-380930481
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2116: TO go: `go get` prior to running unit tests for the golang.org/x dependencies

[GitBox]

asfgit commented on issue #2116: TO go: `go get` prior to running unit tests 
for the golang.org/x dependencies
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2116#issuecomment-380908798
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1405/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for the servers

[GitBox]

asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for 
the servers
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2128#issuecomment-380890476
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1404/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2088: TO Go: implement tenants CRUD

[GitBox]

mitchell852 commented on a change in pull request #2088: TO Go: implement 
tenants CRUD
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2088#discussion_r18115
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/routes.go
 ##
 @@ -205,6 +206,13 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
 
//System
{1.2, http.MethodGet, `system/info/?(\.json)?$`, 
systeminfo.Handler(d.DB), auth.PrivLevelReadOnly, Authenticated, nil},
+
+   //Tenants
+   {1.3, http.MethodGet, `tenants/?(\.json)?$`, 
api.ReadHandler(tenant.GetRefType(), d.DB), auth.PrivLevelReadOnly, 
Authenticated, nil},
 
 Review comment:
   I think you should change these to 1.2 because you are simply rewriting the 
same perl endpoints in go


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #540

[Apache Jenkins Server]

See 


Changes:

[dewrich] in global 5xx handler, if there are custom alerts, show them

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 29fbb4e578a1c4e8371f90925008bc4af9a308fc 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 29fbb4e578a1c4e8371f90925008bc4af9a308fc
Commit message: "in global 5xx handler, if there are custom alerts, show them"
 > git rev-list --no-walk b91791d17505bd6b94c6ea564d3ec05f0a058e9a # timeout=10
[incubator-trafficcontrol-traffic_ops-test] $ /bin/bash 
/tmp/jenkins3381243975903286557.sh
Traceback (most recent call last):
  File "/usr/local/bin/docker-compose", line 7, in 
from compose.cli.main import main
  File "/usr/local/lib/python2.7/dist-packages/compose/cli/main.py", line 45, 
in 
from .command import get_config_from_options
  File "/usr/local/lib/python2.7/dist-packages/compose/cli/command.py", line 
17, in 
from .docker_client import docker_client
  File "/usr/local/lib/python2.7/dist-packages/compose/cli/docker_client.py", 
line 12, in 
from docker.utils.config import home_dir
ImportError: No module named config
+ trap finish EXIT
+ proj=jenkins-incubator-trafficcontrol-traffic_ops-test-540
++ pwd
+ 
compose=
+ cfile=traffic_ops/app/bin/tests/docker-compose.yml
+ [[ -z 

 ]]
+ [[ ! -x 

 ]]
+ 

 -p jenkins-incubator-trafficcontrol-traffic_ops-test-540 -f 
traffic_ops/app/bin/tests/docker-compose.yml up --build --exit-code-from 
unit_golang unit_golang
WARNING: Dependency conflict: an older version of the 'docker-py' package may 
be polluting the namespace. If you're experiencing crashes, run the following 
command to remedy the issue:
pip uninstall docker-py; pip uninstall docker; pip install docker
using --exit-code-from implies --abort-on-container-exit
Creating network "jenkinsincubatortrafficcontroltrafficopstest540_default" with 
the default driver
Creating volume "jenkinsincubatortrafficcontroltrafficopstest540_traffic_ops" 
with default driver
Creating volume 
"jenkinsincubatortrafficcontroltrafficopstest540_traffic_ops_golang" with 
default driver
Building unit_golang
Step 1/7 : FROM golang:1.8
1.8: Pulling from library/golang
Digest: sha256:f0b5dab7581eddb49dabd1d1b9aa505ca3edcdf79a66395b5bfa4f3c036b49ef
Status: Downloaded newer image for golang:1.8
 ---> 0d283eb41a92
Step 2/7 : MAINTAINER Dan Kirkwood 
 ---> Using cache
 ---> 540751262b20
Step 3/7 : ARG DIR=github.com/apache/incubator-trafficcontrol
 ---> Using cache
 ---> 56fcf02450a1
Step 4/7 : ADD traffic_ops /go/src/$DIR/traffic_ops
 ---> 655a00716ae5
Removing intermediate container f7720d987ae2
Step 5/7 : ADD lib /go/src/$DIR/lib
 ---> 45173e6af430
Removing intermediate container 508be663c2a5
Step 6/7 : WORKDIR /go/src/$DIR/traffic_ops/traffic_ops_golang
 ---> 363b410174d8
Removing intermediate container 6803ecc32321
Step 7/7 : CMD bash -c 'go test -v $(go list ./... | grep -v /vendor/)'
 ---> Running in 3363cdb486f8
 ---> d7d2d029ebc1
Removing intermediate container 3363cdb486f8
Successfully built d7d2d029ebc1
Successfully tagged 
jenkinsincubatortrafficcontroltrafficopstest540_unit_golang:latest
Creating jenkinsincubatortrafficcontroltrafficopstest540_unit_golang_1 ... 
Creating jenkinsincubatortrafficcontroltrafficopstest540_unit_golang_1
Creating jenkinsincubatortrafficcontroltrafficopstest540_unit_golang_1 ... 
doneAttaching to jenkinsincubatortrafficcontroltrafficopstest540_unit_golang_1
unit_golang_1  | auth/authenticate.go:31:2: cannot 

Jenkins build is back to normal : incubator-trafficcontrol-master-build #697

[Apache Jenkins Server]

See 

Jenkins build is back to normal : incubator-trafficcontrol-rat #651

[Apache Jenkins Server]

See 

Build failed in Jenkins: incubator-trafficcontrol-master-build #696

[Apache Jenkins Server]

See 


--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Archiving artifacts
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:243)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
 does 
not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutor

Build failed in Jenkins: incubator-trafficcontrol-rat #650

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-master-build" build 
number 695
originally caused by:
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Archiving artifacts
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:243)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
 does not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(Intercept

Build failed in Jenkins: incubator-trafficcontrol-master-build #695

[Apache Jenkins Server]

See 


--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Archiving artifacts
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:243)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
 does 
not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutor

Build failed in Jenkins: incubator-trafficcontrol-master-build #694

[Apache Jenkins Server]

See 


--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Archiving artifacts
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:243)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
 does 
not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutor

Build failed in Jenkins: incubator-trafficcontrol-master-build #693

[Apache Jenkins Server]

See 


--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Archiving artifacts
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:243)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
 does 
not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutor

Build failed in Jenkins: incubator-trafficcontrol-master-build #692

[Apache Jenkins Server]

See 


--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Archiving artifacts
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:243)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
 does 
not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutor

Jenkins build is back to normal : incubator-trafficcontrol-rat #646

[Apache Jenkins Server]

See 

Build failed in Jenkins: incubator-trafficcontrol-master-build #691

[Apache Jenkins Server]

See 


--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Done
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Archiving artifacts
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:243)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
 does 
not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(In

[GitHub] dewrich closed pull request #2129: TP - in global 5xx handler, if there are custom alerts, show them

[GitBox]

dewrich closed pull request #2129: TP - in global 5xx handler, if there are 
custom alerts, show them
URL: https://github.com/apache/incubator-trafficcontrol/pull/2129
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_portal/app/src/app.js b/traffic_portal/app/src/app.js
index 49a464588..c7c1e6dbc 100644
--- a/traffic_portal/app/src/app.js
+++ b/traffic_portal/app/src/app.js
@@ -419,7 +419,11 @@ trafficPortal.factory('authInterceptor', function 
($rootScope, $q, $window, $loc
 } else if (rejection.status.toString().match(/^5\d[01356789]$/)) {
 // matches 5xx EXCEPT for 502's and 504's which indicate a 
timeout and will be handled by each service call accordingly
 $timeout(function () {
-messageModel.setMessages([ { level: 'error', text: 
rejection.status.toString() + ': ' + rejection.statusText } ], false);
+if (alerts.length > 0) {
+messageModel.setMessages(alerts, false);
+} else {
+messageModel.setMessages([ { level: 'error', text: 
rejection.status.toString() + ': ' + rejection.statusText } ], false);
+}
 }, 200);
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 opened a new pull request #2129: TP - in global 5xx handler, if there are custom alerts, show them

[GitBox]

mitchell852 opened a new pull request #2129: TP - in global 5xx handler, if 
there are custom alerts, show them
URL: https://github.com/apache/incubator-trafficcontrol/pull/2129
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-rat #645

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-master-build" build 
number 690
originally caused by:
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Archiving artifacts
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:243)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
 does not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
 

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #697

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1403
originally caused by:
 GitHub pull request #2128 of commit ccef48c6423d4d456ca20cb94857eace403c56d5, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

FATAL: Unable to produce a script file
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at hudson.FilePath.createTextTempFile(FilePath.java:1363)
at 
hudson.tasks.CommandInterpreter.createScriptFile(CommandInterpreter.java:162)
at 
hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:94)
at 
hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:66)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at hudson.model.Build$BuildExecution.build(Build.java:206)
at hudson.model.Build$BuildExecution.doRun(Build.java:163)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
java.io.IOException: No space left on device
at java.io.FileOutputStream.writeBytes(Native Method)
at java.io.FileOutputStream.write(FileOutputStream.java:326)
at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221)
at sun.nio.cs.StreamEncoder.implClose(StreamEncoder.java:316)
at sun.nio.cs.StreamEncoder.close(StreamEncoder.java:149)
at java.io.OutputStreamWriter.close(OutputStreamWriter.java:233)
at hudson.FilePath$17.invoke(FilePath.java:1380)
at hudson.FilePath$17.invoke(FilePath.java:1363)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Caused: java.io.IOException: remote file operation failed: 
 at 
hudson.remoting.Channel@23905e9a:H23
at hudson.FilePath.act(FilePath.java:993)
at hudson.FilePath.act(FilePath.java:975)
at hudson.FilePath.createTextTempFile(FilePath.java:1363)
Caused: java.io.IOException: Failed to create a temp file on 

at hudson.FilePath.createTextTempFile(FilePath.java:1386)
at 
hudson.tasks.CommandInterpreter.createScriptFile(CommandInterpreter.java:162)
at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:94)
at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:66)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at hudson.model.Build$BuildExecution.build(Build.java:206)
at hudson.model.Build$BuildExecution.doRun(Build.java:163)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Build step 'Execute shell' marked build as failure
Archiving artifacts
[Fast Archiver] Compressed 428.99 KB of artifacts by 52.2% relative to #695

Build failed in Jenkins: incubator-trafficcontrol-master-build #690

[Apache Jenkins Server]

See 


Changes:

[mitchell852] removed status comments and fixed the test cases

[mitchell852] fixed nil panic on the ChangeLogMessage for the servers

[mitchell852] added domainName to the the server changelog

--
[...truncated 12.44 MB...]
traffic_portal_build_1   | warning: File listed twice: 
/opt/traffic_portal/node_modules/forever/bin/monitor
traffic_router_build_1   | [INFO]   
  
traffic_router_build_1   | [INFO] 

traffic_router_build_1   | [INFO] Building traffic_router_rpm 2.3.0
traffic_router_build_1   | [INFO] 

traffic_router_build_1   | Downloading: 
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-enforcer-plugin/1.4.1/maven-enforcer-plugin-1.4.1.pom
traffic_router_build_1   | 3/8 KB  6/8 KB   8/8 KB
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-enforcer-plugin/1.4.1/maven-enforcer-plugin-1.4.1.pom
 (8 KB at 447.3 KB/sec)
traffic_router_build_1   | Downloading: 
https://repo.maven.apache.org/maven2/org/apache/maven/enforcer/enforcer/1.4.1/enforcer-1.4.1.pom
traffic_router_build_1   | 3/8 KB   5/8 KB   8/8 KBDownloaded: 
https://repo.maven.apache.org/maven2/org/apache/maven/enforcer/enforcer/1.4.1/enforcer-1.4.1.pom
 (8 KB at 502.7 KB/sec)
traffic_router_build_1   | Downloading: 
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-enforcer-plugin/1.4.1/maven-enforcer-plugin-1.4.1.jar
traffic_router_build_1   | 3/27 KB   5/27 KB   8/27 KB   11/27 KB   13/27 KB   
16/27 KB   19/27 KB   21/27 KB   24/27 KB   27/27 KB   27/27 KB  
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-enforcer-plugin/1.4.1/maven-enforcer-plugin-1.4.1.jar
 (27 KB at 1774.7 KB/sec)
traffic_router_build_1   | [INFO] 
traffic_router_build_1   | [INFO] --- maven-clean-plugin:2.5:clean 
(default-clean) @ traffic_router_rpm ---
traffic_router_build_1   | [INFO] 
traffic_router_build_1   | [INFO] --- buildnumber-maven-plugin:1.2:create 
(default) @ traffic_router_rpm ---
traffic_portal_build_1   | warning: File listed twice: 
/opt/traffic_portal/public/traffic_portal_properties.json
traffic_portal_build_1   | Provides: traffic_portal = 2.3.0-8220.b91791d1.el7 
traffic_portal(x86-64) = 2.3.0-8220.b91791d1.el7
traffic_portal_build_1   | Requires(interp): /bin/sh
traffic_portal_build_1   | Requires(rpmlib): rpmlib(FileDigests) <= 4.6.0-1 
rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1
traffic_portal_build_1   | Requires(post): /bin/sh
traffic_portal_build_1   | Checking for unpackaged file(s): 
/usr/lib/rpm/check-files 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-2.3.0-8220.b91791d1.el7.x86_64
traffic_router_build_1   | [INFO] Checking for local modifications: skipped.
traffic_router_build_1   | [INFO] Updating project files from SCM: skipped.
traffic_router_build_1   | [INFO] ShortRevision tag detected. The value is '8'.
traffic_router_build_1   | [INFO] Executing: /bin/sh -c cd 
/tmp/trafficcontrol/traffic_router/build && git rev-parse --verify --short=8 
HEAD
traffic_router_build_1   | [INFO] Working directory: 
/tmp/trafficcontrol/traffic_router/build
traffic_router_build_1   | [INFO] Storing buildNumber: b91791d1 at timestamp: 
2018-04-12
traffic_router_build_1   | [INFO] ShortRevision tag detected. The value is '8'.
traffic_router_build_1   | [INFO] Executing: /bin/sh -c cd 
/tmp/trafficcontrol/traffic_router/build && git rev-parse --verify --short=8 
HEAD
traffic_router_build_1   | [INFO] Working directory: 
/tmp/trafficcontrol/traffic_router/build
traffic_router_build_1   | [INFO] Storing buildScmBranch: UNKNOWN
traffic_router_build_1   | [INFO] 
traffic_router_build_1   | [INFO] --- maven-enforcer-plugin:1.4.1:enforce 
(enforce-environment-variable-is-set) @ traffic_router_rpm ---
traffic_router_build_1   | Downloading: 
https://repo.maven.apache.org/maven2/junit/junit/4.11/junit-4.11.pom
traffic_router_build_1   | 3/3 KB  Downloaded: 
https://repo.maven.apache.org/maven2/junit/junit/4.11/junit-4.11.pom (3 KB at 
143.1 KB/sec)
traffic_router_build_1   | Downloading: 
https://repo.maven.apache.org/maven2/commons-lang/commons-lang/2.3/commons-lang-2.3.pom
traffic_router_build_1   | 3/11 KB   5/11 KB   8/11 KB   11/11 KB   11/11 KB
  Downloaded: 
https://repo.maven.apache.org/maven2/commons-lang/commons-lang/2.3/commons-lang-2.3.pom
 (11 KB at 723.6 KB/sec)
traffic_portal_build_1   | Wrote: 
/tmp/trafficcontrol/rpmbuild/SRPMS/traffic_portal-2.3.0-8220.b91791d1.el7.src.rpm
traffic_router_build_1   | Downloading: 
https://repo.maven.apache.org/maven2/org/apache

[GitHub] asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for the servers

[GitBox]

asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for 
the servers
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2128#issuecomment-380870480
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1403/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR #1403

[Apache Jenkins Server]

See 


--
GitHub pull request #2128 of commit ccef48c6423d4d456ca20cb94857eace403c56d5, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H29 (ubuntu xenial) in workspace 

Cloning the remote Git repository
Cloning repository git://github.com/apache/incubator-trafficcontrol.git
 > git init  # 
 > timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse ccef48c6423d4d456ca20cb94857eace403c56d5^{commit} # timeout=10
 > git rev-parse origin/ccef48c6423d4d456ca20cb94857eace403c56d5^{commit} # 
 > timeout=10
 > git rev-parse ccef48c6423d4d456ca20cb94857eace403c56d5^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse ccef48c6423d4d456ca20cb94857eace403c56d5^{commit} # timeout=10
 > git rev-parse origin/ccef48c6423d4d456ca20cb94857eace403c56d5^{commit} # 
 > timeout=10
 > git rev-parse ccef48c6423d4d456ca20cb94857eace403c56d5^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse ccef48c6423d4d456ca20cb94857eace403c56d5^{commit} # timeout=10
 > git rev-parse origin/ccef48c6423d4d456ca20cb94857eace403c56d5^{commit} # 
 > timeout=10
 > git rev-parse ccef48c6423d4d456ca20cb94857eace403c56d5^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Archiving artifacts
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script  : export COMPOSE_HTTP_TIMEOUT=120
./bin/docker-compose -p "${BUILD_TAG}" -f 
infrastructure/docker/build/docker-compose.yml down -v
[incubator-trafficcontrol-PR] $ /bin/bash -xe /tmp/jenkins5213140677430593191.sh
+ export COMPOSE_HTTP_TIMEOUT=120
+ COMPOSE_HTTP_TIMEOUT=120
+ ./bin/docker-compose -p jenkins-incubator-trafficcontrol-PR-1403 -f 
infrastructure/docker/build/docker-compose.yml down -v
/tmp/jenkins5213140677430593191.sh: line 3: ./bin/docker-compose: No such file 
or directory
POST BUILD TASK : FAILURE
END OF POST BUILD TASK : 0

[GitHub] dewrich commented on issue #2124: Add TO Go GET deliveryservices routes

[GitBox]

dewrich commented on issue #2124: Add TO Go GET deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380868344
 
 
   np, lemme know if you need help


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed pull request #2128: fixed nil panic on the ChangeLogMessage for the servers

[GitBox]

mitchell852 closed pull request #2128: fixed nil panic on the ChangeLogMessage 
for the servers
URL: https://github.com/apache/incubator-trafficcontrol/pull/2128
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/traffic_ops_golang/server/servers.go 
b/traffic_ops/traffic_ops_golang/server/servers.go
index 484994b96..60a46826d 100644
--- a/traffic_ops/traffic_ops_golang/server/servers.go
+++ b/traffic_ops/traffic_ops_golang/server/servers.go
@@ -151,10 +151,28 @@ func (server *TOServer) Validate(db *sqlx.DB) []error {
 
 // ChangeLogMessage implements the api.ChangeLogger interface for a custom log 
message
 func (server TOServer) ChangeLogMessage(action string) (string, error) {
-   status := *server.Status
-   hostName := *server.HostName
 
-   message := action + ` ` + status + `server: { "hostName":"` + hostName 
+ `", id:` + strconv.Itoa(*server.ID) + ` }`
+   var status string
+   if server.Status != nil {
+   status = *server.Status
+   }
+
+   var hostName string
+   if server.HostName != nil {
+   hostName = *server.HostName
+   }
+
+   var domainName string
+   if server.DomainName != nil {
+   domainName = *server.DomainName
+   }
+
+   var serverID string
+   if server.ID != nil {
+   serverID = strconv.Itoa(*server.ID)
+   }
+
+   message := action + ` ` + status + ` server: { "hostName":"` + hostName 
+ `", "domainName":"` + domainName + `", id:` + serverID + ` }`
 
return message, nil
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed issue #2126: Creating a new server thru the API results in internal server error

[GitBox]

mitchell852 closed issue #2126: Creating a new server thru the API results in 
internal server error
URL: https://github.com/apache/incubator-trafficcontrol/issues/2126
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich opened a new pull request #2128: fixed nil panic on the ChangeLogMessage for the servers

[GitBox]

dewrich opened a new pull request #2128: fixed nil panic on the 
ChangeLogMessage for the servers
URL: https://github.com/apache/incubator-trafficcontrol/pull/2128
 
 
   Fixes #2126 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 opened a new issue #2127: Server form: filter profiles by selected cdn

[GitBox]

mitchell852 opened a new issue #2127: Server form: filter profiles by selected 
cdn
URL: https://github.com/apache/incubator-trafficcontrol/issues/2127
 
 
   When creating or updating a server, you can't assign the server to cdn 1 and 
to profile A (which belongs to cdn 2). this will result in an API error because 
of the cdn mismatch.
   
   therefore, it would be nice when you select cdn 1 if it would filter the 
list of profiles to only show those that belong to cdn 1.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed pull request #2117: removed status comments and fixed the test cases

[GitBox]

mitchell852 closed pull request #2117: removed status comments and fixed the 
test cases
URL: https://github.com/apache/incubator-trafficcontrol/pull/2117
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/testing/api/v13/statuses_test.go 
b/traffic_ops/testing/api/v13/statuses_test.go
index d8d798a28..afe375ba6 100644
--- a/traffic_ops/testing/api/v13/statuses_test.go
+++ b/traffic_ops/testing/api/v13/statuses_test.go
@@ -25,9 +25,9 @@ import (
 func TestStatuses(t *testing.T) {
 
CreateTestStatuses(t)
-   //UpdateTestStatuses(t)
-   //GetTestStatuses(t)
-   //DeleteTestStatuses(t)
+   UpdateTestStatuses(t)
+   GetTestStatuses(t)
+   DeleteTestStatuses(t)
 
 }
 
@@ -52,8 +52,8 @@ func UpdateTestStatuses(t *testing.T) {
t.Errorf("cannot GET Status by name: %v - %v\n", 
firstStatus.Name, err)
}
remoteStatus := resp[0]
-   expectedStatusName := "testStatus1"
-   remoteStatus.Name = expectedStatusName
+   expectedStatusDesc := "new description"
+   remoteStatus.Description = expectedStatusDesc
var alert tc.Alerts
alert, _, err = TOSession.UpdateStatusByID(remoteStatus.ID, 
remoteStatus)
if err != nil {
@@ -63,11 +63,11 @@ func UpdateTestStatuses(t *testing.T) {
// Retrieve the Status to check Status name got updated
resp, _, err = TOSession.GetStatusByID(remoteStatus.ID)
if err != nil {
-   t.Errorf("cannot GET Status by name: %v - %v\n", 
firstStatus.Name, err)
+   t.Errorf("cannot GET Status by ID: %v - %v\n", 
firstStatus.Description, err)
}
respStatus := resp[0]
-   if respStatus.Name != expectedStatusName {
-   t.Errorf("results do not match actual: %s, expected: %s\n", 
respStatus.Name, expectedStatusName)
+   if respStatus.Description != expectedStatusDesc {
+   t.Errorf("results do not match actual: %s, expected: %s\n", 
respStatus.Name, expectedStatusDesc)
}
 
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 opened a new issue #2126: Creating a new server thru the API results in internal server error

[GitBox]

mitchell852 opened a new issue #2126: Creating a new server thru the API 
results in internal server error
URL: https://github.com/apache/incubator-trafficcontrol/issues/2126
 
 
   POST /api/1.2/servers results in internal server error. more specifically:
   
   2018/04/12 09:44:48 http: panic serving 127.0.0.1:63520: runtime error: 
invalid memory address or nil pointer dereference
   goroutine 7 [running]:
   net/http.(*conn).serve.func1(0xc4203012c0)
/usr/local/Cellar/go@1.8/1.8.4/libexec/src/net/http/server.go:1721 +0xd0
   panic(0x13f0700, 0x1696e70)
/usr/local/Cellar/go@1.8/1.8.4/libexec/src/runtime/panic.go:489 +0x2cf
   
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/server.(*TOServer).ChangeLogMessage(0xc42025a820,
 0x1470c3b, 0x7, 0x1b31db8, 0xc42025a820, 0x1, 0xb)

/code/src/github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/server/servers.go:156
 +0xa6


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-rat #644

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-master-build" build 
number 689
originally caused by:
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Archiving artifacts
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:243)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
 does not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #696

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1401
originally caused by:
 GitHub pull request #2124 of commit 780839c997cbbb522c70f67ea0db881c008e4702, 
no merge conflicts.
Started by upstream project "incubator-trafficcontrol-PR" build number 1402
originally caused by:
 GitHub pull request #2124 of commit 0caca6b4ff02dda6fd8120602d8015b35f36a3ee, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

FATAL: Unable to produce a script file
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at hudson.FilePath.createTextTempFile(FilePath.java:1363)
at 
hudson.tasks.CommandInterpreter.createScriptFile(CommandInterpreter.java:162)
at 
hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:94)
at 
hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:66)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at hudson.model.Build$BuildExecution.build(Build.java:206)
at hudson.model.Build$BuildExecution.doRun(Build.java:163)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
java.io.IOException: No space left on device
at java.io.FileOutputStream.writeBytes(Native Method)
at java.io.FileOutputStream.write(FileOutputStream.java:326)
at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221)
at sun.nio.cs.StreamEncoder.implClose(StreamEncoder.java:316)
at sun.nio.cs.StreamEncoder.close(StreamEncoder.java:149)
at java.io.OutputStreamWriter.close(OutputStreamWriter.java:233)
at hudson.FilePath$17.invoke(FilePath.java:1380)
at hudson.FilePath$17.invoke(FilePath.java:1363)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Caused: java.io.IOException: remote file operation failed: 
 at 
hudson.remoting.Channel@23905e9a:H23
at hudson.FilePath.act(FilePath.java:993)
at hudson.FilePath.act(FilePath.java:975)
at hudson.FilePath.createTextTempFile(FilePath.java:1363)
Caused: java.io.IOException: Failed to create a temp file on 

at hudson.FilePath.createTextTempFile(FilePath.java:1386)
at 
hudson.tasks.CommandInterpreter.createScriptFile(CommandInterpreter.java:162)
at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:94)
at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:66)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at hudson.model.Build$BuildExecution.build(Build.java:206)
at hudson.model.Build$BuildExecution.doRun(Build.java:163)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Build step 'Execute shell' marked build as failure
Archiving artifacts
[Fast Archiver] Compressed 428

Build failed in Jenkins: incubator-trafficcontrol-PR #1402

[Apache Jenkins Server]

See 


--
GitHub pull request #2124 of commit 0caca6b4ff02dda6fd8120602d8015b35f36a3ee, 
no merge conflicts.
Setting status of 0caca6b4ff02dda6fd8120602d8015b35f36a3ee to PENDING with url 
https://builds.apache.org/job/incubator-trafficcontrol-PR/1402/ and message: 
'Build started sha1 is merged.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:1170)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1200)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Archiving artifacts
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H23
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:243)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
 does not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting

[GitHub] asfgit commented on issue #2124: Add TO Go GET deliveryservices routes

[GitBox]

asfgit commented on issue #2124: Add TO Go GET deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380844558
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1402/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 opened a new issue #2125: Create configurable labels/tooltips for each property of a server

[GitBox]

mitchell852 opened a new issue #2125: Create configurable labels/tooltips for 
each property of a server
URL: https://github.com/apache/incubator-trafficcontrol/issues/2125
 
 
   Like the delivery service form, each field on the server form should have 
configurable labels and tooltips. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2124: Add TO Go GET deliveryservices routes

[GitBox]

asfgit commented on issue #2124: Add TO Go GET deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380837795
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1401/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR #1401

[Apache Jenkins Server]

See 


--
GitHub pull request #2124 of commit 780839c997cbbb522c70f67ea0db881c008e4702, 
no merge conflicts.
Setting status of 780839c997cbbb522c70f67ea0db881c008e4702 to PENDING with url 
https://builds.apache.org/job/incubator-trafficcontrol-PR/1401/ and message: 
'Build started sha1 is merged.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H35 (ubuntu xenial) in workspace 

Cloning the remote Git repository
Cloning repository git://github.com/apache/incubator-trafficcontrol.git
 > git init  # 
 > timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 780839c997cbbb522c70f67ea0db881c008e4702^{commit} # timeout=10
 > git rev-parse origin/780839c997cbbb522c70f67ea0db881c008e4702^{commit} # 
 > timeout=10
 > git rev-parse 780839c997cbbb522c70f67ea0db881c008e4702^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 780839c997cbbb522c70f67ea0db881c008e4702^{commit} # timeout=10
 > git rev-parse origin/780839c997cbbb522c70f67ea0db881c008e4702^{commit} # 
 > timeout=10
 > git rev-parse 780839c997cbbb522c70f67ea0db881c008e4702^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 780839c997cbbb522c70f67ea0db881c008e4702^{commit} # timeout=10
 > git rev-parse origin/780839c997cbbb522c70f67ea0db881c008e4702^{commit} # 
 > timeout=10
 > git rev-parse 780839c997cbbb522c70f67ea0db881c008e4702^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Archiving artifacts
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script  : export COMPOSE_HTTP_TIMEOUT=120
./bin/docker-compose -p "${BUILD_TAG}" -f 
infrastructure/docker/build/docker-compose.yml down -v
[incubator-trafficcontrol-PR] $ /bin/bash -xe /tmp/jenkins5453406405023106301.sh
+ export COMPOSE_HTTP_TIMEOUT=120
+ COMPOSE_HTTP_TIMEOUT=120
+ ./bin/docker-compose -p jenkins-incubator-trafficcontrol-PR-1401 -f 
infrastructure/docker/build/docker-compose.yml down -v
/tmp/jenkins5453406405023106301.sh: line 3: ./bin/docker-compose: No such file 
or directory
POST BUILD TASK : FAILURE
END OF POST BUILD TASK : 0

[GitHub] rob05c commented on issue #2124: Add TO Go GET deliveryservices routes

[GitBox]

rob05c commented on issue #2124: Add TO Go GET deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380836830
 
 
   @dewrich Ah, great, that's what I was looking for. I'll try to make 
deliveryservice tests based on that, and add them to this PR. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich commented on issue #2124: Add TO Go GET deliveryservices routes

[GitBox]

dewrich commented on issue #2124: Add TO Go GET deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380835316
 
 
   @rob05c The `cdnName` in these two examples refer to the cdnName linkage in 
the tc-fixtures.json.  The Test case will read the fixtures and use that 
`cdnName` to retrieve the associated CDN to get it's `id`.
   
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/testing/api/v13/tc-fixtures.json#L549
   
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/testing/api/v13/profiles_test.go#L46
   
   To complete the test case though, you have to setup all the data 
dependencies by calling the funcs from the other test cases to setup for 
instance the CDNs, Regions, Divisions, Types (for example) before you can start 
testing Profiles.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed pull request #2122: Created Swagger documentation for /phys_locations

[GitBox]

mitchell852 closed pull request #2122: Created Swagger documentation for 
/phys_locations
URL: https://github.com/apache/incubator-trafficcontrol/pull/2122
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/lib/go-tc/v13/physlocations.go b/lib/go-tc/v13/physlocations.go
new file mode 100644
index 0..dc1c4f512
--- /dev/null
+++ b/lib/go-tc/v13/physlocations.go
@@ -0,0 +1,194 @@
+package v13
+
+import tc "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+type PhysLocationsResponse struct {
+   Response []PhysLocation `json:"response"`
+}
+
+type PhysLocationResponse struct {
+   Response PhysLocationNullable `json:"response"`
+}
+
+type PhysLocation struct {
+
+   //
+   // The Street Address of the physical location
+   //
+   // required: true
+   Address string `json:"address" db:"address"`
+
+   //
+   // The Address of the physical location
+   //
+   // required: true
+   City string `json:"city" db:"city"`
+
+   //
+   // comments are additional details about the physical location
+   //
+   Comments string `json:"comments" db:"comments"`
+
+   //
+   // The email address for the Point of Contact at the physical location
+   //
+   Email string `json:"email" db:"email"`
+
+   //
+   // The name of the physical location
+   //
+   // required: true
+   ID int `json:"id" db:"id"`
+
+   // Timestamp of the last time this row was updated
+   //
+   LastUpdated tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+
+   //
+   // The name of the physical location
+   //
+   // required: true
+   Name string `json:"name" db:"name"`
+
+   //
+   // The phone number of the physical location
+   //
+   // required: true
+   Phone string `json:"phone" db:"phone"`
+
+   //
+   // The Point Of Contact at the physical location
+   //
+   // required: true
+   POC string `json:"poc" db:"poc"`
+
+   //
+   // The RegionID associated to this physical location
+   //
+   // required: true
+   RegionID int `json:"regionId" db:"region"`
+
+   //
+   // The Region Name for the region associated to this physical location
+   //
+   RegionName string `json:"region" db:"region_name"`
+
+   //
+   // The shortName for the physical location (like an alias)
+   //
+   // required: true
+   ShortName string `json:"shortName" db:"short_name"`
+
+   //
+   // The State for the physical location
+   //
+   // required: true
+   State string `json:"state" db:"state"`
+
+   //
+   // The Zipcode for the physical location
+   //
+   // required: true
+   Zip string `json:"zip" db:"zip"`
+}
+
+// PhysLocationNullable - a struct version that allows for all fields to be 
null
+type PhysLocationNullable struct {
+   //
+   // The Street Address of the physical location
+   //
+   // required: true
+   Address *string `json:"address" db:"address"`
+
+   //
+   // The Address of the physical location
+   //
+   // required: true
+   City *string `json:"city" db:"city"`
+
+   //
+   // comments are additional details about the physical location
+   //
+   Comments *string `json:"comments" db:"comments"`
+
+   //
+   // The email address for the Point of Contact at the physical location
+   //
+   Email *string `json:"email" db:"email"`
+
+   //
+   // The name of the physical location
+   //
+   // required: true
+   ID *int `json:"id" db:"id"`
+
+   // Timestamp of the last time this row was updated
+   //
+   LastUpdated *tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+
+   //
+   // The name of the physical location
+   //
+   // required: true
+   Name *string `json:"name" db:"name"`
+
+ 

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #537

[Apache Jenkins Server]

See 


Changes:

[dewrich] Fix broken link in MSO quick-how-to doc

[mitchell852] added swaggerdocs for statuses

[mitchell852] created swaggerdocs for /regions

[mitchell852] updated to use the tc.TimeNoMod type

--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H35 (ubuntu xenial) in workspace 

Cloning the remote Git repository
Cloning repository git://github.com/apache/incubator-trafficcontrol.git
 > git init 
 > 
 >  # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 58637c52cb85a40dca044c61b942563d3dd96d5b 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 58637c52cb85a40dca044c61b942563d3dd96d5b
Commit message: "updated to use the tc.TimeNoMod type"
 > git rev-list --no-walk ee715fa889c07f041ef80d12ae5448e615504140 # timeout=10
[incubator-trafficcontrol-traffic_ops-test] $ /bin/bash 
/tmp/jenkins6905398313866157439.sh
docker-compose version 1.20.1, build 5d8c71b
docker-py version: 3.2.1
CPython version: 2.7.12
OpenSSL version: OpenSSL 1.0.2g  1 Mar 2016
+ trap finish EXIT
+ proj=jenkins-incubator-trafficcontrol-traffic_ops-test-537
++ pwd
+ 
compose=
+ cfile=traffic_ops/app/bin/tests/docker-compose.yml
+ [[ -z 

 ]]
+ [[ ! -x 

 ]]
+ mkdir bin
++ uname -s
++ uname -m
+ curl -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0   1807  0 --:--:-- --:--:-- --:--:--  1804
  1 8079k1  134k0 0   111k  0  0:01:12  0:00:01  0:01:11  111k 
23 8079k   23 1936k0 0   889k  0  0:00:09  0:00:02  0:00:07 
1853k100 8079k  100 8079k0 0  2675k  0  0:00:03  0:00:03 --:--:-- 
4377k
+ chmod +x 

+ 

 -p jenkins-incubator-trafficcontrol-traffic_ops-test-537 -f 
traffic_ops/app/bin/tests/docker-compose.yml up --build --exit-code-from 
unit_golang unit_golang
using --exit-code-from implies --abort-on-container-exit
Creating network "jenkinsincubatortrafficcontroltrafficopstest537_default" with 
the default driver
Creating volume "jenkinsincubatortrafficcontroltrafficopstest537_traffic_ops" 
with default driver
Creating volume 
"jenkinsincubatortrafficcontroltrafficopstest537_traffic_ops_golang" with 
default driver
Building unit_golang
Step 1/7 : FROM golang:1.8
1.8: Pulling from library/golang
Digest: sha256:f0b5dab7581eddb49dabd1d1b9aa505ca3edcdf79a66395b5bfa4f3c036b49ef
Status: Downloaded newer image for golang:1.8
 ---> 0d283eb41a92
Step 2/7 : MAINTAINER Dan Kirkwood 
 ---> Using cache
 ---> 4936cab951dd
Step 3/7 : ARG DIR=github.com/apache/incubator-trafficcontrol
 ---> Using cache
 ---> 919199280b4f
Step 4/7 : ADD traffic_ops /go/src/$DIR/traffic_ops
 ---> 2a6fe72669d3
Removing intermediate container e8de5737064e
Step 5/7 : ADD lib /go/src/$DIR/lib
 ---> 4c54bea550ac
Removing intermediate container 1154c15ded98
Step 6/

[GitHub] rob05c commented on a change in pull request #2124: Add TO Go GET deliveryservices routes

[GitBox]

rob05c commented on a change in pull request #2124: Add TO Go GET 
deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#discussion_r181101714
 
 

 ##
 File path: 
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv13.go
 ##
 @@ -0,0 +1,272 @@
+package deliveryservice
+
+import (
+   "errors"
+   "fmt"
+
+   "github.com/apache/incubator-trafficcontrol/lib/go-log"
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/api"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/auth"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
+
+   "github.com/jmoiron/sqlx"
+   "github.com/lib/pq"
+)
+
+//we need a type alias to define functions on
+type TODeliveryServiceV13 tc.DeliveryServiceNullableV13
+
+//the refType is passed into the handlers where a copy of its type is used to 
decode the json.
+var refTypeV13 = TODeliveryServiceV13{}
+
+func GetRefTypeV13() *TODeliveryServiceV13 {
+   return &refTypeV13
+}
+
+func (ds TODeliveryServiceV13) GetKeyFieldsInfo() []api.KeyFieldInfo {
+   return 
TODeliveryServiceV12(ds.DeliveryServiceNullableV12).GetKeyFieldsInfo()
+}
+
+//Implementation of the Identifier, Validator interface functions
+func (ds TODeliveryServiceV13) GetKeys() (map[string]interface{}, bool) {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetKeys()
+}
+
+func (ds *TODeliveryServiceV13) SetKeys(keys map[string]interface{}) {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   v12.SetKeys(keys)
+}
+
+func (ds *TODeliveryServiceV13) GetAuditName() string {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetAuditName()
+}
+
+func (ds *TODeliveryServiceV13) GetType() string {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetType()
+}
+
+func ValidateV13(db *sqlx.DB, ds *tc.DeliveryServiceNullableV13) []error {
+   if ds == nil {
+   return []error{}
+   }
+   tods := TODeliveryServiceV13(*ds)
+   return tods.Validate(db)
+}
+
+func (ds *TODeliveryServiceV13) Validate(db *sqlx.DB) []error {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.Validate(db)
+}
+
+// Create implements the Creator interface.
+//all implementations of Creator should use transactions and return the proper 
errorType
+//ParsePQUniqueConstraintError is used to determine if a ds with conflicting 
values exists
+//if so, it will return an errorType of DataConflict and the type should be 
appended to the
+//generic error message returned
+//The insert sql returns the id and lastUpdated values of the newly inserted 
ds and have
+//to be added to the struct
+func (ds *TODeliveryServiceV13) Create(db *sqlx.DB, user auth.CurrentUser) 
(error, tc.ApiErrorType) {
+   tx, err := db.Beginx()
+   defer func() {
+   if tx == nil {
+   return
+   }
+   if err != nil {
+   tx.Rollback()
+   return
+   }
+   tx.Commit()
+   }()
+
+   if err != nil {
+   log.Error.Printf("could not begin transaction: %v", err)
+   return tc.DBError, tc.SystemError
+   }
+   fmt.Printf("ds ---> %v\n", ds)
+   resultRows, err := tx.NamedQuery(insertDSQuery(), ds)
+   if err != nil {
+   if pqerr, ok := err.(*pq.Error); ok {
+   err, eType := 
dbhelpers.ParsePQUniqueConstraintError(pqerr)
+   return errors.New("a delivery service with " + 
err.Error()), eType
+   }
+   log.Errorf("received non pq error: %++v from create execution", 
err)
+   return tc.DBError, tc.SystemError
+   }
+   var id int
+   var lastUpdated tc.TimeNoMod
+   rowsAffected := 0
+   for resultRows.Next() {
+   rowsAffected++
+   if err := resultRows.Scan(&id, &lastUpdated); err != nil {
+   log.Error.Printf("could not scan id from insert: %s\n", 
err)
+   return tc.DBError, tc.SystemError
+   }
+   }
+   if rowsAffected == 0 {
+   err = errors.New("no delivery service was inserted, no id was 
returned")
+   log.Errorln(err)
+   return tc.DBError, tc.SystemError
+   } else if rowsAffected > 1 {
+   err = errors.New("too many ids returned from delivery service 
insert")
+   log.Errorln(err)
+   return tc.DBError, tc.SystemError
+   }
+   ds.SetKeys(map[string]interface{}{"id": id})
+   ds.LastUpdated = &la

[GitHub] rob05c commented on a change in pull request #2124: Add TO Go GET deliveryservices routes

[GitBox]

rob05c commented on a change in pull request #2124: Add TO Go GET 
deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#discussion_r181101662
 
 

 ##
 File path: 
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv13.go
 ##
 @@ -0,0 +1,272 @@
+package deliveryservice
+
+import (
+   "errors"
+   "fmt"
+
+   "github.com/apache/incubator-trafficcontrol/lib/go-log"
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/api"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/auth"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
+
+   "github.com/jmoiron/sqlx"
+   "github.com/lib/pq"
+)
+
+//we need a type alias to define functions on
+type TODeliveryServiceV13 tc.DeliveryServiceNullableV13
+
+//the refType is passed into the handlers where a copy of its type is used to 
decode the json.
+var refTypeV13 = TODeliveryServiceV13{}
+
+func GetRefTypeV13() *TODeliveryServiceV13 {
+   return &refTypeV13
+}
+
+func (ds TODeliveryServiceV13) GetKeyFieldsInfo() []api.KeyFieldInfo {
+   return 
TODeliveryServiceV12(ds.DeliveryServiceNullableV12).GetKeyFieldsInfo()
+}
+
+//Implementation of the Identifier, Validator interface functions
+func (ds TODeliveryServiceV13) GetKeys() (map[string]interface{}, bool) {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetKeys()
+}
+
+func (ds *TODeliveryServiceV13) SetKeys(keys map[string]interface{}) {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   v12.SetKeys(keys)
+}
+
+func (ds *TODeliveryServiceV13) GetAuditName() string {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetAuditName()
+}
+
+func (ds *TODeliveryServiceV13) GetType() string {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetType()
+}
+
+func ValidateV13(db *sqlx.DB, ds *tc.DeliveryServiceNullableV13) []error {
+   if ds == nil {
+   return []error{}
+   }
+   tods := TODeliveryServiceV13(*ds)
+   return tods.Validate(db)
+}
+
+func (ds *TODeliveryServiceV13) Validate(db *sqlx.DB) []error {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.Validate(db)
+}
+
+// Create implements the Creator interface.
+//all implementations of Creator should use transactions and return the proper 
errorType
+//ParsePQUniqueConstraintError is used to determine if a ds with conflicting 
values exists
+//if so, it will return an errorType of DataConflict and the type should be 
appended to the
+//generic error message returned
+//The insert sql returns the id and lastUpdated values of the newly inserted 
ds and have
+//to be added to the struct
+func (ds *TODeliveryServiceV13) Create(db *sqlx.DB, user auth.CurrentUser) 
(error, tc.ApiErrorType) {
+   tx, err := db.Beginx()
+   defer func() {
+   if tx == nil {
+   return
+   }
+   if err != nil {
+   tx.Rollback()
+   return
+   }
+   tx.Commit()
+   }()
+
+   if err != nil {
+   log.Error.Printf("could not begin transaction: %v", err)
+   return tc.DBError, tc.SystemError
+   }
+   fmt.Printf("ds ---> %v\n", ds)
+   resultRows, err := tx.NamedQuery(insertDSQuery(), ds)
+   if err != nil {
+   if pqerr, ok := err.(*pq.Error); ok {
+   err, eType := 
dbhelpers.ParsePQUniqueConstraintError(pqerr)
+   return errors.New("a delivery service with " + 
err.Error()), eType
+   }
+   log.Errorf("received non pq error: %++v from create execution", 
err)
+   return tc.DBError, tc.SystemError
+   }
+   var id int
+   var lastUpdated tc.TimeNoMod
+   rowsAffected := 0
+   for resultRows.Next() {
+   rowsAffected++
+   if err := resultRows.Scan(&id, &lastUpdated); err != nil {
+   log.Error.Printf("could not scan id from insert: %s\n", 
err)
+   return tc.DBError, tc.SystemError
+   }
+   }
+   if rowsAffected == 0 {
+   err = errors.New("no delivery service was inserted, no id was 
returned")
+   log.Errorln(err)
+   return tc.DBError, tc.SystemError
+   } else if rowsAffected > 1 {
+   err = errors.New("too many ids returned from delivery service 
insert")
+   log.Errorln(err)
+   return tc.DBError, tc.SystemError
+   }
+   ds.SetKeys(map[string]interface{}{"id": id})
+   ds.LastUpdated = &la

[GitHub] mitchell852 closed pull request #2105: created swaggerdocs for /regions

[GitBox]

mitchell852 closed pull request #2105: created swaggerdocs for /regions
URL: https://github.com/apache/incubator-trafficcontrol/pull/2105
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/lib/go-tc/v13/regions.go b/lib/go-tc/v13/regions.go
new file mode 100644
index 0..8b7cde31b
--- /dev/null
+++ b/lib/go-tc/v13/regions.go
@@ -0,0 +1,66 @@
+package v13
+
+import tc "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+// A List of Regions Response
+// swagger:response RegionsResponse
+// in: body
+type RegionsResponse struct {
+   // in: body
+   Response []Region `json:"response"`
+}
+
+// A Single Region Response for Update and Create to depict what changed
+// swagger:response RegionResponse
+// in: body
+type RegionResponse struct {
+   // in: body
+   Response Region `json:"response"`
+}
+
+type Region struct {
+
+   // The Region to retrieve
+
+   // DivisionName - Name of the Division associated to this Region
+   //
+   // required: true
+   DivisionName string `json:"divisionName"`
+
+   // DivisionName of the Division
+   //
+   // required: true
+   Division int `json:"division" db:"division"`
+
+   // Region ID
+   //
+   ID int `json:"id" db:"id"`
+
+   // LastUpdated
+   //
+   LastUpdated tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+
+   // Region Name
+   //
+   // required: true
+   Name string `json:"name" db:"name"`
+}
diff --git a/traffic_ops/traffic_ops_golang/swaggerdocs/v13/regions.go 
b/traffic_ops/traffic_ops_golang/swaggerdocs/v13/regions.go
new file mode 100644
index 0..f3cb335c0
--- /dev/null
+++ b/traffic_ops/traffic_ops_golang/swaggerdocs/v13/regions.go
@@ -0,0 +1,147 @@
+package v13
+
+import "github.com/apache/incubator-trafficcontrol/lib/go-tc/v13"
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+// Regions -  RegionsResponse to get the "response" top level key
+// swagger:response Regions
+// in: body
+type Regions struct {
+   // Region Response Body
+   // in: body
+   RegionsResponse v13.RegionsResponse `json:"response"`
+}
+
+// Region -  RegionResponse to get the "response" top level key
+// swagger:response Region
+// in: body
+type Region struct {
+   // Region Response Body
+   // in: body
+   RegionResponse v13.RegionResponse
+}
+
+// RegionQueryParams
+//
+// swagger:parameters GetRegions
+type RegionQueryParams struct {
+
+   // RegionsQueryParams
+
+   // Division ID that refers to this Region
+   //
+   Division string `json:"division"`
+
+   // Division Name that refers to this Region
+   //
+   DivisionName string `json:"divisionName"`
+
+   // Unique identifier for the Region
+   //
+   ID string `json:"id"`
+
+   //
+   //
+   Orderby string `json:"orderby"`
+}
+
+// swagger:parameters PostRegion
+type RegionPostParam struct {
+   // Region Request Body
+   //
+   // in: body
+   // required: true
+   Region v13.Region
+}
+
+// swagger:parameters GetRegionById DeleteRegion
+type RegionPathParams struct {
+
+   // Id associated

[GitHub] mitchell852 closed pull request #2107: added swaggerdocs for /statuses

[GitBox]

mitchell852 closed pull request #2107: added swaggerdocs for /statuses
URL: https://github.com/apache/incubator-trafficcontrol/pull/2107
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/lib/go-tc/v13/statuses.go b/lib/go-tc/v13/statuses.go
new file mode 100644
index 0..8e02595ba
--- /dev/null
+++ b/lib/go-tc/v13/statuses.go
@@ -0,0 +1,60 @@
+package v13
+
+import tc "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+// A List of Statuses Response that depict the state of a server
+// swagger:response StatusesResponse
+type StatusesResponse struct {
+   // in: body
+   Response []Status `json:"response"`
+}
+
+// A Single Status Response for Update and Create to depict what changed
+// swagger:response StatusResponse
+// in: body
+type StatusResponse struct {
+   // in: body
+   Response Status `json:"response"`
+}
+
+// A Single Statuses Response for Update and Create to depict what changed
+// swagger:model Statuses
+type Status struct {
+
+   // The Statuses to retrieve
+   //
+   // description of the status type
+   //
+   Description string `json:"description" db:"description"`
+
+   // ID of the Status
+   //
+   // required: true
+   ID int `json:"id" db:"id"`
+
+   // The Time / Date this server entry was last updated
+   //
+   LastUpdated tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+
+   // enum: ["OFFLINE", "ONLINE", "ADMIN_DOWN", "REPORTED", "CCR_IGNORE", 
"PRE_PROD"]
+   Name string `json:"name" db:"name"`
+}
diff --git a/traffic_ops/traffic_ops_golang/swaggerdocs/v13/statuses.go 
b/traffic_ops/traffic_ops_golang/swaggerdocs/v13/statuses.go
new file mode 100644
index 0..f73db7218
--- /dev/null
+++ b/traffic_ops/traffic_ops_golang/swaggerdocs/v13/statuses.go
@@ -0,0 +1,149 @@
+package v13
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc/v13"
+)
+
+// Statuses -  StatusesResponse to get the "response" top level key
+// swagger:response Statuses
+// in: body
+type Statuses struct {
+   // Status Response Body
+   // in: body
+   StatusesResponse v13.StatusesResponse `json:"response"`
+}
+
+// Status -  StatusResponse to get the "response" top level key
+// swagger:response Status
+// in: body
+type Status struct {
+   // Status Response Body
+   // in: body
+   StatusResponse v13.StatusResponse
+}
+
+// StatusQueryParams
+//
+// swagger:parameters GetStatuses
+type StatusQueryParams struct {
+
+   // StatusesQueryParams
+
+   // The name that refers to this Status
+   //
+   Name string `json:"name"`
+
+   // A short description of the status
+   //
+   Description string `json:"description"`
+
+   // Unique identifier for the Status
+   //
+   ID string `json:"id"`
+
+   //
+   //
+   Orderby string `json:"orderby"`
+}
+
+// swagger:parameters PostStatus
+type StatusPostParam struct {
+   // Status Request Body
+   //
+   // in: body
+   // required: true
+   Status v13.Status
+}
+
+// swagger:parameters GetStatusBy

[GitHub] dewrich commented on a change in pull request #2124: Add TO Go GET deliveryservices routes

[GitBox]

dewrich commented on a change in pull request #2124: Add TO Go GET 
deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#discussion_r181099681
 
 

 ##
 File path: 
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv13.go
 ##
 @@ -0,0 +1,272 @@
+package deliveryservice
+
+import (
+   "errors"
+   "fmt"
+
+   "github.com/apache/incubator-trafficcontrol/lib/go-log"
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/api"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/auth"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
+
+   "github.com/jmoiron/sqlx"
+   "github.com/lib/pq"
+)
+
+//we need a type alias to define functions on
+type TODeliveryServiceV13 tc.DeliveryServiceNullableV13
+
+//the refType is passed into the handlers where a copy of its type is used to 
decode the json.
+var refTypeV13 = TODeliveryServiceV13{}
+
+func GetRefTypeV13() *TODeliveryServiceV13 {
+   return &refTypeV13
+}
+
+func (ds TODeliveryServiceV13) GetKeyFieldsInfo() []api.KeyFieldInfo {
+   return 
TODeliveryServiceV12(ds.DeliveryServiceNullableV12).GetKeyFieldsInfo()
+}
+
+//Implementation of the Identifier, Validator interface functions
+func (ds TODeliveryServiceV13) GetKeys() (map[string]interface{}, bool) {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetKeys()
+}
+
+func (ds *TODeliveryServiceV13) SetKeys(keys map[string]interface{}) {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   v12.SetKeys(keys)
+}
+
+func (ds *TODeliveryServiceV13) GetAuditName() string {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetAuditName()
+}
+
+func (ds *TODeliveryServiceV13) GetType() string {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetType()
+}
+
+func ValidateV13(db *sqlx.DB, ds *tc.DeliveryServiceNullableV13) []error {
+   if ds == nil {
+   return []error{}
+   }
+   tods := TODeliveryServiceV13(*ds)
+   return tods.Validate(db)
+}
+
+func (ds *TODeliveryServiceV13) Validate(db *sqlx.DB) []error {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.Validate(db)
+}
+
+// Create implements the Creator interface.
+//all implementations of Creator should use transactions and return the proper 
errorType
+//ParsePQUniqueConstraintError is used to determine if a ds with conflicting 
values exists
+//if so, it will return an errorType of DataConflict and the type should be 
appended to the
+//generic error message returned
+//The insert sql returns the id and lastUpdated values of the newly inserted 
ds and have
+//to be added to the struct
+func (ds *TODeliveryServiceV13) Create(db *sqlx.DB, user auth.CurrentUser) 
(error, tc.ApiErrorType) {
+   tx, err := db.Beginx()
+   defer func() {
+   if tx == nil {
+   return
+   }
+   if err != nil {
+   tx.Rollback()
+   return
+   }
+   tx.Commit()
+   }()
+
+   if err != nil {
+   log.Error.Printf("could not begin transaction: %v", err)
+   return tc.DBError, tc.SystemError
+   }
+   fmt.Printf("ds ---> %v\n", ds)
+   resultRows, err := tx.NamedQuery(insertDSQuery(), ds)
+   if err != nil {
+   if pqerr, ok := err.(*pq.Error); ok {
+   err, eType := 
dbhelpers.ParsePQUniqueConstraintError(pqerr)
+   return errors.New("a delivery service with " + 
err.Error()), eType
+   }
+   log.Errorf("received non pq error: %++v from create execution", 
err)
+   return tc.DBError, tc.SystemError
+   }
+   var id int
+   var lastUpdated tc.TimeNoMod
+   rowsAffected := 0
+   for resultRows.Next() {
+   rowsAffected++
+   if err := resultRows.Scan(&id, &lastUpdated); err != nil {
+   log.Error.Printf("could not scan id from insert: %s\n", 
err)
+   return tc.DBError, tc.SystemError
+   }
+   }
+   if rowsAffected == 0 {
+   err = errors.New("no delivery service was inserted, no id was 
returned")
+   log.Errorln(err)
+   return tc.DBError, tc.SystemError
+   } else if rowsAffected > 1 {
+   err = errors.New("too many ids returned from delivery service 
insert")
+   log.Errorln(err)
+   return tc.DBError, tc.SystemError
+   }
+   ds.SetKeys(map[string]interface{}{"id": id})
+   ds.LastUpdated = &l

[GitHub] dewrich commented on a change in pull request #2124: Add TO Go GET deliveryservices routes

[GitBox]

dewrich commented on a change in pull request #2124: Add TO Go GET 
deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#discussion_r181099605
 
 

 ##
 File path: 
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv13.go
 ##
 @@ -0,0 +1,272 @@
+package deliveryservice
+
+import (
+   "errors"
+   "fmt"
+
+   "github.com/apache/incubator-trafficcontrol/lib/go-log"
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/api"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/auth"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
+
+   "github.com/jmoiron/sqlx"
+   "github.com/lib/pq"
+)
+
+//we need a type alias to define functions on
+type TODeliveryServiceV13 tc.DeliveryServiceNullableV13
+
+//the refType is passed into the handlers where a copy of its type is used to 
decode the json.
+var refTypeV13 = TODeliveryServiceV13{}
+
+func GetRefTypeV13() *TODeliveryServiceV13 {
+   return &refTypeV13
+}
+
+func (ds TODeliveryServiceV13) GetKeyFieldsInfo() []api.KeyFieldInfo {
+   return 
TODeliveryServiceV12(ds.DeliveryServiceNullableV12).GetKeyFieldsInfo()
+}
+
+//Implementation of the Identifier, Validator interface functions
+func (ds TODeliveryServiceV13) GetKeys() (map[string]interface{}, bool) {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetKeys()
+}
+
+func (ds *TODeliveryServiceV13) SetKeys(keys map[string]interface{}) {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   v12.SetKeys(keys)
+}
+
+func (ds *TODeliveryServiceV13) GetAuditName() string {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetAuditName()
+}
+
+func (ds *TODeliveryServiceV13) GetType() string {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.GetType()
+}
+
+func ValidateV13(db *sqlx.DB, ds *tc.DeliveryServiceNullableV13) []error {
+   if ds == nil {
+   return []error{}
+   }
+   tods := TODeliveryServiceV13(*ds)
+   return tods.Validate(db)
+}
+
+func (ds *TODeliveryServiceV13) Validate(db *sqlx.DB) []error {
+   v12 := TODeliveryServiceV12(ds.DeliveryServiceNullableV12)
+   return v12.Validate(db)
+}
+
+// Create implements the Creator interface.
+//all implementations of Creator should use transactions and return the proper 
errorType
+//ParsePQUniqueConstraintError is used to determine if a ds with conflicting 
values exists
+//if so, it will return an errorType of DataConflict and the type should be 
appended to the
+//generic error message returned
+//The insert sql returns the id and lastUpdated values of the newly inserted 
ds and have
+//to be added to the struct
+func (ds *TODeliveryServiceV13) Create(db *sqlx.DB, user auth.CurrentUser) 
(error, tc.ApiErrorType) {
+   tx, err := db.Beginx()
+   defer func() {
+   if tx == nil {
+   return
+   }
+   if err != nil {
+   tx.Rollback()
+   return
+   }
+   tx.Commit()
+   }()
+
+   if err != nil {
+   log.Error.Printf("could not begin transaction: %v", err)
+   return tc.DBError, tc.SystemError
+   }
+   fmt.Printf("ds ---> %v\n", ds)
+   resultRows, err := tx.NamedQuery(insertDSQuery(), ds)
+   if err != nil {
+   if pqerr, ok := err.(*pq.Error); ok {
+   err, eType := 
dbhelpers.ParsePQUniqueConstraintError(pqerr)
+   return errors.New("a delivery service with " + 
err.Error()), eType
+   }
+   log.Errorf("received non pq error: %++v from create execution", 
err)
+   return tc.DBError, tc.SystemError
+   }
+   var id int
+   var lastUpdated tc.TimeNoMod
+   rowsAffected := 0
+   for resultRows.Next() {
+   rowsAffected++
+   if err := resultRows.Scan(&id, &lastUpdated); err != nil {
+   log.Error.Printf("could not scan id from insert: %s\n", 
err)
+   return tc.DBError, tc.SystemError
+   }
+   }
+   if rowsAffected == 0 {
+   err = errors.New("no delivery service was inserted, no id was 
returned")
+   log.Errorln(err)
+   return tc.DBError, tc.SystemError
+   } else if rowsAffected > 1 {
+   err = errors.New("too many ids returned from delivery service 
insert")
+   log.Errorln(err)
+   return tc.DBError, tc.SystemError
+   }
+   ds.SetKeys(map[string]interface{}{"id": id})
+   ds.LastUpdated = &l

[GitHub] rob05c commented on issue #2124: Add TO Go GET deliveryservices routes

[GitBox]

rob05c commented on issue #2124: Add TO Go GET deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380818865
 
 
   @dewrich Is there an example of that in the code or docs somewhere? I was 
looking for one to go off of, but didn't see any


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich closed pull request #2123: Fix broken link in MSO quick-how-to doc

[GitBox]

dewrich closed pull request #2123: Fix broken link in MSO quick-how-to doc
URL: https://github.com/apache/incubator-trafficcontrol/pull/2123
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/source/admin/quick_howto/multi_site.rst 
b/docs/source/admin/quick_howto/multi_site.rst
index 95b122824..6e0f0dd2f 100644
--- a/docs/source/admin/quick_howto/multi_site.rst
+++ b/docs/source/admin/quick_howto/multi_site.rst
@@ -63,7 +63,7 @@ Configure Multi Site Origin
 
cond %{REMAP_PSEUDO_HOOK} __RETURN__ set-config 
proxy.config.http.parent_origin.dead_server_retry_enabled 1 __RETURN__ 
set-config proxy.config.http.parent_origin.simple_retry_enabled 1 __RETURN__ 
set-config proxy.config.http.parent_origin.simple_retry_response_codes 
"400,404,412" __RETURN__ set-config 
proxy.config.http.parent_origin.dead_server_retry_response_codes "502,503" 
__RETURN__ set-config proxy.config.http.connect_attempts_timeout 2 __RETURN__ 
set-config proxy.config.http.connect_attempts_max_retries 2 __RETURN__ 
set-config proxy.config.http.connect_attempts_max_retries_dead_server 1 
__RETURN__ set-config proxy.config.http.transaction_active_timeout_in 5 [L] 
__RETURN__
 
-7) Create a delivery service profile. This must be done to set the MSO 
algorithm.  Also, as of ATS 6.x, multi-site options must be set as parameters 
within the parent.config.  Header rewrite parameters will be ignored.  See `ATS 
parent.config 
`
 for more details.  These parameters are now handled by the creation of a 
delivery service profile.
+7) Create a delivery service profile. This must be done to set the MSO 
algorithm.  Also, as of ATS 6.x, multi-site options must be set as parameters 
within the parent.config.  Header rewrite parameters will be ignored.  See `ATS 
parent.config 
`_
 for more details.  These parameters are now handled by the creation of a 
delivery service profile.
 
a) Create a profile of the type DS_PROFILE for the delivery service in 
question.
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich commented on issue #2124: Add TO Go GET deliveryservices routes

[GitBox]

dewrich commented on issue #2124: Add TO Go GET deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380814242
 
 
   @rob05c We're trying to stay away from id's in the "fixture data" so in your 
API test you have to make multiple calls (by calling the get by name) to get 
the ID's


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services