[GitHub] dewrich commented on issue #2124: Add TO Go GET deliveryservices routes

2018-04-12 Thread GitBox
dewrich commented on issue #2124: Add TO Go GET deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380868344
 
 
   np, lemme know if you need help


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dewrich commented on issue #2124: Add TO Go GET deliveryservices routes

2018-04-12 Thread GitBox
dewrich commented on issue #2124: Add TO Go GET deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380835316
 
 
   @rob05c The `cdnName` in these two examples refer to the cdnName linkage in 
the tc-fixtures.json.  The Test case will read the fixtures and use that 
`cdnName` to retrieve the associated CDN to get it's `id`.
   
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/testing/api/v13/tc-fixtures.json#L549
   
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/testing/api/v13/profiles_test.go#L46
   
   To complete the test case though, you have to setup all the data 
dependencies by calling the funcs from the other test cases to setup for 
instance the CDNs, Regions, Divisions, Types (for example) before you can start 
testing Profiles.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dewrich commented on issue #2124: Add TO Go GET deliveryservices routes

2018-04-12 Thread GitBox
dewrich commented on issue #2124: Add TO Go GET deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380814242
 
 
   @rob05c We're trying to stay away from id's in the "fixture data" so in your 
API test you have to make multiple calls (by calling the get by name) to get 
the ID's


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services