[GitHub] incubator-trafficcontrol issue #289: Added license verifier tool.
Github user alficles commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/289 I opened a new PR with the followup to this conversation. This is no longer applicable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #289: Added license verifier tool.
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/289 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #289: Added license verifier tool.
Github user alficles commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/289 Patch needs to be reworked. I need to pull out the body of the verifier, but not the supporting script. It's... on the todo list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #289: Added license verifier tool.
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/289 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #289: Added license verifier tool.
Github user alficles commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/289 Yeah. I seriously considered its own repo. But then, if we wanted to run it via CI, and I think we should, we'd have to either include the binary, which is tricky in an Apache project, or vendor the source, which puts it right back here. Any ideas? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #289: Added license verifier tool.
Github user dangogh commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/289 I agree this might be useful, but I'm -1 on including this directly in the trafficcontrol repo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #289: Added license verifier tool.
Github user alficles commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/289 It's worth mentioning... the current master does not pass, because it's licensing is genuinely problematic in ways that are not trivial to correct. So if we decide to add this to CI, we'll probably want to think about how quickly we can remove the problematic library. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
